From 118f28344daf154e47e73e79779a60bc7430a40f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Haso=C5=88?= <martin.hason@gmail.com>
Date: Thu, 23 Jan 2014 13:33:02 +0100
Subject: [PATCH] Synchronized error messages with native php error messages

---
 grammar/zend_language_parser.phpy             |  2 +-
 lib/PHPParser/Lexer.php                       |  4 ++--
 lib/PHPParser/Node/Stmt/Class.php             | 10 ++++-----
 lib/PHPParser/Node/Stmt/ClassMethod.php       | 15 ++++++++-----
 lib/PHPParser/Node/Stmt/Interface.php         |  6 ++---
 lib/PHPParser/Node/Stmt/Namespace.php         |  4 ++--
 lib/PHPParser/Node/Stmt/UseUse.php            |  4 ++--
 lib/PHPParser/Parser.php                      |  2 +-
 .../code/parser/stmt/class/modifier.test-fail |  4 ++--
 test/code/parser/stmt/class/name.test-fail    | 22 +++++++++----------
 .../parser/stmt/class/staticMethod.test-fail  | 18 ++++++++++++---
 .../stmt/haltCompilerInvalidSyntax.test-fail  |  2 +-
 .../stmt/haltCompilerOutermostScope.test-fail |  2 +-
 .../code/parser/stmt/namespace/name.test-fail | 10 ++++-----
 14 files changed, 61 insertions(+), 44 deletions(-)

diff --git a/grammar/zend_language_parser.phpy b/grammar/zend_language_parser.phpy
index 85d72b2..08ed192 100644
--- a/grammar/zend_language_parser.phpy
+++ b/grammar/zend_language_parser.phpy
@@ -166,7 +166,7 @@ inner_statement:
       statement                                             { $$ = $1; }
     | function_declaration_statement                        { $$ = $1; }
     | class_declaration_statement                           { $$ = $1; }
-    | T_HALT_COMPILER                                       { error('__halt_compiler() can only be used from the outermost scope'); }
+    | T_HALT_COMPILER                                       { error('__HALT_COMPILER() can only be used from the outermost scope'); }
 ;
 
 statement:
diff --git a/lib/PHPParser/Lexer.php b/lib/PHPParser/Lexer.php
index b4202fc..35ece08 100644
--- a/lib/PHPParser/Lexer.php
+++ b/lib/PHPParser/Lexer.php
@@ -148,7 +148,7 @@ class PHPParser_Lexer
         // this simplifies the situation, by not allowing any comments
         // in between of the tokens.
         if (!preg_match('~\s*\(\s*\)\s*(?:;|\?>\r?\n?)~', $textAfter, $matches)) {
-            throw new PHPParser_Error('__halt_compiler must be followed by "();"');
+            throw new PHPParser_Error('__HALT_COMPILER must be followed by "();"');
         }
 
         // prevent the lexer from returning any further tokens
@@ -192,4 +192,4 @@ class PHPParser_Lexer
 
         return $tokenMap;
     }
-}
\ No newline at end of file
+}
diff --git a/lib/PHPParser/Node/Stmt/Class.php b/lib/PHPParser/Node/Stmt/Class.php
index 2585d98..d02d160 100644
--- a/lib/PHPParser/Node/Stmt/Class.php
+++ b/lib/PHPParser/Node/Stmt/Class.php
@@ -46,16 +46,16 @@ class PHPParser_Node_Stmt_Class extends PHPParser_Node_Stmt
         $this->name = $name;
 
         if (isset(self::$specialNames[(string) $this->name])) {
-            throw new PHPParser_Error(sprintf('Cannot use "%s" as class name as it is reserved', $this->name));
+            throw new PHPParser_Error(sprintf('Cannot use \'%s\' as class name as it is reserved', $this->name));
         }
 
         if (isset(self::$specialNames[(string) $this->extends])) {
-            throw new PHPParser_Error(sprintf('Cannot use "%s" as class name as it is reserved', $this->extends));
+            throw new PHPParser_Error(sprintf('Cannot use \'%s\' as class name as it is reserved', $this->extends));
         }
 
         foreach ($this->implements as $interface) {
             if (isset(self::$specialNames[(string) $interface])) {
-                throw new PHPParser_Error(sprintf('Cannot use "%s" as interface name as it is reserved', $interface));
+                throw new PHPParser_Error(sprintf('Cannot use \'%s\' as interface name as it is reserved', $interface));
             }
         }
     }
@@ -96,7 +96,7 @@ class PHPParser_Node_Stmt_Class extends PHPParser_Node_Stmt
         }
 
         if ($a & 48 && $b & 48) {
-            throw new PHPParser_Error('Cannot use the final and abstract modifier at the same time');
+            throw new PHPParser_Error('Cannot use the final modifier on an abstract class member');
         }
     }
-}
\ No newline at end of file
+}
diff --git a/lib/PHPParser/Node/Stmt/ClassMethod.php b/lib/PHPParser/Node/Stmt/ClassMethod.php
index 99c0c3d..c7945e3 100644
--- a/lib/PHPParser/Node/Stmt/ClassMethod.php
+++ b/lib/PHPParser/Node/Stmt/ClassMethod.php
@@ -33,10 +33,15 @@ class PHPParser_Node_Stmt_ClassMethod extends PHPParser_Node_Stmt
         );
         $this->name = $name;
 
-        if (($this->type & PHPParser_Node_Stmt_Class::MODIFIER_STATIC)
-            && ('__construct' == $this->name || '__destruct' == $this->name || '__clone' == $this->name)
-        ) {
-            throw new PHPParser_Error(sprintf('"%s" method cannot be static', $this->name));
+        if ($this->type & PHPParser_Node_Stmt_Class::MODIFIER_STATIC) {
+            switch (strtolower($this->name)) {
+                case '__construct':
+                    throw new PHPParser_Error(sprintf('Constructor %s() cannot be static', $this->name));
+                case '__destruct':
+                    throw new PHPParser_Error(sprintf('Destructor %s() cannot be static', $this->name));
+                case '__clone':
+                    throw new PHPParser_Error(sprintf('Clone method %s() cannot be static', $this->name));
+            }
         }
     }
 
@@ -63,4 +68,4 @@ class PHPParser_Node_Stmt_ClassMethod extends PHPParser_Node_Stmt
     public function isStatic() {
         return (bool) ($this->type & PHPParser_Node_Stmt_Class::MODIFIER_STATIC);
     }
-}
\ No newline at end of file
+}
diff --git a/lib/PHPParser/Node/Stmt/Interface.php b/lib/PHPParser/Node/Stmt/Interface.php
index 8fc0241..ec811c9 100644
--- a/lib/PHPParser/Node/Stmt/Interface.php
+++ b/lib/PHPParser/Node/Stmt/Interface.php
@@ -33,13 +33,13 @@ class PHPParser_Node_Stmt_Interface extends PHPParser_Node_Stmt
         $this->name = $name;
 
         if (isset(self::$specialNames[(string) $this->name])) {
-            throw new PHPParser_Error(sprintf('Cannot use "%s" as interface name as it is reserved', $this->name));
+            throw new PHPParser_Error(sprintf('Cannot use \'%s\' as class name as it is reserved', $this->name));
         }
 
         foreach ($this->extends as $interface) {
             if (isset(self::$specialNames[(string) $interface])) {
-                throw new PHPParser_Error(sprintf('Cannot use "%s" as interface name as it is reserved', $interface));
+                throw new PHPParser_Error(sprintf('Cannot use \'%s\' as interface name as it is reserved', $interface));
             }
         }
     }
-}
\ No newline at end of file
+}
diff --git a/lib/PHPParser/Node/Stmt/Namespace.php b/lib/PHPParser/Node/Stmt/Namespace.php
index 7647239..f4064ce 100644
--- a/lib/PHPParser/Node/Stmt/Namespace.php
+++ b/lib/PHPParser/Node/Stmt/Namespace.php
@@ -29,7 +29,7 @@ class PHPParser_Node_Stmt_Namespace extends PHPParser_Node_Stmt
         );
 
         if (isset(self::$specialNames[(string) $this->name])) {
-            throw new PHPParser_Error(sprintf('Cannot use "%s" as namespace name as it is reserved', $this->name));
+            throw new PHPParser_Error(sprintf('Cannot use \'%s\' as namespace name', $this->name));
         }
 
         if (null !== $this->stmts) {
@@ -119,4 +119,4 @@ class PHPParser_Node_Stmt_Namespace extends PHPParser_Node_Stmt
             return $newStmts;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/lib/PHPParser/Node/Stmt/UseUse.php b/lib/PHPParser/Node/Stmt/UseUse.php
index 2287af0..d7d4fd6 100644
--- a/lib/PHPParser/Node/Stmt/UseUse.php
+++ b/lib/PHPParser/Node/Stmt/UseUse.php
@@ -20,7 +20,7 @@ class PHPParser_Node_Stmt_UseUse extends PHPParser_Node_Stmt
 
         if ('self' == $alias || 'parent' == $alias) {
             throw new PHPParser_Error(sprintf(
-                'Cannot use "%s" as "%s" because "%2$s" is a special class name',
+                'Cannot use %s as %s because \'%2$s\' is a special class name',
                 $name, $alias
             ));
         }
@@ -33,4 +33,4 @@ class PHPParser_Node_Stmt_UseUse extends PHPParser_Node_Stmt
             $attributes
         );
     }
-}
\ No newline at end of file
+}
diff --git a/lib/PHPParser/Parser.php b/lib/PHPParser/Parser.php
index fb30ce6..393aa80 100644
--- a/lib/PHPParser/Parser.php
+++ b/lib/PHPParser/Parser.php
@@ -1226,7 +1226,7 @@ class PHPParser_Parser
     }
 
     protected function yyn29($attributes) {
-         throw new PHPParser_Error('__halt_compiler() can only be used from the outermost scope'); 
+         throw new PHPParser_Error('__HALT_COMPILER() can only be used from the outermost scope'); 
     }
 
     protected function yyn30($attributes) {
diff --git a/test/code/parser/stmt/class/modifier.test-fail b/test/code/parser/stmt/class/modifier.test-fail
index b1bfc72..7272b4c 100644
--- a/test/code/parser/stmt/class/modifier.test-fail
+++ b/test/code/parser/stmt/class/modifier.test-fail
@@ -22,8 +22,8 @@ Multiple final modifiers are not allowed on line 1
 -----
 <?php class A { abstract final a(); }
 -----
-Cannot use the final and abstract modifier at the same time on line 1
+Cannot use the final modifier on an abstract class member on line 1
 -----
 <?php abstract final class A { }
 -----
-Syntax error, unexpected T_FINAL, expecting T_CLASS on line 1
\ No newline at end of file
+Syntax error, unexpected T_FINAL, expecting T_CLASS on line 1
diff --git a/test/code/parser/stmt/class/name.test-fail b/test/code/parser/stmt/class/name.test-fail
index f706cbe..01f06ba 100644
--- a/test/code/parser/stmt/class/name.test-fail
+++ b/test/code/parser/stmt/class/name.test-fail
@@ -2,11 +2,11 @@ Invalid class name
 -----
 <?php class self {}
 -----
-Cannot use "self" as class name as it is reserved on line 1
+Cannot use 'self' as class name as it is reserved on line 1
 -----
 <?php class parent {}
 -----
-Cannot use "parent" as class name as it is reserved on line 1
+Cannot use 'parent' as class name as it is reserved on line 1
 -----
 <?php class static {}
 -----
@@ -14,11 +14,11 @@ Syntax error, unexpected T_STATIC, expecting T_STRING on line 1
 -----
 <?php class A extends self {}
 -----
-Cannot use "self" as class name as it is reserved on line 1
+Cannot use 'self' as class name as it is reserved on line 1
 -----
 <?php class A extends parent {}
 -----
-Cannot use "parent" as class name as it is reserved on line 1
+Cannot use 'parent' as class name as it is reserved on line 1
 -----
 <?php class A extends static {}
 -----
@@ -26,11 +26,11 @@ Syntax error, unexpected T_STATIC, expecting T_STRING or T_NAMESPACE or T_NS_SEP
 -----
 <?php class A implements self {}
 -----
-Cannot use "self" as interface name as it is reserved on line 1
+Cannot use 'self' as interface name as it is reserved on line 1
 -----
 <?php class A implements parent {}
 -----
-Cannot use "parent" as interface name as it is reserved on line 1
+Cannot use 'parent' as interface name as it is reserved on line 1
 -----
 <?php class A implements static {}
 -----
@@ -38,11 +38,11 @@ Syntax error, unexpected T_STATIC, expecting T_STRING or T_NAMESPACE or T_NS_SEP
 -----
 <?php interface self {}
 -----
-Cannot use "self" as interface name as it is reserved on line 1
+Cannot use 'self' as class name as it is reserved on line 1
 -----
 <?php interface parent {}
 -----
-Cannot use "parent" as interface name as it is reserved on line 1
+Cannot use 'parent' as class name as it is reserved on line 1
 -----
 <?php interface static {}
 -----
@@ -50,12 +50,12 @@ Syntax error, unexpected T_STATIC, expecting T_STRING on line 1
 -----
 <?php interface A extends self {}
 -----
-Cannot use "self" as interface name as it is reserved on line 1
+Cannot use 'self' as interface name as it is reserved on line 1
 -----
 <?php interface A extends parent {}
 -----
-Cannot use "parent" as interface name as it is reserved on line 1
+Cannot use 'parent' as interface name as it is reserved on line 1
 -----
 <?php interface A extends static {}
 -----
-Syntax error, unexpected T_STATIC, expecting T_STRING or T_NAMESPACE or T_NS_SEPARATOR on line 1
\ No newline at end of file
+Syntax error, unexpected T_STATIC, expecting T_STRING or T_NAMESPACE or T_NS_SEPARATOR on line 1
diff --git a/test/code/parser/stmt/class/staticMethod.test-fail b/test/code/parser/stmt/class/staticMethod.test-fail
index 5c7178c..7de9e03 100644
--- a/test/code/parser/stmt/class/staticMethod.test-fail
+++ b/test/code/parser/stmt/class/staticMethod.test-fail
@@ -2,12 +2,24 @@ Some special methods cannot be static
 -----
 <?php class A { static function __construct() {} }
 -----
-"__construct" method cannot be static on line 1
+Constructor __construct() cannot be static on line 1
 -----
 <?php class A { static function __destruct() {} }
 -----
-"__destruct" method cannot be static on line 1
+Destructor __destruct() cannot be static on line 1
 -----
 <?php class A { static function __clone() {} }
 -----
-"__clone" method cannot be static on line 1
\ No newline at end of file
+Clone method __clone() cannot be static on line 1
+-----
+<?php class A { static function __CONSTRUCT() {} }
+-----
+Constructor __CONSTRUCT() cannot be static on line 1
+-----
+<?php class A { static function __Destruct() {} }
+-----
+Destructor __Destruct() cannot be static on line 1
+-----
+<?php class A { static function __cLoNe() {} }
+-----
+Clone method __cLoNe() cannot be static on line 1
diff --git a/test/code/parser/stmt/haltCompilerInvalidSyntax.test-fail b/test/code/parser/stmt/haltCompilerInvalidSyntax.test-fail
index 1aa4e80..597710f 100644
--- a/test/code/parser/stmt/haltCompilerInvalidSyntax.test-fail
+++ b/test/code/parser/stmt/haltCompilerInvalidSyntax.test-fail
@@ -3,4 +3,4 @@ Invalid __halt_compiler() syntax
 <?php
 __halt_compiler()
 -----
-__halt_compiler must be followed by "();" on line 2
\ No newline at end of file
+__HALT_COMPILER must be followed by "();" on line 2
diff --git a/test/code/parser/stmt/haltCompilerOutermostScope.test-fail b/test/code/parser/stmt/haltCompilerOutermostScope.test-fail
index b5c0162..6cb7e94 100644
--- a/test/code/parser/stmt/haltCompilerOutermostScope.test-fail
+++ b/test/code/parser/stmt/haltCompilerOutermostScope.test-fail
@@ -5,4 +5,4 @@ if (true) {
     __halt_compiler();
 }
 -----
-__halt_compiler() can only be used from the outermost scope on line 3
\ No newline at end of file
+__HALT_COMPILER() can only be used from the outermost scope on line 3
diff --git a/test/code/parser/stmt/namespace/name.test-fail b/test/code/parser/stmt/namespace/name.test-fail
index 222f55a..4bdfc49 100644
--- a/test/code/parser/stmt/namespace/name.test-fail
+++ b/test/code/parser/stmt/namespace/name.test-fail
@@ -2,11 +2,11 @@ Invalid namespace names
 -----
 <?php namespace self;
 -----
-Cannot use "self" as namespace name as it is reserved on line 1
+Cannot use 'self' as namespace name on line 1
 -----
 <?php namespace parent;
 -----
-Cannot use "parent" as namespace name as it is reserved on line 1
+Cannot use 'parent' as namespace name on line 1
 -----
 <?php namespace static;
 -----
@@ -14,12 +14,12 @@ Syntax error, unexpected T_STATIC, expecting T_STRING or T_NS_SEPARATOR or '{' o
 -----
 <?php use A as self;
 -----
-Cannot use "A" as "self" because "self" is a special class name on line 1
+Cannot use A as self because 'self' is a special class name on line 1
 -----
 <?php use B as parent;
 -----
-Cannot use "B" as "parent" because "parent" is a special class name on line 1
+Cannot use B as parent because 'parent' is a special class name on line 1
 -----
 <?php use C as static;
 -----
-Syntax error, unexpected T_STATIC, expecting T_STRING on line 1
\ No newline at end of file
+Syntax error, unexpected T_STATIC, expecting T_STRING on line 1