danog/PHP-Parser
1
0
Fork 0
mirror of https://github.com/danog/PHP-Parser.git synced 2024-11-26 20:04:48 +01:00
Code Issues Projects Releases Wiki Activity

Error on final or abstract properties

Browse Source
This commit is contained in:
nikic 2014-11-13 20:25:52 +01:00
parent 0f69f12b94
commit e26e63e9b0
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/PhpParser/Node/Stmt/Property.php
View File

@ -3,6 +3,7 @@
namespace PhpParser\Node\Stmt; namespace PhpParser\Node\Stmt;
use PhpParser\Node; use PhpParser\Node;
use PhpParser\Error;
/** /**
* @property int $type Modifiers * @property int $type Modifiers
@ -23,6 +24,14 @@ class Property extends Node\Stmt
$type |= Class_::MODIFIER_PUBLIC; $type |= Class_::MODIFIER_PUBLIC;
} }
if ($type & Class_::MODIFIER_ABSTRACT) {
throw new Error('Properties cannot be declared abstract');
}
if ($type & Class_::MODIFIER_FINAL) {
throw new Error('Properties cannot be declared final');
}
parent::__construct( parent::__construct(
array( array(
'type' => $type, 'type' => $type,

8
test/code/parser/stmt/class/modifier.test-fail
View File

@ -27,3 +27,11 @@ Cannot use the final modifier on an abstract class member on line 1
<?php abstract final class A { } <?php abstract final class A { }
----- -----
Syntax error, unexpected T_FINAL, expecting T_CLASS on line 1 Syntax error, unexpected T_FINAL, expecting T_CLASS on line 1
-----
<?php class A { abstract $a; }
-----
Properties cannot be declared abstract on line 1
-----
<?php class A { final $a; }
-----
Properties cannot be declared final on line 1