mirror of
https://github.com/danog/Valinor.git
synced 2025-01-10 06:38:24 +01:00
90dc586018
The mapper is now more type-sensitive and will fail in the following situations: - When a value does not match exactly the awaited scalar type, for instance a string `"42"` given to a node that awaits an integer. - When unnecessary array keys are present, for instance mapping an array `['foo' => …, 'bar' => …, 'baz' => …]` to an object that needs only `foo` and `bar`. - When permissive types like `mixed` or `object` are encountered. These limitations can be bypassed by enabling the flexible mode: ```php (new \CuyZ\Valinor\MapperBuilder()) ->flexible() ->mapper(); ->map('array{foo: int, bar: bool}', [ 'foo' => '42', // Will be cast from `string` to `int` 'bar' => 'true', // Will be cast from `string` to `bool` 'baz' => '…', // Will be ignored ]); ``` When using this library for a provider application — for instance an API endpoint that can be called with a JSON payload — it is recommended to use the strict mode. This ensures that the consumers of the API provide the exact awaited data structure, and prevents unknown values to be passed. When using this library as a consumer of an external source, it can make sense to enable the flexible mode. This allows for instance to convert string numeric values to integers or to ignore data that is present in the source but not needed in the application. --- All these changes led to a new check that runs on all registered object constructors. If a collision is found between several constructors that have the same signature (the same parameter names), an exception will be thrown. ```php final class SomeClass { public static function constructorA(string $foo, string $bar): self { // … } public static function constructorB(string $foo, string $bar): self { // … } } (new \CuyZ\Valinor\MapperBuilder()) ->registerConstructor( SomeClass::constructorA(...), SomeClass::constructorB(...), ) ->mapper(); ->map(SomeClass::class, [ 'foo' => 'foo', 'bar' => 'bar', ]); // Exception: A collision was detected […] ```
161 lines
5.3 KiB
PHP
161 lines
5.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace CuyZ\Valinor\Tests\Integration\Mapping\Object;
|
|
|
|
use CuyZ\Valinor\Mapper\MappingError;
|
|
use CuyZ\Valinor\MapperBuilder;
|
|
use CuyZ\Valinor\Tests\Integration\IntegrationTest;
|
|
use CuyZ\Valinor\Tests\Integration\Mapping\Fixture\SimpleObject;
|
|
use CuyZ\Valinor\Tests\Integration\Mapping\Fixture\SimpleObject as SimpleObjectAlias;
|
|
|
|
final class ListValuesMappingTest extends IntegrationTest
|
|
{
|
|
public function test_values_are_mapped_properly(): void
|
|
{
|
|
$source = [
|
|
'booleans' => [true, false, true],
|
|
'floats' => [42.404, 404.42],
|
|
'integers' => [42, 404, 1337],
|
|
'strings' => ['foo', 'bar', 'baz'],
|
|
'objects' => [
|
|
['value' => 'foo'],
|
|
['value' => 'bar'],
|
|
['value' => 'baz'],
|
|
],
|
|
'objectsWithAlias' => [
|
|
['value' => 'foo'],
|
|
['value' => 'bar'],
|
|
['value' => 'baz'],
|
|
],
|
|
'listOfStrings' => ['foo', 'bar', 'baz',],
|
|
'nonEmptyListOfStrings' => ['foo', 'bar', 'baz'],
|
|
];
|
|
|
|
foreach ([ListValues::class, ListValuesWithConstructor::class] as $class) {
|
|
try {
|
|
$result = (new MapperBuilder())->mapper()->map($class, $source);
|
|
} catch (MappingError $error) {
|
|
$this->mappingFail($error);
|
|
}
|
|
|
|
self::assertSame($source['booleans'], $result->booleans);
|
|
self::assertSame($source['floats'], $result->floats);
|
|
self::assertSame($source['integers'], $result->integers);
|
|
self::assertSame($source['strings'], $result->strings);
|
|
self::assertSame('foo', $result->objects[0]->value);
|
|
self::assertSame('bar', $result->objects[1]->value);
|
|
self::assertSame('baz', $result->objects[2]->value);
|
|
self::assertSame('foo', $result->objectsWithAlias[0]->value);
|
|
self::assertSame('bar', $result->objectsWithAlias[1]->value);
|
|
self::assertSame('baz', $result->objectsWithAlias[2]->value);
|
|
self::assertSame($source['listOfStrings'], $result->listOfStrings);
|
|
self::assertSame($source['nonEmptyListOfStrings'], $result->nonEmptyListOfStrings);
|
|
}
|
|
}
|
|
|
|
public function test_empty_list_in_non_empty_list_throws_exception(): void
|
|
{
|
|
try {
|
|
(new MapperBuilder())->mapper()->map(ListValues::class, [
|
|
'nonEmptyListOfStrings' => [],
|
|
]);
|
|
} catch (MappingError $exception) {
|
|
$error = $exception->node()->children()['nonEmptyListOfStrings']->messages()[0];
|
|
|
|
self::assertSame('1630678334', $error->code());
|
|
self::assertSame('Value array (empty) does not match type `non-empty-list<string>`.', (string)$error);
|
|
}
|
|
}
|
|
|
|
public function test_map_array_with_non_sequential_keys_to_list_throws_exception(): void
|
|
{
|
|
try {
|
|
(new MapperBuilder())->mapper()->map('list<string>', [
|
|
0 => 'foo',
|
|
2 => 'bar',
|
|
]);
|
|
} catch (MappingError $exception) {
|
|
$error = $exception->node()->children()[2]->messages()[0];
|
|
|
|
self::assertSame('1654273010', $error->code());
|
|
self::assertSame('Invalid sequential key 2, expected 1.', (string)$error);
|
|
}
|
|
}
|
|
|
|
public function test_value_with_invalid_type_throws_exception(): void
|
|
{
|
|
try {
|
|
(new MapperBuilder())->mapper()->map(ListValues::class, [
|
|
'integers' => ['foo'],
|
|
]);
|
|
} catch (MappingError $exception) {
|
|
$error = $exception->node()->children()['integers']->children()['0']->messages()[0];
|
|
|
|
self::assertSame('1655030601', $error->code());
|
|
self::assertSame("Value 'foo' does not match type `int`.", (string)$error);
|
|
}
|
|
}
|
|
}
|
|
|
|
class ListValues
|
|
{
|
|
/** @var list<bool> */
|
|
public array $booleans;
|
|
|
|
/** @var list<float> */
|
|
public array $floats;
|
|
|
|
/** @var list<int> */
|
|
public array $integers;
|
|
|
|
/** @var list<string> */
|
|
public array $strings;
|
|
|
|
/** @var list<SimpleObject> */
|
|
public array $objects;
|
|
|
|
/** @var list<SimpleObjectAlias> */
|
|
public array $objectsWithAlias;
|
|
|
|
/** @var list<string> */
|
|
public array $listOfStrings;
|
|
|
|
/** @var non-empty-list<string> */
|
|
public array $nonEmptyListOfStrings = ['foo'];
|
|
}
|
|
|
|
class ListValuesWithConstructor extends ListValues
|
|
{
|
|
/**
|
|
* @param list<bool> $booleans
|
|
* @param list<float> $floats
|
|
* @param list<int> $integers
|
|
* @param list<string> $strings
|
|
* @param list<SimpleObject> $objects
|
|
* @param list<SimpleObjectAlias> $objectsWithAlias
|
|
* @param list<string> $listOfStrings
|
|
* @param non-empty-list<string> $nonEmptyListOfStrings
|
|
*/
|
|
public function __construct(
|
|
array $booleans,
|
|
array $floats,
|
|
array $integers,
|
|
array $strings,
|
|
array $objects,
|
|
array $objectsWithAlias,
|
|
array $listOfStrings,
|
|
array $nonEmptyListOfStrings
|
|
) {
|
|
$this->booleans = $booleans;
|
|
$this->floats = $floats;
|
|
$this->integers = $integers;
|
|
$this->strings = $strings;
|
|
$this->objects = $objects;
|
|
$this->objectsWithAlias = $objectsWithAlias;
|
|
$this->listOfStrings = $listOfStrings;
|
|
$this->nonEmptyListOfStrings = $nonEmptyListOfStrings;
|
|
}
|
|
}
|