mirror of
https://github.com/danog/Valinor.git
synced 2025-01-09 14:18:33 +01:00
6ce1a439ad
/!\ This change fixes a security issue.
Userland exception thrown in a constructor will not be automatically
caught by the mapper anymore. This prevents messages with sensible
information from reaching the final user — for instance an SQL exception
showing a part of a query.
To allow exceptions to be considered as safe, the new method
`MapperBuilder::filterExceptions()` must be used, with caution.
```php
final class SomeClass
{
public function __construct(private string $value)
{
\Webmozart\Assert\Assert::startsWith($value, 'foo_');
}
}
try {
(new \CuyZ\Valinor\MapperBuilder())
->filterExceptions(function (Throwable $exception) {
if ($exception instanceof \Webmozart\Assert\InvalidArgumentException) {
return \CuyZ\Valinor\Mapper\Tree\Message\ThrowableMessage::from($exception);
}
// If the exception should not be caught by this library, it
// must be thrown again.
throw $exception;
})
->mapper()
->map(SomeClass::class, 'bar_baz');
} catch (\CuyZ\Valinor\Mapper\MappingError $exception) {
// Should print something similar to:
// > Expected a value to start with "foo_". Got: "bar_baz"
echo $exception->node()->messages()[0];
}
```
33 lines
884 B
PHP
33 lines
884 B
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace CuyZ\Valinor\Tests\Unit\Mapper\Tree\Message;
|
|
|
|
use CuyZ\Valinor\Mapper\Tree\Message\ThrowableMessage;
|
|
use PHPUnit\Framework\TestCase;
|
|
use RuntimeException;
|
|
|
|
final class ThrowableMessageTest extends TestCase
|
|
{
|
|
public function test_properties_can_be_accessed(): void
|
|
{
|
|
$message = 'some message';
|
|
$code = 'some code';
|
|
|
|
$codedError = ThrowableMessage::new($message, $code);
|
|
|
|
self::assertSame($message, (string)$codedError);
|
|
self::assertSame($code, $codedError->code());
|
|
}
|
|
|
|
public function test_from_throwable_returns_error_message(): void
|
|
{
|
|
$original = new RuntimeException('some message', 1337);
|
|
$message = ThrowableMessage::from($original);
|
|
|
|
self::assertSame('some message', $message->getMessage());
|
|
self::assertSame('1337', $message->code());
|
|
}
|
|
}
|