mirror of
https://github.com/danog/Valinor.git
synced 2024-12-13 09:37:34 +01:00
90dc586018
The mapper is now more type-sensitive and will fail in the following
situations:
- When a value does not match exactly the awaited scalar type, for
instance a string `"42"` given to a node that awaits an integer.
- When unnecessary array keys are present, for instance mapping an array
`['foo' => …, 'bar' => …, 'baz' => …]` to an object that needs only
`foo` and `bar`.
- When permissive types like `mixed` or `object` are encountered.
These limitations can be bypassed by enabling the flexible mode:
```php
(new \CuyZ\Valinor\MapperBuilder())
->flexible()
->mapper();
->map('array{foo: int, bar: bool}', [
'foo' => '42', // Will be cast from `string` to `int`
'bar' => 'true', // Will be cast from `string` to `bool`
'baz' => '…', // Will be ignored
]);
```
When using this library for a provider application — for instance an API
endpoint that can be called with a JSON payload — it is recommended to
use the strict mode. This ensures that the consumers of the API provide
the exact awaited data structure, and prevents unknown values to be
passed.
When using this library as a consumer of an external source, it can make
sense to enable the flexible mode. This allows for instance to convert
string numeric values to integers or to ignore data that is present in
the source but not needed in the application.
---
All these changes led to a new check that runs on all registered object
constructors. If a collision is found between several constructors that
have the same signature (the same parameter names), an exception will be
thrown.
```php
final class SomeClass
{
public static function constructorA(string $foo, string $bar): self
{
// …
}
public static function constructorB(string $foo, string $bar): self
{
// …
}
}
(new \CuyZ\Valinor\MapperBuilder())
->registerConstructor(
SomeClass::constructorA(...),
SomeClass::constructorB(...),
)
->mapper();
->map(SomeClass::class, [
'foo' => 'foo',
'bar' => 'bar',
]);
// Exception: A collision was detected […]
```
61 lines
2.4 KiB
PHP
61 lines
2.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace CuyZ\Valinor\Tests\Unit\Mapper\Tree\Builder;
|
|
|
|
use AssertionError;
|
|
use CuyZ\Valinor\Mapper\Tree\Builder\RootNodeBuilder;
|
|
use CuyZ\Valinor\Mapper\Tree\Builder\ShapedArrayNodeBuilder;
|
|
use CuyZ\Valinor\Mapper\Tree\Exception\SourceMustBeIterable;
|
|
use CuyZ\Valinor\Tests\Fake\Mapper\FakeShell;
|
|
use CuyZ\Valinor\Tests\Fake\Type\FakeObjectType;
|
|
use CuyZ\Valinor\Tests\Fake\Type\FakeType;
|
|
use CuyZ\Valinor\Type\Types\ShapedArrayElement;
|
|
use CuyZ\Valinor\Type\Types\ShapedArrayType;
|
|
use CuyZ\Valinor\Type\Types\StringValueType;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
final class ShapedArrayNodeBuilderTest extends TestCase
|
|
{
|
|
public function test_invalid_type_fails_assertion(): void
|
|
{
|
|
$this->expectException(AssertionError::class);
|
|
|
|
(new RootNodeBuilder(new ShapedArrayNodeBuilder(true)))->build(FakeShell::any());
|
|
}
|
|
|
|
public function test_build_with_invalid_source_throws_exception(): void
|
|
{
|
|
$type = new ShapedArrayType(new ShapedArrayElement(new StringValueType('foo'), new FakeType('SomeType')));
|
|
|
|
$this->expectException(SourceMustBeIterable::class);
|
|
$this->expectExceptionCode(1618739163);
|
|
$this->expectExceptionMessage("Value 'foo' does not match type `array{foo: SomeType}`.");
|
|
|
|
(new RootNodeBuilder(new ShapedArrayNodeBuilder(true)))->build(FakeShell::new($type, 'foo'));
|
|
}
|
|
|
|
public function test_build_with_invalid_source_for_shaped_array_containing_object_type_throws_exception(): void
|
|
{
|
|
$type = new ShapedArrayType(new ShapedArrayElement(new StringValueType('foo'), new FakeObjectType()));
|
|
|
|
$this->expectException(SourceMustBeIterable::class);
|
|
$this->expectExceptionCode(1618739163);
|
|
$this->expectExceptionMessage("Invalid value 'foo'.");
|
|
|
|
(new RootNodeBuilder(new ShapedArrayNodeBuilder(true)))->build(FakeShell::new($type, 'foo'));
|
|
}
|
|
|
|
public function test_build_with_null_source_throws_exception(): void
|
|
{
|
|
$type = new ShapedArrayType(new ShapedArrayElement(new StringValueType('foo'), new FakeType('SomeType')));
|
|
|
|
$this->expectException(SourceMustBeIterable::class);
|
|
$this->expectExceptionCode(1618739163);
|
|
$this->expectExceptionMessage("Cannot be empty and must be filled with a value matching type `array{foo: SomeType}`.");
|
|
|
|
(new RootNodeBuilder(new ShapedArrayNodeBuilder(true)))->build(FakeShell::new($type));
|
|
}
|
|
}
|