danog/amp
1
0
Fork 0
mirror of https://github.com/danog/amp.git synced 2025-01-22 05:11:42 +01:00
Code Issues Projects Releases Wiki Activity

Call posix_kill() in defer for better consistency

Browse Source 
Using a short delay was sometimes not long enough to ensure that $sig2 was actually enabled before the signal was sent. Using a defer after enabling pushes the call to posix_kill() to the next tick.
This commit is contained in:
Aaron Piotrowski 2016-06-07 12:31:49 -05:00
parent 8c2063157b
commit 6fd7fe5b11
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Test.php
View File

@ -577,12 +577,11 @@ abstract class Test extends \PHPUnit_Framework_TestCase {
$loop->onSignal(SIGUSR1, $f(5));
$loop->defer(function() use ($loop, $sig2) {
$loop->enable($sig2);
});
$loop->delay($msDelay = 1, function() use ($loop) {
\posix_kill(\getmypid(), \SIGUSR1);
$loop->delay($msDelay = 10, function() use ($loop) {
$loop->stop();
$loop->defer(function() use ($loop) {
\posix_kill(\getmypid(), \SIGUSR1);
$loop->delay($msDelay = 10, function() use ($loop) {
$loop->stop();
});
});
});
});