danog/amp
1
0
Fork 0
mirror of https://github.com/danog/amp.git synced 2024-11-30 04:29:08 +01:00
Code Issues Projects Releases Wiki Activity

Use writability hack to improve zero-delay repeating UV watchers

Browse Source
This commit is contained in:
Daniel Lowrey 2014-08-08 17:08:28 -04:00
parent 609cc2ddfe
commit 92f1ae05f5
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/UvReactor.php
View File

@ -151,17 +151,21 @@ class UvReactor implements SignalReactor {
}
/**
* Schedule a recurring callback to execute every $interval seconds until cancelled
* Schedule a recurring callback to execute every $msInterval seconds until cancelled
*
* @param callable $callback Any valid PHP callable
* @param int $msInterval The interval in milliseconds between callback invocations
* @return int Returns a unique integer watcher ID
*/
public function repeat(callable $callback, $msInterval) {
// A zero interval is interpreted as a "non-repeating" timer by php-uv; use 1ms instead.
$msInterval = ($msInterval && $msInterval > 0) ? (int) $msInterval : 1;
// A zero interval is interpreted as a "non-repeating" timer by php-uv. Here
// we use a hack to notify on STDOUT writability for 0 interval repeating
// callbacks because it's much more performant than churning 1ms timers.
$msInterval = ($msInterval && $msInterval > 0) ? (int) $msInterval : -1;
return $this->startTimer($callback, $msInterval, $msInterval, self::$MODE_REPEAT);
return ($msInterval === -1)
? $this->watchStream(STDOUT, $callback, self::WATCH_WRITE | self::WATCH_NOW)
: $this->startTimer($callback, $msInterval, $msInterval, self::$MODE_REPEAT);
}
private function startTimer($callback, $msDelay, $msInterval, $mode) {