danog/amp
1
0
Fork 0
mirror of https://github.com/danog/amp.git synced 2024-12-11 17:09:40 +01:00
Code Issues Projects Releases Wiki Activity

Fix backpressure release

Browse Source 
Previously, backpressure was only released once advance() was called
again. This means the last backpressure item was never free'd in case
the caller knows there are no more items to consume and didn't call
advance() the last time.
This commit is contained in:
Niklas Keller 2019-09-20 22:41:20 +02:00
parent 27ea578649
commit c45cd5a3a9
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/Internal/Producer.php
View File

@ -54,6 +54,12 @@ trait Producer
++$this->position;
if (\array_key_exists($this->position, $this->values)) {
if (isset($this->backPressure[$this->position])) {
$future = $this->backPressure[$this->position];
unset($this->backPressure[$this->position]);
$future->resolve();
}
return new Success(true);
}
@ -62,6 +68,14 @@ trait Producer
}
$this->waiting = new Deferred;
$this->waiting->promise()->onResolve(function () {
if (isset($this->backPressure[$this->position])) {
$future = $this->backPressure[$this->position];
unset($this->backPressure[$this->position]);
$future->resolve();
}
});
return $this->waiting->promise();
}