danog/byte-stream
1
0
Fork 0
mirror of https://github.com/danog/byte-stream.git synced 2024-11-29 20:09:07 +01:00
Code Issues Projects Releases Wiki Activity

Solve performance issues with very large chunks

Browse Source 
Very large chunks need to be copied every time there's a partial write, which is pretty problematic. Instead of doing an almost full copy of the full chunk every time, this patch splits very large chunks into multiple smaller chunks automatically.

Fixes #41.
This commit is contained in:
Niklas Keller 2018-05-23 19:39:34 +02:00
parent bd2de267cc
commit b420ae4d6b
1 changed files with 29 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
lib/ResourceOutputStream.php
View File

@ -13,6 +13,7 @@ use Amp\Success;
*/
final class ResourceOutputStream implements OutputStream {
const MAX_CONSECUTIVE_EMPTY_WRITES = 3;
const LARGE_CHUNK_SIZE = 128 * 1024;
/** @var resource */
private $resource;
@ -64,6 +65,9 @@ final class ResourceOutputStream implements OutputStream {
$length = \strlen($data);
if ($length === 0) {
// If there's no deferred at this place, there's a bug somewhere else and the item should have
// been removed earlier from the queue.
\assert($deferred !== null);
$deferred->resolve(0);
continue;
}
@ -104,16 +108,24 @@ final class ResourceOutputStream implements OutputStream {
return;
}
$deferred->resolve($written + $previous);
if ($deferred !== null) {
$deferred->resolve($written + $previous);
}
}
} catch (\Throwable $exception) {
$resource = null;
$writable = false;
$deferred->fail($exception);
if ($deferred !== null) {
$deferred->fail($exception);
}
while (!$writes->isEmpty()) {
list(, , $deferred) = $writes->shift();
$deferred->fail($exception);
if ($deferred !== null) {
$deferred->fail($exception);
}
}
Loop::cancel($watcher);
@ -198,6 +210,16 @@ final class ResourceOutputStream implements OutputStream {
}
$deferred = new Deferred;
if ($length - $written > self::LARGE_CHUNK_SIZE) {
$chunks = \str_split($data, self::LARGE_CHUNK_SIZE);
$data = \array_pop($chunks);
foreach ($chunks as $chunk) {
$this->writes->push([$chunk, $written, null]);
$written += self::LARGE_CHUNK_SIZE;
}
}
$this->writes->push([$data, $written, $deferred]);
Loop::enable($this->watcher);
$promise = $deferred->promise();
@ -241,6 +263,10 @@ final class ResourceOutputStream implements OutputStream {
do {
/** @var \Amp\Deferred $deferred */
list(, , $deferred) = $this->writes->shift();
if ($deferred === null) {
continue;
}
$deferred->fail($exception);
} while (!$this->writes->isEmpty());
}