danog/code-server
1
0
Fork 0
mirror of https://github.com/danog/code-server.git synced 2024-11-26 20:34:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash when unable to request an update

Browse Source
This commit is contained in:
Asher 2020-03-25 15:00:35 -05:00
parent 27320465b7
commit 0a5687bacf
No known key found for this signature in database
GPG Key ID: D63C1EF81242354A
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/node/app/update.ts
View File

@ -341,7 +341,7 @@ export class UpdateHttpProvider extends HttpProvider {
const request = (uri: string): void => {
logger.debug("Making request", field("uri", uri))
const httpx = uri.startsWith("https") ? https : http
httpx.get(uri, { headers: { "User-Agent": "code-server" } }, (response) => {
const client = httpx.get(uri, { headers: { "User-Agent": "code-server" } }, (response) => {
if (
response.statusCode &&
response.statusCode >= 300 &&
@ -362,6 +362,7 @@ export class UpdateHttpProvider extends HttpProvider {
resolve(response)
})
client.on("error", reject)
}
request(uri)
})

19
test/update.test.ts
View File

@ -222,4 +222,23 @@ describe("update", () => {
const archiveName = await p.getReleaseName(update)
assert.deepEqual(spy, ["/latest", `/download/${version}/${archiveName}`, `/download/${version}/${archiveName}`])
})
it("should not reject if unable to fetch", async () => {
const options = {
auth: AuthType.None,
base: "/update",
commit: "test",
}
let provider = new UpdateHttpProvider(options, true, "invalid", "invalid", settings)
await assert.doesNotReject(() => provider.getUpdate(true))
provider = new UpdateHttpProvider(
options,
true,
"http://probably.invalid.dev.localhost/latest",
"http://probably.invalid.dev.localhost/download",
settings,
)
await assert.doesNotReject(() => provider.getUpdate(true))
})
})