mirror of
https://github.com/danog/code-server.git
synced 2024-11-30 04:39:46 +01:00
c32d8b155f
This had me very confused for quite a while until I did a binary search
inspection on route/index.ts. Only with the heart.beat line commented
out did my tests pass without leaking.
They weren't leaking fds but just this heartbeat timer and node of
course prints just fds that are active when it detects some sort of leak
I guess and that made the whole thing very confusing. These fds are not
leaked and will close when node's event loop detects there are no more
callbacks to run.
no of handles 3
tcp stream {
fd: 20,
readable: false,
writable: true,
address: {},
serverAddr: null
}
tcp stream {
fd: 22,
readable: false,
writable: true,
address: {},
serverAddr: null
}
tcp stream {
fd: 23,
readable: true,
writable: false,
address: {},
serverAddr: null
}
It kept printing the above text again and again for 60s and then the
test binary times out I think. I'm not sure if it was node printing the
stuff above or if it was a mocha thing. But it was really confusing...
cc @code-asher for thoughts on what was going on.
edit: It was the leaked-handles import in socket.test.ts!!!
Not sure if we should keep it, this was really confusing and misleading.
22 lines
791 B
TypeScript
22 lines
791 B
TypeScript
import * as express from "express"
|
|
import { createApp } from "../src/node/app"
|
|
import { parse, setDefaults, parseConfigFile, DefaultedArgs } from "../src/node/cli"
|
|
import { register } from "../src/node/routes"
|
|
import * as httpserver from "./httpserver"
|
|
|
|
export async function setup(
|
|
argv: string[],
|
|
configFile?: string,
|
|
): Promise<[express.Application, express.Application, httpserver.HttpServer, DefaultedArgs]> {
|
|
argv = ["--bind-addr=localhost:0", ...argv]
|
|
|
|
const cliArgs = parse(argv)
|
|
const configArgs = parseConfigFile(configFile || "", "test/integration.ts")
|
|
const args = await setDefaults(cliArgs, configArgs)
|
|
|
|
const [app, wsApp, server] = await createApp(args)
|
|
await register(app, wsApp, server, args)
|
|
|
|
return [app, wsApp, new httpserver.HttpServer(server), args]
|
|
}
|