mirror of
https://github.com/danog/code-server.git
synced 2024-11-26 20:34:56 +01:00
7027ec7d60
* chore: upgrade Code to 1.66
* docs: update docs for Code upgrades
* fixup!: docs
* chore: update vscode submodule
* chore: update integration patch
* chore: update node-version patch
* chore: update github-auth patch
They completely changed how auth is handled for GitHub in
https://github.com/microsoft/vscode/pull/145424 so our patch may not
work. Will need to test and revisit.
* refactor: remove postinstall patch
It appears they renamed postinstall.js to postinstall.mjs and removed
the use of `rimraf` which means our patch is no longer needed! 🎉
b0e8554cce
* chore: refresh local-storage patch
* chore: refresh service-worker patch
* chore: bulk refresh patches
* fixup!: docs formatting
* refactor: remove unused last-opened patch
* fixup!: formatting docs
* fixup!: formatting docs
* refactor: remove rsync postinstall
* Revert "refactor: remove rsync postinstall"
This reverts commit 8d6b613e9d779ba18d0297710614516cde108bcf.
* refactor: update postinstall.js to .mjs
* feat(patches): add parent-origin bypass
* docs(patches): add notes for testing store-socket
* docs(patches): update testing info for node-version
* refactor(patches): delete github-auth.diff patch
* docs(patches): add notes for testing connection-type
* fixup!: delete github-auth patch
* fixup!: update connection type testing
* docs(patches): add notes to insecure-notification.diff
* docs(patches): add nots for update-check.diff
* fixup!: remove comma in integration patch
* fix(e2e): disable workspace trust
* refactor: add --no-default-rc for yarn install
* feat(patches): remove yarnrc in presinstall
* fixup!: silly mistake
* docs: add note about KEEP_MODULES=1
* docs(patches): add testing notes for node-version
* refactor(patches): remove node-version
It appears this is no longer needed due to the `remote/package.json` now which
targets node rather than electron.
* fixup!: add cd ../.. to code upgrade instructions
* fixup!: add note to yarn --production flag
* fixup!: make parent-origin easier to upstream
* Revert "refactor(patches): delete github-auth.diff patch"
This reverts commit 31a354a34345309fadc475491b392d7601e51a32.
* Revert "fixup!: delete github-auth patch"
This reverts commit bdeb5212e8c7be6cadd109941b486a4bcdae69fa.
* Merge webview origin patch into webview patch
* Remove unused post-install patch
* Prevent builtin extensions from updating
* Refresh sourcemaps patch
* Update Node to v16
This matches the version in ./lib/vscode/remote/.yarnrc.
I changed the engine to exactly 16 since if you use any different
version it will just not work since the modules will have been built for
16 (due to the .yarnrc).
* Replace fs.rmdir with fs.rm
Node is showing a deprecation warning about it.
* Update github-auth patch
The local credentials provider is no longer used when there is a remote
so this code moved into the backend web credential provider.
* Prevent fs.rm from erroring about non-existent files
We were using fs.rmdir which presumably did not have the same behavior
in v14 (in v16 fs.rmdir also errors).
* Install Python 3 in CentOS CI container
Co-authored-by: Asher <ash@coder.com>
63 lines
1.9 KiB
Diff
63 lines
1.9 KiB
Diff
Add a notification when accessing code-server in an insecure context
|
|
|
|
This is done because otherwise when things like the clipboard do not work users
|
|
may think code-server is broken. Ideally there would be a notification at the
|
|
point where these things are used instead of this though.
|
|
|
|
To test access over something like an HTTP domain or an IP address (not
|
|
localhost). For example:
|
|
|
|
1. run code-server
|
|
2. use ngrok to expose code-server
|
|
3. access via HTTP
|
|
4. look for notification in bottom right
|
|
|
|
Index: code-server/lib/vscode/src/vs/workbench/browser/client.ts
|
|
===================================================================
|
|
--- code-server.orig/lib/vscode/src/vs/workbench/browser/client.ts
|
|
+++ code-server/lib/vscode/src/vs/workbench/browser/client.ts
|
|
@@ -1,7 +1,10 @@
|
|
import { Disposable } from 'vs/base/common/lifecycle';
|
|
+import { localize } from 'vs/nls';
|
|
+import { INotificationService, Severity } from 'vs/platform/notification/common/notification';
|
|
|
|
export class CodeServerClient extends Disposable {
|
|
constructor (
|
|
+ @INotificationService private notificationService: INotificationService,
|
|
) {
|
|
super();
|
|
}
|
|
@@ -42,5 +45,32 @@ export class CodeServerClient extends Di
|
|
}
|
|
});
|
|
}
|
|
+
|
|
+ if (!window.isSecureContext) {
|
|
+ this.notificationService.notify({
|
|
+ severity: Severity.Warning,
|
|
+ message: localize(
|
|
+ 'insecureContext',
|
|
+ "{0} is being accessed in an insecure context. Web views, the clipboard, and other functionality may not work as expected.",
|
|
+ 'code-server',
|
|
+ ),
|
|
+ actions: {
|
|
+ primary: [
|
|
+ {
|
|
+ id: 'understand',
|
|
+ label: localize('confirmInsecure', "I understand"),
|
|
+ tooltip: '',
|
|
+ class: undefined,
|
|
+ enabled: true,
|
|
+ checked: true,
|
|
+ dispose: () => undefined,
|
|
+ run: () => {
|
|
+ return Promise.resolve();
|
|
+ },
|
|
+ },
|
|
+ ],
|
|
+ },
|
|
+ });
|
|
+ }
|
|
}
|
|
}
|