Get rid of the dart2 test tag (#477)

We're only ever running tests under Dart 2 now, so it's irrelevant
whether they're Dart 2-only.
This commit is contained in:
Natalie Weizenbaum 2018-09-19 15:28:47 -04:00 committed by GitHub
parent 918a3fedf2
commit 04ada09a82
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 7 additions and 27 deletions

View File

@ -2,7 +2,4 @@ tags:
# Indicates tests that require Node.js. # Indicates tests that require Node.js.
node: node:
# Indicates tests that only run on Dart 2.
dart2:
platforms: [vm, node] platforms: [vm, node]

View File

@ -327,10 +327,7 @@ void main() {
expect(error.toString(), contains('must be a Sass value type')); expect(error.toString(), contains('must be a Sass value type'));
}); });
}); });
}, });
// render() and renderError() use Zone.bindBinaryCallbackGuarded(), which
// is only available on Dart 2.
tags: "dart2");
// Node Sass currently doesn't provide any representation of first-class // Node Sass currently doesn't provide any representation of first-class
// functions, but they shouldn't crash or be corrupted. // functions, but they shouldn't crash or be corrupted.

View File

@ -3,7 +3,7 @@
// https://opensource.org/licenses/MIT. // https://opensource.org/licenses/MIT.
@TestOn('node') @TestOn('node')
@Tags(const ['node', 'dart2']) @Tags(const ['node'])
import 'dart:async'; import 'dart:async';
@ -661,8 +661,5 @@ void main() {
" stdin 1:9 root stylesheet"))); " stdin 1:9 root stylesheet")));
}); });
}); });
}, });
// render() and renderError() use Zone.bindBinaryCallbackGuarded(), which
// is only available on Dart 2.
tags: "dart2");
} }

View File

@ -3,7 +3,7 @@
// https://opensource.org/licenses/MIT. // https://opensource.org/licenses/MIT.
@TestOn('node') @TestOn('node')
@Tags(const ['node', 'dart2']) @Tags(const ['node'])
import 'dart:convert'; import 'dart:convert';

View File

@ -460,8 +460,5 @@ a {
equals("Error: Expected expression.\n" equals("Error: Expected expression.\n"
" $sassPath 1:7 root stylesheet")); " $sassPath 1:7 root stylesheet"));
}); });
}, });
// render() and renderError() use Zone.bindBinaryCallbackGuarded(), which
// is only available on Dart 2.
tags: "dart2");
} }

View File

@ -15,18 +15,10 @@ elif [ "$TASK" = format ]; then
elif [ "$TASK" = tests ]; then elif [ "$TASK" = tests ]; then
if [ -z "$NODE_VERSION" ]; then if [ -z "$NODE_VERSION" ]; then
echo "${bold}Running Dart tests against $(dart --version &> /dev/stdout).$none" echo "${bold}Running Dart tests against $(dart --version &> /dev/stdout).$none"
if [ "$DART_CHANNEL" = dev ]; then pub run test -p vm -x node
pub run test -p vm -x node
else
pub run test -p vm -x dart2 -x node
fi
else else
echo "${bold}Running Node tests against Node $(node --version).$none" echo "${bold}Running Node tests against Node $(node --version).$none"
if [ "$DART_CHANNEL" = dev ]; then pub run test -j 2 -t node
pub run test -j 2 -t node
else
pub run test -j 2 -x dart2 -t node
fi
fi; fi;
else else
echo "${bold}Running sass-spec against $(dart --version &> /dev/stdout).$none" echo "${bold}Running sass-spec against $(dart --version &> /dev/stdout).$none"