danog/dart-sass
1
0
Fork 0
mirror of https://github.com/danog/dart-sass.git synced 2024-11-30 04:39:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix extending selectors across multiple modules. (#1298)

Browse Source 
* Fix extending selectors across multiple modules.

Allows more than one module to extend the same upstream selector that,
in turn, extends a selector from its upstream module.

Properly skips creating an extra extension that was being counted as
unresolved when evaluating @extends.

See https://github.com/sass/sass-spec/pull/1635
Fixes https://github.com/sass/dart-sass/issues/1295
This commit is contained in:
Awjin Ahn 2021-04-28 16:19:12 -05:00 committed by GitHub
parent 295a116962
commit 30ede40732
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGELOG.md
View File

@ -1,3 +1,9 @@
## 1.32.12
* Fix a bug that disallowed more than one module from extending the same
selector from a module if that selector itself extended a selector from
another upstream module.
## 1.32.11
* Fix a bug where bogus indented syntax errors were reported for lines that

2
lib/src/extend/extension_store.dart
View File

@ -328,7 +328,7 @@ class ExtensionStore {
}
var containsExtension = selectors.first == extension.extender.selector;
var first = false;
var first = true;
for (var complex in selectors) {
// If the output contains the original complex selector, there's no
// need to recreate it.

2
pubspec.yaml
View File

@ -1,5 +1,5 @@
name: sass
version: 1.32.11
version: 1.32.12
description: A Sass implementation in Dart.
author: Sass Team
homepage: https://github.com/sass/dart-sass