danog/dart-sass
1
0
Fork 0
mirror of https://github.com/danog/dart-sass.git synced 2024-11-27 04:34:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor some Node API testing

Browse Source
This commit is contained in:
Natalie Weizenbaum 2017-10-20 16:56:54 -07:00
parent 1651dcab96
commit 530c4244d0
5 changed files with 105 additions and 82 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pubspec.yaml
View File

@ -34,6 +34,6 @@ dev_dependencies:
stream_channel: "^1.0.0"
test_descriptor: "^1.0.0"
test_process: "^1.0.0-rc.1"
test: "^0.12.24"
test: "^0.12.26"
xml: "^2.4.0"
yaml: "^2.0.0"

6
test/ensure_npm_package.dart
View File

@ -10,7 +10,7 @@ import 'package:test/test.dart';
hybridMain(StreamChannel channel) async {
if (!new Directory("build/npm").existsSync()) {
throw "NPM package is not build. Run pub run grinder npm_package.";
throw "NPM package is not built. Run pub run grinder npm_package.";
}
var lastModified = new DateTime(0);
@ -35,8 +35,8 @@ hybridMain(StreamChannel channel) async {
/// Ensures that the NPM package is compiled and up-to-date.
///
/// This is safe to call even outside the Dart VM.k
/// This is safe to call even outside the Dart VM.
Future ensureNpmPackage() {
var channel = spawnHybridUri("ensure_npm_package.dart");
var channel = spawnHybridUri("/test/ensure_npm_package.dart");
return channel.stream.toList();
}

0
test/node_api.dart → test/node_api/api.dart
View File

72
test/node_api/utils.dart Normal file
View File

@ -0,0 +1,72 @@
// Copyright 2017 Google Inc. Use of this source code is governed by an
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.
import 'dart:async';
import 'dart:convert';
import 'package:js/js.dart';
import 'package:test/test.dart';
import 'package:sass/src/util/path.dart';
import '../ensure_npm_package.dart';
import '../hybrid.dart';
import 'api.dart';
String sandbox;
void useSandbox() {
setUp(() async {
sandbox = await createTempDir();
});
tearDown(() async {
if (sandbox != null) await deleteDirectory(sandbox);
});
}
/// Validates that a [RenderError]'s `toString()` and `message` both equal
/// [text].
Matcher toStringAndMessageEqual(String text) => predicate((error) {
expect(error.toString(), equals("Error: $text"));
expect(error.message, equals(text));
return true;
});
/// Returns the result of rendering via [options] as a string.
Future<String> render(RenderOptions options) {
var completer = new Completer<String>();
sass.render(options, allowInterop((error, result) {
expect(error, isNull);
completer.complete(UTF8.decode(result.css));
}));
return completer.future;
}
/// Asserts that rendering via [options] produces an error, and returns that
/// error.
Future<RenderError> renderError(RenderOptions options) {
var completer = new Completer<RenderError>();
sass.render(options, allowInterop((error, result) {
expect(result, isNull);
completer.complete(error);
}));
return completer.future;
}
/// Returns the result of rendering via [options] as a string.
String renderSync(RenderOptions options) =>
UTF8.decode(sass.renderSync(options).css);
/// Asserts that rendering via [options] produces an error, and returns that
/// error.
RenderError renderSyncError(RenderOptions options) {
try {
sass.renderSync(options);
} catch (error) {
return error as RenderError;
}
throw "Expected renderSync() to throw an error.";
}

107
test/node_api_test.dart
View File

@ -15,27 +15,23 @@ import 'package:sass/src/util/path.dart';
import 'ensure_npm_package.dart';
import 'hybrid.dart';
import 'node_api.dart';
import 'node_api/api.dart';
import 'node_api/utils.dart';
String sandbox;
String sassPath;
void main() {
setUpAll(ensureNpmPackage);
useSandbox();
setUp(() async {
sandbox = await createTempDir();
sassPath = p.join(sandbox, 'test.scss');
await writeTextFile(sassPath, 'a {b: c}');
});
tearDown(() async {
if (sandbox != null) await deleteDirectory(sandbox);
});
group("renderSync()", () {
test("renders a file", () {
expect(_renderSync(new RenderOptions(file: sassPath)), equals('''
expect(renderSync(new RenderOptions(file: sassPath)), equals('''
a {
b: c;
}'''));
@ -44,7 +40,7 @@ a {
test("renders a file with the indented syntax", () async {
var indentedPath = p.join(sandbox, 'test.sass');
await writeTextFile(indentedPath, 'a\n b: c');
expect(_renderSync(new RenderOptions(file: indentedPath)), equals('''
expect(renderSync(new RenderOptions(file: indentedPath)), equals('''
a {
b: c;
}'''));
@ -53,14 +49,14 @@ a {
test("supports relative imports for a file", () async {
var importerPath = p.join(sandbox, 'importer.scss');
await writeTextFile(importerPath, '@import "test"');
expect(_renderSync(new RenderOptions(file: importerPath)), equals('''
expect(renderSync(new RenderOptions(file: importerPath)), equals('''
a {
b: c;
}'''));
});
test("renders a string", () {
expect(_renderSync(new RenderOptions(data: "a {b: c}")), equals('''
expect(renderSync(new RenderOptions(data: "a {b: c}")), equals('''
a {
b: c;
}'''));
@ -68,20 +64,20 @@ a {
test("data and file may not both be set", () {
var error =
_renderSyncError(new RenderOptions(data: "x {y: z}", file: sassPath));
renderSyncError(new RenderOptions(data: "x {y: z}", file: sassPath));
expect(error.toString(),
contains('options.data and options.file may not both be set.'));
});
test("one of data and file must be set", () {
var error = _renderSyncError(new RenderOptions());
var error = renderSyncError(new RenderOptions());
expect(error.toString(),
contains('Either options.data or options.file must be set.'));
});
test("supports load paths", () {
expect(
_renderSync(new RenderOptions(
renderSync(new RenderOptions(
data: "@import 'test'", includePaths: [sandbox])),
equals('''
a {
@ -98,7 +94,7 @@ a {
await writeTextFile(importerPath, '@import "test"');
expect(
_renderSync(new RenderOptions(
renderSync(new RenderOptions(
file: importerPath, includePaths: [p.join(sandbox, 'sub')])),
equals('''
a {
@ -108,7 +104,7 @@ a {
test("can render the indented syntax", () {
expect(
_renderSync(
renderSync(
new RenderOptions(data: "a\n b: c", indentedSyntax: true)),
equals('''
a {
@ -121,7 +117,7 @@ a {
var scssPath = p.join(sandbox, 'test.scss');
await writeTextFile(scssPath, 'a\n b: c');
expect(
_renderSync(new RenderOptions(file: scssPath, indentedSyntax: true)),
renderSync(new RenderOptions(file: scssPath, indentedSyntax: true)),
equals('''
a {
b: c;
@ -130,7 +126,7 @@ a {
test("supports the expanded output style", () {
expect(
_renderSync(
renderSync(
new RenderOptions(file: sassPath, outputStyle: 'expanded')),
equals('''
a {
@ -139,13 +135,13 @@ a {
});
test("doesn't support other output styles", () {
var error = _renderSyncError(
var error = renderSyncError(
new RenderOptions(file: sassPath, outputStyle: 'nested'));
expect(error.toString(), contains('Unsupported output style "nested".'));
});
test("allows tab indentation", () {
expect(_renderSync(new RenderOptions(file: sassPath, indentType: 'tab')),
expect(renderSync(new RenderOptions(file: sassPath, indentType: 'tab')),
equals('''
a {
\t\tb: c;
@ -153,7 +149,7 @@ a {
});
test("allows unknown indentation names", () {
expect(_renderSync(new RenderOptions(file: sassPath, indentType: 'asdf')),
expect(renderSync(new RenderOptions(file: sassPath, indentType: 'asdf')),
equals('''
a {
b: c;
@ -162,29 +158,29 @@ a {
group("linefeed allows", () {
test("cr", () {
expect(_renderSync(new RenderOptions(file: sassPath, linefeed: 'cr')),
expect(renderSync(new RenderOptions(file: sassPath, linefeed: 'cr')),
equals('a {\r b: c;\r}'));
});
test("crlf", () {
expect(_renderSync(new RenderOptions(file: sassPath, linefeed: 'crlf')),
expect(renderSync(new RenderOptions(file: sassPath, linefeed: 'crlf')),
equals('a {\r\n b: c;\r\n}'));
});
test("lfcr", () {
expect(_renderSync(new RenderOptions(file: sassPath, linefeed: 'lfcr')),
expect(renderSync(new RenderOptions(file: sassPath, linefeed: 'lfcr')),
equals('a {\n\r b: c;\n\r}'));
});
test("unknown names", () {
expect(_renderSync(new RenderOptions(file: sassPath, linefeed: 'asdf')),
expect(renderSync(new RenderOptions(file: sassPath, linefeed: 'asdf')),
equals('a {\n b: c;\n}'));
});
});
group("indentWidth allows", () {
test("a number", () {
expect(_renderSync(new RenderOptions(file: sassPath, indentWidth: 10)),
expect(renderSync(new RenderOptions(file: sassPath, indentWidth: 10)),
equals('''
a {
b: c;
@ -192,7 +188,7 @@ a {
});
test("a string", () {
expect(_renderSync(new RenderOptions(file: sassPath, indentWidth: '1')),
expect(renderSync(new RenderOptions(file: sassPath, indentWidth: '1')),
equals('''
a {
b: c;
@ -256,7 +252,7 @@ a {
group("for a parse error in a file", () {
setUp(() async {
await writeTextFile(sassPath, "a {b: }");
error = _renderSyncError(new RenderOptions(file: sassPath));
error = renderSyncError(new RenderOptions(file: sassPath));
});
test("has a useful toString() and message", () async {
@ -284,7 +280,7 @@ a {
group("for a parse error in a string", () {
setUp(() {
error = _renderSyncError(new RenderOptions(data: "a {b: }"));
error = renderSyncError(new RenderOptions(data: "a {b: }"));
});
test("has a useful toString() and message", () {
@ -313,7 +309,7 @@ a {
group("for a runtime error in a file", () {
setUp(() async {
await writeTextFile(sassPath, "a {b: 1 % a}");
error = _renderSyncError(new RenderOptions(file: sassPath));
error = renderSyncError(new RenderOptions(file: sassPath));
});
test("has a useful toString() and message", () {
@ -341,7 +337,7 @@ a {
group("for a runtime error in a string", () {
setUp(() {
error = _renderSyncError(new RenderOptions(data: "a {b: 1 % a}"));
error = renderSyncError(new RenderOptions(data: "a {b: 1 % a}"));
});
test("has a useful toString() and message", () {
@ -371,7 +367,7 @@ a {
group("render()", () {
test("renders a file", () async {
expect(await _render(new RenderOptions(file: sassPath)), equals('''
expect(await render(new RenderOptions(file: sassPath)), equals('''
a {
b: c;
}'''));
@ -380,7 +376,7 @@ a {
test("throws an error that has a useful toString", () async {
await writeTextFile(sassPath, 'a {b: }');
var error = await _renderError(new RenderOptions(file: sassPath));
var error = await renderError(new RenderOptions(file: sassPath));
expect(
error.toString(),
equals("Error: Expected expression.\n"
@ -388,48 +384,3 @@ a {
});
});
}
/// Validates that a [RenderError]'s `toString()` and `message` both equal
/// [text].
Matcher toStringAndMessageEqual(String text) => predicate((error) {
expect(error.toString(), equals("Error: $text"));
expect(error.message, equals(text));
return true;
});
/// Returns the result of rendering via [options] as a string.
Future<String> _render(RenderOptions options) {
var completer = new Completer<String>();
sass.render(options, allowInterop((error, result) {
expect(error, isNull);
completer.complete(UTF8.decode(result.css));
}));
return completer.future;
}
/// Asserts that rendering via [options] produces an error, and returns that
/// error.
Future<RenderError> _renderError(RenderOptions options) {
var completer = new Completer<RenderError>();
sass.render(options, allowInterop((error, result) {
expect(result, isNull);
completer.complete(error);
}));
return completer.future;
}
/// Returns the result of rendering via [options] as a string.
String _renderSync(RenderOptions options) =>
UTF8.decode(sass.renderSync(options).css);
/// Asserts that rendering via [options] produces an error, and returns that
/// error.
RenderError _renderSyncError(RenderOptions options) {
try {
sass.renderSync(options);
} catch (error) {
return error as RenderError;
}
throw "Expected renderSync() to throw an error.";
}