Fix the tracking of variable nodes for scopes (#1681)

Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
This commit is contained in:
Christophe Coevoet 2022-04-26 23:59:21 +02:00 committed by GitHub
parent 0c24114bad
commit 7004d49f98
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 15 additions and 4 deletions

View File

@ -1,3 +1,8 @@
## 1.51.1
* Fix an issue where source locations tracked through variable references could
potentially become incorrect.
## 1.51.0 ## 1.51.0
* **Potentially breaking change**: Change the order of maps returned by * **Potentially breaking change**: Change the order of maps returned by

View File

@ -773,6 +773,7 @@ class AsyncEnvironment {
for (var name in _variables.removeLast().keys) { for (var name in _variables.removeLast().keys) {
_variableIndices.remove(name); _variableIndices.remove(name);
} }
_variableNodes.removeLast();
for (var name in _functions.removeLast().keys) { for (var name in _functions.removeLast().keys) {
_functionIndices.remove(name); _functionIndices.remove(name);
} }

View File

@ -5,7 +5,7 @@
// DO NOT EDIT. This file was generated from async_environment.dart. // DO NOT EDIT. This file was generated from async_environment.dart.
// See tool/grind/synchronize.dart for details. // See tool/grind/synchronize.dart for details.
// //
// Checksum: 6b97030ff074d0b39e027ea97ba5893d242b9d3d // Checksum: 88f81b417129a74e4eb776d518c8e019dbf2ec36
// //
// ignore_for_file: unused_import // ignore_for_file: unused_import
@ -779,6 +779,7 @@ class Environment {
for (var name in _variables.removeLast().keys) { for (var name in _variables.removeLast().keys) {
_variableIndices.remove(name); _variableIndices.remove(name);
} }
_variableNodes.removeLast();
for (var name in _functions.removeLast().keys) { for (var name in _functions.removeLast().keys) {
_functionIndices.remove(name); _functionIndices.remove(name);
} }

View File

@ -1,3 +1,7 @@
## 1.0.0-beta.44
* No user-visible changes.
## 1.0.0-beta.43 ## 1.0.0-beta.43
* No user-visible changes. * No user-visible changes.

View File

@ -2,7 +2,7 @@ name: sass_api
# Note: Every time we add a new Sass AST node, we need to bump the *major* # Note: Every time we add a new Sass AST node, we need to bump the *major*
# version because it's a breaking change for anyone who's implementing the # version because it's a breaking change for anyone who's implementing the
# visitor interface(s). # visitor interface(s).
version: 1.0.0-beta.43 version: 1.0.0-beta.44
description: Additional APIs for Dart Sass. description: Additional APIs for Dart Sass.
homepage: https://github.com/sass/dart-sass homepage: https://github.com/sass/dart-sass
@ -10,7 +10,7 @@ environment:
sdk: '>=2.12.0 <3.0.0' sdk: '>=2.12.0 <3.0.0'
dependencies: dependencies:
sass: 1.51.0 sass: 1.51.1
dependency_overrides: dependency_overrides:
sass: {path: ../..} sass: {path: ../..}

View File

@ -1,5 +1,5 @@
name: sass name: sass
version: 1.51.0 version: 1.51.1-dev
description: A Sass implementation in Dart. description: A Sass implementation in Dart.
homepage: https://github.com/sass/dart-sass homepage: https://github.com/sass/dart-sass