From 918a3fedf241c0256a1fa7f497c25b8dc31a70d5 Mon Sep 17 00:00:00 2001 From: Natalie Weizenbaum Date: Tue, 11 Sep 2018 14:39:47 -0700 Subject: [PATCH] Pass --omit-implicit-checks to dart2js in release mode (#473) Substantially addresses #113 --- CHANGELOG.md | 8 +++++++- pubspec.yaml | 2 +- tool/grind/npm.dart | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fe814562..a13cac35 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +## 1.13.4 + +### Node JS + +* Tweak JS compilation options to substantially improve performance. + ## 1.13.3 * Properly generate source maps for stylesheets that emit `@charset` @@ -38,7 +44,7 @@ * Add a `SassException` type that provides information about Sass compilation failures. -### JS API +### Node JS API * Remove the source map comment from the compiled JS. We don't ship with the source map, so this pointed to nothing. diff --git a/pubspec.yaml b/pubspec.yaml index 21e914f0..d327dc28 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: sass -version: 1.13.3 +version: 1.13.4 description: A Sass implementation in Dart. author: Dart Team homepage: https://github.com/sass/dart-sass diff --git a/tool/grind/npm.dart b/tool/grind/npm.dart index 1c9a82fe..dd62d5c3 100644 --- a/tool/grind/npm.dart +++ b/tool/grind/npm.dart @@ -35,7 +35,7 @@ void _js({@required bool release}) { '-Dversion=$version', '-Ddart-version=$dartVersion', ]; - if (release) args..add("--minify")..add("--trust-type-annotations"); + if (release) args..add("--minify")..add("--omit-implicit-checks"); Dart2js.compile(new File('bin/sass.dart'), outFile: destination, extraArgs: args);