Don't put style rules inside empty @keyframes rules (#613)

Closes #611
This commit is contained in:
Natalie Weizenbaum 2019-03-07 17:04:30 -08:00 committed by GitHub
parent 7249698cac
commit e84c8b1995
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 4 deletions

View File

@ -1,3 +1,7 @@
## 1.17.3
* Don't put style rules inside empty `@keyframes` selectors.
## 1.17.2 ## 1.17.2
* Deprecate `!global` variable assignments to variables that aren't yet defined. * Deprecate `!global` variable assignments to variables that aren't yet defined.

View File

@ -666,7 +666,7 @@ class _EvaluateVisitor
await _withParent(ModifiableCssAtRule(name, node.span, value: value), await _withParent(ModifiableCssAtRule(name, node.span, value: value),
() async { () async {
if (!_inStyleRule) { if (!_inStyleRule || _inKeyframes) {
for (var child in node.children) { for (var child in node.children) {
await child.accept(this); await child.accept(this);
} }

View File

@ -5,7 +5,7 @@
// DO NOT EDIT. This file was generated from async_evaluate.dart. // DO NOT EDIT. This file was generated from async_evaluate.dart.
// See tool/synchronize.dart for details. // See tool/synchronize.dart for details.
// //
// Checksum: 607d30ac9d49b341367f71b69bed09f19f93e77d // Checksum: ffaa86c905bb6ef4bcb3d5a0c4ddf7b9af5d4d55
// //
// ignore_for_file: unused_import // ignore_for_file: unused_import
@ -668,7 +668,7 @@ class _EvaluateVisitor
} }
_withParent(ModifiableCssAtRule(name, node.span, value: value), () { _withParent(ModifiableCssAtRule(name, node.span, value: value), () {
if (!_inStyleRule) { if (!_inStyleRule || _inKeyframes) {
for (var child in node.children) { for (var child in node.children) {
child.accept(this); child.accept(this);
} }

View File

@ -1,5 +1,5 @@
name: sass name: sass
version: 1.17.2 version: 1.17.3-dev
description: A Sass implementation in Dart. description: A Sass implementation in Dart.
author: Dart Team <misc@dartlang.org> author: Dart Team <misc@dartlang.org>
homepage: https://github.com/sass/dart-sass homepage: https://github.com/sass/dart-sass