Commit Graph

289 Commits

Author SHA1 Message Date
Natalie Weizenbaum
77563be056
Add support for SASS_PATH (#514)
Closes #512
2018-11-05 15:24:14 -08:00
Natalie Weizenbaum
bf71ca359d
Add support for interpolation in at-rule names (#509)
Closes #496
2018-11-01 14:31:46 -07:00
Natalie Weizenbaum
9e18b7e95b
Always include the error location in JS error messages (#511)
Always include the error location in JS error messages

I was trying to match Node Sass's behavior by having Error.formatted
property have more detail than Error.message, but our errors rely on
source snippets for context so this just ended up making them
confusing.
2018-10-31 18:13:04 -07:00
Natalie Weizenbaum
6bdb49a9d5
Properly escape U+0009 CHARACTER TABULATION in unquoted strings (#504) 2018-10-18 18:50:03 -07:00
Natalie Weizenbaum
a25bbb3fc7
Add a ParenthesizedExpression class (#503)
This allows us to accurately track the source spans for parenthesized
expressions, which in turn allows us to print accurate error
indications.

Adding a new class for this more accurately represents the structure
of the expression, but it also involves an extra allocation during
parsing and an extra level of nesting during evaluation which could
have a small but real performance impact.

We could alternatively add a package-internal setter for
Expression.span, and update the source span for parenthesized
expressions after they're initially parsed. However, this has its own
downsides: it adds complexity and mutability to the object model; and
many expression classes currently use lazily-generated spans, so
making them settable would require adding extra slots on those
classes.

I decided to go with the extra class because it only adds overhead
when parentheses are actually used in practice, as opposed to adding
overhead to every list/color/etc. The runtime overhead is also likely
to be mitigated if at any point we add a constant-folding step.
2018-10-17 16:52:32 -07:00
Natalie Weizenbaum
453d89bad5
Treat :before et al a pseudo-elements (#495)
Closes #484
2018-10-12 14:35:49 -07:00
Jen Thakar
9a1f322d7f Remove space around combinators in compressed mode (#494)
Complex selectors like "a > b" will now be output as "a>b" in
compressed mode.
2018-10-11 18:03:09 -07:00
Natalie Weizenbaum
0595ac3e71
Fix an import-resolution bug (#488)
When a stylesheet is imported, the parsed stylesheet object is cached
based on its canonical URL. However, the stylesheet.span.sourceUrl was
based on the text of the import that was used to load that stylesheet.
The idea was to make the source URL in stack traces look nicer, but it
meant that relative URLs could be resolved based on the old importer's
URL before being sent to the new importer, which caused bugs.

Now stylesheet.span.sourceUrl is always the canonical URL of the
stylesheet, and thus safe to cache. We then use the import cache to
convert the canonical URL to a human-friendly URL at the point at
which we generate stack traces.

This also deprecates support for relative canonical URLs. The
semantics of these URLs were always unclear, and with the new change
in import internals the old behavior doesn't make much sense. It's
preserved for backwards-compatibility, but deprecated.
2018-10-11 15:06:26 -07:00
Natalie Weizenbaum
123bc1ff68
Properly escape U+001F INFORMATION SEPARATOR ONE in unquoted strings (#487)
See sass/sass-spec#1288
2018-10-10 15:49:43 -07:00
Natalie Weizenbaum
0620ccc19a
Fix @debug on stdin (#493) 2018-10-10 15:05:23 -07:00
Natalie Weizenbaum
ff3cea5312
Properly parse escaped digits at the beginning of identifiers (#486)
See sass/sass#1542
Closes sass/dart-sass#485
2018-09-26 21:01:46 -04:00
Natalie Weizenbaum
b3c9e7b00f
Fix a parsing bug involving nested content blocks (#483)
Closes #482
2018-09-26 14:32:55 -04:00
Progracientist
a6164217df Prettify URIs (#481)
Closes #464
2018-09-26 13:39:49 -04:00
Natalie Weizenbaum
89b86be5e8
Enable full alpha hex support (#478)
Closes #371
2018-09-19 16:03:32 -04:00
Natalie Weizenbaum
918a3fedf2
Pass --omit-implicit-checks to dart2js in release mode (#473)
Substantially addresses #113
2018-09-11 14:39:47 -07:00
Natalie Weizenbaum
1a5eb2a2e3
Fix embedding source maps with non-ASCII characters (#471)
Closes #457
2018-09-11 12:13:43 -07:00
Natalie Weizenbaum
ede9c81e0b
Properly adjust source maps when prepending encoding information (#470)
Closes #469
2018-09-10 15:38:30 -07:00
Natalie Weizenbaum
edf3370cd9
Parse :nth-child() selectors with extra whitespace (#467)
As a side effect of the new parse, this also removes extra whitespace
from :nth-child() selectors.

Closes #465
2018-09-05 15:28:26 -07:00
Natalie Weizenbaum
048b17495e
Support browser hacks in plain CSS mode (#468)
Closes #466
2018-09-05 14:31:59 -07:00
Natalie Weizenbaum
9e5ef91f22
Add support for the single-equals operator in plain CSS (#463)
Closes #462
2018-08-31 18:15:23 -06:00
Natalie Weizenbaum
997e068499
Add support for extending selector lists (#455)
Closes #452
2018-08-17 13:32:10 -07:00
Natalie Weizenbaum
677d781c52
Fix a crash with nested media rules (#454)
Closes #453
2018-08-17 12:34:31 -07:00
Natalie Weizenbaum
c5dff3e841
Remove the source map comment from the JS blob we release (#448)
See bazelbuild/rules_sass#44
2018-08-15 13:28:02 -07:00
Natalie Weizenbaum
874ee0b076
Expose the SassException class publicly (#446) 2018-08-14 12:58:47 -07:00
Natalie Weizenbaum
d1bb4a0d6d
Allow a BOM at the beginning of a document (#441)
This was only breaking in JS because apparently dart:io automatically
filters out BOMs.

Closes #437
2018-08-10 16:31:15 -07:00
Natalie Weizenbaum
0f7f9e69a7
Add support for plain CSS imports (#436)
Closes #424
2018-08-10 15:58:15 -07:00
Natalie Weizenbaum
534256a381 Merge branch '1.10.x' into master 2018-08-09 17:56:30 -07:00
Natalie Weizenbaum
511319a3b4 Declare support for test 1.0.0
Closes sass/homebrew-sass#10
2018-08-09 15:16:56 -07:00
Natalie Weizenbaum
98fa94e3e7 Merge branch '1.10.x' 2018-08-03 15:42:23 -07:00
Natalie Weizenbaum
8bffd52729
Don't hang after a syntax error in --watch (#435)
Closes #401
2018-08-03 15:38:16 -07:00
Natalie Weizenbaum
89ce44aac4
Pass --no-preview-dart-2 to the Chocolatey script (#434)
I missed this in c462b82.

Closes #433
2018-08-03 14:24:53 -07:00
Natalie Weizenbaum
3b2f20d71b
Add support for plain CSS min() and max() (#428)
See sass/sass#2378
Closes #426
2018-08-03 12:50:56 -07:00
Natalie Weizenbaum
d00b30a1af Merge tag '1.10.2' 2018-08-02 17:11:55 -07:00
Natalie Weizenbaum
5ee73e2ead Release 1.10.2
This is just intended to trigger a new Chocolatey build.

Closes #413
2018-08-02 16:28:07 -07:00
Natalie Weizenbaum
468e3b0270
Normalize escapes in identifiers (#427)
Closes #425
See sass/sass#1542
2018-07-26 16:21:02 -07:00
Natalie Weizenbaum
313b939ed8
Add support for range-form media queries (#423)
See sass/sass#1864
2018-07-25 15:48:24 -07:00
Natalie Weizenbaum
e1750216ee Don't crash when passing includePaths with importer
Closes #412
2018-07-23 16:20:06 -07:00
Natalie Weizenbaum
45da11dad5
Preserve nested media queries when they can't be merged (#410)
See sass/sass#1831
2018-07-18 12:12:17 -07:00
Natalie Weizenbaum
f740e97e05
Fix a typo in an error message (#411) 2018-07-18 12:11:24 -07:00
Natalie Weizenbaum
02781130b8
Give the dummy Node.js FileSystemException a usable toString() (#407)
Closes #406
2018-07-12 19:26:21 -07:00
Jenny Messerly
6d3cd8dd06 Fix --watch option with node on Mac OS (#402)
Closes #399
2018-07-11 13:15:55 -07:00
Natalie Weizenbaum
df7c1030cf
Don't emit ANSI codes to Windows terminals that don't support them (#403)
These codes *could* be supported on all Windows terminals, but
dart-lang/sdk#28614 means that they won't actually be recognized.

Partially addresses #395
2018-07-10 15:59:16 -07:00
Natalie Weizenbaum
9bb272dcff
Support Node Sass's sass.types.Color(argb) constructor (#398)
Closes #397
2018-07-03 17:09:54 -07:00
Natalie Weizenbaum
96c46a242e
Add a --stop-on-error flag (#391)
Closes #264
2018-06-29 18:12:36 -07:00
Natalie Weizenbaum
425305725b
Add a --poll option (#390)
Partially addresses #264.
2018-06-28 18:20:28 -07:00
Natalie Weizenbaum
cd0211c2ab
Fix the Chocolatey version of the Dart SDK (#389)
Dev SDKs changed from 2.0.0.XX-dev to 2.0.0.XX-dev-Y.
2018-06-27 17:42:07 -07:00
Natalie Weizenbaum
39eeeb51ef
Add a missing _ignoreErrors() call in StylesheetGraph (#377)
We weren't ignoring errors when reloading a file, which meant that
syntax errors would get surfaced in the wrong place and cause a crash.

Closes #359
2018-06-26 20:10:46 -07:00
Natalie Weizenbaum
e95d57ce25
Fix @-moz-document parsing and add deprecation warnings (#379)
Partially addresses #378
Closes #372
2018-06-26 17:11:25 -07:00
Natalie Weizenbaum
3b6730369b
Pin the version of Dart that gets published (#382)
This version was set separately than the version we test against, for
some reason.

Closes #380
2018-06-25 13:14:36 -07:00
Natalie Weizenbaum
023bf91745
Add deprecation warnings for hex alpha colors (#367)
Also support unambiguous hex alpha colors.

Closes #360
See sass/sass#2179
2018-06-21 17:47:06 -07:00
Natalie Weizenbaum
87e568faa4
Fix a bug where we were setting the base URL of stylesheets wrong (#370)
Closes #369
2018-06-20 17:43:40 -07:00
Natalie Weizenbaum
fdbccc8625
Ensure that source map comment URLs are relative to the CSS file (#365)
Closes #364
2018-06-19 17:50:37 -07:00
Natalie Weizenbaum
c97e36409d
Support the latest version of cli_repl (#362) 2018-06-19 13:44:52 -07:00
Natalie Weizenbaum
b949f9fe72 Use Dart 2 constants 2018-06-15 13:59:28 -07:00
Natalie Weizenbaum
7e19b9e7d6 Update the pubspec and changelog
[skip ci]
2018-06-13 18:28:52 -07:00
Natalie Weizenbaum
594f936c54 Fix an edge-case bug
If a non-partial stylesheet is next to a partial with the same name,
canonicalizing the source URL would fail. We don't really need to
canonicalize that URL anyway, though, since it's only used for import
loops and such a loop will reload and rerun the entrypoint anyway.
2018-06-08 20:28:38 -04:00
Natalie Weizenbaum
0a21fb7063 Make sure --update surfaces failures properly 2018-06-08 20:28:38 -04:00
Natalie Weizenbaum
e2266ded68
Produce better errors when expected tokens are missing (#344) 2018-06-01 20:56:12 -04:00
Natalie Weizenbaum
224dc91792
Forbid empty custom properties (#343) 2018-05-31 20:39:33 -04:00
Natalie Weizenbaum
c26903e30e
Don't consider drive separators to be path-separating colons (#342)
Closes #340
2018-05-31 20:38:45 -04:00
Natalie Weizenbaum
942d1e4099
Error out on ambiguous imports (#339)
Closes #335
2018-05-30 21:03:23 -04:00
Natalie Weizenbaum
920a79b408 Pubspec and changelog
[skip ci]
2018-05-30 19:15:06 -04:00
Natalie Weizenbaum
d4655f22bd
Fix an Importer-calling bug (#338)
We were resolving URLs relative to the canonical URL rather than the
original URL, which broke importers for which those were different,
like the package importer.

Closes #334
2018-05-30 17:47:37 -04:00
Natalie Weizenbaum
ac8c01a595 Add an --update flag
Partially addresses #264
2018-05-28 16:58:09 -04:00
Natalie Weizenbaum
17d3c1ae63 Add Importer.modificationTime() 2018-05-28 16:57:56 -04:00
Natalie Weizenbaum
8007892075
Improve handling of invalid semicolons in the indented syntax (#330)
This improves the error message and fixes a bug where semicolons were
allowed after declarations.
2018-05-24 19:15:56 -04:00
Natalie Weizenbaum
7c26959156
Node API: generate a source map even when outFile isn't set (#331)
Contrary to documentation, Node Sass generates a source map when
outFile is unset as long as sourceMap is a string.
2018-05-24 18:42:16 -04:00
Natalie Weizenbaum
d68acf9ac2
Support compiling entire directories at once (#324)
Partially addresses #264
2018-05-22 23:06:33 +01:00
Natalie Weizenbaum
1450c241c6 Support input:output syntax for compiling multiple files at once
Partially addresses #264
2018-05-20 20:57:33 +01:00
Natalie Weizenbaum
2d72f1cdca
Add support for @elseif (#317)
Closes #316
2018-05-03 17:12:40 -07:00
Natalie Weizenbaum
b5fd1409ce
Fix relative imports through relative load paths in the Node API (#315)
Closes #314
2018-05-02 17:04:36 -07:00
Natalie Weizenbaum
6a117905ab
Fix a crash when printing warnings through the Node API (#311)
Closes #307
2018-04-25 17:47:29 -07:00
Natalie Weizenbaum
50b820aed3 Add CHANGELOG entries for source map CLI support
See #2

[skip ci]
2018-04-25 17:10:02 -07:00
Natalie Weizenbaum
a1f56d783d Add a CHANGELOG entry for mbullington/node_preamble.dart#6
This doesn't actually require any changes in Dart Sass itself, but it
was producing behavior that was visible to our users (#301) so it
makes sense to include it in the CHANGELOG for the version that will
include the fix.

[skip ci]
2018-04-25 17:06:37 -07:00
Natalie Weizenbaum
7a882bd3be Fix a relative import bug in the JS API
Closes #284
2018-04-21 00:50:23 -07:00
Natalie Weizenbaum
fd19bc85b6
Add a JavaScript API for source map generation (#302)
Partially addresses #2
2018-04-20 17:56:00 -07:00
Natalie Weizenbaum
9ea001598a
Add a Dart API for source map generation (#299)
Partially addresses #2
2018-04-19 16:51:20 -07:00
Natalie Weizenbaum
b23993ea66
Always emit units for non-length/angle 0 values (#300)
Closes #297
2018-04-19 15:20:17 -07:00
Natalie Weizenbaum
6fd0f6d6e3
Improve the error message for extending compound selectors. (#294)
Closes #286
2018-04-14 16:02:53 -07:00
Natalie Weizenbaum
2e42c749a0
Properly parse #{$var} -#{$var} (#292)
Closes #290
2018-04-12 17:41:21 -07:00
Natalie Weizenbaum
a31251fdc9
Create a directory for CSS output if necessary (#291)
Closes #288
2018-04-12 16:40:53 -07:00
Natalie Weizenbaum
5cce76b6d4
Use constants from dart2_constants (#282) 2018-04-04 15:49:07 -07:00
Natalie Weizenbaum
dd61b8cf1d Merge tag '1.1.0'
This will be released as 1.1.1, since 1.1.0 accidentally didn't
include 880c914.
2018-03-27 14:20:45 -07:00
Natalie Weizenbaum
880c91444e
Add support for "sass input.scss output.css" (#275)
Closes #274
2018-03-27 13:45:03 -07:00
Natalie Weizenbaum
d316fe19b9 Use $0 rather than $BASH_SOURCE for POSIX-compatibility
Closes #276
2018-03-27 13:35:45 -07:00
Natalie Weizenbaum
7b2dfef289 Release 1.0.0 2018-03-26 12:49:52 -07:00
Natalie Weizenbaum
74cfe29814
Remove the deprecated render() function (#270) 2018-03-26 12:45:43 -07:00
Natalie Weizenbaum
6608a46d1e Make errors subtypes of Error 2018-03-23 15:22:10 -07:00
Natalie Weizenbaum
0e5a707ab4 Support both data and path options for the Node API 2018-03-23 14:55:28 -07:00
Natalie Weizenbaum
4c293f3ca7
Allow "!" in custom property values (#266)
Closes #260
2018-03-22 17:07:19 -07:00
Natalie Weizenbaum
2dae4f61f3 Release 1.0.0-rc.1 2018-03-16 16:23:57 -07:00
Natalie Weizenbaum
0cc3777b46
Fix media query merging (#258)
Closes #244
2018-03-16 16:22:56 -07:00
Natalie Weizenbaum
65229499b3
Name the standalone executable sass rather than dart-sass (#257) 2018-03-16 14:38:46 -07:00
Natalie Weizenbaum
9d3c8cdc1e
Allow mod 0 (#255)
Closes #254
2018-03-16 13:39:21 -07:00
Natalie Weizenbaum
7fd8f7d6c2
Add an --indented flag (#253)
Closes #105
2018-03-11 23:07:31 -07:00
Natalie Weizenbaum
b93fcdb5ed Add a --quiet flag to the CLI
Partially addresses #105
2018-03-11 21:05:34 -07:00
Natalie Weizenbaum
4c6494c288 Add a Logger class to control how output is emitted 2018-03-11 21:05:34 -07:00
Natalie Weizenbaum
da32588af1
Add support for the --load-path flag (#251)
Partially addresses #105
2018-03-11 20:39:00 -07:00
Natalie Weizenbaum
07b02174e0
Represent DynamicImport.url as a String (#250)
This works around dart-lang/sdk#32490. We need to preserve the leading
"./" to match Node Sass's behavior.

Closes #246
2018-03-11 15:46:59 -07:00
John Harvey
e63b8e1b40 Add support for _index files (#220)
See sass/sass#690
2018-03-09 14:46:46 -08:00