Jennifer Thakar
fba0ea37a1
Properly handle escaped @else
( #1014 )
...
Fixes #1011 .
This also fixes a bug where `@else` was parsed case-insensitively
(unlike all other Sass at-rules, which must be lowercase).
2020-05-28 11:48:24 -07:00
awjin
21a1c58b20
Don't read file
if Node importer returns file
and contents
.
...
Instead, use `contents` with `file` as the canonical url.
Closes https://github.com/sass/dart-sass/issues/975 .
2020-04-24 17:38:30 -07:00
Jennifer Thakar
7160b6426d
Add missing constants to JS API ( #990 )
...
Fixes #977 .
2020-04-24 16:11:46 -07:00
Natalie Weizenbaum
a7b0ad8e64
Release 1.26.5 ( #987 )
...
This needs a release because the release process for 1.26.4 was broken
by dart-lang/sdk#41259 .
2020-04-23 18:39:10 -07:00
Natalie Weizenbaum
bf35513a4c
Avoid adding duplicate modules when importing forwarded stylesheets ( #973 )
...
Avoid adding duplicate modules when importing forwarded stylesheets
In Google stylesheets that imported import-only stylesheets with many
forwards many of times, we were seeing Environment._globalModules grow
large enough that variable accesses were a problem. This addresses
that in several ways:
* Forwarded modules are now ignored if the module is already being
forwarded.
* Module equality is more intelligent, so that shadowed and forwarded
modules can be effectively de-duplicated.
* If a module would be fully shadowed by a later import *and* that
module has no CSS, we no longer add an empty ShadowedModule to the
module list.
2020-03-24 15:31:06 -07:00
georgpukk
4d78316cb7
Fix a check that prevents compiling .css files to themselves ( #968 )
...
Co-Authored-By: Natalie Weizenbaum <nweiz@google.com>
2020-03-11 14:48:00 -07:00
Natalie Weizenbaum
cb8a048e58
Refactor Extender._extendOrReplace() ( #965 )
...
This combines all targets into a single extender invocation, which is
more efficient and allows it to more aggressively do redundant
selector elimination.
2020-02-28 15:48:36 -08:00
Natalie Weizenbaum
a333059e71
Keep recompiling downstream dependencies after an error in --watch
...
Prior to this, the watcher handled all the logic around recompiling
stylesheets if an upstream file was deleted or added in a way that
could affect their import resolution. This left a gap where the
stylesheet graph wouldn't be aware that a newly-added file had become
upstream dependency of an existing downstream file, leading to
recompilation failures.
This commit fixes that by moving all that logic into the stylesheet
graph. The graph now has full and sole responsibility for providing a
consistent view of which stylesheets depend on one another even as the
shape of the graph changes, and the watcher is just a client of that
logic.
Closes #550
2020-02-24 20:18:03 -08:00
Natalie Weizenbaum
01ed720e9c
Temporarily disable deploying to Chocolatey ( #960 )
...
The cli_pkg Chocolatey deployment is still failing for unknown
reasons, and until I have time to debug it I want to get a full
release out.
2020-02-24 11:38:42 -08:00
Natalie Weizenbaum
4f8f509584
Cut a release ( #958 )
...
* Use cli_pkg's updated Chocolatey support
* Stop running Node tests on the Dart dev channel for now
See dart-lang/test#1184
2020-02-19 13:42:56 -08:00
Natalie Weizenbaum
0d0270cb12
Cut a release ( #957 )
2020-02-13 16:05:04 -08:00
Natalie Weizenbaum
6d388248b6
Eagerly initialize Environment._globalModules ( #952 )
...
We had been lazily initializing this to be more efficient when no
global modules were used, but this meant that the object wasn't shared
with closures created for mixins and functions that were created when
it was still `null`, so later imported forwards weren't visible to
those members.
2020-02-13 15:23:53 -08:00
Natalie Weizenbaum
0a2142dc86
Don't include leading underscores in implicit namespaces ( #955 )
...
Closes #934
See sass/sass#2800
2020-02-12 12:52:53 -08:00
Natalie Weizenbaum
7d8002ec9b
Cut a release
2020-02-07 17:04:13 -08:00
Natalie Weizenbaum
67c4e1bdea
Don't throw conflict errors for identical members ( #947 )
...
See sass/sass#2820
Closes #946
2020-02-07 15:17:05 -08:00
Natalie Weizenbaum
73ddae9c34
Bump the pubspec and add a CHANGELOG entry
...
Normally I'd just release this, but releasing is currently on hold
until a few cli_pkg bugs are fixed.
2020-02-07 01:00:41 -08:00
Natalie Weizenbaum
7457d2e9e7
Create a release to test cli_pkg infrastructure ( #940 )
2020-01-24 16:49:59 -08:00
Natalie Weizenbaum
eeeac1d689
Give JavaScript value objects useful constructor.name values ( #936 )
...
Closes #810
2020-01-17 14:46:10 -08:00
awjin
4c0c6b48e4
Merge branch 'master' into math-functions
2020-01-16 14:55:40 -08:00
Awjin Ahn
75cab86448
Add trigonometric math functions. ( #921 )
...
See https://github.com/sass/sass-spec/pull/1504
2020-01-15 14:44:13 -08:00
Awjin Ahn
3cbaec11b2
Add exponential math functions. ( #909 )
2020-01-15 14:44:13 -08:00
awjin
d487d761bd
Revert "Revert "Add built-in variables e and pi. ( #907 )""
...
This reverts commit 3c64addbf3
.
2020-01-15 14:44:13 -08:00
awjin
5f72acb14d
Revert "Revert "Adds built-in clamp() and hypot() ( #906 )""
...
This reverts commit 76280409bd
.
2020-01-15 14:44:13 -08:00
Natalie Weizenbaum
0c1370ce25
Allow errors to refer to multiple source spans at once
...
This makes error messages for issues like configuring a module after
it's loaded much clearer.
2020-01-10 22:31:48 -08:00
Natalie Weizenbaum
ca63b1ba7d
Don't try to resolve relative Node importer URLs for source maps ( #923 )
...
* Don't try to resolve relative Node importer URLs for source maps
Closes #922
* Reformat
2020-01-09 13:14:44 -08:00
Natalie Weizenbaum
e110961120
Pass the version variable to script snapshots at build time ( #920 )
...
Closes #914
See https://github.com/dart-lang/sdk/issues/36579#issuecomment-571386118
2020-01-07 13:53:30 -08:00
Jennifer Thakar
bfdf4b35a4
Fix import-only files for Node importers ( #919 )
2020-01-03 15:41:12 -08:00
Jennifer Thakar
79d9a73474
Cache separate canonical URLs for @use and @import ( #908 )
...
Fixes #899 .
The cache for canonical URLs is now keyed on *both* the rule URL and
whether that URL was canonicalized for an `@import` rule.
2020-01-02 15:25:02 -08:00
Jennifer Thakar
76280409bd
Revert "Adds built-in clamp() and hypot() ( #906 )"
...
This reverts commit 24f84e2c88
.
2020-01-02 13:45:51 -08:00
Jennifer Thakar
3c64addbf3
Revert "Add built-in variables e and pi. ( #907 )"
...
This reverts commit 2cb69e70ab
.
2020-01-02 13:45:49 -08:00
Awjin Ahn
2cb69e70ab
Add built-in variables e and pi. ( #907 )
2019-12-26 16:31:33 -08:00
Awjin Ahn
24f84e2c88
Adds built-in clamp() and hypot() ( #906 )
2019-12-26 12:40:08 -08:00
Natalie Weizenbaum
de3f3208e9
Support @forward ... with
...
See sass/sass#2744
Closes #846
2019-11-27 16:03:43 -08:00
Jennifer Thakar
8270dc1664
Support configuring modules through imports ( #885 )
...
Fixes #882
See sass/sass-spec#1497
2019-11-26 09:46:51 -08:00
Natalie Weizenbaum
15be59be31
Make SassFormatException implement SourceSpanFormatException ( #891 )
2019-11-25 18:54:45 -08:00
Natalie Weizenbaum
731bd441ca
Don't produce name conflict errors due to imports
...
Closes #888
2019-11-20 16:25:48 -08:00
Natalie Weizenbaum
aa76c8ab3b
Always create scopes for nested imports
2019-11-20 16:21:03 -08:00
Natalie Weizenbaum
aac599947d
Run the GitHub Windows release on the latest Dart version ( #886 )
2019-11-18 17:33:56 -08:00
Natalie Weizenbaum
e1e96338d8
Bump the version
2019-11-15 16:40:47 -08:00
Natalie Weizenbaum
0d782fbccf
Fix inline comments in the indented syntax ( #881 )
...
Closes #880
2019-11-15 15:45:11 -08:00
Awjin Ahn
07b5c84b7d
Fix arity in overloaded function argument error ( #883 )
...
When overloaded functions receive an incorrect number of positional
arguments, determine which overload has the most similar number of
arguments, and then correctly display that number in the error.
Closes #520
sass/sass-spec#1496
2019-11-15 14:26:11 -08:00
Awjin Ahn
3d1dab3563
Print call-site for @errors in mixins and functions ( #878 )
...
For any @errors encountered in mixins or functions, use the call-site
(instead of the @error rule) as the span printed in the error message.
Closes #474
See sass/sass-spec#1494
2019-11-13 17:56:35 -08:00
Natalie Weizenbaum
44059573bb
Watch files through @forward rules ( #871 )
...
Closes #870
2019-11-04 13:32:27 -08:00
Natalie Weizenbaum
be4ca60045
Propagate selector source specificity between modules
...
Closes #866
2019-10-30 15:11:25 -07:00
Natalie Weizenbaum
3392db0074
Don't compile .css files in directories to themselves ( #862 )
...
This also adds support for compiling .css files in directories *at
all*, which had previously only worked in --watch mode.
Closes #853
2019-10-29 23:48:21 +00:00
Natalie Weizenbaum
1b17ab76cf
Reset the forwarded config to empty for @use and meta.load-module() ( #855 )
...
In #827 I made configuration never be null, but this turns out to be
overkill: we still need a way for _loadModule() and _execute() to
distinguish between "use the existing configuration" (for @forward)
and "use no configuration" (for an unconfigured @use or
meta.load-module()). We now use null as a sentinel value there, while
still ensuring that _configuration is non-nullable.
Closes #854
2019-10-22 01:35:11 +01:00
Natalie Weizenbaum
73de08b817
Only generate and update selectors, not rules, in Extender ( #856 )
...
We switched to *updating* selectors a while ago so that cloned rules
would continue to see updates in their selectors, but we were still
generating and tracking rules in the Extender. This caused skew
between what rules the extender knew about and what rules actually
existed in situations where rules were copied (such as when resolving
nested media queries).
There's no principled reason the extender needs to know about style
rules at all, so now it just tracks modifiable wrappers of selectors.
These are re-used even when style rules are cloned, so they're safe
from the skew problem.
Closes #843
2019-10-21 21:07:51 +01:00
Natalie Weizenbaum
6b8c168779
Improve error messages for color functions that aren't in sass:color ( #844 )
2019-10-14 17:56:13 -07:00
Natalie Weizenbaum
e68592f8f3
Allow saturate() in plain CSS files ( #845 )
...
Closes #840
2019-10-14 11:47:16 -07:00
Jennifer Thakar
664260159e
Update changelog and bump pubspec version
2019-10-10 15:42:39 -07:00
Natalie Weizenbaum
87c9223b66
Fix broken CHANGELOG links ( #836 )
2019-10-02 11:19:51 -07:00
Natalie Weizenbaum
5052350150
Bump the pubspec and add a changelog entry for @use
2019-10-01 14:54:54 -07:00
Natalie Weizenbaum
d901bcb00c
Properly handle some CSS identifier edge cases ( #816 )
...
See sass/sass#2738
Closes #815
2019-09-06 16:54:54 -07:00
Natalie Weizenbaum
aea990d4fc
Properly watch .css files for changes ( #814 )
...
Closes #806
2019-09-03 16:42:21 -07:00
Natalie Weizenbaum
4ccddf8b13
Dash-normalize user-defined functions ( #813 )
...
Closes #811
2019-09-03 16:00:07 -07:00
Natalie Weizenbaum
35880d171f
Check fs.existsSync() before running fs.statSync() ( #812 )
...
This produces non-negligible speed improvements for Node users with
lots of imports.
2019-09-03 13:26:57 -07:00
Natalie Weizenbaum
a89c67b563
Fix unquoted plain-CSS imports ( #800 )
...
Closes #799
2019-08-28 14:09:35 -07:00
Natalie Weizenbaum
fc8c987fc1
Fix a few @extend edge cases ( #797 )
2019-08-16 14:00:14 -07:00
Natalie Weizenbaum
0e5ed4a37d
Fix dash-insensitivity in get-function() ( #795 )
...
Closes #792
2019-08-14 12:20:47 -07:00
Natalie Weizenbaum
c8ac543d1e
Re-add support for Node Carbon ( #785 )
...
Apparently npm and Yarn won't avoid installing a package version that
declares incompatibility with them, so dropping compatibility for an
old version is actually a breaking change 😭 .
2019-07-29 22:32:53 +01:00
Natalie Weizenbaum
d840b84b59
Clarify the error for the wrong number of positional arguments
...
Closes #776
2019-07-25 08:37:01 +01:00
Natalie Weizenbaum
382af499e0
Avoid double "Error:" headers when reporting selector parse errors
...
Closes #774
2019-07-25 08:37:01 +01:00
Natalie Weizenbaum
44b542fcef
Include argument names when reporting selector parse errors
2019-07-25 08:37:01 +01:00
Natalie Weizenbaum
8d5e3d9a67
Include argument names when reporting range errors
...
Closes #771
2019-07-25 08:37:00 +01:00
Natalie Weizenbaum
d0f471ca9d
Drop support for Node 8.x
...
url.pathToFileURL, which wasn't supported until Node 10.x, is now used
in node_preamble.
2019-07-22 16:51:15 -07:00
Natalie Weizenbaum
b1707f61cd
Release 1.22.8
...
This doesn't contain any code changes relative to 1.22.7, but the JS
release will pick up mbullington/node_preamble.dart#16 .
2019-07-22 14:47:38 -07:00
Natalie Weizenbaum
ea4436b87d
Limit the Dart SDK constraint to ^2.4.0 ( #769 )
...
2.3.2 and earlier releases suffered from dart-lang/sdk#37027, which
causes them to fail to parse Dart Sass.
Closes #768
2019-07-18 21:49:36 +01:00
Natalie Weizenbaum
c794abd858
Eagerly dash-normalize Sass identifiers
...
This avoids using maps and sets with custom equality, which are
moderately inefficient relative to built-in maps and sets on both Node
and the Dart VM. In order to make error messages continue to use the
original identifiers where possible, this updates some of them to rely
more heavily on their associated source spans for context.
2019-07-16 19:42:38 -07:00
Natalie Weizenbaum
535030bb0f
Release 1.22.5
2019-07-15 21:59:54 +01:00
Natalie Weizenbaum
0e47e03305
Fix at-rules in nested imports ( #758 )
...
Closes #755
2019-07-12 01:55:30 +01:00
Natalie Weizenbaum
d3e288ccf2
Support map-remove() with a named $key argument
...
Closes #742
2019-07-03 15:31:56 -07:00
Natalie Weizenbaum
eff8c37457
Fix a deadlock in zip()
...
Closes #739
2019-07-03 15:31:56 -07:00
Natalie Weizenbaum
5ff434da6a
Fix join() and append() $separator error messages
...
Closes #738
2019-07-03 15:31:56 -07:00
Natalie Weizenbaum
47e0cfc8c8
Empty maps have undecided separators
...
Closes #737
2019-07-03 15:31:56 -07:00
Natalie Weizenbaum
821b5e2521
Fix str-insert() with $index: -1
...
Closes #733
2019-07-02 17:25:46 -07:00
Natalie Weizenbaum
40df8e3bc1
Fix str-slice() with astral plane characters
...
Closes #732
2019-07-02 17:25:46 -07:00
Natalie Weizenbaum
2105a138c0
Clamp $alpha in adjust-color() with HSL args
...
Closes #708
2019-07-02 17:25:45 -07:00
Natalie Weizenbaum
7bfba04b79
Throw an error for plain-CSS invert() with $weight
...
Closes #705
2019-07-02 17:25:36 -07:00
Natalie Weizenbaum
d5adb4621e
Fix invert() with $weight: 50%
...
Closes #704
2019-07-02 17:25:25 -07:00
Natalie Weizenbaum
9838caff6f
Improve errors for alpha() with the wrong number of arguments
...
Closes #700
2019-07-02 17:25:14 -07:00
Natalie Weizenbaum
ed06a41afc
Fix the argument name for a single-argument saturate() function
...
Closes #699
2019-07-02 16:10:28 -07:00
Natalie Weizenbaum
60af5f6c25
Release 1.22.2 ( #745 )
...
The CHANGELOG entry from #727 got misplaced; that code hasn't been
released yet.
2019-07-01 13:31:13 -07:00
Natalie Weizenbaum
532358d7fa
Merge pull request #727 from sass/static-require
...
Require dependencies in the preamble rather than through JS-interop
2019-06-28 14:32:18 -07:00
Natalie Weizenbaum
2cdbbebcaf
Declare support for Chokidar 3.0.0 ( #731 )
...
Closes #730
2019-06-26 16:06:22 -07:00
Natalie Weizenbaum
174ef128a2
Merge remote-tracking branch 'origin/feature.use' into merge-use
2019-06-24 14:12:05 -07:00
Natalie Weizenbaum
494e208067
Require dependencies in the preamble rather than through JS-interop
...
Closes #726
2019-06-19 19:41:16 +01:00
Natalie Weizenbaum
a46e779675
Clarify !global deprecation warnings
...
Closes #723
2019-06-18 17:39:29 -07:00
Natalie Weizenbaum
e4b18b5231
Produce better stack traces for syntax errors loaded via import/use ( #722 )
...
We now wrap _withStackFrame() around wider sections of code, including
_loadStylesheet() which handles parse errors, so that the @use/@import
stack frames are available.
2019-06-18 17:26:46 -07:00
Natalie Weizenbaum
4716349a0e
Add new module-system features for existing functions ( #720 )
2019-06-18 12:03:12 -07:00
Natalie Weizenbaum
a87631777b
Declare a "sass" executable in the pubspec ( #712 )
2019-06-06 21:19:09 +01:00
Natalie Weizenbaum
bea609d74b
Add a top-level warn() function for functions and importers ( #711 )
...
In addition to being useful for users of Sass, this will make it
possible for core Sass functions to produce warnings without needing
an explicit reference to the evaluator.
2019-06-06 19:42:44 +01:00
Natalie Weizenbaum
48c284b4ef
Properly mark secure variables so they're decrypted by Travis ( #697 )
2019-05-31 17:01:33 +01:00
Natalie Weizenbaum
2836780339
Merge pull request #689 from sass/exponent
...
Fix some number serialization bugs
2019-05-24 15:09:37 -07:00
Natalie Weizenbaum
0fe0208f6e
Remove exponent notation for integers on Node.js
...
Closes #688
2019-05-21 13:36:36 -07:00
Natalie Weizenbaum
fb383de20e
Fix a bug in SerializeVisitor._writeDecimal
...
This function didn't expect a number ending in ".0", because they're
normally filtered out by fuzzyAsInt(). However, they can make it
through for very large doubles.
2019-05-20 15:50:45 -07:00
Natalie Weizenbaum
768da7088c
Resolve imports using custom imports before load paths ( #687 )
...
Closes #681
2019-05-20 15:34:57 -07:00
Natalie Weizenbaum
4b7699291c
Compile release executables in native mode ( #679 )
2019-05-15 16:02:02 -07:00
Natalie Weizenbaum
60fc306ab4
Release 1.20.1
...
This doesn't have any code changes, but I want to verify that the new
deployment infrastructure works and the only way to do that is to
actually deploy.
2019-05-03 13:13:20 -07:00
Natalie Weizenbaum
34c068a189
Generate a CSS file describing an error when one occurs ( #659 )
...
Closes #657
2019-05-02 18:14:25 -07:00
Natalie Weizenbaum
407eefded1
Add support for attribute selector modifiers ( #658 )
...
Closes #656
2019-04-30 11:31:18 -07:00