Commit Graph

235 Commits

Author SHA1 Message Date
Christophe Coevoet
6ea8ce6cf9
Fix the CI to use a PR version of sass-spec (#1201)
The previous implementation contained 2 mistakes:

- there was a mismatch between names of env variables in the workflow
  config and in the script
- the `github.base_ref` property in github actions contains a branch
  name, not a full git ref like `github.ref`
2021-01-13 13:06:56 -08:00
Natalie Weizenbaum
a2d2fe20fd
Wait 30 seconds for the npm package to be available for Bazel (#1202) 2021-01-12 13:59:59 -08:00
Natalie Weizenbaum
e97dd1a279
Merge pull request #1198 from sass/deploy
Fix some deployment infrastructure
2021-01-11 17:41:17 -08:00
Natalie Weizenbaum
0b877a127d Fix an analysis hint 2021-01-11 17:04:00 -08:00
Natalie Weizenbaum
b9f313295b
Update benchmarks (#1196) 2021-01-11 16:54:14 -08:00
Natalie Weizenbaum
f3bd9103ed If Yarn can't find the new Sass version immediately, wait 10 seconds 2021-01-11 16:44:51 -08:00
Natalie Weizenbaum
ec8cfb32f9 Use GH_TOKEN and GH_USER for Bazel deploy 2021-01-11 16:37:46 -08:00
Natalie Weizenbaum
0cae33007f
Fix the expected format for GitHub refs (#1197) 2021-01-11 16:11:24 -08:00
Natalie Weizenbaum
ae967c7e6e
Remove lingering references to Travis CI (#1195) 2021-01-11 15:02:36 -08:00
Natalie Weizenbaum
c1cdabc4a3 Use GH_* instead of GITHUB_* for environment variables
According to [the docs], environment variables may not begin with
`GITHUB_`.

[the docs]: https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables#naming-conventions-for-environment-variables
2021-01-08 17:22:07 -08:00
Christophe Coevoet
b4ab18968e Migrate the CI to github actions 2021-01-08 17:22:07 -08:00
Natalie Weizenbaum
4a0da21ed3
Fix a stack overflow when setting pkg.githubReleaseNotes (#1130) 2020-10-29 13:43:27 -07:00
Natalie Weizenbaum
a9a3946fb4
Use node_interop rather than manually declaring Node APIs (#1127) 2020-10-28 15:00:05 -07:00
Natalie Weizenbaum
73ebf92e9f
Support the latest version of the analyzer package (#1115) 2020-10-14 14:10:46 -07:00
Natalie Weizenbaum
ca39c834cd
Use cli_pkg 1.0.0-beta.10 (#1114) 2020-10-13 17:37:22 -07:00
Natalie Weizenbaum
6ec78f975b
Test against a matching sass-spec feature branch by default (#1082)
Rather than always defaulting to master, if Travis is running for a
feature branch or a pull request targeting a feature branch, it will
default to using the same feature branch in sass-spec.
2020-09-16 17:53:36 -07:00
Jennifer Thakar
830bb3aab2
Move Node tests on Windows to Travis (#1063)
* Move Node tests on Windows to Travis

Appveyor is flaky and can't be restarted by all team members, so moving
everything to Travis is preferable if we can get it to work.

* Actually use latest stable Node

This should also workaround the issue with lts/* not working on
Windows.

* Use npm.cmd instead of raw npm on Windows

* Use p.prettyUri() for Node API tests

Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
2020-09-08 09:23:46 -07:00
Natalie Weizenbaum
9f640625e9
Improve the error messages for syntax errors (#1055)
* Produce a useful error for "@else i<EOF>"

* Produce a useful error for out-of-range hex escapes

Closes #1029, #1049, #1030
2020-08-10 13:55:13 -07:00
Jennifer Thakar
fcd7c26a6f
Fix release notes to include changes (#1037) 2020-07-01 14:59:26 -07:00
Natalie Weizenbaum
cf43f0d851
Add a release header (#961)
This got dropped in the move to cli_pkg.

Closes #944
2020-03-09 12:17:09 -07:00
Natalie Weizenbaum
3318efa087
Export the Bazel deploy task from grind.dart (#963) 2020-02-25 14:05:01 -08:00
Natalie Weizenbaum
9a23831cb9 Fix a typo in the Chocolatey XML 2020-02-07 17:03:45 -08:00
Natalie Weizenbaum
5450c1c07b
Use cli_pkg to build and release executables (#924) 2020-01-24 13:05:04 -08:00
Natalie Weizenbaum
e110961120
Pass the version variable to script snapshots at build time (#920)
Closes #914
See https://github.com/dart-lang/sdk/issues/36579#issuecomment-571386118
2020-01-07 13:53:30 -08:00
Natalie Weizenbaum
7113a729cd
Update dependency versions (#918) 2020-01-02 14:53:19 -08:00
Natalie Weizenbaum
ec3d0ddc19 Fix new pedantic lints 2019-12-18 15:46:36 -08:00
Natalie Weizenbaum
be05a5d77a Use dart2native rather than dart2aot 2019-11-15 16:40:15 -08:00
Natalie Weizenbaum
20978e0320 Fix new strict inference hints from Dart 2.6 2019-11-06 14:47:24 -08:00
Natalie Weizenbaum
3de78be2f0
Plug in the actual Sass compiler (#5)
This now supports real CompileRequest and CompileResponses, although
it's missing features like importers, custom functions, and source
maps.
2019-11-04 19:50:50 -08:00
Natalie Weizenbaum
2b11aa1c21 Use cli_pkg to deploy to GitHub 2019-11-01 19:23:33 -07:00
Natalie Weizenbaum
3bf67e0011 Add a grinder task to generate protocol buffer libraries 2019-11-01 19:02:12 -07:00
Natalie Weizenbaum
d6aa4c25e1 Stop benchmarking Ruby Sass
We already know it's way slower than any other implementation,
it's reached end-of-life, and it slows down the process of running
benchmarks significantly.
2019-07-16 19:42:38 -07:00
Natalie Weizenbaum
a841882724 Don't compile to JS in minified mode
The JS size doesn't really matter on the server side, and this makes
profiling the release-mode binary substantially easier, as well as
improving the quality of stack traces provided by downstream users.
2019-07-15 21:59:54 +01:00
Natalie Weizenbaum
fb75fc39ce
Fix a Travis task that was broken by sass/sass-spec#1426 (#757) 2019-07-10 16:02:40 -07:00
Natalie Weizenbaum
532358d7fa
Merge pull request #727 from sass/static-require
Require dependencies in the preamble rather than through JS-interop
2019-06-28 14:32:18 -07:00
Natalie Weizenbaum
033533ae75
Avoid deprecated analyzer APIs (#735) 2019-06-26 14:53:37 -07:00
Natalie Weizenbaum
174ef128a2 Merge remote-tracking branch 'origin/feature.use' into merge-use 2019-06-24 14:12:05 -07:00
Natalie Weizenbaum
31f3ca2ead Replace dynamic require()s in dependencies with static alternatives 2019-06-20 19:05:23 +01:00
Natalie Weizenbaum
494e208067 Require dependencies in the preamble rather than through JS-interop
Closes #726
2019-06-19 19:41:16 +01:00
Natalie Weizenbaum
e888f84ce5 Merge branch 'master' into feature.use 2019-06-06 21:46:51 +01:00
Natalie Weizenbaum
11e3749721
Merge pull request #709 from sass/analysis
Enable stricter analysis options, especially around typing
2019-05-31 17:01:13 +01:00
Natalie Weizenbaum
ac38653776 Enable strict raw types 2019-05-31 16:01:49 +01:00
Natalie Weizenbaum
79e9bbd816 Enable strict inference 2019-05-31 15:54:59 +01:00
Natalie Weizenbaum
1340ba7b8a Enable and fix (most) pedantic lints 2019-05-31 15:18:59 +01:00
Natalie Weizenbaum
58a525c435
Get npm and pub credentials from environment variables (#694)
Getting them from a file made the process of updating either set of
credentials convoluted and error-prone, and meant that if one needed
to be updated both had to be re-encrypted.

This also updates the pub credentials to accommodate the new scope, as
described in dart-lang/pub-dev#2281.
2019-05-24 16:43:04 -07:00
Natalie Weizenbaum
c76ef209af Merge branch 'master' into master-into-use 2019-05-20 16:52:20 -07:00
Natalie Weizenbaum
2317be8812
Give Module a type parameter rather than making it synchronized (#686)
This allows us to have one fewer synchronized file, which reduces
complexity, and also lets us just write "Module" in async code rather
than "AsyncModule".
2019-05-20 15:34:14 -07:00
Natalie Weizenbaum
db87ed2f0e
Use the new Dart 2.3.0 literal syntax (#684) 2019-05-17 18:02:12 -07:00
Natalie Weizenbaum
19df69d26c Continue running feature.use in use mode 2019-05-17 14:40:34 -07:00
Natalie Weizenbaum
7857c9eb09
Merge pull request #675 from sass/update
Update dependencies
2019-05-16 14:19:16 -07:00
Natalie Weizenbaum
6a5f6227f2
Pass the package version to dart2aot (#683)
This can't be set via dartaotruntime, so we have to set it at
compile-time.
2019-05-16 11:59:35 -07:00
Natalie Weizenbaum
7c9d63a4dc Reformat with the latest formatter 2019-05-15 18:17:26 -07:00
Natalie Weizenbaum
5ed3bbc9c7 Update dependencies 2019-05-15 18:17:06 -07:00
Natalie Weizenbaum
aaebd424ed Get rid of tool/synchronize.dart
This was moved to tool/grind/synchronize.dart in #318, but the old
file never got removed.
2019-05-15 18:17:06 -07:00
Natalie Weizenbaum
1027737d9c
Update encrypted credentials (#682)
The old npm credentials got leaked in sass/migrator#44 as a result of
dart-lang/pub#2132.
2019-05-15 18:02:32 -07:00
Natalie Weizenbaum
4b7699291c
Compile release executables in native mode (#679) 2019-05-15 16:02:02 -07:00
Natalie Weizenbaum
9ff1e20064
Run app-snapshot in the before-test grinder task (#660)
This matches the behavior recommended by the tests if the snapshot is
out-of-date.
2019-05-03 12:55:53 -07:00
Natalie Weizenbaum
75ec9241f0
Build standalone Mac OS releases on Mac OS bots (#662)
This will allow us to distribute application snapshots, rather than
script snapshots, for Mac OS.
2019-05-02 15:08:46 -07:00
Natalie Weizenbaum
8b03319c97 Run each type of test from its own script file 2019-04-25 11:51:50 -07:00
Natalie Weizenbaum
7bd0f422b9 Test Windows and OS X on Travis 2019-04-25 11:51:27 -07:00
Natalie Weizenbaum
a0e63ac704 Merge branch 'feature.use' into merge-use 2019-03-07 18:17:42 -08:00
Anthony Sottile
7249698cac https-ify sass-lang.com urls (#614)
See https://github.com/sass/sass-site/issues/217

Committed via https://github.com/asottile/all-repos
2019-03-04 16:38:55 -08:00
Natalie Weizenbaum
0929aa5ce2
Update pub credentials (#605)
Pub recently started requiring more OAuth2 scopes than our old
credentials held.
2019-02-22 15:53:44 -08:00
Natalie Weizenbaum
7a7aea95b3 Add a module class and a way to create it from an Environment 2019-02-21 00:30:04 -08:00
Natalie Weizenbaum
4d23acd119 Run tests against sass-spec's feature.use branch 2019-02-11 17:17:31 -08:00
Natalie Weizenbaum
3368e890cd
Add a grind script to sanity-check a release (#563)
Add a grind script to sanity-check a release

This will help avoid accidentally releasing dev versions 😖.
2019-01-09 19:45:27 -05:00
Natalie Weizenbaum
dbda396401
Compile to JS with -O4 (#555)
Closes #526
2019-01-03 10:47:12 -08:00
Natalie Weizenbaum
7ae11f1c0e Make synchronize_test draw from the canonical list of synced files 2018-12-20 16:22:43 -08:00
Natalie Weizenbaum
56247975ed Automatically synchronize lib/src/compile.dart 2018-12-10 17:39:21 -08:00
Natalie Weizenbaum
cc009fb235
Update the Chocolatey push URL (#538) 2018-12-06 17:08:59 -08:00
Natalie Weizenbaum
f914c39067
Fix pushing to Bazel again (#531)
With #506, we're pushing the master branch to the Bazel repo. But
we're actually committing to a detached HEAD, rather than the master
branch. This pushes the current HEAD instead.

Closes bazelbuild/rules_sass#61
2018-11-19 16:38:15 -08:00
Natalie Weizenbaum
487e5025ff Reformat with Dart-2-only features 2018-11-15 15:16:24 -08:00
Natalie Weizenbaum
5d885e6905 Enforce non-whitespace formatting rules 2018-11-14 13:53:55 -08:00
Natalie Weizenbaum
80afdd88f8 Run in Dart 2 runtime mode everywhere 2018-11-14 13:53:53 -08:00
Natalie Weizenbaum
1a100c4864
Push both tags AND branches to the Bazel repo (#506) 2018-11-01 14:32:01 -07:00
Natalie Weizenbaum
15fe12be21
Pass the --fast-startup flag to dart2js (#480)
My benchmarks indicate a small but reliable improvement in startup
time with this option.
2018-09-19 22:17:02 -04:00
Natalie Weizenbaum
6a76a1e058
Fix the Homebrew deployment script (#479)
The Git command for pushing a detached HEAD has changed slightly.
2018-09-19 22:16:21 -04:00
Natalie Weizenbaum
ddf687fba9
Merge pull request #475 from sass/benchmark
Clean up the benchmark code
2018-09-19 15:29:08 -04:00
Natalie Weizenbaum
04ada09a82
Get rid of the dart2 test tag (#477)
We're only ever running tests under Dart 2 now, so it's irrelevant
whether they're Dart 2-only.
2018-09-19 15:28:47 -04:00
Natalie Weizenbaum
f15400325b Make sure not to load Ruby Sass from the global installation 2018-09-17 15:33:36 -07:00
Natalie Weizenbaum
0e0237bcb2 Run benchmarks against Dart 2 as well 2018-09-17 15:33:36 -07:00
Natalie Weizenbaum
ea6af41867 Fail when a benchmark emits a non-0 exit code 2018-09-17 14:29:46 -07:00
Natalie Weizenbaum
a6f7d94830 Generate the proper trailing benchmark header 2018-09-17 14:29:46 -07:00
Natalie Weizenbaum
7b4137bb5a Run benchmarks against the release-compiled JS 2018-09-17 14:29:46 -07:00
Natalie Weizenbaum
ba22b59d2f Fix Dart VM invocations 2018-09-17 14:29:46 -07:00
Natalie Weizenbaum
67bd53b938 Add some real-world benchmarks 2018-09-17 14:29:46 -07:00
Natalie Weizenbaum
a86fb98749 Move benchmark generation into a grind task 2018-09-17 10:26:43 -07:00
Natalie Weizenbaum
918a3fedf2
Pass --omit-implicit-checks to dart2js in release mode (#473)
Substantially addresses #113
2018-09-11 14:39:47 -07:00
Natalie Weizenbaum
c5dff3e841
Remove the source map comment from the JS blob we release (#448)
See bazelbuild/rules_sass#44
2018-08-15 13:28:02 -07:00
Natalie Weizenbaum
3e5d4752c9
Add new npm credentials (#408)
The old credentials were invalidated due to
https://status.npmjs.org/incidents/dn7c1fgrr7ng.
2018-07-13 12:35:49 -07:00
Natalie Weizenbaum
8801279796
Run Yarn after updating the Bazel rule's package.json (#404)
See bazelbuild/rules_sass#36
2018-07-11 13:12:59 -07:00
Natalie Weizenbaum
cd0211c2ab
Fix the Chocolatey version of the Dart SDK (#389)
Dev SDKs changed from 2.0.0.XX-dev to 2.0.0.XX-dev-Y.
2018-06-27 17:42:07 -07:00
Natalie Weizenbaum
c462b82102 Run snapshots in Dart 1 mode
Until dart-lang/sdk#33257 is fixed, this ensures that users get as
much performance as possible.
2018-06-27 15:51:16 -07:00
Natalie Weizenbaum
1d176059f2
Reformat using the newest version of the formatter (#388) 2018-06-27 15:16:13 -07:00
Natalie Weizenbaum
ecc04665cf
Fix a couple more Grinder invocations (#387) 2018-06-27 14:32:44 -07:00
Natalie Weizenbaum
7e6f03fc18
Run the Dart CLI tests from app snapshots on CI (#383)
This substantially speeds up the test time, and once we re-enable Dart
2 support is should work around dart-lang/sdk#33257.
2018-06-27 13:12:16 -07:00
Natalie Weizenbaum
a87300a1e9 Use camel-case for grinder task names
This also causes Grinder to use hyphen-separated names for them on the
CLI, rather than underscore-separated.
2018-06-25 16:40:26 -07:00
Natalie Weizenbaum
458598ed83 Remove the constraint on which Dart versions can compile Sass to JS
Sass's entire SDK constraint is now within the constraint, so it no
longer does anything.
2018-06-25 16:40:19 -07:00
Natalie Weizenbaum
44b23d1874
Fetch the pull request body using @sassbot's credentials (#375)
This avoids running into GitHub's low rate limits for unauthenticated
requests.
2018-06-21 17:59:01 -07:00
Natalie Weizenbaum
281838e0da
Deploy to Bazel on release (#358)
Closes bazelbuild/rules_sass#28
2018-06-19 14:00:06 -07:00