Commit Graph

1946 Commits

Author SHA1 Message Date
Natalie Weizenbaum
e35b51135b Code review 2019-12-17 15:26:43 -08:00
Natalie Weizenbaum
de3f3208e9 Support @forward ... with
See sass/sass#2744
Closes #846
2019-11-27 16:03:43 -08:00
Natalie Weizenbaum
af648bfa7c Drop Configuration.clone()
There was no reason not to use the original configuration.
2019-11-27 13:42:43 -08:00
Jennifer Thakar
8270dc1664
Support configuring modules through imports (#885)
Fixes #882

See sass/sass-spec#1497
2019-11-26 09:46:51 -08:00
Natalie Weizenbaum
15be59be31
Make SassFormatException implement SourceSpanFormatException (#891) 2019-11-25 18:54:45 -08:00
Natalie Weizenbaum
9635a523b7
Merge pull request #890 from sass/import-forward-twice
Fix some @import edge cases
2019-11-21 11:42:45 -08:00
Natalie Weizenbaum
731bd441ca Don't produce name conflict errors due to imports
Closes #888
2019-11-20 16:25:48 -08:00
Natalie Weizenbaum
3ec2f3faaa
Fix a documentation typo (#889) 2019-11-20 16:25:37 -08:00
Natalie Weizenbaum
aa76c8ab3b Always create scopes for nested imports 2019-11-20 16:21:03 -08:00
Natalie Weizenbaum
f1410ffac1
Fix invalid YAML in .travis.yml (#887)
This also adds a test to verify that all YAML files are valid. Travis
won't run tests at all if its YAML is invalid, but this way Appveyor
can warn about broken Travis config and vice versa, and a local test
run will warn about either.
2019-11-19 14:27:20 -08:00
Natalie Weizenbaum
aac599947d
Run the GitHub Windows release on the latest Dart version (#886) 2019-11-18 17:33:56 -08:00
Natalie Weizenbaum
ab0a2b68cc
Merge pull request #884 from sass/fix-release
Fix release infrastructure for Dart 2.6
2019-11-15 17:02:29 -08:00
Natalie Weizenbaum
e1e96338d8 Bump the version 2019-11-15 16:40:47 -08:00
Natalie Weizenbaum
be05a5d77a Use dart2native rather than dart2aot 2019-11-15 16:40:15 -08:00
Natalie Weizenbaum
3ab40b0d6a Run Chocolatey on the latest Dart version
See dart-lang/sdk#38334
2019-11-15 16:37:16 -08:00
Natalie Weizenbaum
0d782fbccf
Fix inline comments in the indented syntax (#881)
Closes #880
2019-11-15 15:45:11 -08:00
Awjin Ahn
07b5c84b7d
Fix arity in overloaded function argument error (#883)
When overloaded functions receive an incorrect number of positional
arguments, determine which overload has the most similar number of
arguments, and then correctly display that number in the error.

Closes #520
sass/sass-spec#1496
2019-11-15 14:26:11 -08:00
Awjin Ahn
3d1dab3563 Print call-site for @errors in mixins and functions (#878)
For any @errors encountered in mixins or functions, use the call-site
(instead of the @error rule) as the span printed in the error message.

Closes #474
See sass/sass-spec#1494
2019-11-13 17:56:35 -08:00
Natalie Weizenbaum
c4b8932bf7
Merge pull request #875 from sass/fix-analysis
Fix new analysis hints
2019-11-06 16:04:10 -08:00
Nate Bosch
7b0faec321 Migrate to stream_transform extension methods
The non-extension implementation will be removed in the next version.

Bump the min SDK to 2.6.0 to reflect the fact that extension methods are
used.
2019-11-06 14:47:24 -08:00
Natalie Weizenbaum
20978e0320 Fix new strict inference hints from Dart 2.6 2019-11-06 14:47:24 -08:00
Natalie Weizenbaum
bf67080c62
Use the latest dev channel Dart (#850)
As suggested by https://github.com/dart-lang/sdk/issues/38334#issuecomment-542861835
2019-11-05 13:50:30 -08:00
Natalie Weizenbaum
44059573bb
Watch files through @forward rules (#871)
Closes #870
2019-11-04 13:32:27 -08:00
Natalie Weizenbaum
071c529772
Use nvm's "lts/*" alias for the latest stable Node (#872)
Follow-up from #859. It turns out that nvm's "stable" alias is
deprecated, Node itself doesn't consider odd-numbered releases
"stable" in any real sense, and pertinently the fibers package doesn't
guarantee support for them. By only building on LTS releases we avoid
all these shenanigans.
2019-11-04 11:48:13 -08:00
Natalie Weizenbaum
1a5102bedb
Merge pull request #869 from sass/second-law-use
Propagate selector source specificity between modules
2019-10-31 22:51:39 -07:00
Natalie Weizenbaum
be4ca60045 Propagate selector source specificity between modules
Closes #866
2019-10-30 15:11:25 -07:00
Natalie Weizenbaum
df5f3af4e9 Remove some unused specificity calculations 2019-10-30 14:23:55 -07:00
Natalie Weizenbaum
3392db0074
Don't compile .css files in directories to themselves (#862)
This also adds support for compiling .css files in directories *at
all*, which had previously only worked in --watch mode.

Closes #853
2019-10-29 23:48:21 +00:00
Howard
0ea2e0dbe0 Fix broken links in perf.md (#861) 2019-10-24 01:07:24 +01:00
Natalie Weizenbaum
3b36b5e638
Run against Node 12 rather than Node 13 (#859)
This works around laverdet/node-fibers#420
2019-10-23 00:01:51 +01:00
Natalie Weizenbaum
bb81bdd2c3
Release 1.23.1 (#858) 2019-10-22 20:58:14 +01:00
Natalie Weizenbaum
1b17ab76cf
Reset the forwarded config to empty for @use and meta.load-module() (#855)
In #827 I made configuration never be null, but this turns out to be
overkill: we still need a way for _loadModule() and _execute() to
distinguish between "use the existing configuration" (for @forward)
and "use no configuration" (for an unconfigured @use or
meta.load-module()). We now use null as a sentinel value there, while
still ensuring that _configuration is non-nullable.

Closes #854
2019-10-22 01:35:11 +01:00
Natalie Weizenbaum
73de08b817
Only generate and update selectors, not rules, in Extender (#856)
We switched to *updating* selectors a while ago so that cloned rules
would continue to see updates in their selectors, but we were still
generating and tracking rules in the Extender. This caused skew
between what rules the extender knew about and what rules actually
existed in situations where rules were copied (such as when resolving
nested media queries).

There's no principled reason the extender needs to know about style
rules at all, so now it just tracks modifiable wrappers of selectors.
These are re-used even when style rules are cloned, so they're safe
from the skew problem.

Closes #843
2019-10-21 21:07:51 +01:00
Natalie Weizenbaum
6b8c168779
Improve error messages for color functions that aren't in sass:color (#844) 2019-10-14 17:56:13 -07:00
Natalie Weizenbaum
e68592f8f3
Allow saturate() in plain CSS files (#845)
Closes #840
2019-10-14 11:47:16 -07:00
Jennifer Thakar
664260159e Update changelog and bump pubspec version 2019-10-10 15:42:39 -07:00
XhmikosR
a95d61e886 Typo fixes (#842) 2019-10-10 15:33:36 -07:00
Jennifer Thakar
c663995f50
Only error for directly configured core modules (#839)
Fixes #838.
2019-10-10 14:33:54 -07:00
Natalie Weizenbaum
87c9223b66
Fix broken CHANGELOG links (#836) 2019-10-02 11:19:51 -07:00
Natalie Weizenbaum
b3cd44f94c
Merge pull request #835 from sass/merge-use
Merge and enable feature.use 🎉
2019-10-01 16:33:05 -07:00
Natalie Weizenbaum
586a0eb703 Code review change 2019-10-01 15:05:11 -07:00
Natalie Weizenbaum
5052350150 Bump the pubspec and add a changelog entry for @use 2019-10-01 14:54:54 -07:00
Natalie Weizenbaum
97203f1527 Merge branch 'feature.use' 2019-10-01 14:26:32 -07:00
Natalie Weizenbaum
fa3c657b56
Support multiple global uses in one file (#833)
Closes #832
2019-09-27 21:36:37 +01:00
Natalie Weizenbaum
7d3440698f
Remove adjust-hue() from sass:color (#828)
See sass/sass#2740
2019-09-27 21:27:26 +01:00
Natalie Weizenbaum
75305a1d21
Always use a non-null map for _EvaluateVisitor._configuration (#827)
We had been using null to represent an empty configuration, but that
caused problems when an empty map snuck its way in as well. Now we
always use maps, with a const empty map for the common case.

See sass/sass#2744
2019-09-27 21:19:24 +01:00
Natalie Weizenbaum
31acfd178d
Add a compatibility note about Node.js versions (#834)
See #780
2019-09-26 17:17:30 +01:00
Natalie Weizenbaum
7bfbba0697
Merge pull request #830 from sass/merge-master
Merge master into feature.use
2019-09-26 17:14:34 +01:00
Natalie Weizenbaum
93a3a6f9f3 Merge branch 'master' into feature.use 2019-09-24 17:20:39 +01:00
Jennifer Thakar
553cf9a6d5 Fix bugs in RecursiveStatementVisitor (#824)
`AtRootRule.query` and `Declaration.value` can be null, so this should be checked before passing them on to `visitInterpolation` and `visitExpression`.
2019-09-23 07:33:28 -07:00