Add lint script

Co-authored-by: Michele Locati <michele@locati.it>
Co-authored-by: Quan TRAN <itscaro@users.noreply.github.com>

.editorconfig

@@ -8,3 +8,7 @@ end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = false
 insert_final_newline = true
+
+[*.{bat,cmd}]
+end_of_line = crlf
+charset = latin1

.travis.yml

@@ -24,7 +24,7 @@ jobs:
       language: go
       go: '1.13'
       before_script: GO111MODULE=on go install mvdan.cc/sh/v3/cmd/shfmt
-      script: shfmt -d -s -ln posix -i 0 -ci -kp install-php-extensions scripts/common scripts/travisci-test-extensions scripts/travisci-update-readme scripts/update-readme
+      script: shfmt -d -s -ln posix -i 0 -ci -kp install-php-extensions scripts/common scripts/lint scripts/travisci-test-extensions scripts/travisci-update-readme scripts/update-readme
 
     - <<: *test-extensions-job-template
       name: Test extensions on Alpine 3.7

README.md

@@ -144,6 +144,10 @@ Some extension has special requirements:
 
 ## How to contribute
 
+### Formatting code
+
+Before submitting any pull request, be sure to execute the `lint` script in the `scripts` directory (or `lint.bat` on Windows).
+
 ### Adding support to a new PHP extension?
 
 1. change the `install-php-extensions` script

scripts/Dockerfile-shfmt

@@ -0,0 +1,3 @@
+FROM golang
+
+RUN go get github.com/mvdan/sh/cmd/shfmt

scripts/lint

@@ -0,0 +1,30 @@
+#!/bin/sh
+
+set -o errexit
+set -o nounset
+
+if ! docker --version >/dev/null 2>/dev/null; then
+	printf 'Docker is not installed, or it is not running\n' >&2
+	exit 1
+fi
+
+#SRC_DIR="$(CDPATH= cd -- "$(dirname -- "$0")" && cd .. pwd)"
+
+if ! docker build -t docker-php-extension-installer-shfmt:latest -f scripts/Dockerfile-shfmt -q .; then
+	printf 'ERROR!' >&2
+	exit 1
+fi
+
+fix() {
+	printf 'Fixing %s... ' "$1"
+	if docker run --rm -v "$SRC_DIR:/src" -w /src docker-php-extension-installer-shfmt:latest shfmt -s -ln posix -i 0 -ci -kp -w "$1"; then
+		printf 'done.\n'
+	fi
+}
+
+fix install-php-extensions
+fix scripts/common
+fix scripts/lint
+fix scripts/travisci-test-extensions
+fix scripts/travisci-update-readme
+fix scripts/update-readme

scripts/lint.bat

@@ -0,0 +1,34 @@
+@echo off
+setlocal
+
+docker --version >NUL 2>NUL
+if errorlevel 1 goto :no-docker
+
+cd /d "%~dp0.."
+if errorlevel 1 goto err
+set SRC_DIR=%CD%
+
+docker build -t docker-php-extension-installer-shfmt:latest -f scripts\Dockerfile-shfmt -q .
+if errorlevel 1 goto :err
+
+call :fix install-php-extensions
+call :fix scripts/common
+call :fix scripts/lint
+call :fix scripts/travisci-test-extensions
+call :fix scripts/travisci-update-readme
+call :fix scripts/update-readme
+goto :eof
+
+:no-docker
+echo Docker is not installed, or it's not running >&2
+goto :eof
+
+:err
+echo ERROR! >&2
+goto :eof
+
+:fix
+echo|set /p="Fixing %1... "
+docker run --rm -v "%SRC_DIR%:/src" -w /src docker-php-extension-installer-shfmt:latest shfmt -s -ln posix -i 0 -ci -kp -w %1
+if not errorlevel 1 echo done.
+exit /b 0