danog/ext-php-rs
1
0
Fork 0
mirror of https://github.com/danog/ext-php-rs.git synced 2024-11-30 04:39:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make ClassMetadata: Send + Sync (#111)

Browse Source 
This wasn't the case because of `PhantomData<T>` inside the metadata.
Replacing this with `PhantomData<AtomicPtr<T>>` ensures that the
metadata will always be `Send + Sync`.
This commit is contained in:
David Cole 2021-11-23 18:59:09 +13:00 committed by GitHub
parent c12dde1866
commit 8d37afc510
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/class.rs
View File

@ -85,7 +85,10 @@ pub struct ClassMetadata<T> {
handlers: MaybeUninit<ZendObjectHandlers>, handlers: MaybeUninit<ZendObjectHandlers>,
ce: AtomicPtr<ClassEntry>, ce: AtomicPtr<ClassEntry>,
phantom: PhantomData<T>, // `AtomicPtr` is used here because it is `Send + Sync`.
// fn() -> T could have been used but that is incompatible with const fns at
// the moment.
phantom: PhantomData<AtomicPtr<T>>,
} }
impl<T> ClassMetadata<T> { impl<T> ClassMetadata<T> {