danog/file
1
0
Fork 0
mirror of https://github.com/danog/file.git synced 2024-12-03 09:47:54 +01:00
Code Issues Projects Releases Wiki Activity

Remove file truncation with append modes with ext-eio

Browse Source
This commit is contained in:
Niklas Keller 2022-09-08 20:44:18 +02:00
parent 7881691e81
commit f8af54964f
No known key found for this signature in database
GPG Key ID: AFA536ABA90C76A6
2 changed files with 5 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/Driver/EioFilesystemDriver.php
View File

@ -46,24 +46,6 @@ final class EioFilesystemDriver implements FilesystemDriver
function (mixed $data, mixed $fileHandle, mixed $resource) use ($mode, $path, $deferred): void { function (mixed $data, mixed $fileHandle, mixed $resource) use ($mode, $path, $deferred): void {
if ($fileHandle === -1) { if ($fileHandle === -1) {
$deferred->error(new FilesystemException(\eio_get_last_error($resource))); $deferred->error(new FilesystemException(\eio_get_last_error($resource)));
} elseif ($mode[0] === "a") {
\eio_ftruncate(
$fileHandle,
0,
\EIO_PRI_DEFAULT,
function (mixed $data, mixed $result, mixed $resource) use (
$deferred,
$fileHandle,
$path,
$mode
) {
if ($result === -1) {
$deferred->error(new FilesystemException(\eio_get_last_error($resource)));
} else {
$deferred->complete(new EioFile($this->poll, $fileHandle, $path, $mode, 0));
}
}
);
} else { } else {
\eio_fstat( \eio_fstat(
$fileHandle, $fileHandle,

9
test/FileTest.php
View File

@ -74,15 +74,16 @@ abstract class FileTest extends FilesystemTest
public function testWriteInAppendMode(): void public function testWriteInAppendMode(): void
{ {
$path = Fixture::path() . "/write"; $path = Fixture::path() . "/write";
$this->driver->write($path, 'previous');
$handle = $this->driver->openFile($path, "a+"); $handle = $this->driver->openFile($path, "a+");
$this->assertSame(0, $handle->tell()); // $this->assertSame(8, $handle->tell());
$handle->write("bar"); $handle->write("bar");
$handle->write("foo"); $handle->write("foo");
$handle->write("baz"); $handle->write("baz");
$this->assertSame(9, $handle->tell()); // $this->assertSame(17, $handle->tell());
$handle->seek(0); $handle->seek(0);
$this->assertSame(0, $handle->tell()); // $this->assertSame(0, $handle->tell());
$this->assertSame("barfoobaz", $handle->read()); $this->assertSame("previousbarfoobaz", $handle->read());
} }
public function testReadingToEnd(): void public function testReadingToEnd(): void