From 0236fc53362d16c36f39dc7a38141fb8b41715a9 Mon Sep 17 00:00:00 2001
From: Aaron Piotrowski <aaron@trowski.com>
Date: Thu, 16 Mar 2017 17:33:30 -0500
Subject: [PATCH] Kill worker forks
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Forking for workers is just not a good idea… it's too likely to be used irresponsibly.
---
 lib/Worker/WorkerFork.php      | 19 -------------------
 test/Worker/ForkPoolTest.php   | 20 --------------------
 test/Worker/WorkerForkTest.php | 15 ---------------
 3 files changed, 54 deletions(-)
 delete mode 100644 lib/Worker/WorkerFork.php
 delete mode 100644 test/Worker/ForkPoolTest.php
 delete mode 100644 test/Worker/WorkerForkTest.php

diff --git a/lib/Worker/WorkerFork.php b/lib/Worker/WorkerFork.php
deleted file mode 100644
index 4e9cc66..0000000
--- a/lib/Worker/WorkerFork.php
+++ /dev/null
@@ -1,19 +0,0 @@
-<?php
-
-namespace Amp\Parallel\Worker;
-
-use Amp\Promise;
-use Amp\Parallel\Forking\Fork;
-use Amp\Parallel\Worker\Internal\TaskRunner;
-
-/**
- * A worker thread that executes task objects.
- */
-class WorkerFork extends AbstractWorker {
-    public function __construct() {
-        parent::__construct(new Fork(function (): Promise {
-            $runner = new TaskRunner($this, new BasicEnvironment);
-            return $runner->run();
-        }));
-    }
-}
diff --git a/test/Worker/ForkPoolTest.php b/test/Worker/ForkPoolTest.php
deleted file mode 100644
index 873071b..0000000
--- a/test/Worker/ForkPoolTest.php
+++ /dev/null
@@ -1,20 +0,0 @@
-<?php
-
-namespace Amp\Parallel\Test\Worker;
-
-use Amp\Parallel\Worker\{ DefaultPool, WorkerFactory, WorkerFork };
-
-/**
- * @group forking
- * @requires extension pcntl
- */
-class ForkPoolTest extends AbstractPoolTest {
-    protected function createPool($min = null, $max = null) {
-        $factory = $this->createMock(WorkerFactory::class);
-        $factory->method('create')->will($this->returnCallback(function () {
-            return new WorkerFork;
-        }));
-
-        return new DefaultPool($min, $max, $factory);
-    }
-}
diff --git a/test/Worker/WorkerForkTest.php b/test/Worker/WorkerForkTest.php
deleted file mode 100644
index 06445d7..0000000
--- a/test/Worker/WorkerForkTest.php
+++ /dev/null
@@ -1,15 +0,0 @@
-<?php
-
-namespace Amp\Parallel\Test\Worker;
-
-use Amp\Parallel\Worker\WorkerFork;
-
-/**
- * @group forking
- * @requires extension pcntl
- */
-class WorkerForkTest extends AbstractWorkerTest {
-    protected function createWorker() {
-        return new WorkerFork;
-    }
-}