Enhance worker tests (#43)

test/Worker/AbstractPoolErrorTest.php

@@ -0,0 +1,29 @@
+<?php
+
+namespace Amp\Parallel\Test\Worker;
+
+use Amp\Loop;
+use Amp\Parallel\Worker\Pool;
+use Amp\PHPUnit\TestCase;
+
+abstract class AbstractPoolErrorTest extends TestCase
+{
+    /**
+     * @param int $min
+     * @param int $max
+     *
+     * @return \Amp\Parallel\Worker\Pool
+     */
+    abstract protected function createPool($max = Pool::DEFAULT_MAX_SIZE): Pool;
+
+    /**
+     * @expectedException        \Error
+     * @expectedExceptionMessage Maximum size must be a non-negative integer
+     */
+    public function testCreatePoolShouldThrowError()
+    {
+        Loop::run(function () {
+            $this->createPool();
+        });
+    }
+}

test/Worker/AbstractPoolTest.php

@@ -42,6 +42,39 @@ abstract class AbstractPoolTest extends TestCase
         });
     }
 
+    /**
+     * @expectedException         \Amp\Parallel\Context\StatusError
+     * @expectedExceptionMessage  The pool was shutdown
+     */
+    public function testShutdownShouldThrowStatusError()
+    {
+        Loop::run(function () {
+            $pool = $this->createPool();
+
+            $this->assertTrue($pool->isIdle());
+
+            yield $pool->shutdown();
+            yield $pool->shutdown();
+        });
+    }
+
+    /**
+     * @expectedException         \Amp\Parallel\Context\StatusError
+     * @expectedExceptionMessage  The pool was shutdown
+     */
+    public function testPullShouldThrowStatusError()
+    {
+        Loop::run(function () {
+            $pool = $this->createPool();
+
+            $this->assertTrue($pool->isIdle());
+
+            yield $pool->shutdown();
+
+            $pool->get();
+        });
+    }
+
     public function testGetMaxSize()
     {
         $pool = $this->createPool(17);

test/Worker/AbstractWorkerTest.php

@@ -60,6 +60,22 @@ abstract class AbstractWorkerTest extends TestCase
         });
     }
 
+    /**
+     * @expectedException         \Amp\Parallel\Context\StatusError
+     * @expectedExceptionMessage  The worker has been shut down
+     */
+    public function testEnqueueShouldThrowStatusError()
+    {
+        Loop::run(function () {
+            $worker = $this->createWorker();
+
+            $this->assertTrue($worker->isIdle());
+
+            yield $worker->shutdown();
+            yield $worker->enqueue(new TestTask(42));
+        });
+    }
+
     public function testEnqueue()
     {
         Loop::run(function () {

test/Worker/BasicEnvironmentTest.php

@@ -29,6 +29,25 @@ class BasicEnvironmentTest extends TestCase
         $this->assertNull($environment->get($key));
     }
 
+    public function testSetWithNullValue()
+    {
+        $environment = new BasicEnvironment;
+        $key = "key";
+
+        $this->assertNull($environment->set($key, null));
+    }
+
+    /**
+     * @expectedException        \Error
+     * @expectedExceptionMessage The time-to-live must be a positive integer or null
+     */
+    public function testSetShouleThrowError()
+    {
+        $environment = new BasicEnvironment;
+        $key = "key";
+        $environment->set($key, 1, 0);
+    }
+
     public function testArrayAccess()
     {
         $environment = new BasicEnvironment;

test/Worker/ProcessPoolErrorTest.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace Amp\Parallel\Test\Worker;
+
+use Amp\Parallel\Worker\DefaultPool;
+use Amp\Parallel\Worker\Pool;
+use Amp\Parallel\Worker\WorkerFactory;
+use Amp\Parallel\Worker\WorkerProcess;
+
+/**
+ * @group process
+ */
+class ProcessPoolErrorTest extends AbstractPoolErrorTest
+{
+    protected function createPool($max = Pool::DEFAULT_MAX_SIZE): Pool
+    {
+        $factory = $this->createMock(WorkerFactory::class);
+        $factory->method('create')->will($this->returnCallback(function () {
+            return new WorkerProcess;
+        }));
+
+        return new DefaultPool(-1, $factory);
+    }
+}

test/Worker/TaskErrorTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Amp\Parallel\Test\Worker;
+
+use Amp\Parallel\Worker\TaskError;
+use Amp\PHPUnit\TestCase;
+
+class TaskErrorTest extends TestCase
+{
+    public function testGetWorkerTrace()
+    {
+        $taskError = new TaskError('name', 'error_message', 'error_message_trace');
+
+        $this->assertSame('error_message_trace', $taskError->getWorkerTrace());
+    }
+}

test/Worker/TaskExceptionTest.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace Amp\Parallel\Test\Worker;
+
+use Amp\Parallel\Worker\TaskException;
+use Amp\PHPUnit\TestCase;
+
+class TaskExceptionTest extends TestCase
+{
+    public function testGetName()
+    {
+        $taskException = new TaskException('task_exception_name', 'task_exception_message', 'task_trace_message');
+
+        $this->assertSame('task_exception_name', $taskException->getName());
+    }
+
+    public function testGetWorkerTrace()
+    {
+        $taskException = new TaskException('task_exception_name', 'task_exception_message', 'task_trace_message');
+
+        $this->assertSame('task_trace_message', $taskException->getWorkerTrace());
+    }
+}

test/Worker/WorkerExceptionTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Amp\Parallel\Test\Worker;
+
+use Amp\Parallel\Worker\WorkerException;
+use Amp\PHPUnit\TestCase;
+
+class WorkerExceptionTest extends TestCase
+{
+    public function testConstructorShouldBeInstance()
+    {
+        $workerException = new WorkerException('work_exception_message');
+
+        $this->assertInstanceOf(WorkerException::class, $workerException);
+    }
+}