From eb33eee2833242f9f67827e881a8ad0432503292 Mon Sep 17 00:00:00 2001 From: Jakob Linskeseder Date: Sun, 17 Oct 2021 22:06:49 +0200 Subject: [PATCH] Add context to comment on php-fpm log-output See docker-library#358 (comment). --- 8.0/alpine3.16/fpm/Dockerfile | 3 ++- 8.0/bullseye/fpm/Dockerfile | 3 ++- 8.0/buster/fpm/Dockerfile | 3 ++- 8.1/alpine3.16/fpm/Dockerfile | 3 ++- 8.1/alpine3.17/fpm/Dockerfile | 3 ++- 8.1/bullseye/fpm/Dockerfile | 3 ++- 8.1/buster/fpm/Dockerfile | 3 ++- 8.2/alpine3.16/fpm/Dockerfile | 3 ++- 8.2/alpine3.17/fpm/Dockerfile | 3 ++- 8.2/bullseye/fpm/Dockerfile | 3 ++- 8.2/buster/fpm/Dockerfile | 3 ++- Dockerfile-linux.template | 3 ++- 12 files changed, 24 insertions(+), 12 deletions(-) diff --git a/8.0/alpine3.16/fpm/Dockerfile b/8.0/alpine3.16/fpm/Dockerfile index d423e84f..c0b51e24 100644 --- a/8.0/alpine3.16/fpm/Dockerfile +++ b/8.0/alpine3.16/fpm/Dockerfile @@ -231,7 +231,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/8.0/bullseye/fpm/Dockerfile b/8.0/bullseye/fpm/Dockerfile index c635e6ed..4cf5450c 100644 --- a/8.0/bullseye/fpm/Dockerfile +++ b/8.0/bullseye/fpm/Dockerfile @@ -246,7 +246,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/8.0/buster/fpm/Dockerfile b/8.0/buster/fpm/Dockerfile index 8d19c063..55bfd053 100644 --- a/8.0/buster/fpm/Dockerfile +++ b/8.0/buster/fpm/Dockerfile @@ -246,7 +246,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/8.1/alpine3.16/fpm/Dockerfile b/8.1/alpine3.16/fpm/Dockerfile index 34a3cb2c..a3c91a83 100644 --- a/8.1/alpine3.16/fpm/Dockerfile +++ b/8.1/alpine3.16/fpm/Dockerfile @@ -231,7 +231,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/8.1/alpine3.17/fpm/Dockerfile b/8.1/alpine3.17/fpm/Dockerfile index 5d1890ed..0d5775cc 100644 --- a/8.1/alpine3.17/fpm/Dockerfile +++ b/8.1/alpine3.17/fpm/Dockerfile @@ -231,7 +231,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/8.1/bullseye/fpm/Dockerfile b/8.1/bullseye/fpm/Dockerfile index 51c9240c..27fc1c43 100644 --- a/8.1/bullseye/fpm/Dockerfile +++ b/8.1/bullseye/fpm/Dockerfile @@ -246,7 +246,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/8.1/buster/fpm/Dockerfile b/8.1/buster/fpm/Dockerfile index 6397678c..0a617146 100644 --- a/8.1/buster/fpm/Dockerfile +++ b/8.1/buster/fpm/Dockerfile @@ -246,7 +246,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/8.2/alpine3.16/fpm/Dockerfile b/8.2/alpine3.16/fpm/Dockerfile index 6cb48d19..32d37896 100644 --- a/8.2/alpine3.16/fpm/Dockerfile +++ b/8.2/alpine3.16/fpm/Dockerfile @@ -231,7 +231,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/8.2/alpine3.17/fpm/Dockerfile b/8.2/alpine3.17/fpm/Dockerfile index 81a34b15..a5df07ec 100644 --- a/8.2/alpine3.17/fpm/Dockerfile +++ b/8.2/alpine3.17/fpm/Dockerfile @@ -231,7 +231,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/8.2/bullseye/fpm/Dockerfile b/8.2/bullseye/fpm/Dockerfile index 2870d642..e11a7722 100644 --- a/8.2/bullseye/fpm/Dockerfile +++ b/8.2/bullseye/fpm/Dockerfile @@ -246,7 +246,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/8.2/buster/fpm/Dockerfile b/8.2/buster/fpm/Dockerfile index ecd8db22..053c58f2 100644 --- a/8.2/buster/fpm/Dockerfile +++ b/8.2/buster/fpm/Dockerfile @@ -246,7 +246,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \ diff --git a/Dockerfile-linux.template b/Dockerfile-linux.template index 03497163..fddb4eec 100644 --- a/Dockerfile-linux.template +++ b/Dockerfile-linux.template @@ -467,7 +467,8 @@ RUN set -eux; \ echo; echo '; https://github.com/docker-library/php/pull/725#issuecomment-443540114'; echo 'log_limit = 8192'; \ echo; \ echo '[www]'; \ - echo '; if we send this to /proc/self/fd/1, it never appears'; \ + echo '; php-fpm closes STDOUT on startup, so sending logs to /proc/self/fd/1 does not work.'; \ + echo '; https://bugs.php.net/bug.php?id=73886'; \ echo 'access.log = /proc/self/fd/2'; \ echo; \ echo 'clear_env = no'; \