php/7.3/buster/zts
Tianon Gravi 3dc9a6988d Add "--with-pic" to configure flags (specifically to fix i386)
After looking/comparing at the output of `./configure` for our i386 and amd64 builds against that of Debian's i386 build, our i386 build was the only one of the three to include `checking whether to force non-PIC code in shared modules... yes` (the other two were `no`).

Debian includes `--with-pic`, and we do not.

Looking at the upstream PHP code for this configure check (313a56add0/configure.ac (L241-L256)), this makes total sense, and explains why i386 is the only architecture we see this issue on:

```m4
dnl Disable PIC mode by default where it is known to be safe to do so, to avoid
dnl the performance hit from the lost register.
AC_MSG_CHECKING([whether to force non-PIC code in shared modules])
case $host_alias in
  i?86-*-linux*|i?86-*-freebsd*)
    if test "${with_pic+set}" != "set" || test "$with_pic" = "no"; then
      with_pic=no
      AC_MSG_RESULT(yes)
    else
      AC_MSG_RESULT(no)
    fi
    ;;
  *)
    AC_MSG_RESULT(no)
    ;;
esac
```

This was probably already implied by our `CFLAGS` (and the compiler) on Alpine, but I figured it doesn't hurt to be explicit / consistent.
2020-11-04 17:22:43 -08:00
..
docker-php-entrypoint Add Debian Buster variant 2019-07-10 17:20:35 +02:00
docker-php-ext-configure Prevent "silent" failures by having docker-php-ext-configure error on unknown flags so users have to fix them 2019-12-03 16:32:01 -08:00
docker-php-ext-enable Drop .so from "extension=" in docker-php-ext-enable generated ini files 2020-10-23 12:34:00 -07:00
docker-php-ext-install Add ini-name to ext-install to pass along to ext-enable 2020-06-02 10:41:14 -07:00
docker-php-source Add Debian Buster variant 2019-07-10 17:20:35 +02:00
Dockerfile Add "--with-pic" to configure flags (specifically to fix i386) 2020-11-04 17:22:43 -08:00