From 167718a046e7812cfa33a0350baf1e694a87aa23 Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:11:44 +0200 Subject: [PATCH 01/15] Set of PHPDOC fixes --- phpseclib/Crypt/DSA/Keys/OpenSSH.php | 2 +- phpseclib/Crypt/DSA/Keys/PKCS1.php | 2 +- phpseclib/Crypt/DSA/Keys/PKCS8.php | 2 +- phpseclib/Crypt/DSA/Keys/PuTTY.php | 2 +- phpseclib/Crypt/DSA/Keys/Raw.php | 2 +- phpseclib/Crypt/DSA/Keys/XML.php | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/phpseclib/Crypt/DSA/Keys/OpenSSH.php b/phpseclib/Crypt/DSA/Keys/OpenSSH.php index 6458ba35..0b5d47b4 100644 --- a/phpseclib/Crypt/DSA/Keys/OpenSSH.php +++ b/phpseclib/Crypt/DSA/Keys/OpenSSH.php @@ -37,7 +37,7 @@ abstract class OpenSSH extends Progenitor * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { diff --git a/phpseclib/Crypt/DSA/Keys/PKCS1.php b/phpseclib/Crypt/DSA/Keys/PKCS1.php index 7a3920ba..fefe3117 100644 --- a/phpseclib/Crypt/DSA/Keys/PKCS1.php +++ b/phpseclib/Crypt/DSA/Keys/PKCS1.php @@ -46,7 +46,7 @@ abstract class PKCS1 extends Progenitor * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { diff --git a/phpseclib/Crypt/DSA/Keys/PKCS8.php b/phpseclib/Crypt/DSA/Keys/PKCS8.php index 1415175a..4a94a861 100644 --- a/phpseclib/Crypt/DSA/Keys/PKCS8.php +++ b/phpseclib/Crypt/DSA/Keys/PKCS8.php @@ -69,7 +69,7 @@ abstract class PKCS8 extends Progenitor * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { diff --git a/phpseclib/Crypt/DSA/Keys/PuTTY.php b/phpseclib/Crypt/DSA/Keys/PuTTY.php index 7b297631..af7a7ea4 100644 --- a/phpseclib/Crypt/DSA/Keys/PuTTY.php +++ b/phpseclib/Crypt/DSA/Keys/PuTTY.php @@ -55,7 +55,7 @@ abstract class PuTTY extends Progenitor * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { diff --git a/phpseclib/Crypt/DSA/Keys/Raw.php b/phpseclib/Crypt/DSA/Keys/Raw.php index 18d0b03a..ab6085fa 100644 --- a/phpseclib/Crypt/DSA/Keys/Raw.php +++ b/phpseclib/Crypt/DSA/Keys/Raw.php @@ -34,7 +34,7 @@ abstract class Raw * @access public * @param array $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { diff --git a/phpseclib/Crypt/DSA/Keys/XML.php b/phpseclib/Crypt/DSA/Keys/XML.php index 02644b7d..0741ae5f 100644 --- a/phpseclib/Crypt/DSA/Keys/XML.php +++ b/phpseclib/Crypt/DSA/Keys/XML.php @@ -39,7 +39,7 @@ abstract class XML * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { From 5fe61b325d345f5781bdedfab8cac2fdf336a17f Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:12:07 +0200 Subject: [PATCH 02/15] PHPDOC fix --- phpseclib/Crypt/DSA/Signature/PKCS.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpseclib/Crypt/DSA/Signature/PKCS.php b/phpseclib/Crypt/DSA/Signature/PKCS.php index fa09e54a..eeb97755 100644 --- a/phpseclib/Crypt/DSA/Signature/PKCS.php +++ b/phpseclib/Crypt/DSA/Signature/PKCS.php @@ -36,7 +36,7 @@ abstract class PKCS * * @access public * @param array $key - * @return array + * @return array|bool */ public static function load($sig) { From 0c6d8607ce39d625c78b8748b115b2806baaeb3b Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:12:56 +0200 Subject: [PATCH 03/15] added missing use statement PHPDOC fix --- phpseclib/File/ASN1.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/phpseclib/File/ASN1.php b/phpseclib/File/ASN1.php index 295a2b72..57cd79cd 100644 --- a/phpseclib/File/ASN1.php +++ b/phpseclib/File/ASN1.php @@ -26,6 +26,7 @@ namespace phpseclib\File; use ParagonIE\ConstantTime\Base64; use phpseclib\File\ASN1\Element; use phpseclib\Math\BigInteger; +use phpseclib\Common\Functions\Strings; /** * Pure-PHP ASN.1 Parser @@ -248,7 +249,7 @@ abstract class ASN1 * @param string $encoded * @param int $start * @param int $encoded_pos - * @return array + * @return array|bool * @access private */ private static function decode_ber($encoded, $start = 0, $encoded_pos = 0) @@ -513,7 +514,7 @@ abstract class ASN1 * @param array $decoded * @param array $mapping * @param array $special - * @return array + * @return array|bool|Element * @access public */ public static function asn1map($decoded, $mapping, $special = []) @@ -826,7 +827,7 @@ abstract class ASN1 * ASN.1 Encode (Helper function) * * @param string $source - * @param string $mapping + * @param array $mapping * @param int $idx * @return string * @throws \RuntimeException if the input has an error in it From f48995ac96bc5ea0097256870a40e5d5f66419b6 Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:13:44 +0200 Subject: [PATCH 04/15] Wrong class name fix PHPDOC fixes --- phpseclib/File/X509.php | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/phpseclib/File/X509.php b/phpseclib/File/X509.php index a95784b5..8ed58c4e 100644 --- a/phpseclib/File/X509.php +++ b/phpseclib/File/X509.php @@ -36,6 +36,7 @@ use phpseclib\File\ASN1\Element; use phpseclib\Math\BigInteger; use phpseclib\File\ASN1\Maps; + /** * Pure-PHP X.509 Parser * @@ -1564,7 +1565,7 @@ class X509 * @param mixed $format optional * @param array $dn optional * @access public - * @return bool + * @return array|bool */ public function getDN($format = self::DN_ARRAY, $dn = null) { @@ -2796,7 +2797,7 @@ class X509 */ if (strtolower($date) == 'lifetime') { $temp = '99991231235959Z'; - $temp = chr(ASN1::TYPE_GENERALIZED_TIME) . Functions::encodeLength(strlen($temp)) . $temp; + $temp = chr(ASN1::TYPE_GENERALIZED_TIME) . ASN1::encodeLength(strlen($temp)) . $temp; $this->endDate = new Element($temp); } else { $this->endDate = @date('D, d M Y H:i:s O', @strtotime($date)); @@ -3117,12 +3118,13 @@ class X509 * * @param string $id * @param array $cert optional + * @param string $path * @access public * @return mixed */ - public function getExtension($id, $cert = null) + public function getExtension($id, $cert = null, $path) { - return $this->getExtensionHelper($id, $cert); + return $this->getExtensionHelper($id, $cert, $path); } /** @@ -3430,7 +3432,7 @@ class X509 * Format a public key as appropriate * * @access private - * @return array + * @return array|bool */ private function formatSubjectPublicKey() { @@ -3602,7 +3604,7 @@ class X509 * * @param array $crl optional * @access public - * @return array + * @return array|bool */ public function listRevoked($crl = null) { @@ -3676,7 +3678,7 @@ class X509 * @param string $serial * @param array $crl optional * @access public - * @return array + * @return array|bool */ public function getRevokedCertificateExtensions($serial, $crl = null) { From a3b252150bdd16c959b9ec2ffc350ec92d97a838 Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:14:32 +0200 Subject: [PATCH 05/15] Set of PHPDOC fixes --- phpseclib/Crypt/RSA/Keys/MSBLOB.php | 2 +- phpseclib/Crypt/RSA/Keys/OpenSSH.php | 2 +- phpseclib/Crypt/RSA/Keys/PKCS1.php | 2 +- phpseclib/Crypt/RSA/Keys/PKCS8.php | 2 +- phpseclib/Crypt/RSA/Keys/PuTTY.php | 2 +- phpseclib/Crypt/RSA/Keys/Raw.php | 4 ++-- phpseclib/Crypt/RSA/Keys/XML.php | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/phpseclib/Crypt/RSA/Keys/MSBLOB.php b/phpseclib/Crypt/RSA/Keys/MSBLOB.php index 8ac478e0..33500fe7 100644 --- a/phpseclib/Crypt/RSA/Keys/MSBLOB.php +++ b/phpseclib/Crypt/RSA/Keys/MSBLOB.php @@ -71,7 +71,7 @@ abstract class MSBLOB * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { diff --git a/phpseclib/Crypt/RSA/Keys/OpenSSH.php b/phpseclib/Crypt/RSA/Keys/OpenSSH.php index 40f20330..b8ba1bb5 100644 --- a/phpseclib/Crypt/RSA/Keys/OpenSSH.php +++ b/phpseclib/Crypt/RSA/Keys/OpenSSH.php @@ -37,7 +37,7 @@ abstract class OpenSSH extends Progenitor * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { diff --git a/phpseclib/Crypt/RSA/Keys/PKCS1.php b/phpseclib/Crypt/RSA/Keys/PKCS1.php index 125927ce..6c73d65d 100644 --- a/phpseclib/Crypt/RSA/Keys/PKCS1.php +++ b/phpseclib/Crypt/RSA/Keys/PKCS1.php @@ -44,7 +44,7 @@ abstract class PKCS1 extends Progenitor * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { diff --git a/phpseclib/Crypt/RSA/Keys/PKCS8.php b/phpseclib/Crypt/RSA/Keys/PKCS8.php index 382fb2b7..40888020 100644 --- a/phpseclib/Crypt/RSA/Keys/PKCS8.php +++ b/phpseclib/Crypt/RSA/Keys/PKCS8.php @@ -70,7 +70,7 @@ abstract class PKCS8 extends Progenitor * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { diff --git a/phpseclib/Crypt/RSA/Keys/PuTTY.php b/phpseclib/Crypt/RSA/Keys/PuTTY.php index 4353fd02..ca9195d0 100644 --- a/phpseclib/Crypt/RSA/Keys/PuTTY.php +++ b/phpseclib/Crypt/RSA/Keys/PuTTY.php @@ -50,7 +50,7 @@ abstract class PuTTY extends Progenitor * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { diff --git a/phpseclib/Crypt/RSA/Keys/Raw.php b/phpseclib/Crypt/RSA/Keys/Raw.php index e2bd636c..fe3c4c62 100644 --- a/phpseclib/Crypt/RSA/Keys/Raw.php +++ b/phpseclib/Crypt/RSA/Keys/Raw.php @@ -42,7 +42,7 @@ abstract class Raw * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { @@ -95,7 +95,7 @@ abstract class Raw * @access public * @param \phpseclib\Math\BigInteger $n * @param \phpseclib\Math\BigInteger $e - * @return string + * @return array */ public static function savePublicKey(BigInteger $n, BigInteger $e) { diff --git a/phpseclib/Crypt/RSA/Keys/XML.php b/phpseclib/Crypt/RSA/Keys/XML.php index a31a4be0..07549026 100644 --- a/phpseclib/Crypt/RSA/Keys/XML.php +++ b/phpseclib/Crypt/RSA/Keys/XML.php @@ -40,7 +40,7 @@ abstract class XML * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ public static function load($key, $password = '') { From 558370304081510cee6c60445967eb3723f7e7ef Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:15:16 +0200 Subject: [PATCH 06/15] Set of PHPDOC fixes --- phpseclib/Math/BigInteger/Engines/BCMath/Reductions/Barrett.php | 2 +- .../Math/BigInteger/Engines/BCMath/Reductions/EvalBarrett.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/phpseclib/Math/BigInteger/Engines/BCMath/Reductions/Barrett.php b/phpseclib/Math/BigInteger/Engines/BCMath/Reductions/Barrett.php index 7237c5ac..f858ce17 100644 --- a/phpseclib/Math/BigInteger/Engines/BCMath/Reductions/Barrett.php +++ b/phpseclib/Math/BigInteger/Engines/BCMath/Reductions/Barrett.php @@ -61,7 +61,7 @@ abstract class Barrett extends Base * * @param string $n * @param string $m - * @return array + * @return array|string */ protected static function reduce($n, $m) { diff --git a/phpseclib/Math/BigInteger/Engines/BCMath/Reductions/EvalBarrett.php b/phpseclib/Math/BigInteger/Engines/BCMath/Reductions/EvalBarrett.php index 2ab676e6..58374b3d 100644 --- a/phpseclib/Math/BigInteger/Engines/BCMath/Reductions/EvalBarrett.php +++ b/phpseclib/Math/BigInteger/Engines/BCMath/Reductions/EvalBarrett.php @@ -55,7 +55,7 @@ abstract class EvalBarrett extends Base * * @param array $m * @param string $class - * @return callable + * @return callable|void */ protected static function generateCustomReduction(BCMath $m, $class) { From 6181b2bfbd2a5b7b3e3f6c40c47df30c6883efdc Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:16:16 +0200 Subject: [PATCH 07/15] Set of PHPDOC fixes --- phpseclib/Crypt/Common/AsymmetricKey.php | 4 ++-- phpseclib/Crypt/Common/Keys/OpenSSH.php | 2 +- phpseclib/Crypt/Common/Keys/PKCS1.php | 2 +- phpseclib/Crypt/Common/Keys/PKCS8.php | 2 +- phpseclib/Crypt/Common/Keys/PuTTY.php | 2 +- phpseclib/Crypt/Common/Signature/Raw.php | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/phpseclib/Crypt/Common/AsymmetricKey.php b/phpseclib/Crypt/Common/AsymmetricKey.php index 08124730..6cc92471 100644 --- a/phpseclib/Crypt/Common/AsymmetricKey.php +++ b/phpseclib/Crypt/Common/AsymmetricKey.php @@ -299,7 +299,7 @@ abstract class AsymmetricKey * @access private * @param string $key * @param string $type - * @return array + * @return array|bool */ protected function load($key, $type) { @@ -339,7 +339,7 @@ abstract class AsymmetricKey * @access private * @param string $key * @param string $type - * @return array + * @return array|bool */ protected function setPublicKey($key, $type) { diff --git a/phpseclib/Crypt/Common/Keys/OpenSSH.php b/phpseclib/Crypt/Common/Keys/OpenSSH.php index eb1ba7a3..fc7fc822 100644 --- a/phpseclib/Crypt/Common/Keys/OpenSSH.php +++ b/phpseclib/Crypt/Common/Keys/OpenSSH.php @@ -64,7 +64,7 @@ abstract class OpenSSH * @access public * @param string $key * @param string $type - * @return array + * @return array|bool */ public static function load($key, $type) { diff --git a/phpseclib/Crypt/Common/Keys/PKCS1.php b/phpseclib/Crypt/Common/Keys/PKCS1.php index afa9ad15..6ae8588d 100644 --- a/phpseclib/Crypt/Common/Keys/PKCS1.php +++ b/phpseclib/Crypt/Common/Keys/PKCS1.php @@ -122,7 +122,7 @@ abstract class PKCS1 extends PKCS * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ protected static function load($key, $password) { diff --git a/phpseclib/Crypt/Common/Keys/PKCS8.php b/phpseclib/Crypt/Common/Keys/PKCS8.php index 74222ab5..e4002fe7 100644 --- a/phpseclib/Crypt/Common/Keys/PKCS8.php +++ b/phpseclib/Crypt/Common/Keys/PKCS8.php @@ -320,7 +320,7 @@ abstract class PKCS8 extends PKCS * @access public * @param string $key * @param string $password optional - * @return array + * @return array|bool */ protected static function load($key, $password = '') { diff --git a/phpseclib/Crypt/Common/Keys/PuTTY.php b/phpseclib/Crypt/Common/Keys/PuTTY.php index 12e4377a..44224510 100644 --- a/phpseclib/Crypt/Common/Keys/PuTTY.php +++ b/phpseclib/Crypt/Common/Keys/PuTTY.php @@ -77,7 +77,7 @@ abstract class PuTTY * @param string $publicHandler * @param string $type * @param string $password - * @return array + * @return array|bool */ protected static function load($key, $password) { diff --git a/phpseclib/Crypt/Common/Signature/Raw.php b/phpseclib/Crypt/Common/Signature/Raw.php index 73aeee8a..7977417c 100644 --- a/phpseclib/Crypt/Common/Signature/Raw.php +++ b/phpseclib/Crypt/Common/Signature/Raw.php @@ -33,7 +33,7 @@ abstract class Raw * * @access public * @param array $sig - * @return array + * @return array|bool */ public static function load($sig) { From ccfb6c92bf0ebdb04e889ced81310a1e370bbfd5 Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:16:37 +0200 Subject: [PATCH 08/15] Set of PHPDOC fixes --- phpseclib/Crypt/DSA.php | 4 ++-- phpseclib/Crypt/Hash.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/phpseclib/Crypt/DSA.php b/phpseclib/Crypt/DSA.php index 9cbee43e..19b0bae2 100644 --- a/phpseclib/Crypt/DSA.php +++ b/phpseclib/Crypt/DSA.php @@ -109,7 +109,7 @@ class DSA extends AsymmetricKey * @access public * @param int $L * @param int $N - * @return \phpseclib\Crypt\DSA + * @return \phpseclib\Crypt\DSA|bool */ static function createParameters($L = 2048, $N = 224) { @@ -183,7 +183,7 @@ class DSA extends AsymmetricKey * - 'publickey': The public key. * * @access public - * @return \phpseclib\Crypt\DSA + * @return array|DSA */ static function createKey() { diff --git a/phpseclib/Crypt/Hash.php b/phpseclib/Crypt/Hash.php index e5af7b48..2b4f7b83 100644 --- a/phpseclib/Crypt/Hash.php +++ b/phpseclib/Crypt/Hash.php @@ -134,7 +134,7 @@ class Hash * Keys can be of any length. * * @access public - * @param string $key + * @param string|bool $key */ public function setKey($key = false) { From 0fd58aeb7e327b50874d3d1f824741227db9aedf Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:19:11 +0200 Subject: [PATCH 09/15] Set of PHPDOC fixes Fixed methods visibility --- phpseclib/Net/SFTP.php | 4 ++-- phpseclib/Net/SSH1.php | 2 +- phpseclib/Net/SSH2.php | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/phpseclib/Net/SFTP.php b/phpseclib/Net/SFTP.php index 4397586e..63496e69 100644 --- a/phpseclib/Net/SFTP.php +++ b/phpseclib/Net/SFTP.php @@ -3024,7 +3024,7 @@ class SFTP extends SSH2 * Returns a string if NET_SFTP_LOGGING == self::LOG_COMPLEX, an array if NET_SFTP_LOGGING == self::LOG_SIMPLE and false if !defined('NET_SFTP_LOGGING') * * @access public - * @return string or Array + * @return array|string */ public function getSFTPLog() { @@ -3086,7 +3086,7 @@ class SFTP extends SSH2 * @return bool * @access private */ - private function disconnect_helper($reason) + protected function disconnect_helper($reason) { $this->pwd = false; parent::disconnect_helper($reason); diff --git a/phpseclib/Net/SSH1.php b/phpseclib/Net/SSH1.php index 973b13f6..8cb3c625 100644 --- a/phpseclib/Net/SSH1.php +++ b/phpseclib/Net/SSH1.php @@ -1079,7 +1079,7 @@ class SSH1 * http://www.securiteam.com/securitynews/5LP042K3FY.html * * @see self::_send_binary_packet() - * @return array + * @return array|bool * @access private */ private function get_binary_packet() diff --git a/phpseclib/Net/SSH2.php b/phpseclib/Net/SSH2.php index 49653416..332b324b 100644 --- a/phpseclib/Net/SSH2.php +++ b/phpseclib/Net/SSH2.php @@ -652,7 +652,7 @@ class SSH2 * @see self::_get_channel_packet() * @access private */ - private $curTimeout; + protected $curTimeout; /** * Real-time log file pointer @@ -890,7 +890,7 @@ class SSH2 * @param int $port * @param int $timeout * @see self::login() - * @return \phpseclib\Net\SSH2 + * @return SSH2|void * @access public */ public function __construct($host, $port = 22, $timeout = 10) @@ -3829,7 +3829,7 @@ class SSH2 * @return bool * @access private */ - private function disconnect_helper($reason) + protected function disconnect_helper($reason) { if ($this->bitmap & self::MASK_CONNECTED) { $data = pack('CNNa*Na*', NET_SSH2_MSG_DISCONNECT, $reason, 0, '', 0, ''); From f314f9795f2a5c43fc680cd6fee2beaf3e192239 Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:20:05 +0200 Subject: [PATCH 10/15] Fixed methods visibility --- phpseclib/Math/BigInteger/Engines/PHP/Base.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpseclib/Math/BigInteger/Engines/PHP/Base.php b/phpseclib/Math/BigInteger/Engines/PHP/Base.php index 640d17c6..3529906e 100644 --- a/phpseclib/Math/BigInteger/Engines/PHP/Base.php +++ b/phpseclib/Math/BigInteger/Engines/PHP/Base.php @@ -80,7 +80,7 @@ abstract class Base extends PHP * @param string $class * @return \phpseclib\Math\BigInteger\Engines\PHP */ - protected static function powModHelper(PHP $x, PHP $e, PHP $n, $class) + public static function powModHelper(PHP $x, PHP $e, PHP $n, $class) { if (empty($e->value)) { $temp = new $class(); From d13f429b77a494c340378619a4ff142bb0d68f60 Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:20:17 +0200 Subject: [PATCH 11/15] PHPDOC fixes --- phpseclib/Math/BigInteger/Engines/PHP/Montgomery.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpseclib/Math/BigInteger/Engines/PHP/Montgomery.php b/phpseclib/Math/BigInteger/Engines/PHP/Montgomery.php index 8bffb1ca..cdbf23a1 100644 --- a/phpseclib/Math/BigInteger/Engines/PHP/Montgomery.php +++ b/phpseclib/Math/BigInteger/Engines/PHP/Montgomery.php @@ -46,7 +46,7 @@ abstract class Montgomery extends Base * @param \phpseclib\Math\BigInteger\Engine $e * @param \phpseclib\Math\BigInteger\Engine $n * @param string $class - * @return \phpseclib\Math\BigInteger\Engine + * @return \phpseclib\Math\BigInteger\Engine|Engine */ protected static function slidingWindow(Engine $x, Engine $e, Engine $n, $class) { From 6f36c49baafc8af2821c18088ebec99e4a53a62d Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:20:33 +0200 Subject: [PATCH 12/15] Fixed methods visibility --- phpseclib/Math/BigInteger/Engines/BCMath/Base.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpseclib/Math/BigInteger/Engines/BCMath/Base.php b/phpseclib/Math/BigInteger/Engines/BCMath/Base.php index 026cd86f..91efeb00 100644 --- a/phpseclib/Math/BigInteger/Engines/BCMath/Base.php +++ b/phpseclib/Math/BigInteger/Engines/BCMath/Base.php @@ -60,7 +60,7 @@ abstract class Base extends BCMath * @param string $class * @return \phpseclib\Math\BigInteger\Engines\BCMath */ - protected static function powModHelper(BCMath $x, BCMath $e, BCMath $n, $class) + public static function powModHelper(BCMath $x, BCMath $e, BCMath $n, $class) { if (empty($e->value)) { $temp = new $class(); From 7bffa6bb8f417023d866570392e3bd0559c1cea3 Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:26:09 +0200 Subject: [PATCH 13/15] Set of PHPDOC fixes --- phpseclib/Math/BigInteger/Engines/Engine.php | 18 +++++++++--------- phpseclib/Math/BigInteger/Engines/GMP.php | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/phpseclib/Math/BigInteger/Engines/Engine.php b/phpseclib/Math/BigInteger/Engines/Engine.php index 89787416..9f3dc497 100644 --- a/phpseclib/Math/BigInteger/Engines/Engine.php +++ b/phpseclib/Math/BigInteger/Engines/Engine.php @@ -396,7 +396,7 @@ abstract class Engine implements \Serializable /** * Logical Not * - * @return \phpseclib\Math\BigInteger\Engines\Engine + * @return Engine|string */ public function bitwise_not() { @@ -465,7 +465,7 @@ abstract class Engine implements \Serializable * Instead of the top x bits being dropped they're appended to the shifted bit string. * * @param int $shift - * @return \phpseclib\Math\BigInteger\Engine\Engines + * @return \phpseclib\Math\BigInteger\Engines\Engine */ public function bitwise_leftRotate($shift) { @@ -563,7 +563,7 @@ abstract class Engine implements \Serializable /** * Performs some pre-processing for powMod * - * @return \phpseclib\Math\BigInteger\Engines\Engine + * @return bool|Engine */ protected function powModOuter(Engine $e, Engine $n) { @@ -591,11 +591,11 @@ abstract class Engine implements \Serializable * however, this function performs a modular reduction after every multiplication and squaring operation. * As such, this function has the same preconditions that the reductions being used do. * - * @param \phpseclib\Math\BigInteger\Engine $x - * @param \phpseclib\Math\BigInteger\Engine $e - * @param \phpseclib\Math\BigInteger\Engine $n + * @param \phpseclib\Math\BigInteger\Engines\Engine $x + * @param \phpseclib\Math\BigInteger\Engines\Engine $e + * @param \phpseclib\Math\BigInteger\Engines\Engine $n * @param string $class - * @return \phpseclib\Math\BigInteger\Engine + * @return \phpseclib\Math\BigInteger\Engines\Engine */ protected static function slidingWindow(Engine $x, Engine $e, Engine $n, $class) { @@ -691,7 +691,7 @@ abstract class Engine implements \Serializable /** * Performs some pre-processing for randomRangePrime * - * @return \phpseclib\Math\BigInteger\Engines\Engine + * @return bool|Engine */ protected static function randomRangePrimeOuter(Engine $min, Engine $max) { @@ -781,7 +781,7 @@ abstract class Engine implements \Serializable /** * Performs some post-processing for randomRangePrime * - * @return \phpseclib\Math\BigInteger\Engine + * @return bool|Engine */ protected static function randomRangePrimeInner(Engine $x, Engine $min, Engine $max) { diff --git a/phpseclib/Math/BigInteger/Engines/GMP.php b/phpseclib/Math/BigInteger/Engines/GMP.php index 5e5a0197..9a406a27 100644 --- a/phpseclib/Math/BigInteger/Engines/GMP.php +++ b/phpseclib/Math/BigInteger/Engines/GMP.php @@ -546,7 +546,7 @@ class GMP extends Engine * * Returns the nth root of a positive biginteger, where n defaults to 2 * - * @return \phpseclib\Math\BigInteger\Engines\Engine\GMP + * @return \phpseclib\Math\BigInteger\Engines\GMP */ protected function rootInner($n) { From de2e4662b004c8ce5c83f46b5382102bba5ca441 Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 09:26:46 +0200 Subject: [PATCH 14/15] Fixed wrong use of new self(1); --- phpseclib/Math/BigInteger/Engines/PHP.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpseclib/Math/BigInteger/Engines/PHP.php b/phpseclib/Math/BigInteger/Engines/PHP.php index 8e448cc0..bee28778 100644 --- a/phpseclib/Math/BigInteger/Engines/PHP.php +++ b/phpseclib/Math/BigInteger/Engines/PHP.php @@ -1314,7 +1314,7 @@ abstract class PHP extends Engine protected function powHelper(PHP $n) { if ($n->compare(static::$zero) == 0) { - return new self(1); + return new static(1); } // n^0 = 1 From eb21fb2bcb781a25c718cdf19f24bc59ea83ae2d Mon Sep 17 00:00:00 2001 From: Sokolovskyy Roman Date: Thu, 3 Aug 2017 11:25:20 +0200 Subject: [PATCH 15/15] Default value for a parameter missed --- phpseclib/File/X509.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpseclib/File/X509.php b/phpseclib/File/X509.php index 8ed58c4e..e2f98817 100644 --- a/phpseclib/File/X509.php +++ b/phpseclib/File/X509.php @@ -3122,7 +3122,7 @@ class X509 * @access public * @return mixed */ - public function getExtension($id, $cert = null, $path) + public function getExtension($id, $cert = null, $path=null) { return $this->getExtensionHelper($id, $cert, $path); }