danog/psalm-plugin-phpunit
1
0
Fork 0
mirror of https://github.com/danog/psalm-plugin-phpunit.git synced 2024-11-30 04:29:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve provider non-optional argument phrasing

Browse Source 
I just ran across a case where I added an argument to a test method and forgot to give it a default value, and this made all previous arguments with defaults non-optional. The phrasing here confused me because I could clearly see that the argument it was complaining about had a default value, and it took me a while to find the actual issue that I forgot to add a default value to the new argument.
This commit is contained in:
AndrolGenhald 2022-02-11 12:50:26 -06:00 committed by GitHub
parent 5dd3be04f3
commit 02a9ac7cd5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Hooks/TestCaseHandler.php
View File

@ -345,7 +345,7 @@ class TestCaseHandler implements
} elseif ($potential_argument_type->possibly_undefined && !$is_optional) { } elseif ($potential_argument_type->possibly_undefined && !$is_optional) {
IssueBuffer::accepts(new Issue\InvalidArgument( IssueBuffer::accepts(new Issue\InvalidArgument(
'Argument ' . ($param_offset + 1) . ' of ' . $method_name 'Argument ' . ($param_offset + 1) . ' of ' . $method_name
. ' has no default value, but possibly undefined ' . ' is not optional, but possibly undefined '
. $potential_argument_type->getId() . ' provided' . $potential_argument_type->getId() . ' provided'
. ' by ' . $provider_method_id . '():(' . $provider_return_type_string . ')', . ' by ' . $provider_method_id . '():(' . $provider_return_type_string . ')',
$provider_docblock_location $provider_docblock_location