danog/psalm-plugin-phpunit
1
0
Fork 0
mirror of https://github.com/danog/psalm-plugin-phpunit.git synced 2024-11-30 04:29:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed reported type for invalid iterables

Browse Source
This commit is contained in:
Bruce Weirdan 2019-02-20 00:47:51 +02:00
parent 55ee7eabc7
commit 6906f62cfa
No known key found for this signature in database
GPG Key ID: CFC3AAB181751B0D
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
hooks/TestCaseHandler.php
View File

@ -92,6 +92,8 @@ class TestCaseHandler implements AfterClassLikeVisitInterface, AfterClassLikeAna
$provider_return_type = $codebase->getMethodReturnType($provider_method_id, $classStorage->name);
assert(null !== $provider_return_type);
$provider_return_type_string = $provider_return_type->getId();
$provider_return_type_location = $codebase->getMethodReturnTypeLocation($provider_method_id);
assert(null !== $provider_return_type_location);
@ -107,7 +109,7 @@ class TestCaseHandler implements AfterClassLikeVisitInterface, AfterClassLikeAna
)) {
IssueBuffer::accepts(new Issue\InvalidReturnType(
'Providers must return ' . $expected_provider_return_type->getId()
. ', ' . $provider_return_type->getId() . ' provided',
. ', ' . $provider_return_type_string . ' provided',
$provider_return_type_location
));
@ -118,7 +120,7 @@ class TestCaseHandler implements AfterClassLikeVisitInterface, AfterClassLikeAna
if (!$type->isIterable($codebase)) {
IssueBuffer::accepts(new Issue\InvalidReturnType(
'Providers must return ' . $expected_provider_return_type->getId()
. ', ' . $provider_return_type->getId() . ' provided',
. ', ' . $provider_return_type_string . ' provided',
$provider_return_type_location
));
continue;
@ -143,7 +145,7 @@ class TestCaseHandler implements AfterClassLikeVisitInterface, AfterClassLikeAna
)) {
IssueBuffer::accepts(new Issue\InvalidReturnType(
'Providers must return ' . $expected_provider_return_type->getId()
. ', ' . $provider_return_type->getId() . ' provided',
. ', ' . $provider_return_type_string . ' provided',
$provider_return_type_location
));
continue;
@ -159,7 +161,7 @@ class TestCaseHandler implements AfterClassLikeVisitInterface, AfterClassLikeAna
$codebase,
$method_id,
$provider_method_id,
$provider_return_type,
$provider_return_type_string,
$provider_docblock_location
) {
assert(null !== $param->type);
@ -170,7 +172,7 @@ class TestCaseHandler implements AfterClassLikeVisitInterface, AfterClassLikeAna
'Argument ' . ($param_offset + 1) . ' of ' . $method_id
. ' expects ' . $param->type->getId() . ', '
. $potential_argument_type->getId() . ' provided'
. ' by ' . $provider_method_id . '():(' . $provider_return_type->getId() . ')',
. ' by ' . $provider_method_id . '():(' . $provider_return_type_string . ')',
$provider_docblock_location
));
} else {
@ -178,7 +180,7 @@ class TestCaseHandler implements AfterClassLikeVisitInterface, AfterClassLikeAna
'Argument ' . ($param_offset + 1) . ' of ' . $method_id
. ' expects ' . $param->type->getId() . ', '
. $potential_argument_type->getId() . ' provided'
. ' by ' . $provider_method_id . '():(' . $provider_return_type->getId() . ')',
. ' by ' . $provider_method_id . '():(' . $provider_return_type_string . ')',
$provider_docblock_location
));
}
@ -204,7 +206,7 @@ class TestCaseHandler implements AfterClassLikeVisitInterface, AfterClassLikeAna
. ' - expecting ' . $method_storage->required_param_count
. ' but saw ' . count($potential_argument_types)
. ' provided by ' . $provider_method_id . '()'
. ':(' . $provider_return_type->getId() . ')',
. ':(' . $provider_return_type_string . ')',
$provider_docblock_location,
$method_id
));