danog/psalm-plugin-symfony
1
0
Fork 0
mirror of https://github.com/danog/psalm-plugin-symfony.git synced 2024-11-30 04:29:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed Finder key and value (#221)

Browse Source
This commit is contained in:
Valentin Udaltsov 2021-10-14 07:46:04 +03:00 committed by GitHub
parent de574cc9f2
commit 0831a0160c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Stubs/common/Component/Finder/Finder.stubphp
View File

@ -6,8 +6,12 @@ use Countable;
use IteratorAggregate;
/**
* @implements IteratorAggregate<string, SplFileInfo>
* @implements IteratorAggregate<non-empty-string, SplFileInfo>
*/
class Finder implements IteratorAggregate, Countable
{
/**
* @return \Iterator<non-empty-string, SplFileInfo>
*/
public function getIterator() {}
}

23
tests/acceptance/acceptance/Finder.feature
View File

@ -4,26 +4,25 @@ Feature: Finder
Background:
Given I have Symfony plugin enabled
Scenario: Finder should be considered as an IteratorAggregate of SplFileInfo
Scenario: Finder is an IteratorAggregate with non-empty-string key and SplFileInfo value
Given I have the following code
"""
<?php
use Symfony\Component\Finder\Finder;
use Symfony\Component\Finder\SplFileInfo;
class Test
{
/**
* @param iterable<SplFileInfo> $files
*/
public static function run(iterable $files): void
function run(Finder $finder): void
{
foreach ($finder as $key => $file) {
/** @psalm-trace $key */
echo $key;
/** @psalm-trace $file */
}
}
$finder = new Finder();
Test::run($finder);
"""
When I run Psalm
Then I see no errors
Then I see these errors
| Type | Message |
| Trace | $key: non-empty-string |
| Trace | $file: Symfony\Component\Finder\SplFileInfo |
And I see no other errors