danog/psalm-plugin-symfony
1
0
Fork 0
mirror of https://github.com/danog/psalm-plugin-symfony.git synced 2025-01-22 13:01:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

[console] option name with -- prefix (#106)

Browse Source
This commit is contained in:
Farhad Safarov 2020-11-29 15:14:05 +03:00 committed by GitHub
parent d4f6d579eb
commit 2aa06e6609
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Handler/ConsoleHandler.php
View File

@ -165,6 +165,10 @@ class ConsoleHandler implements AfterMethodCallAnalysisInterface
return;
}
if (0 === strpos($identifier, '--')) {
$identifier = substr($identifier, 2);
}
if (isset($args[2])) {
try {
$mode = self::getModeValue($args[2]->value);

35
tests/acceptance/acceptance/ConsoleOption.feature
View File

@ -122,6 +122,41 @@ Feature: ConsoleOption
| Trace | $option5: null\|string |
And I see no other errors
Scenario: Asserting options return types have inferred with -- prefix in names
Given I have the following code
"""
class MyCommand extends Command
{
public function configure(): void
{
$this->addOption('--option1', null, InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY, '', []);
$this->addOption('--option2', null, InputOption::VALUE_REQUIRED, '', 'default');
$this->addOption('--option3', null, InputOption::VALUE_NONE, '', true);
}
public function execute(InputInterface $input, OutputInterface $output): int
{
/** @psalm-trace $option1 */
$option1 = $input->getOption('option1');
/** @psalm-trace $option2 */
$option2 = $input->getOption('option2');
/** @psalm-trace $option3 */
$option3 = $input->getOption('option3');
return 0;
}
}
"""
When I run Psalm
Then I see these errors
| Type | Message |
| Trace | $option1: array<int, string> |
| Trace | $option2: string |
| Trace | $option3: bool |
And I see no other errors
Scenario: Asserting options return types have inferred (without error) using Definition
Given I have the following code
"""