danog/psalm-plugin-symfony
1
0
Fork 0
mirror of https://github.com/danog/psalm-plugin-symfony.git synced 2024-11-30 04:29:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

[RepositoryStringShortcut] complain when argument is string only (#33)

Browse Source
This commit is contained in:
Farhad Safarov 2020-05-26 18:53:50 +03:00 committed by GitHub
parent 55aa860581
commit 7a628c6fda
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 50 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Handler/ClassHandler.php
View File

@ -5,6 +5,7 @@ namespace Psalm\SymfonyPsalmPlugin\Handler;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\ClassConstFetch;
use PhpParser\Node\Scalar\String_;
use Psalm\Codebase;
use Psalm\CodeLocation;
use Psalm\Context;
@ -72,7 +73,7 @@ class ClassHandler implements AfterClassLikeAnalysisInterface, AfterMethodCallAn
break;
case 'Doctrine\ORM\EntityManagerInterface::getrepository':
case 'Doctrine\Persistence\ObjectManager::getrepository':
if (!$expr->args[0]->value instanceof ClassConstFetch) {
if ($expr->args[0]->value instanceof String_ ) {
IssueBuffer::accepts(
new RepositoryStringShortcut(new CodeLocation($statements_source, $expr->args[0]->value)),
$statements_source->getSuppressedIssues()

55
tests/acceptance/acceptance/RepositoryStringShortcut.feature
View File

@ -22,20 +22,9 @@ Feature: RepositoryStringShortcut
</plugins>
</psalm>
"""
Scenario: Asserting using 'AppBundle:Entity' syntax raises issue
Given I have the following code
And I have the following code preamble
"""
<?php
use Doctrine\ORM\EntityManagerInterface;
class SomeService
{
public function __construct(EntityManagerInterface $entityManager)
{
$entityManager->getRepository('AppBundle:Entity');
}
}
namespace Doctrine\ORM;
interface EntityManagerInterface
{
@ -47,8 +36,50 @@ Feature: RepositoryStringShortcut
public function getRepository($className);
}
"""
Scenario: Asserting using 'AppBundle:Entity' syntax raises issue
Given I have the following code
"""
use Doctrine\ORM\EntityManagerInterface;
class SomeService
{
public function __construct(EntityManagerInterface $entityManager)
{
$entityManager->getRepository('AppBundle:Entity');
}
}
"""
When I run Psalm
Then I see these errors
| Type | Message |
| RepositoryStringShortcut | Use Entity::class syntax instead |
And I see no other errors
Scenario: Asserting using 'Entity::class' notation does not raise issue
Given I have the following code
"""
class SomeService
{
public function __construct(EntityManagerInterface $entityManager)
{
$entityManager->getRepository(Entity::class);
}
}
"""
When I run Psalm
Then I see no errors
Scenario: Dynamic repository calls should not be complained
Given I have the following code
"""
class SomeService
{
public function __construct(EntityManagerInterface $entityManager)
{
$className = 'App\Entity\EntityA';
$entityManager->getRepository($className);
}
}
"""
When I run Psalm
Then I see no errors

17
tests/acceptance/acceptance/RequestContent.feature
View File

@ -16,14 +16,15 @@ Feature: Request getContent
</plugins>
</psalm>
"""
And I have the following code preamble
"""
<?php
use Symfony\Component\HttpFoundation\Request;
"""
Scenario: Asserting '$request->getContent()' without any argument returns string
Given I have the following code
"""
<?php
use Symfony\Component\HttpFoundation\Request;
class App
{
public function index(Request $request): void
@ -38,10 +39,6 @@ Feature: Request getContent
Scenario: Asserting '$request->getContent(false)' returns string
Given I have the following code
"""
<?php
use Symfony\Component\HttpFoundation\Request;
class App
{
public function index(Request $request): void
@ -56,10 +53,6 @@ Feature: Request getContent
Scenario: Asserting '$request->getContent(true)' returns resource
Given I have the following code
"""
<?php
use Symfony\Component\HttpFoundation\Request;
class App
{
public function index(Request $request): void