danog/psalm-plugin-symfony
1
0
Fork 0
mirror of https://github.com/danog/psalm-plugin-symfony.git synced 2025-01-22 21:12:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

assume service as public if public attribute is missing (#15)

Browse Source
This commit is contained in:
Farhad Safarov 2020-03-15 13:38:16 +03:00 committed by GitHub
parent 007d3c6511
commit c2b2dd4ae7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/ContainerMeta.php
View File

@ -33,7 +33,7 @@ class ContainerMeta
if (isset($serviceAttributes->alias)) {
$service->setAlias((string) $serviceAttributes->alias);
}
$service->setIsPublic('true' === (string) $serviceAttributes->public);
$service->setIsPublic('false' !== (string) $serviceAttributes->public);
$this->add($service);
}

1
tests/acceptance/container.xml
View File

@ -16,5 +16,6 @@
<service id="Symfony\Component\HttpKernel\HttpKernelInterface" alias="http_kernel" public="true"/>
<service id="Foo\Bar" class="Foo\Bar" public="false"/>
<service id="private_service" class="Foo\Bar" public="false"/>
<service id="public_service_wo_public_attr" class="Foo\Bar"/>
</services>
</container>

5
tests/unit/Symfony/ContainerMetaTest.php
View File

@ -57,6 +57,11 @@ class ContainerMetaTest extends TestCase
'className' => 'Symfony\Component\HttpKernel\HttpKernel',
'isPublic' => true,
],
[
'id' => 'public_service_wo_public_attr',
'className' => 'Foo\Bar',
'isPublic' => true,
],
];
}