acceptance tests (#3)

.gitignore

@@ -1,2 +1,3 @@
 vendor
 composer.lock
+.php_cs.cache

README.md

@@ -1,8 +1,14 @@
 # Symfony Psalm Plugin
 
+[![Build Status](https://travis-ci.com/seferov/symfony-psalm-plugin.svg?branch=master)](https://travis-ci.com/seferov/symfony-psalm-plugin)
+
 ### Installation
 
 ```
 composer require --dev seferov/symfony-psalm-plugin
 vendor/bin/psalm-plugin enable seferov/symfony-psalm-plugin
 ```
+
+### Credits
+
+- [@weirdan](https://github.com/weirdan) for [codeception psalm module](https://github.com/weirdan/codeception-psalm-module)

codeception.yml

@@ -0,0 +1,14 @@
+namespace: Psalm\PhpUnitPlugin\Tests
+
+paths:
+  tests: tests
+  output: tests/_output
+  data: tests/_data
+  support: tests/_support
+  envs: tests/_envs
+
+actor_suffix: Tester
+
+extensions:
+  enabled:
+    - Codeception\Extension\RunFailed

composer.json

@@ -2,11 +2,6 @@
     "name": "seferov/symfony-psalm-plugin",
     "description": "Psalm Plugin for Symfony",
     "type": "psalm-plugin",
-    "require": {
-        "php": "^7.1",
-        "vimeo/psalm": "^3.2",
-        "symfony/framework-bundle": "^3.0 || ^4.0"
-    },
     "license": "MIT",
     "authors": [
         {
@@ -14,11 +9,25 @@
             "email": "farhad.safarov@gmail.com"
         }
     ],
+    "require": {
+        "php": "^7.1",
+        "vimeo/psalm": "^3.2",
+        "symfony/framework-bundle": "^3.0 || ^4.0"
+    },
+    "require-dev": {
+        "codeception/base": "^2.5",
+        "weirdan/codeception-psalm-module": "^0.2.2"
+    },
     "autoload": {
         "psr-4": {
             "Seferov\\SymfonyPsalmPlugin\\": "src"
         }
     },
+    "autoload-dev": {
+        "psr-4": {
+            "Seferov\\SymfonyPsalmPlugin\\Tests\\": ["tests/_support"]
+        }
+    },
     "extra": {
         "psalm" : {
             "pluginClass": "Seferov\\SymfonyPsalmPlugin\\Plugin"
@@ -26,8 +35,13 @@
     },
     "scripts": {
         "check": [
-            "@analyze"
+            "@analyze",
+            "@test"
         ],
-        "analyze": "psalm"
+        "analyze": "psalm",
+        "test": [
+            "codecept build",
+            "codecept run -v"
+        ]
     }
 }

tests/_output/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore

tests/_run/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore

tests/_support/AcceptanceTester.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace Psalm\PhpUnitPlugin\Tests;
+
+use Codeception\Actor;
+use Codeception\Lib\Friend;
+
+/**
+ * Inherited Methods
+ * @method void wantToTest($text)
+ * @method void wantTo($text)
+ * @method void execute($callable)
+ * @method void expectTo($prediction)
+ * @method void expect($prediction)
+ * @method void amGoingTo($argumentation)
+ * @method void am($role)
+ * @method void lookForwardTo($achieveValue)
+ * @method void comment($description)
+ * @method Friend haveFriend($name, $actorClass = NULL)
+ *
+ * @SuppressWarnings(PHPMD)
+ */
+class AcceptanceTester extends Actor
+{
+    use _generated\AcceptanceTesterActions;
+}

tests/_support/_generated/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore

tests/acceptance.suite.yml

@@ -0,0 +1,7 @@
+actor: AcceptanceTester
+
+modules:
+  enabled:
+    - Cli
+    - Filesystem
+    - \Weirdan\Codeception\Psalm\Module

tests/acceptance/ContainerDependency.feature

@@ -0,0 +1,37 @@
+Feature: ContainerDependency
+  In order to follow best practices for Symfony
+  As a Psalm user
+  I need Psalm to check container is not injected as a dependency
+
+  Background:
+    Given I have the following config
+      """
+      <?xml version="1.0"?>
+      <psalm totallyTyped="true">
+        <projectFiles>
+          <directory name="."/>
+          <ignoreFiles> <directory name="../../vendor"/> </ignoreFiles>
+        </projectFiles>
+        <plugins>
+          <pluginClass class="Seferov\SymfonyPsalmPlugin\Plugin"/>
+        </plugins>
+      </psalm>
+      """
+
+  Scenario: Asserting container dependency raises issue
+    Given I have the following code
+      """
+      <?php
+      use Symfony\Component\DependencyInjection\ContainerInterface;
+      class SomeService
+      {
+        public function __construct(ContainerInterface $container)
+        {
+        }
+      }
+      """
+    When I run Psalm
+    Then I see these errors
+      | Type                 | Message                                                   |
+      | ContainerDependency | Container must not inject into services as dependency! |
+    And I see no other errors

tests/acceptance/RepositoryStringShortcut.feature

@@ -0,0 +1,54 @@
+Feature: RepositoryStringShortcut
+  In order to follow best practices for Symfony
+  As a Psalm user
+  I need Psalm to check preferred repository syntax
+
+  Background:
+    Given I have the following config
+      """
+      <?xml version="1.0"?>
+      <psalm totallyTyped="true">
+        <projectFiles>
+          <directory name="."/>
+          <ignoreFiles> <directory name="../../vendor"/> </ignoreFiles>
+        </projectFiles>
+
+        <issueHandlers>
+          <UndefinedClass errorLevel="info" />
+        </issueHandlers>
+
+        <plugins>
+          <pluginClass class="Seferov\SymfonyPsalmPlugin\Plugin"/>
+        </plugins>
+      </psalm>
+      """
+
+  Scenario: Asserting using 'AppBundle:Entity' syntax raises issue
+    Given I have the following code
+      """
+      <?php
+      use Doctrine\ORM\EntityManagerInterface;
+      class SomeService
+      {
+        public function __construct(EntityManagerInterface $entityManager)
+        {
+          $entityManager->getRepository('AppBundle:Entity');
+        }
+      }
+
+      namespace Doctrine\ORM;
+      interface EntityManagerInterface
+      {
+        /**
+         * @param string $className
+         *
+         * @return void
+         */
+        public function getRepository($className);
+      }
+      """
+    When I run Psalm
+    Then I see these errors
+      | Type                       | Message                            |
+      | RepositoryStringShortcut  | Use Entity::class syntax instead |
+    And I see no other errors