2018-10-29 16:41:02 +01:00
|
|
|
<?php
|
2019-05-10 00:58:30 +02:00
|
|
|
namespace Psalm\Tests\Config;
|
2018-10-29 16:41:02 +01:00
|
|
|
|
2021-12-03 21:40:18 +01:00
|
|
|
use InvalidArgumentException;
|
2021-06-08 04:55:21 +02:00
|
|
|
use PHPUnit\Framework\MockObject\MockObject;
|
2021-01-09 01:51:26 +01:00
|
|
|
use PhpParser\Node\Expr;
|
|
|
|
use PhpParser\Node\Stmt\ClassLike;
|
|
|
|
use Psalm\Codebase;
|
2021-06-08 04:55:21 +02:00
|
|
|
use Psalm\Config;
|
|
|
|
use Psalm\Context;
|
2021-12-03 20:29:06 +01:00
|
|
|
use Psalm\Exception\CodeException;
|
2021-01-09 01:51:26 +01:00
|
|
|
use Psalm\FileSource;
|
2021-12-03 20:11:20 +01:00
|
|
|
use Psalm\Internal\Analyzer\ProjectAnalyzer;
|
2021-06-08 04:55:21 +02:00
|
|
|
use Psalm\Internal\IncludeCollector;
|
2021-07-02 01:10:21 +02:00
|
|
|
use Psalm\Internal\Provider\FakeFileProvider;
|
2021-12-03 20:11:20 +01:00
|
|
|
use Psalm\Internal\Provider\Providers;
|
2021-06-08 04:55:21 +02:00
|
|
|
use Psalm\Internal\RuntimeCaches;
|
2021-12-03 20:11:20 +01:00
|
|
|
use Psalm\IssueBuffer;
|
2021-06-08 04:55:21 +02:00
|
|
|
use Psalm\Plugin\EventHandler\AfterCodebasePopulatedInterface;
|
2021-01-06 15:05:53 +01:00
|
|
|
use Psalm\Plugin\EventHandler\AfterEveryFunctionCallAnalysisInterface;
|
|
|
|
use Psalm\Plugin\EventHandler\Event\AfterCodebasePopulatedEvent;
|
|
|
|
use Psalm\Plugin\EventHandler\Event\AfterEveryFunctionCallAnalysisEvent;
|
2021-12-11 05:43:11 +01:00
|
|
|
use Psalm\Plugin\Hook\AfterClassLikeVisitInterface as LegacyAfterClassLikeVisitInterface;
|
|
|
|
use Psalm\Plugin\Hook\AfterMethodCallAnalysisInterface as LegacyAfterMethodCallAnalysisInterface;
|
2021-06-08 04:55:21 +02:00
|
|
|
use Psalm\PluginRegistrationSocket;
|
2021-12-03 20:11:20 +01:00
|
|
|
use Psalm\Report;
|
|
|
|
use Psalm\Report\ReportOptions;
|
2021-01-09 01:51:26 +01:00
|
|
|
use Psalm\StatementsSource;
|
|
|
|
use Psalm\Storage\ClassLikeStorage;
|
2021-12-03 20:11:20 +01:00
|
|
|
use Psalm\Test\Config\Plugin\Hook\StringProvider\TSqlSelectString;
|
2021-12-04 21:55:53 +01:00
|
|
|
use Psalm\Tests\Internal\Provider\FakeParserCacheProvider;
|
2021-12-03 20:11:20 +01:00
|
|
|
use Psalm\Tests\TestCase;
|
2021-06-08 04:55:21 +02:00
|
|
|
use Psalm\Tests\TestConfig;
|
2021-01-09 01:51:26 +01:00
|
|
|
use Psalm\Type\Union;
|
2021-12-03 21:40:18 +01:00
|
|
|
use stdClass;
|
2021-06-08 04:55:21 +02:00
|
|
|
|
2019-07-05 22:24:00 +02:00
|
|
|
use function define;
|
|
|
|
use function defined;
|
|
|
|
use function dirname;
|
|
|
|
use function get_class;
|
|
|
|
use function getcwd;
|
|
|
|
use function microtime;
|
2020-07-20 10:52:01 +02:00
|
|
|
use function ob_end_clean;
|
2021-06-08 04:55:21 +02:00
|
|
|
use function ob_start;
|
|
|
|
use function sprintf;
|
|
|
|
|
|
|
|
use const DIRECTORY_SEPARATOR;
|
2018-10-29 16:41:02 +01:00
|
|
|
|
2021-12-03 20:11:20 +01:00
|
|
|
class PluginTest extends TestCase
|
2018-10-29 16:41:02 +01:00
|
|
|
{
|
|
|
|
/** @var TestConfig */
|
|
|
|
protected static $config;
|
|
|
|
|
2021-12-05 18:51:26 +01:00
|
|
|
public static function setUpBeforeClass(): void
|
2018-10-29 16:41:02 +01:00
|
|
|
{
|
|
|
|
self::$config = new TestConfig();
|
|
|
|
|
|
|
|
if (!defined('PSALM_VERSION')) {
|
2021-05-17 15:27:08 +02:00
|
|
|
define('PSALM_VERSION', '4.0.0');
|
2018-10-29 16:41:02 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!defined('PHP_PARSER_VERSION')) {
|
|
|
|
define('PHP_PARSER_VERSION', '4.0.0');
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-12-05 18:51:26 +01:00
|
|
|
public function setUp(): void
|
2018-10-29 16:41:02 +01:00
|
|
|
{
|
2020-08-23 16:32:07 +02:00
|
|
|
RuntimeCaches::clearAll();
|
2021-07-02 01:10:21 +02:00
|
|
|
$this->file_provider = new FakeFileProvider();
|
2018-10-29 16:41:02 +01:00
|
|
|
}
|
|
|
|
|
2021-12-03 20:11:20 +01:00
|
|
|
private function getProjectAnalyzerWithConfig(Config $config): ProjectAnalyzer
|
2018-10-29 16:41:02 +01:00
|
|
|
{
|
2020-07-11 23:17:22 +02:00
|
|
|
$config->setIncludeCollector(new IncludeCollector());
|
2021-12-03 20:11:20 +01:00
|
|
|
return new ProjectAnalyzer(
|
2018-10-29 16:41:02 +01:00
|
|
|
$config,
|
2021-12-03 20:11:20 +01:00
|
|
|
new Providers(
|
2018-10-29 16:41:02 +01:00
|
|
|
$this->file_provider,
|
2021-12-04 21:55:53 +01:00
|
|
|
new FakeParserCacheProvider()
|
2019-05-30 16:30:41 +02:00
|
|
|
),
|
2021-12-03 20:11:20 +01:00
|
|
|
new ReportOptions()
|
2018-10-29 16:41:02 +01:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testStringAnalyzerPlugin(): void
|
2018-10-29 16:54:25 +01:00
|
|
|
{
|
2019-05-17 00:36:36 +02:00
|
|
|
$this->expectExceptionMessage('InvalidClass');
|
2021-12-03 20:29:06 +01:00
|
|
|
$this->expectException(CodeException::class);
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
2018-10-29 16:54:25 +01:00
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2018-10-29 16:54:25 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2018-10-29 16:54:25 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2018-11-06 03:57:36 +01:00
|
|
|
<plugin filename="examples/plugins/StringChecker.php" />
|
2018-10-29 16:54:25 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
2018-10-29 16:54:25 +01:00
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
2018-11-06 03:57:36 +01:00
|
|
|
$a = "Psalm\Internal\Analyzer\ProjectAnalyzer";'
|
2018-10-29 16:54:25 +01:00
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testStringAnalyzerPluginWithClassConstant(): void
|
2018-10-29 16:54:25 +01:00
|
|
|
{
|
2019-05-17 00:36:36 +02:00
|
|
|
$this->expectExceptionMessage('InvalidClass');
|
2021-12-03 20:29:06 +01:00
|
|
|
$this->expectException(CodeException::class);
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
2018-10-29 16:54:25 +01:00
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2018-10-29 16:54:25 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2018-10-29 16:54:25 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2018-11-06 03:57:36 +01:00
|
|
|
<plugin filename="examples/plugins/StringChecker.php" />
|
2018-10-29 16:54:25 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
2018-10-29 16:54:25 +01:00
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
class A {
|
|
|
|
const C = [
|
2018-11-06 03:57:36 +01:00
|
|
|
"foo" => "Psalm\Internal\Analyzer\ProjectAnalyzer",
|
2018-10-29 16:54:25 +01:00
|
|
|
];
|
|
|
|
}'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testStringAnalyzerPluginWithClassConstantConcat(): void
|
2018-10-29 16:41:02 +01:00
|
|
|
{
|
2019-05-17 00:36:36 +02:00
|
|
|
$this->expectExceptionMessage('UndefinedMethod');
|
2021-12-03 20:29:06 +01:00
|
|
|
$this->expectException(CodeException::class);
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
2018-10-29 16:41:02 +01:00
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2018-10-29 16:41:02 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2018-10-29 16:41:02 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2018-11-06 03:57:36 +01:00
|
|
|
<plugin filename="examples/plugins/StringChecker.php" />
|
2018-10-29 16:41:02 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
2018-10-29 16:41:02 +01:00
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
2020-07-23 01:27:35 +02:00
|
|
|
namespace Psalm;
|
|
|
|
|
2018-10-29 16:41:02 +01:00
|
|
|
class A {
|
|
|
|
const C = [
|
2018-11-06 03:57:36 +01:00
|
|
|
"foo" => \Psalm\Internal\Analyzer\ProjectAnalyzer::class . "::foo",
|
2018-10-29 16:41:02 +01:00
|
|
|
];
|
|
|
|
}'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
2018-10-29 16:54:25 +01:00
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testEchoAnalyzerPluginWithJustHtml(): void
|
2018-10-29 16:54:25 +01:00
|
|
|
{
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
2018-10-29 16:54:25 +01:00
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2018-10-29 16:54:25 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2018-10-29 16:54:25 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2018-11-06 03:57:36 +01:00
|
|
|
<plugin filename="examples/plugins/composer-based/echo-checker/EchoChecker.php" />
|
2018-10-29 16:54:25 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
2018-10-29 16:54:25 +01:00
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<h3>This is a header</h3>'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testEchoAnalyzerPluginWithUnescapedConcatenatedString(): void
|
2018-10-29 16:54:25 +01:00
|
|
|
{
|
2019-05-17 00:36:36 +02:00
|
|
|
$this->expectExceptionMessage('TypeCoercion');
|
2021-12-03 20:29:06 +01:00
|
|
|
$this->expectException(CodeException::class);
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
2018-10-29 16:54:25 +01:00
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2018-10-29 16:54:25 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2018-10-29 16:54:25 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2018-11-06 03:57:36 +01:00
|
|
|
<plugin filename="examples/plugins/composer-based/echo-checker/EchoChecker.php" />
|
2018-10-29 16:54:25 +01:00
|
|
|
</plugins>
|
|
|
|
<issueHandlers>
|
|
|
|
<UndefinedGlobalVariable errorLevel="suppress" />
|
|
|
|
<MixedArgument errorLevel="suppress" />
|
|
|
|
<MixedOperand errorLevel="suppress" />
|
|
|
|
</issueHandlers>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
2018-10-29 16:54:25 +01:00
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?= $unsafe . "safeString" ?>'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testEchoAnalyzerPluginWithUnescapedString(): void
|
2018-10-29 16:54:25 +01:00
|
|
|
{
|
2019-05-17 00:36:36 +02:00
|
|
|
$this->expectExceptionMessage('TypeCoercion');
|
2021-12-03 20:29:06 +01:00
|
|
|
$this->expectException(CodeException::class);
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
2018-10-29 16:54:25 +01:00
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2018-10-29 16:54:25 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2018-10-29 16:54:25 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2018-11-06 03:57:36 +01:00
|
|
|
<plugin filename="examples/plugins/composer-based/echo-checker/EchoChecker.php" />
|
2018-10-29 16:54:25 +01:00
|
|
|
</plugins>
|
|
|
|
<issueHandlers>
|
|
|
|
<UndefinedGlobalVariable errorLevel="suppress" />
|
|
|
|
<MixedArgument errorLevel="suppress" />
|
|
|
|
</issueHandlers>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
2018-10-29 16:54:25 +01:00
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?= $unsafe ?>'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testEchoAnalyzerPluginWithEscapedString(): void
|
2018-10-29 16:54:25 +01:00
|
|
|
{
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
2018-10-29 16:54:25 +01:00
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2018-10-29 16:54:25 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2018-10-29 16:54:25 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2018-11-06 03:57:36 +01:00
|
|
|
<plugin filename="examples/plugins/composer-based/echo-checker/EchoChecker.php" />
|
2018-10-29 16:54:25 +01:00
|
|
|
</plugins>
|
|
|
|
<issueHandlers>
|
|
|
|
<UndefinedGlobalVariable errorLevel="suppress" />
|
|
|
|
<MixedArgument errorLevel="suppress" />
|
|
|
|
</issueHandlers>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
2018-10-29 16:54:25 +01:00
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
/**
|
|
|
|
* @param mixed $s
|
|
|
|
* @return html-escaped-string
|
|
|
|
*/
|
|
|
|
function escapeHtml($s) : string {
|
|
|
|
if (!is_scalar($s)) {
|
|
|
|
throw new \UnexpectedValueException("bad value passed to escape");
|
|
|
|
}
|
|
|
|
/** @var html-escaped-string */
|
|
|
|
return htmlentities((string) $s);
|
|
|
|
}
|
|
|
|
?>
|
|
|
|
Some text
|
|
|
|
<?= escapeHtml($unsafe) ?>'
|
|
|
|
);
|
2019-01-07 14:38:56 +01:00
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testFileAnalyzerPlugin(): void
|
2020-08-10 16:49:53 +02:00
|
|
|
{
|
|
|
|
require_once __DIR__ . '/Plugin/FilePlugin.php';
|
|
|
|
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
|
|
|
'<?xml version="1.0"?>
|
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
|
|
|
<pluginClass class="Psalm\\Test\\Config\\Plugin\\FilePlugin" />
|
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$codebase = $this->project_analyzer->getCodebase();
|
2021-01-06 15:05:53 +01:00
|
|
|
$this->assertEmpty($codebase->config->eventDispatcher->before_file_checks);
|
|
|
|
$this->assertEmpty($codebase->config->eventDispatcher->after_file_checks);
|
2020-08-10 16:49:53 +02:00
|
|
|
$codebase->config->initializePlugins($this->project_analyzer);
|
2021-01-06 15:05:53 +01:00
|
|
|
$this->assertCount(1, $codebase->config->eventDispatcher->before_file_checks);
|
|
|
|
$this->assertCount(1, $codebase->config->eventDispatcher->after_file_checks);
|
2020-08-10 16:49:53 +02:00
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
$a = 0;
|
|
|
|
'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
$file_storage = $codebase->file_storage_provider->get($file_path);
|
|
|
|
$this->assertEquals(
|
|
|
|
[
|
|
|
|
'before-analysis' => true,
|
|
|
|
'after-analysis' => true,
|
|
|
|
],
|
|
|
|
$file_storage->custom_metadata
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testFloatCheckerPlugin(): void
|
2019-01-07 14:38:56 +01:00
|
|
|
{
|
2019-05-17 00:36:36 +02:00
|
|
|
$this->expectExceptionMessage('NoFloatAssignment');
|
2021-12-03 20:29:06 +01:00
|
|
|
$this->expectException(CodeException::class);
|
2019-01-07 14:38:56 +01:00
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-01-07 14:38:56 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-01-07 14:38:56 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
|
|
|
<plugin filename="examples/plugins/PreventFloatAssignmentChecker.php" />
|
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
|
|
|
|
$a = 5.0;'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testFloatCheckerPluginIssueSuppressionByConfig(): void
|
2019-01-07 14:38:56 +01:00
|
|
|
{
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-01-07 14:38:56 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-01-07 14:38:56 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
|
|
|
<plugin filename="examples/plugins/PreventFloatAssignmentChecker.php" />
|
|
|
|
</plugins>
|
|
|
|
|
|
|
|
<issueHandlers>
|
|
|
|
<PluginIssue name="NoFloatAssignment" errorLevel="suppress" />
|
|
|
|
<PluginIssue name="SomeOtherCustomIssue" errorLevel="suppress" />
|
|
|
|
</issueHandlers>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
|
|
|
|
$a = 5.0;'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testFloatCheckerPluginIssueSuppressionByDocblock(): void
|
2019-01-07 14:38:56 +01:00
|
|
|
{
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-01-07 14:38:56 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-01-07 14:38:56 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
|
|
|
<plugin filename="examples/plugins/PreventFloatAssignmentChecker.php" />
|
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
|
|
|
|
/** @psalm-suppress NoFloatAssignment */
|
|
|
|
$a = 5.0;'
|
|
|
|
);
|
2018-10-29 16:54:25 +01:00
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
2018-11-06 03:57:36 +01:00
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testInheritedHookHandlersAreCalled(): void
|
Plugin loading (#855)
* add ability to load plugins by class names
- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals
* added `psalm-plugin` cli tool to manage plugins
Available commands:
`psalm-plugin list` - lists available and enabled plugins
`psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
`psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)
Plugin installation:
`composer install plugin-vendor/plugin-package-name`
Plugin authoring:
Plugins are identified by package `type` field, which should contain
`psalm-plugin` string.
`extra.pluginClass` should refer to the name of the class implementing
`__invoke(PluginFacade $psalm):void` function
Todo:
- better config file search
- better output for `psalm-plugin`
- better formatting for modified xml file
- composer skeleton project for plugins
- ability to refer to plugins by package name (cli only)
- composer plugin to (optionally) enable plugin upon installation
- documentation on plugin installation and authoring
- interfaces for plugin dependencies
- interface for plugin entry point
- migration path for legacy plugins
* documented previously undocumented plugin methods
* split legacy plugin registration into a wrapper class
also added `PluginApi` namespace and `RegistrationInterface`
* reuse psalm's config search algorithm
* enable/disable plugins by composer package name
* allow specifying alternative config file name
* whitelist PluginApi namespace
three times, but well, it works now
* interface for plugin entry points
* psalm-plugin as a symfony console app
* fixed errors found by psalm
* suppressed false positive UnusedMethods
* cs fix
* better psalm-plugin output
* don't leave empty `plugins` node to avoid old schema violation
* removed junk file that shouldn't be there
* cs fix
* fixed phpunit failure (constant redefinition)
* work around missing docblock in on symfony console
* php 7.0 compatibility
* allow `pluginClass` child elements as plugin configuration
* decouple console commands from undelying implementation
- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`
* PluginList tests
* ComposerLock test
* droppped debugging statement
* added part of console command tests
* added tests for EnableCommand
* added DisableCommand tests
* ignore unused args
* ConfigFile test
* disable travis cache in attempt to fix builds
* nah, that didn't work
* update for upstream changes
* rebase fixes
* namespaced `extra` entry for entry point
* s/PluginFacade/PluginRegistrationSocket/g
* Added $config parameter to PluginEntryPointInterface::__invoke()
* cs fixes
* entry point interface php7.0 compatibility
* cleaned up old cruft
- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface
* fixed legacy plugins docs
* Added RegistrationInterface::registerHooksFromClass()
It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.
Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.
* Converted EchoChecker plugin to composer-based format
- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
```
composer require psalm/echo-checker-plugin
```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.
* Updated docs
* Don't reject hook handlers that inherit handling methods
* strip void return type in stub file
2018-11-11 05:23:36 +01:00
|
|
|
{
|
2021-02-14 00:42:34 +01:00
|
|
|
require_once dirname(__DIR__) . '/fixtures/stubs/extending_plugin_entrypoint.phpstub';
|
Plugin loading (#855)
* add ability to load plugins by class names
- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals
* added `psalm-plugin` cli tool to manage plugins
Available commands:
`psalm-plugin list` - lists available and enabled plugins
`psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
`psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)
Plugin installation:
`composer install plugin-vendor/plugin-package-name`
Plugin authoring:
Plugins are identified by package `type` field, which should contain
`psalm-plugin` string.
`extra.pluginClass` should refer to the name of the class implementing
`__invoke(PluginFacade $psalm):void` function
Todo:
- better config file search
- better output for `psalm-plugin`
- better formatting for modified xml file
- composer skeleton project for plugins
- ability to refer to plugins by package name (cli only)
- composer plugin to (optionally) enable plugin upon installation
- documentation on plugin installation and authoring
- interfaces for plugin dependencies
- interface for plugin entry point
- migration path for legacy plugins
* documented previously undocumented plugin methods
* split legacy plugin registration into a wrapper class
also added `PluginApi` namespace and `RegistrationInterface`
* reuse psalm's config search algorithm
* enable/disable plugins by composer package name
* allow specifying alternative config file name
* whitelist PluginApi namespace
three times, but well, it works now
* interface for plugin entry points
* psalm-plugin as a symfony console app
* fixed errors found by psalm
* suppressed false positive UnusedMethods
* cs fix
* better psalm-plugin output
* don't leave empty `plugins` node to avoid old schema violation
* removed junk file that shouldn't be there
* cs fix
* fixed phpunit failure (constant redefinition)
* work around missing docblock in on symfony console
* php 7.0 compatibility
* allow `pluginClass` child elements as plugin configuration
* decouple console commands from undelying implementation
- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`
* PluginList tests
* ComposerLock test
* droppped debugging statement
* added part of console command tests
* added tests for EnableCommand
* added DisableCommand tests
* ignore unused args
* ConfigFile test
* disable travis cache in attempt to fix builds
* nah, that didn't work
* update for upstream changes
* rebase fixes
* namespaced `extra` entry for entry point
* s/PluginFacade/PluginRegistrationSocket/g
* Added $config parameter to PluginEntryPointInterface::__invoke()
* cs fixes
* entry point interface php7.0 compatibility
* cleaned up old cruft
- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface
* fixed legacy plugins docs
* Added RegistrationInterface::registerHooksFromClass()
It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.
Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.
* Converted EchoChecker plugin to composer-based format
- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
```
composer require psalm/echo-checker-plugin
```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.
* Updated docs
* Don't reject hook handlers that inherit handling methods
* strip void return type in stub file
2018-11-11 05:23:36 +01:00
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
Plugin loading (#855)
* add ability to load plugins by class names
- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals
* added `psalm-plugin` cli tool to manage plugins
Available commands:
`psalm-plugin list` - lists available and enabled plugins
`psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
`psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)
Plugin installation:
`composer install plugin-vendor/plugin-package-name`
Plugin authoring:
Plugins are identified by package `type` field, which should contain
`psalm-plugin` string.
`extra.pluginClass` should refer to the name of the class implementing
`__invoke(PluginFacade $psalm):void` function
Todo:
- better config file search
- better output for `psalm-plugin`
- better formatting for modified xml file
- composer skeleton project for plugins
- ability to refer to plugins by package name (cli only)
- composer plugin to (optionally) enable plugin upon installation
- documentation on plugin installation and authoring
- interfaces for plugin dependencies
- interface for plugin entry point
- migration path for legacy plugins
* documented previously undocumented plugin methods
* split legacy plugin registration into a wrapper class
also added `PluginApi` namespace and `RegistrationInterface`
* reuse psalm's config search algorithm
* enable/disable plugins by composer package name
* allow specifying alternative config file name
* whitelist PluginApi namespace
three times, but well, it works now
* interface for plugin entry points
* psalm-plugin as a symfony console app
* fixed errors found by psalm
* suppressed false positive UnusedMethods
* cs fix
* better psalm-plugin output
* don't leave empty `plugins` node to avoid old schema violation
* removed junk file that shouldn't be there
* cs fix
* fixed phpunit failure (constant redefinition)
* work around missing docblock in on symfony console
* php 7.0 compatibility
* allow `pluginClass` child elements as plugin configuration
* decouple console commands from undelying implementation
- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`
* PluginList tests
* ComposerLock test
* droppped debugging statement
* added part of console command tests
* added tests for EnableCommand
* added DisableCommand tests
* ignore unused args
* ConfigFile test
* disable travis cache in attempt to fix builds
* nah, that didn't work
* update for upstream changes
* rebase fixes
* namespaced `extra` entry for entry point
* s/PluginFacade/PluginRegistrationSocket/g
* Added $config parameter to PluginEntryPointInterface::__invoke()
* cs fixes
* entry point interface php7.0 compatibility
* cleaned up old cruft
- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface
* fixed legacy plugins docs
* Added RegistrationInterface::registerHooksFromClass()
It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.
Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.
* Converted EchoChecker plugin to composer-based format
- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
```
composer require psalm/echo-checker-plugin
```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.
* Updated docs
* Don't reject hook handlers that inherit handling methods
* strip void return type in stub file
2018-11-11 05:23:36 +01:00
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
Plugin loading (#855)
* add ability to load plugins by class names
- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals
* added `psalm-plugin` cli tool to manage plugins
Available commands:
`psalm-plugin list` - lists available and enabled plugins
`psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
`psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)
Plugin installation:
`composer install plugin-vendor/plugin-package-name`
Plugin authoring:
Plugins are identified by package `type` field, which should contain
`psalm-plugin` string.
`extra.pluginClass` should refer to the name of the class implementing
`__invoke(PluginFacade $psalm):void` function
Todo:
- better config file search
- better output for `psalm-plugin`
- better formatting for modified xml file
- composer skeleton project for plugins
- ability to refer to plugins by package name (cli only)
- composer plugin to (optionally) enable plugin upon installation
- documentation on plugin installation and authoring
- interfaces for plugin dependencies
- interface for plugin entry point
- migration path for legacy plugins
* documented previously undocumented plugin methods
* split legacy plugin registration into a wrapper class
also added `PluginApi` namespace and `RegistrationInterface`
* reuse psalm's config search algorithm
* enable/disable plugins by composer package name
* allow specifying alternative config file name
* whitelist PluginApi namespace
three times, but well, it works now
* interface for plugin entry points
* psalm-plugin as a symfony console app
* fixed errors found by psalm
* suppressed false positive UnusedMethods
* cs fix
* better psalm-plugin output
* don't leave empty `plugins` node to avoid old schema violation
* removed junk file that shouldn't be there
* cs fix
* fixed phpunit failure (constant redefinition)
* work around missing docblock in on symfony console
* php 7.0 compatibility
* allow `pluginClass` child elements as plugin configuration
* decouple console commands from undelying implementation
- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`
* PluginList tests
* ComposerLock test
* droppped debugging statement
* added part of console command tests
* added tests for EnableCommand
* added DisableCommand tests
* ignore unused args
* ConfigFile test
* disable travis cache in attempt to fix builds
* nah, that didn't work
* update for upstream changes
* rebase fixes
* namespaced `extra` entry for entry point
* s/PluginFacade/PluginRegistrationSocket/g
* Added $config parameter to PluginEntryPointInterface::__invoke()
* cs fixes
* entry point interface php7.0 compatibility
* cleaned up old cruft
- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface
* fixed legacy plugins docs
* Added RegistrationInterface::registerHooksFromClass()
It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.
Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.
* Converted EchoChecker plugin to composer-based format
- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
```
composer require psalm/echo-checker-plugin
```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.
* Updated docs
* Don't reject hook handlers that inherit handling methods
* strip void return type in stub file
2018-11-11 05:23:36 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
Plugin loading (#855)
* add ability to load plugins by class names
- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals
* added `psalm-plugin` cli tool to manage plugins
Available commands:
`psalm-plugin list` - lists available and enabled plugins
`psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
`psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)
Plugin installation:
`composer install plugin-vendor/plugin-package-name`
Plugin authoring:
Plugins are identified by package `type` field, which should contain
`psalm-plugin` string.
`extra.pluginClass` should refer to the name of the class implementing
`__invoke(PluginFacade $psalm):void` function
Todo:
- better config file search
- better output for `psalm-plugin`
- better formatting for modified xml file
- composer skeleton project for plugins
- ability to refer to plugins by package name (cli only)
- composer plugin to (optionally) enable plugin upon installation
- documentation on plugin installation and authoring
- interfaces for plugin dependencies
- interface for plugin entry point
- migration path for legacy plugins
* documented previously undocumented plugin methods
* split legacy plugin registration into a wrapper class
also added `PluginApi` namespace and `RegistrationInterface`
* reuse psalm's config search algorithm
* enable/disable plugins by composer package name
* allow specifying alternative config file name
* whitelist PluginApi namespace
three times, but well, it works now
* interface for plugin entry points
* psalm-plugin as a symfony console app
* fixed errors found by psalm
* suppressed false positive UnusedMethods
* cs fix
* better psalm-plugin output
* don't leave empty `plugins` node to avoid old schema violation
* removed junk file that shouldn't be there
* cs fix
* fixed phpunit failure (constant redefinition)
* work around missing docblock in on symfony console
* php 7.0 compatibility
* allow `pluginClass` child elements as plugin configuration
* decouple console commands from undelying implementation
- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`
* PluginList tests
* ComposerLock test
* droppped debugging statement
* added part of console command tests
* added tests for EnableCommand
* added DisableCommand tests
* ignore unused args
* ConfigFile test
* disable travis cache in attempt to fix builds
* nah, that didn't work
* update for upstream changes
* rebase fixes
* namespaced `extra` entry for entry point
* s/PluginFacade/PluginRegistrationSocket/g
* Added $config parameter to PluginEntryPointInterface::__invoke()
* cs fixes
* entry point interface php7.0 compatibility
* cleaned up old cruft
- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface
* fixed legacy plugins docs
* Added RegistrationInterface::registerHooksFromClass()
It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.
Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.
* Converted EchoChecker plugin to composer-based format
- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
```
composer require psalm/echo-checker-plugin
```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.
* Updated docs
* Don't reject hook handlers that inherit handling methods
* strip void return type in stub file
2018-11-11 05:23:36 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
|
|
|
<pluginClass class="ExtendingPluginRegistration" />
|
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
Plugin loading (#855)
* add ability to load plugins by class names
- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals
* added `psalm-plugin` cli tool to manage plugins
Available commands:
`psalm-plugin list` - lists available and enabled plugins
`psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
`psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)
Plugin installation:
`composer install plugin-vendor/plugin-package-name`
Plugin authoring:
Plugins are identified by package `type` field, which should contain
`psalm-plugin` string.
`extra.pluginClass` should refer to the name of the class implementing
`__invoke(PluginFacade $psalm):void` function
Todo:
- better config file search
- better output for `psalm-plugin`
- better formatting for modified xml file
- composer skeleton project for plugins
- ability to refer to plugins by package name (cli only)
- composer plugin to (optionally) enable plugin upon installation
- documentation on plugin installation and authoring
- interfaces for plugin dependencies
- interface for plugin entry point
- migration path for legacy plugins
* documented previously undocumented plugin methods
* split legacy plugin registration into a wrapper class
also added `PluginApi` namespace and `RegistrationInterface`
* reuse psalm's config search algorithm
* enable/disable plugins by composer package name
* allow specifying alternative config file name
* whitelist PluginApi namespace
three times, but well, it works now
* interface for plugin entry points
* psalm-plugin as a symfony console app
* fixed errors found by psalm
* suppressed false positive UnusedMethods
* cs fix
* better psalm-plugin output
* don't leave empty `plugins` node to avoid old schema violation
* removed junk file that shouldn't be there
* cs fix
* fixed phpunit failure (constant redefinition)
* work around missing docblock in on symfony console
* php 7.0 compatibility
* allow `pluginClass` child elements as plugin configuration
* decouple console commands from undelying implementation
- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`
* PluginList tests
* ComposerLock test
* droppped debugging statement
* added part of console command tests
* added tests for EnableCommand
* added DisableCommand tests
* ignore unused args
* ConfigFile test
* disable travis cache in attempt to fix builds
* nah, that didn't work
* update for upstream changes
* rebase fixes
* namespaced `extra` entry for entry point
* s/PluginFacade/PluginRegistrationSocket/g
* Added $config parameter to PluginEntryPointInterface::__invoke()
* cs fixes
* entry point interface php7.0 compatibility
* cleaned up old cruft
- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface
* fixed legacy plugins docs
* Added RegistrationInterface::registerHooksFromClass()
It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.
Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.
* Converted EchoChecker plugin to composer-based format
- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
```
composer require psalm/echo-checker-plugin
```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.
* Updated docs
* Don't reject hook handlers that inherit handling methods
* strip void return type in stub file
2018-11-11 05:23:36 +01:00
|
|
|
$this->assertContains(
|
|
|
|
'ExtendingPlugin',
|
2021-01-06 15:05:53 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->eventDispatcher->after_function_checks
|
Plugin loading (#855)
* add ability to load plugins by class names
- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals
* added `psalm-plugin` cli tool to manage plugins
Available commands:
`psalm-plugin list` - lists available and enabled plugins
`psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
`psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)
Plugin installation:
`composer install plugin-vendor/plugin-package-name`
Plugin authoring:
Plugins are identified by package `type` field, which should contain
`psalm-plugin` string.
`extra.pluginClass` should refer to the name of the class implementing
`__invoke(PluginFacade $psalm):void` function
Todo:
- better config file search
- better output for `psalm-plugin`
- better formatting for modified xml file
- composer skeleton project for plugins
- ability to refer to plugins by package name (cli only)
- composer plugin to (optionally) enable plugin upon installation
- documentation on plugin installation and authoring
- interfaces for plugin dependencies
- interface for plugin entry point
- migration path for legacy plugins
* documented previously undocumented plugin methods
* split legacy plugin registration into a wrapper class
also added `PluginApi` namespace and `RegistrationInterface`
* reuse psalm's config search algorithm
* enable/disable plugins by composer package name
* allow specifying alternative config file name
* whitelist PluginApi namespace
three times, but well, it works now
* interface for plugin entry points
* psalm-plugin as a symfony console app
* fixed errors found by psalm
* suppressed false positive UnusedMethods
* cs fix
* better psalm-plugin output
* don't leave empty `plugins` node to avoid old schema violation
* removed junk file that shouldn't be there
* cs fix
* fixed phpunit failure (constant redefinition)
* work around missing docblock in on symfony console
* php 7.0 compatibility
* allow `pluginClass` child elements as plugin configuration
* decouple console commands from undelying implementation
- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`
* PluginList tests
* ComposerLock test
* droppped debugging statement
* added part of console command tests
* added tests for EnableCommand
* added DisableCommand tests
* ignore unused args
* ConfigFile test
* disable travis cache in attempt to fix builds
* nah, that didn't work
* update for upstream changes
* rebase fixes
* namespaced `extra` entry for entry point
* s/PluginFacade/PluginRegistrationSocket/g
* Added $config parameter to PluginEntryPointInterface::__invoke()
* cs fixes
* entry point interface php7.0 compatibility
* cleaned up old cruft
- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface
* fixed legacy plugins docs
* Added RegistrationInterface::registerHooksFromClass()
It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.
Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.
* Converted EchoChecker plugin to composer-based format
- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
```
composer require psalm/echo-checker-plugin
```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.
* Updated docs
* Don't reject hook handlers that inherit handling methods
* strip void return type in stub file
2018-11-11 05:23:36 +01:00
|
|
|
);
|
|
|
|
}
|
2019-02-24 20:11:36 +01:00
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testAfterCodebasePopulatedHookIsLoaded(): void
|
2019-02-24 20:11:36 +01:00
|
|
|
{
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-02-24 20:11:36 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-02-24 20:11:36 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2019-03-23 19:27:54 +01:00
|
|
|
$hook = new class implements AfterCodebasePopulatedInterface {
|
2021-12-05 18:51:26 +01:00
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @phpcsSuppress SlevomatCodingStandard.TypeHints.ReturnTypeHint
|
|
|
|
*/
|
2021-01-06 15:05:53 +01:00
|
|
|
public static function afterCodebasePopulated(AfterCodebasePopulatedEvent $event)
|
2019-02-24 20:11:36 +01:00
|
|
|
{
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2019-03-01 14:57:10 +01:00
|
|
|
$codebase = $this->project_analyzer->getCodebase();
|
2019-02-24 20:11:36 +01:00
|
|
|
|
2019-03-01 14:57:10 +01:00
|
|
|
$config = $codebase->config;
|
|
|
|
|
|
|
|
(new PluginRegistrationSocket($config, $codebase))->registerHooksFromClass(get_class($hook));
|
2019-02-24 20:11:36 +01:00
|
|
|
|
|
|
|
$this->assertContains(
|
|
|
|
get_class($hook),
|
2021-01-06 15:05:53 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->eventDispatcher->after_codebase_populated
|
2019-02-24 20:11:36 +01:00
|
|
|
);
|
|
|
|
}
|
2019-03-01 14:57:10 +01:00
|
|
|
|
2021-01-09 01:51:26 +01:00
|
|
|
public function testAfterMethodCallAnalysisLegacyHookIsLoaded(): void
|
|
|
|
{
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
|
|
|
'<?xml version="1.0"?>
|
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2021-12-11 05:43:11 +01:00
|
|
|
$hook = new class implements LegacyAfterMethodCallAnalysisInterface {
|
2021-01-09 01:51:26 +01:00
|
|
|
public static function afterMethodCallAnalysis(
|
|
|
|
Expr $expr,
|
|
|
|
string $method_id,
|
|
|
|
string $appearing_method_id,
|
|
|
|
string $declaring_method_id,
|
|
|
|
Context $context,
|
|
|
|
StatementsSource $statements_source,
|
|
|
|
Codebase $codebase,
|
|
|
|
array &$file_replacements = [],
|
|
|
|
Union &$return_type_candidate = null
|
|
|
|
): void {
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
|
|
|
|
|
|
$config = $codebase->config;
|
|
|
|
|
|
|
|
(new PluginRegistrationSocket($config, $codebase))->registerHooksFromClass(get_class($hook));
|
|
|
|
|
|
|
|
$this->assertTrue($this->project_analyzer->getCodebase()->config->eventDispatcher->hasAfterMethodCallAnalysisHandlers());
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testAfterClassLikeAnalysisLegacyHookIsLoaded(): void
|
|
|
|
{
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
|
|
|
'<?xml version="1.0"?>
|
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2021-12-11 05:43:11 +01:00
|
|
|
$hook = new class implements LegacyAfterClassLikeVisitInterface {
|
2021-12-05 18:51:26 +01:00
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @phpcsSuppress SlevomatCodingStandard.TypeHints.ReturnTypeHint
|
|
|
|
*/
|
2021-01-09 01:51:26 +01:00
|
|
|
public static function afterClassLikeVisit(
|
|
|
|
ClassLike $stmt,
|
|
|
|
ClassLikeStorage $storage,
|
|
|
|
FileSource $statements_source,
|
|
|
|
Codebase $codebase,
|
|
|
|
array &$file_replacements = []
|
2021-12-05 18:51:26 +01:00
|
|
|
) {
|
2021-01-09 01:51:26 +01:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
|
|
|
|
|
|
$config = $codebase->config;
|
|
|
|
|
|
|
|
(new PluginRegistrationSocket($config, $codebase))->registerHooksFromClass(get_class($hook));
|
|
|
|
|
|
|
|
$this->assertTrue($this->project_analyzer->getCodebase()->config->eventDispatcher->hasAfterClassLikeVisitHandlers());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testPropertyProviderHooks(): void
|
2019-03-01 14:57:10 +01:00
|
|
|
{
|
|
|
|
require_once __DIR__ . '/Plugin/PropertyPlugin.php';
|
|
|
|
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-03-01 14:57:10 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-03-01 14:57:10 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2019-05-10 00:58:30 +02:00
|
|
|
<pluginClass class="Psalm\\Test\\Config\\Plugin\\PropertyPlugin" />
|
2019-03-01 14:57:10 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
namespace Ns;
|
|
|
|
|
|
|
|
class Foo {}
|
|
|
|
|
|
|
|
$foo = new Foo();
|
|
|
|
echo $foo->magic_property;'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testMethodProviderHooksValidArg(): void
|
2019-03-01 14:57:10 +01:00
|
|
|
{
|
|
|
|
require_once __DIR__ . '/Plugin/MethodPlugin.php';
|
|
|
|
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-03-01 14:57:10 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-03-01 14:57:10 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2019-05-10 00:58:30 +02:00
|
|
|
<pluginClass class="Psalm\\Test\\Config\\Plugin\\MethodPlugin" />
|
2019-03-01 14:57:10 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
namespace Ns;
|
|
|
|
|
2020-03-23 18:24:36 +01:00
|
|
|
interface I {}
|
|
|
|
class Foo2 implements I {
|
|
|
|
public function id(): int { return 1; }
|
|
|
|
}
|
2020-09-01 00:56:21 +02:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @method static int magicMethod(string $s) this method return type gets overridden
|
|
|
|
*/
|
|
|
|
class Foo {
|
|
|
|
public function __call(string $method_name, array $args) {}
|
|
|
|
public static function __callStatic(string $method_name, array $args) {}
|
|
|
|
}
|
2019-03-01 14:57:10 +01:00
|
|
|
|
2020-03-23 18:24:36 +01:00
|
|
|
function i(I $i): void {}
|
|
|
|
|
2019-03-01 14:57:10 +01:00
|
|
|
$foo = new Foo();
|
2020-03-23 18:24:36 +01:00
|
|
|
|
2019-03-01 14:57:10 +01:00
|
|
|
echo $foo->magicMethod("hello");
|
2020-09-01 00:56:21 +02:00
|
|
|
echo strlen($foo->magicMethod("hello"));
|
2020-03-23 18:24:36 +01:00
|
|
|
echo $foo::magicMethod("hello");
|
2020-09-01 00:56:21 +02:00
|
|
|
echo strlen($foo::magicMethod("hello"));
|
2020-03-23 18:24:36 +01:00
|
|
|
|
|
|
|
$foo2 = $foo->magicMethod2("test");
|
|
|
|
$foo2->id();
|
|
|
|
i($foo2);
|
|
|
|
echo $foo2->id();'
|
2019-03-01 14:57:10 +01:00
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testFunctionProviderHooks(): void
|
2019-03-01 14:57:10 +01:00
|
|
|
{
|
|
|
|
require_once __DIR__ . '/Plugin/FunctionPlugin.php';
|
|
|
|
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-03-01 14:57:10 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-03-01 14:57:10 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2019-05-10 00:58:30 +02:00
|
|
|
<pluginClass class="Psalm\\Test\\Config\\Plugin\\FunctionPlugin" />
|
2019-03-01 14:57:10 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
magicFunction("hello");'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testSqlStringProviderHooks(): void
|
2019-05-21 05:14:41 +02:00
|
|
|
{
|
|
|
|
require_once __DIR__ . '/Plugin/SqlStringProviderPlugin.php';
|
|
|
|
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-05-21 05:14:41 +02:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
|
|
|
<pluginClass class="Psalm\\Test\\Config\\Plugin\\SqlStringProviderPlugin" />
|
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
$a = "select * from videos;";'
|
|
|
|
);
|
|
|
|
|
|
|
|
$context = new Context();
|
|
|
|
$this->analyzeFile($file_path, $context);
|
|
|
|
|
|
|
|
$this->assertTrue(isset($context->vars_in_scope['$a']));
|
|
|
|
|
2020-01-04 18:20:26 +01:00
|
|
|
foreach ($context->vars_in_scope['$a']->getAtomicTypes() as $type) {
|
2021-12-03 20:11:20 +01:00
|
|
|
$this->assertInstanceOf(TSqlSelectString::class, $type);
|
2019-05-21 05:14:41 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testPropertyProviderHooksInvalidAssignment(): void
|
2019-03-01 14:57:10 +01:00
|
|
|
{
|
2019-05-17 00:36:36 +02:00
|
|
|
$this->expectExceptionMessage('InvalidPropertyAssignmentValue');
|
2021-12-03 20:29:06 +01:00
|
|
|
$this->expectException(CodeException::class);
|
2019-03-01 14:57:10 +01:00
|
|
|
require_once __DIR__ . '/Plugin/PropertyPlugin.php';
|
|
|
|
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-03-01 14:57:10 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-03-01 14:57:10 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2019-05-10 00:58:30 +02:00
|
|
|
<pluginClass class="Psalm\\Test\\Config\\Plugin\\PropertyPlugin" />
|
2019-03-01 14:57:10 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
namespace Ns;
|
|
|
|
|
|
|
|
class Foo {}
|
|
|
|
|
|
|
|
$foo = new Foo();
|
|
|
|
$foo->magic_property = 5;'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testMethodProviderHooksInvalidArg(): void
|
2019-03-01 14:57:10 +01:00
|
|
|
{
|
2019-05-17 00:36:36 +02:00
|
|
|
$this->expectExceptionMessage('InvalidScalarArgument');
|
2021-12-03 20:29:06 +01:00
|
|
|
$this->expectException(CodeException::class);
|
2019-03-01 14:57:10 +01:00
|
|
|
require_once __DIR__ . '/Plugin/MethodPlugin.php';
|
|
|
|
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-03-01 14:57:10 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-03-01 14:57:10 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2019-05-10 00:58:30 +02:00
|
|
|
<pluginClass class="Psalm\\Test\\Config\\Plugin\\MethodPlugin" />
|
2019-03-01 14:57:10 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
namespace Ns;
|
|
|
|
|
2020-09-01 00:56:21 +02:00
|
|
|
class Foo {
|
|
|
|
public function __call(string $method_name, array $args) {}
|
|
|
|
}
|
2019-03-01 14:57:10 +01:00
|
|
|
|
|
|
|
$foo = new Foo();
|
2020-09-01 00:56:21 +02:00
|
|
|
echo strlen($foo->magicMethod(5));'
|
2019-03-01 14:57:10 +01:00
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testFunctionProviderHooksInvalidArg(): void
|
2019-03-01 14:57:10 +01:00
|
|
|
{
|
2019-05-17 00:36:36 +02:00
|
|
|
$this->expectExceptionMessage('InvalidScalarArgument');
|
2021-12-03 20:29:06 +01:00
|
|
|
$this->expectException(CodeException::class);
|
2019-03-01 14:57:10 +01:00
|
|
|
require_once __DIR__ . '/Plugin/FunctionPlugin.php';
|
|
|
|
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-03-01 14:57:10 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-03-01 14:57:10 +01:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2019-05-10 00:58:30 +02:00
|
|
|
<pluginClass class="Psalm\\Test\\Config\\Plugin\\FunctionPlugin" />
|
2019-03-01 14:57:10 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
magicFunction(5);'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
2019-03-23 17:47:46 +01:00
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testAfterAnalysisHooks(): void
|
2019-03-23 17:47:46 +01:00
|
|
|
{
|
|
|
|
require_once __DIR__ . '/Plugin/AfterAnalysisPlugin.php';
|
|
|
|
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-03-23 17:47:46 +01:00
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-03-23 17:47:46 +01:00
|
|
|
<projectFiles>
|
2019-05-10 00:23:14 +02:00
|
|
|
<directory name="tests/fixtures/DummyProject" />
|
2019-03-23 17:47:46 +01:00
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
2019-05-10 00:58:30 +02:00
|
|
|
<pluginClass class="Psalm\\Test\\Config\\Plugin\\AfterAnalysisPlugin" />
|
2019-03-23 17:47:46 +01:00
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
2019-06-09 18:37:28 +02:00
|
|
|
$this->assertNotNull($this->project_analyzer->stdout_report_options);
|
|
|
|
|
2021-12-03 20:11:20 +01:00
|
|
|
$this->project_analyzer->stdout_report_options->format = Report::TYPE_JSON;
|
2019-03-23 17:47:46 +01:00
|
|
|
|
2019-05-10 00:23:14 +02:00
|
|
|
$this->project_analyzer->check('tests/fixtures/DummyProject', true);
|
2020-07-20 10:52:01 +02:00
|
|
|
ob_start();
|
2021-12-03 20:11:20 +01:00
|
|
|
IssueBuffer::finish($this->project_analyzer, true, microtime(true));
|
2020-07-20 10:52:01 +02:00
|
|
|
ob_end_clean();
|
2019-03-23 17:47:46 +01:00
|
|
|
}
|
2019-05-03 16:27:09 +02:00
|
|
|
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testPluginFilenameCanBeAbsolute(): void
|
2019-05-03 16:27:09 +02:00
|
|
|
{
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-05-03 16:27:09 +02:00
|
|
|
sprintf(
|
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-05-03 16:27:09 +02:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
|
|
|
<plugin filename="%s/examples/plugins/StringChecker.php" />
|
|
|
|
</plugins>
|
|
|
|
</psalm>',
|
2019-07-05 22:24:00 +02:00
|
|
|
__DIR__ . '/../..'
|
2019-05-03 16:27:09 +02:00
|
|
|
)
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
}
|
|
|
|
|
2021-12-05 18:51:26 +01:00
|
|
|
public function testPluginInvalidAbsoluteFilenameThrowsException(): void
|
2019-05-03 16:27:09 +02:00
|
|
|
{
|
2021-12-03 21:40:18 +01:00
|
|
|
$this->expectException(InvalidArgumentException::class);
|
2019-05-17 00:36:36 +02:00
|
|
|
$this->expectExceptionMessage('does-not-exist/plugins/StringChecker.php');
|
|
|
|
|
2019-05-03 16:27:09 +02:00
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
2019-05-10 00:58:30 +02:00
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
2019-05-03 16:27:09 +02:00
|
|
|
sprintf(
|
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
>
|
2019-05-03 16:27:09 +02:00
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
|
|
|
<plugin filename="%s/does-not-exist/plugins/StringChecker.php" />
|
|
|
|
</plugins>
|
|
|
|
</psalm>',
|
2019-07-05 22:24:00 +02:00
|
|
|
__DIR__ . '/..'
|
2019-05-03 16:27:09 +02:00
|
|
|
)
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
}
|
2020-02-13 13:04:02 +01:00
|
|
|
|
|
|
|
public function testAfterEveryFunctionPluginIsCalledInAllCases(): void
|
|
|
|
{
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
|
|
|
'<?xml version="1.0"?>
|
2020-03-23 18:24:36 +01:00
|
|
|
<psalm
|
|
|
|
errorLevel="1"
|
|
|
|
></psalm>'
|
2020-02-13 13:04:02 +01:00
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2021-12-03 21:40:18 +01:00
|
|
|
$mock = $this->getMockBuilder(stdClass::class)->setMethods(['check'])->getMock();
|
2020-06-25 19:05:34 +02:00
|
|
|
$mock->expects($this->exactly(4))
|
2020-02-13 13:04:02 +01:00
|
|
|
->method('check')
|
|
|
|
->withConsecutive(
|
2020-06-25 19:05:34 +02:00
|
|
|
[$this->equalTo('b')],
|
2020-02-13 13:04:02 +01:00
|
|
|
[$this->equalTo('array_map')],
|
|
|
|
[$this->equalTo('fopen')],
|
|
|
|
[$this->equalTo('a')]
|
|
|
|
);
|
|
|
|
$plugin = new class($mock) implements AfterEveryFunctionCallAnalysisInterface {
|
|
|
|
/** @var MockObject */
|
|
|
|
private static $m;
|
|
|
|
|
|
|
|
public function __construct(MockObject $m)
|
|
|
|
{
|
|
|
|
self::$m = $m;
|
|
|
|
}
|
|
|
|
|
2021-01-06 15:05:53 +01:00
|
|
|
public static function afterEveryFunctionCallAnalysis(AfterEveryFunctionCallAnalysisEvent $event): void
|
|
|
|
{
|
|
|
|
$function_id = $event->getFunctionId();
|
2020-02-13 13:04:02 +01:00
|
|
|
/** @psalm-suppress UndefinedInterfaceMethod */
|
|
|
|
self::$m->check($function_id);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
2021-01-06 15:05:53 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->eventDispatcher->after_every_function_checks[] = get_class($plugin);
|
2020-02-13 13:04:02 +01:00
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php
|
|
|
|
|
|
|
|
function a(): void {}
|
|
|
|
function b(int $e): int { return $e; }
|
|
|
|
|
|
|
|
array_map("b", [1,3,3]);
|
|
|
|
fopen("/tmp/foo.dat", "r");
|
|
|
|
a();
|
|
|
|
'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
|
|
|
}
|
2021-03-20 03:41:41 +01:00
|
|
|
|
|
|
|
public function testRemoveTaints(): void
|
|
|
|
{
|
|
|
|
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
|
|
|
|
TestConfig::loadFromXML(
|
|
|
|
dirname(__DIR__, 2) . DIRECTORY_SEPARATOR,
|
|
|
|
'<?xml version="1.0"?>
|
|
|
|
<psalm
|
|
|
|
errorLevel="6"
|
|
|
|
runTaintAnalysis="true"
|
|
|
|
>
|
|
|
|
<projectFiles>
|
|
|
|
<directory name="src" />
|
|
|
|
</projectFiles>
|
|
|
|
<plugins>
|
|
|
|
<plugin filename="examples/plugins/SafeArrayKeyChecker.php" />
|
|
|
|
</plugins>
|
|
|
|
</psalm>'
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->getCodebase()->config->initializePlugins($this->project_analyzer);
|
|
|
|
|
|
|
|
$file_path = getcwd() . '/src/somefile.php';
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php // --taint-analysis
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @psalm-taint-sink html $build
|
|
|
|
*/
|
|
|
|
function output(array $build) {}
|
|
|
|
|
|
|
|
$build = [
|
|
|
|
"nested" => [
|
|
|
|
"safe_key" => $_GET["input"],
|
|
|
|
],
|
|
|
|
];
|
|
|
|
output($build);'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->trackTaintedInputs();
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
2021-03-20 20:42:24 +01:00
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
$file_path,
|
|
|
|
'<?php // --taint-analysis
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @psalm-taint-sink html $build
|
|
|
|
*/
|
|
|
|
function output(array $build) {}
|
|
|
|
|
|
|
|
$build = [
|
|
|
|
"nested" => [
|
|
|
|
"safe_key" => $_GET["input"],
|
|
|
|
"a" => $_GET["input"],
|
|
|
|
],
|
|
|
|
];
|
|
|
|
output($build);'
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->project_analyzer->trackTaintedInputs();
|
|
|
|
|
2021-12-03 20:29:06 +01:00
|
|
|
$this->expectException(CodeException::class);
|
2021-03-20 20:42:24 +01:00
|
|
|
$this->expectExceptionMessageRegExp('/TaintedHtml/');
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, new Context());
|
2021-03-20 03:41:41 +01:00
|
|
|
}
|
2018-10-29 16:41:02 +01:00
|
|
|
}
|