1
0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
psalm/tests/ArrayAssignmentTest.php

1130 lines
37 KiB
PHP
Raw Normal View History

2016-09-12 06:02:50 +02:00
<?php
namespace Psalm\Tests;
2016-11-02 07:29:00 +01:00
use Psalm\Context;
2016-09-12 06:02:50 +02:00
class ArrayAssignmentTest extends TestCase
2016-09-12 06:02:50 +02:00
{
2018-11-06 03:57:36 +01:00
use Traits\InvalidCodeAnalysisTestTrait;
use Traits\ValidCodeAnalysisTestTrait;
2016-09-22 18:26:24 +02:00
2017-01-13 20:07:23 +01:00
/**
* @return void
*/
2016-09-22 18:26:24 +02:00
public function testConditionalAssignment()
{
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
$this->addFile(
2016-09-22 18:26:24 +02:00
'somefile.php',
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
'<?php
2016-09-22 18:26:24 +02:00
if ($b) {
$foo["a"] = "hello";
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
}'
2016-09-22 18:26:24 +02:00
);
2016-11-02 07:29:00 +01:00
$context = new Context();
2016-10-15 19:10:05 +02:00
$context->vars_in_scope['$b'] = \Psalm\Type::getBool();
$context->vars_in_scope['$foo'] = \Psalm\Type::getArray();
$this->analyzeFile('somefile.php', $context);
2016-10-15 19:10:05 +02:00
$this->assertFalse(isset($context->vars_in_scope['$foo[\'a\']']));
2016-09-22 19:45:47 +02:00
}
/**
* @return array
*/
2018-11-06 03:57:36 +01:00
public function providerValidCodeParse()
{
return [
'genericArrayCreationWithSingleIntValue' => [
'<?php
$out = [];
$out[] = 4;',
'assertions' => [
'$out' => 'non-empty-array<int, int>',
],
],
'genericArrayCreationWithInt' => [
'<?php
$out = [];
2017-06-29 16:22:49 +02:00
foreach ([1, 2, 3, 4, 5] as $value) {
$out[] = 4;
}',
'assertions' => [
'$out' => 'non-empty-array<int, int>',
2017-05-27 02:05:57 +02:00
],
],
'generic2dArrayCreation' => [
'<?php
$out = [];
2017-06-29 16:22:49 +02:00
foreach ([1, 2, 3, 4, 5] as $value) {
$out[] = [4];
}',
'assertions' => [
'$out' => 'non-empty-array<int, array{0:int}>',
2017-05-27 02:05:57 +02:00
],
],
'generic2dArrayCreationAddedInIf' => [
'<?php
$out = [];
2017-06-29 16:22:49 +02:00
$bits = [];
2017-06-29 16:22:49 +02:00
foreach ([1, 2, 3, 4, 5] as $value) {
if (rand(0,100) > 50) {
$out[] = $bits;
$bits = [];
}
2017-06-29 16:22:49 +02:00
$bits[] = 4;
2016-10-15 19:11:08 +02:00
}
2017-06-29 16:22:49 +02:00
$out[] = $bits;',
'assertions' => [
'$out' => 'non-empty-array<int, non-empty-array<int, int>>',
2017-05-27 02:05:57 +02:00
],
],
'genericArrayCreationWithObjectAddedInIf' => [
'<?php
class B {}
2017-06-29 16:22:49 +02:00
$out = [];
2017-06-29 16:22:49 +02:00
if (rand(0,10) === 10) {
$out[] = new B();
}',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$out' => 'array<int, B>',
2017-05-27 02:05:57 +02:00
],
],
'genericArrayCreationWithElementAddedInSwitch' => [
'<?php
$out = [];
2017-06-29 16:22:49 +02:00
switch (rand(0,10)) {
case 5:
$out[] = 4;
break;
2017-06-29 16:22:49 +02:00
case 6:
// do nothing
}',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$out' => 'array<int, int>',
2017-05-27 02:05:57 +02:00
],
],
'genericArrayCreationWithElementsAddedInSwitch' => [
'<?php
$out = [];
2017-06-29 16:22:49 +02:00
switch (rand(0,10)) {
case 5:
$out[] = 4;
break;
2017-06-29 16:22:49 +02:00
case 6:
$out[] = "hello";
break;
}',
'assertions' => [
'$out' => 'array<int, string|int>',
2017-05-27 02:05:57 +02:00
],
],
'genericArrayCreationWithElementsAddedInSwitchWithNothing' => [
'<?php
$out = [];
2017-06-29 16:22:49 +02:00
switch (rand(0,10)) {
case 5:
$out[] = 4;
break;
2017-06-29 16:22:49 +02:00
case 6:
$out[] = "hello";
break;
2017-06-29 16:22:49 +02:00
case 7:
// do nothing
}',
'assertions' => [
'$out' => 'array<int, string|int>',
2017-05-27 02:05:57 +02:00
],
],
'implicitIntArrayCreation' => [
'<?php
$foo = [];
$foo[] = "hello";',
'assertions' => [
'$foo' => 'non-empty-array<int, string>',
2017-05-27 02:05:57 +02:00
],
],
'implicit2dIntArrayCreation' => [
'<?php
$foo = [];
$foo[][] = "hello";',
'assertions' => [
'$foo' => 'non-empty-array<int, array<int, string>>',
2017-05-27 02:05:57 +02:00
],
],
'implicit3dIntArrayCreation' => [
'<?php
$foo = [];
$foo[][][] = "hello";',
'assertions' => [
'$foo' => 'non-empty-array<int, array<int, array<int, string>>>',
2017-05-27 02:05:57 +02:00
],
],
'implicit4dIntArrayCreation' => [
'<?php
$foo = [];
$foo[][][][] = "hello";',
'assertions' => [
'$foo' => 'non-empty-array<int, array<int, array<int, array<int, string>>>>',
2017-05-27 02:05:57 +02:00
],
],
'implicitIndexedIntArrayCreation' => [
'<?php
$foo = [];
$foo[0] = "hello";
$foo[1] = "hello";
$foo[2] = "hello";
2017-06-29 16:22:49 +02:00
$bar = [0, 1, 2];
2017-06-29 16:22:49 +02:00
$bat = [];
2017-06-29 16:22:49 +02:00
foreach ($foo as $i => $text) {
$bat[$text] = $bar[$i];
}',
'assertions' => [
'$foo' => 'array{0:string, 1:string, 2:string}',
'$bar' => 'array{0:int, 1:int, 2:int}',
2017-06-29 16:22:49 +02:00
'$bat' => 'array<string, int>',
2017-05-27 02:05:57 +02:00
],
],
'implicitStringArrayCreation' => [
'<?php
$foo = [];
$foo["bar"] = "hello";',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{bar:string}',
'$foo[\'bar\']' => 'string',
2017-05-27 02:05:57 +02:00
],
],
'implicit2dStringArrayCreation' => [
'<?php
$foo = [];
$foo["bar"]["baz"] = "hello";',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{bar:array{baz:string}}',
'$foo[\'bar\'][\'baz\']' => 'string',
2017-05-27 02:05:57 +02:00
],
],
'implicit3dStringArrayCreation' => [
'<?php
$foo = [];
$foo["bar"]["baz"]["bat"] = "hello";',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{bar:array{baz:array{bat:string}}}',
'$foo[\'bar\'][\'baz\'][\'bat\']' => 'string',
2017-05-27 02:05:57 +02:00
],
],
'implicit4dStringArrayCreation' => [
'<?php
$foo = [];
$foo["bar"]["baz"]["bat"]["bap"] = "hello";',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{bar:array{baz:array{bat:array{bap:string}}}}',
'$foo[\'bar\'][\'baz\'][\'bat\'][\'bap\']' => 'string',
2017-05-27 02:05:57 +02:00
],
],
'2Step2dStringArrayCreation' => [
'<?php
$foo = ["bar" => []];
$foo["bar"]["baz"] = "hello";',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{bar:array{baz:string}}',
'$foo[\'bar\'][\'baz\']' => 'string',
2017-05-27 02:05:57 +02:00
],
],
'2StepImplicit3dStringArrayCreation' => [
'<?php
$foo = ["bar" => []];
$foo["bar"]["baz"]["bat"] = "hello";',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{bar:array{baz:array{bat:string}}}',
2017-05-27 02:05:57 +02:00
],
],
'conflictingTypesWithNoAssignment' => [
'<?php
$foo = [
"bar" => ["a" => "b"],
"baz" => [1]
];',
'assertions' => [
'$foo' => 'array{bar:array{a:string}, baz:array{0:int}}',
2017-05-27 02:05:57 +02:00
],
],
'implicitObjectLikeCreation' => [
'<?php
$foo = [
"bar" => 1,
];
$foo["baz"] = "a";',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{bar:int, baz:string}',
2017-05-27 02:05:57 +02:00
],
],
'conflictingTypesWithAssignment' => [
'<?php
$foo = [
"bar" => ["a" => "b"],
"baz" => [1]
];
$foo["bar"]["bam"]["baz"] = "hello";',
'assertions' => [
'$foo' => 'array{bar:array{a:string, bam:array{baz:string}}, baz:array{0:int}}',
2017-05-27 02:05:57 +02:00
],
],
'conflictingTypesWithAssignment2' => [
'<?php
$foo = [];
$foo["a"] = "hello";
$foo["b"][] = "goodbye";
$bar = $foo["a"];',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{a:string, b:array<int, string>}',
'$foo[\'a\']' => 'string',
'$foo[\'b\']' => 'array<int, string>',
'$bar' => 'string',
2017-05-27 02:05:57 +02:00
],
],
'conflictingTypesWithAssignment3' => [
'<?php
$foo = [];
$foo["a"] = "hello";
$foo["b"]["c"]["d"] = "goodbye";',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{a:string, b:array{c:array{d:string}}}',
2017-05-27 02:05:57 +02:00
],
],
'nestedObjectLikeAssignment' => [
'<?php
$foo = [];
$foo["a"]["b"] = "hello";
$foo["a"]["c"] = 1;',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{a:array{b:string, c:int}}',
2017-05-27 02:05:57 +02:00
],
],
'conditionalObjectLikeAssignment' => [
'<?php
$foo = ["a" => "hello"];
if (rand(0, 10) === 5) {
$foo["b"] = 1;
}
else {
$foo["b"] = 2;
}',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$foo' => 'array{a:string, b:int}',
2017-05-27 02:05:57 +02:00
],
],
'arrayKey' => [
'<?php
$a = ["foo", "bar"];
$b = $a[0];
2017-06-29 16:22:49 +02:00
$c = ["a" => "foo", "b"=> "bar"];
$d = "a";
$e = $c[$d];',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$b' => 'string',
'$e' => 'string',
2017-05-27 02:05:57 +02:00
],
],
'conditionalCheck' => [
'<?php
/**
* @param array{b:string} $a
* @return null|string
*/
function fooFoo($a) {
if ($a["b"]) {
return $a["b"];
}
}',
2017-05-27 02:05:57 +02:00
'assertions' => [],
],
'variableKeyArrayCreate' => [
'<?php
$a = [];
$b = "boop";
$a[$b][] = "bam";
2017-06-29 16:22:49 +02:00
$c = [];
$c[$b][$b][] = "bam";',
'assertions' => [
'$a' => 'non-empty-array<string, array<int, string>>',
'$c' => 'non-empty-array<string, array<string, array<int, string>>>',
2017-05-27 02:05:57 +02:00
],
],
'assignExplicitValueToGeneric' => [
'<?php
/** @var array<string, array<string, string>> */
$a = [];
$a["foo"] = ["bar" => "baz"];',
'assertions' => [
'$a' => 'non-empty-array<string, non-empty-array<string, string>>',
2017-05-27 02:05:57 +02:00
],
],
'additionWithEmpty' => [
'<?php
$a = [];
$a += ["bar"];
2017-06-29 16:22:49 +02:00
$b = [] + ["bar"];',
'assertions' => [
'$a' => 'array{0:string}',
'$b' => 'array{0:string}',
2017-05-27 02:05:57 +02:00
],
],
'additionDifferentType' => [
'<?php
$a = ["bar"];
$a += [1];
2017-06-29 16:22:49 +02:00
$b = ["bar"] + [1];',
'assertions' => [
'$a' => 'array{0:string}',
'$b' => 'array{0:string}',
2017-05-27 02:05:57 +02:00
],
],
'present1dArrayTypeWithVarKeys' => [
'<?php
/** @var array<string, array<int, string>> */
$a = [];
2017-06-29 16:22:49 +02:00
$foo = "foo";
2017-06-29 16:22:49 +02:00
$a[$foo][] = "bat";',
2017-05-27 02:05:57 +02:00
'assertions' => [],
],
'present2dArrayTypeWithVarKeys' => [
'<?php
/** @var array<string, array<string, array<int, string>>> */
$b = [];
2017-06-29 16:22:49 +02:00
$foo = "foo";
$bar = "bar";
2017-06-29 16:22:49 +02:00
$b[$foo][$bar][] = "bat";',
2017-05-27 02:05:57 +02:00
'assertions' => [],
],
'objectLikeWithIntegerKeys' => [
'<?php
/** @var array{0: string, 1: int} **/
$a = ["hello", 5];
$b = $a[0]; // string
$c = $a[1]; // int
list($d, $e) = $a; // $d is string, $e is int',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$b' => 'string',
'$c' => 'int',
'$d' => 'string',
'$e' => 'int',
2017-05-27 02:05:57 +02:00
],
],
'objectLikeArrayAddition' => [
'<?php
$foo = [];
$foo["a"] = 1;
$foo += ["b" => [2, 3]];',
'assertions' => [
'$foo' => 'array{a:int, b:array{0:int, 1:int}}',
],
],
'nestedObjectLikeArrayAddition' => [
'<?php
$foo = [];
$foo["root"]["a"] = 1;
$foo["root"] += ["b" => [2, 3]];',
'assertions' => [
'$foo' => 'array{root:array{a:int, b:array{0:int, 1:int}}}',
],
],
'updateStringIntKey1' => [
'<?php
$a = [];
$a["a"] = 5;
$a[0] = 3;',
'assertions' => [
'$a' => 'array{a:int, 0:int}',
],
],
'updateStringIntKey2' => [
'<?php
$string = "c";
$b = [];
$b[$string] = 5;
$b[0] = 3;',
'assertions' => [
'$b' => 'non-empty-array<string|int, int>',
],
],
'updateStringIntKey3' => [
'<?php
$string = "c";
$c = [];
$c[0] = 3;
$c[$string] = 5;',
'assertions' => [
'$c' => 'non-empty-array<int|string, int>',
],
],
'updateStringIntKey4' => [
'<?php
$int = 5;
$d = [];
$d[$int] = 3;
$d["a"] = 5;',
'assertions' => [
'$d' => 'non-empty-array<int|string, int>',
],
],
'updateStringIntKey5' => [
'<?php
$string = "c";
$int = 5;
$e = [];
$e[$int] = 3;
$e[$string] = 5;',
'assertions' => [
'$e' => 'non-empty-array<string|int, int>',
],
],
'updateStringIntKeyWithIntRootAndNumberOffset' => [
'<?php
$string = "c";
$int = 5;
$a = [];
$a[0]["a"] = 5;
$a[0][0] = 3;',
'assertions' => [
'$a' => 'array{0:array{a:int, 0:int}}',
],
],
'updateStringIntKeyWithIntRoot' => [
'<?php
$string = "c";
$int = 5;
$b = [];
$b[0][$string] = 5;
$b[0][0] = 3;
$c = [];
$c[0][0] = 3;
$c[0][$string] = 5;
$d = [];
$d[0][$int] = 3;
$d[0]["a"] = 5;
$e = [];
$e[0][$int] = 3;
$e[0][$string] = 5;',
'assertions' => [
'$b' => 'array{0:array<string|int, int>}',
'$c' => 'array{0:array<int|string, int>}',
'$d' => 'array{0:array<int|string, int>}',
'$e' => 'array{0:array<string|int, int>}',
],
],
'updateStringIntKeyWithObjectLikeRootAndNumberOffset' => [
'<?php
$string = "c";
$int = 5;
$a = [];
$a["root"]["a"] = 5;
$a["root"][0] = 3;',
'assertions' => [
'$a' => 'array{root:array{a:int, 0:int}}',
],
],
'updateStringIntKeyWithObjectLikeRoot' => [
'<?php
$string = "c";
$int = 5;
$b = [];
$b["root"][$string] = 5;
$b["root"][0] = 3;
$c = [];
$c["root"][0] = 3;
$c["root"][$string] = 5;
$d = [];
$d["root"][$int] = 3;
$d["root"]["a"] = 5;
$e = [];
$e["root"][$int] = 3;
$e["root"][$string] = 5;',
'assertions' => [
'$b' => 'array{root:array<string|int, int>}',
'$c' => 'array{root:array<int|string, int>}',
'$d' => 'array{root:array<int|string, int>}',
'$e' => 'array{root:array<string|int, int>}',
],
],
'mixedArrayAssignmentWithStringKeys' => [
'<?php
function foo(array $a) : array {
$a["b"]["c"] = 5;
echo $a["b"]["d"];
echo $a["a"];
return $a;
}',
'assertions' => [],
'error_levels' => ['MixedArrayAssignment', 'MixedArrayAccess', 'MixedArgument'],
],
'mixedArrayCoercion' => [
'<?php
/** @param int[] $arg */
2018-01-11 21:50:45 +01:00
function expect_int_array($arg): void { }
/** @return array */
function generic_array() { return []; }
expect_int_array(generic_array());
2018-01-11 21:50:45 +01:00
function expect_int(int $arg): void {}
/** @return mixed */
function return_mixed() { return 2; }
expect_int(return_mixed());',
'assertions' => [],
'error_levels' => ['MixedTypeCoercion', 'MixedArgument'],
],
'suppressMixedObjectOffset' => [
'<?php
2018-01-11 21:50:45 +01:00
function getThings(): array {
return [];
}
$arr = [];
foreach (getThings() as $a) {
$arr[$a->id] = $a;
}
echo $arr[0];',
'assertions' => [],
'error_levels' => ['MixedAssignment', 'MixedPropertyFetch', 'MixedArrayOffset', 'MixedArgument'],
],
'changeObjectLikeType' => [
'<?php
$a = ["b" => "c"];
$a["d"] = ["e" => "f"];
$a["b"] = 4;
$a["d"]["e"] = 5;',
'assertions' => [
'$a[\'b\']' => 'int',
'$a[\'d\']' => 'array{e:int}',
'$a[\'d\'][\'e\']' => 'int',
'$a' => 'array{b:int, d:array{e:int}}',
],
],
'changeObjectLikeTypeInIf' => [
'<?php
$a = [];
if (rand(0, 5) > 3) {
$a["b"] = new stdClass;
} else {
$a["b"] = ["e" => "f"];
}
if ($a["b"] instanceof stdClass) {
$a["b"] = [];
}
$a["b"]["e"] = "d";',
'assertions' => [
'$a' => 'array{b:array{e:string}}',
'$a[\'b\']' => 'array{e:string}',
'$a[\'b\'][\'e\']' => 'string',
],
],
2017-11-20 17:49:26 +01:00
'implementsArrayAccess' => [
'<?php
class A implements \ArrayAccess {
/**
* @param string|int $offset
* @param mixed $value
*/
2018-01-11 21:50:45 +01:00
public function offsetSet($offset, $value): void {}
2017-11-20 17:49:26 +01:00
/** @param string|int $offset */
2018-01-11 21:50:45 +01:00
public function offsetExists($offset): bool {
2017-11-20 17:49:26 +01:00
return true;
}
/** @param string|int $offset */
2018-01-11 21:50:45 +01:00
public function offsetUnset($offset): void {}
2017-11-20 17:49:26 +01:00
/**
* @param string $offset
* @return mixed
*/
2017-11-20 17:49:26 +01:00
public function offsetGet($offset) {
return 1;
}
}
$a = new A();
$a["bar"] = "cool";
$a["bar"]->foo();',
'assertions' => [
'$a' => 'A',
],
'error_levels' => ['MixedMethodCall'],
],
'assignToNullDontDie' => [
'<?php
$a = null;
$a[0][] = 1;',
'assertions' => [
'$a' => 'array{0:array<int, int>}',
],
'error_levels' => ['PossiblyNullArrayAssignment'],
],
'stringAssignment' => [
'<?php
$str = "hello";
$str[0] = "i";',
'assertions' => [
'$str' => 'string',
],
],
'ignoreInvalidArrayOffset' => [
'<?php
$a = [
"b" => [],
];
$a["b"]["c"] = 0;
foreach ([1, 2, 3] as $i) {
/**
* @psalm-suppress InvalidArrayOffset
* @psalm-suppress MixedOperand
* @psalm-suppress PossiblyUndefinedArrayOffset
*/
$a["b"]["d"] += $a["b"][$i];
}',
'assertions' => [],
],
'keyedIntOffsetArrayValues' => [
'<?php
$a = ["hello", 5];
$a_values = array_values($a);
$a_keys = array_keys($a);',
'assertions' => [
'$a' => 'array{0:string, 1:int}',
'$a_values' => 'array<int, string|int>',
'$a_keys' => 'array<int, int>',
],
],
'changeIntOffsetKeyValuesWithDirectAssignment' => [
'<?php
$b = ["hello", 5];
$b[0] = 3;',
'assertions' => [
'$b' => 'array{0:int, 1:int}',
],
],
'changeIntOffsetKeyValuesAfterCopy' => [
'<?php
$b = ["hello", 5];
$c = $b;
$c[0] = 3;',
'assertions' => [
'$b' => 'array{0:string, 1:int}',
'$c' => 'array{0:int, 1:int}',
],
],
'mergeIntOffsetValues' => [
'<?php
$d = array_merge(["hello", 5], []);
$e = array_merge(["hello", 5], ["hello again"]);',
'assertions' => [
'$d' => 'array{0:string, 1:int}',
'$e' => 'array{0:string, 1:int, 2:string}',
],
],
'addIntOffsetToEmptyArray' => [
'<?php
$f = [];
$f[0] = "hello";',
'assertions' => [
'$f' => 'array{0:string}',
],
],
2018-01-20 17:48:16 +01:00
'assignArrayOrSetNull' => [
'<?php
$a = [];
if (rand(0, 1)) {
$a[] = 4;
}
if (!$a) {
$a = null;
}',
'assertions' => [
2018-11-09 17:19:44 +01:00
'$a' => 'non-empty-array<int, int>|null',
2018-01-20 17:48:16 +01:00
],
],
'assignArrayOrSetNullInElseIf' => [
'<?php
$a = [];
if (rand(0, 1)) {
$a[] = 4;
}
if ($a) {
} elseif (rand(0, 1)) {
$a = null;
}',
'assertions' => [
'$a' => 'array<int, int>|null',
],
],
'assignArrayOrSetNullInElse' => [
'<?php
$a = [];
if (rand(0, 1)) {
$a[] = 4;
}
if ($a) {
} else {
$a = null;
}',
'assertions' => [
2018-11-09 17:19:44 +01:00
'$a' => 'non-empty-array<int, int>|null',
2018-01-20 17:48:16 +01:00
],
],
'mixedMethodCallArrayAccess' => [
'<?php
function foo(object $obj) : array {
$ret = [];
$ret["a"][$obj->foo()] = 1;
return $ret["a"];
}',
'assertions' => [],
'error_levels' => ['MixedMethodCall', 'MixedArrayOffset'],
],
'mixedAccessNestedKeys' => [
'<?php
function takesString(string $s) : void {}
function updateArray(array $arr) : array {
foreach ($arr as $i => $item) {
$arr[$i]["a"]["b"] = 5;
$arr[$i]["a"]["c"] = takesString($arr[$i]["a"]["c"]);
}
return $arr;
}',
'assertions' => [],
'error_levels' => [
'MixedArrayAccess', 'MixedAssignment', 'MixedArrayOffset', 'MixedArrayAssignment', 'MixedArgument',
],
],
'possiblyUndefinedArrayAccessWithIsset' => [
'<?php
if (rand(0,1)) {
$a = ["a" => 1];
} else {
$a = [2, 3];
}
if (isset($a[0])) {
echo $a[0];
}',
],
'possiblyUndefinedArrayAccessWithArrayKeyExists' => [
'<?php
if (rand(0,1)) {
$a = ["a" => 1];
} else {
$a = [2, 3];
}
if (array_key_exists(0, $a)) {
echo $a[0];
}',
],
'noCrashOnArrayKeyExistsBracket' => [
'<?php
class MyCollection {
/**
* @param int $commenter
* @param int $numToGet
* @return int[]
*/
public function getPosters($commenter, $numToGet=10) {
$posters = array();
$count = 0;
$a = new ArrayObject([[1234]]);
$iter = $a->getIterator();
while ($iter->valid() && $count < $numToGet) {
$value = $iter->current();
if ($value[0] != $commenter) {
if (!array_key_exists($value[0], $posters)) {
$posters[$value[0]] = 1;
$count++;
}
}
$iter->next();
}
return array_keys($posters);
}
}',
'assertions' => [],
'error_levels' => [
'MixedArrayAccess', 'MixedAssignment', 'MixedArrayOffset',
'MixedArgument', 'MixedTypeCoercion',
],
],
'accessArrayAfterSuppressingBugs' => [
'<?php
$a = [];
foreach (["one", "two", "three"] as $key) {
/**
* @psalm-suppress EmptyArrayAccess
* @psalm-suppress InvalidOperand
*/
$a[$key] += 5;
}
$a["four"] = true;
if ($a["one"]) {}',
],
'noDuplicateImplicitIntArrayKey' => [
'<?php
$arr = [1 => 0, 1, 2, 3];
2018-09-17 18:15:45 +02:00
$arr = [1 => "one", 2 => "two", "three"];',
],
'constArrayAssignment' => [
'<?php
const BAR = 2;
$arr = [1 => 2];
$arr[BAR] = [6];
$bar = $arr[BAR][0];',
],
'castToArray' => [
'<?php
$a = (array) (rand(0, 1) ? [1 => "one"] : 0);
$b = (array) null;',
'assertions' => [
'$a' => 'array{1?:string, 0?:int}',
'$b' => 'array<empty, empty>',
],
],
'getOnCoercedArray' => [
'<?php
function getArray() : array {
return rand(0, 1) ? ["attr" => []] : [];
}
$out = getArray();
$out["attr"] = (array) ($out["attr"] ?? []);
$out["attr"]["bar"] = 1;',
'assertions' => [
'$out[\'attr\'][\'bar\']' => 'int'
],
],
'arrayAssignmentOnMixedArray' => [
'<?php
function foo(array $arr) : void {
$arr["a"] = 1;
foreach ($arr["b"] as $b) {}
}',
'assertions' => [],
'error_levels' => ['MixedAssignment'],
],
];
}
/**
* @return array
*/
2018-11-06 03:57:36 +01:00
public function providerInvalidCodeParse()
{
return [
'objectAssignment' => [
'<?php
class A {}
(new A)["b"] = 1;',
2017-05-27 02:05:57 +02:00
'error_message' => 'InvalidArrayAssignment',
],
'invalidArrayAccess' => [
'<?php
$a = 5;
$a[0] = 5;',
2017-05-27 02:05:57 +02:00
'error_message' => 'InvalidArrayAssignment',
],
'possiblyUndefinedArrayAccess' => [
'<?php
if (rand(0,1)) {
$a = ["a" => 1];
} else {
$a = [2, 3];
}
echo $a[0];',
'error_message' => 'PossiblyUndefinedArrayOffset',
],
'mixedStringOffsetAssignment' => [
'<?php
/** @var mixed */
$a = 5;
"hello"[0] = $a;',
'error_message' => 'MixedStringOffsetAssignment',
2017-05-27 02:05:57 +02:00
'error_level' => ['MixedAssignment'],
],
'mixedArrayArgument' => [
'<?php
/** @param array<mixed, int|string> $foo */
2018-01-11 21:50:45 +01:00
function fooFoo(array $foo): void { }
2017-06-29 16:22:49 +02:00
2018-01-11 21:50:45 +01:00
function barBar(array $bar): void {
fooFoo($bar);
}
2017-06-29 16:22:49 +02:00
barBar([1, "2"]);',
'error_message' => 'MixedTypeCoercion',
2017-05-27 02:05:57 +02:00
'error_level' => ['MixedAssignment'],
],
'arrayPropertyAssignment' => [
'<?php
class A {
/** @var string[] */
public $strs = ["a", "b", "c"];
2017-06-29 16:22:49 +02:00
/** @return void */
public function bar() {
$this->strs = [new stdClass()]; // no issue emitted
}
}',
'error_message' => 'InvalidPropertyAssignmentValue',
],
'incrementalArrayPropertyAssignment' => [
'<?php
class A {
/** @var string[] */
public $strs = ["a", "b", "c"];
2017-06-29 16:22:49 +02:00
/** @return void */
public function bar() {
$this->strs[] = new stdClass(); // no issue emitted
}
}',
'error_message' => 'InvalidPropertyAssignmentValue',
2017-05-27 02:05:57 +02:00
],
'possiblyUndefinedArrayAccessWithArrayKeyExistsOnWrongKey' => [
'<?php
if (rand(0,1)) {
$a = ["a" => 1];
} else {
$a = [2, 3];
}
if (array_key_exists("a", $a)) {
echo $a[0];
}',
'error_message' => 'PossiblyUndefinedArrayOffset',
],
'possiblyUndefinedArrayAccessWithArrayKeyExistsOnMissingKey' => [
'<?php
if (rand(0,1)) {
$a = ["a" => 1];
} else {
$a = [2, 3];
}
if (array_key_exists("b", $a)) {
echo $a[0];
}',
'error_message' => 'PossiblyUndefinedArrayOffset',
],
'duplicateStringArrayKey' => [
'<?php
$arr = [
"a" => 1,
"b" => 2,
"c" => 3,
"c" => 4,
];',
'error_message' => 'DuplicateArrayKey',
],
'duplicateIntArrayKey' => [
'<?php
$arr = [
0 => 1,
1 => 2,
2 => 3,
2 => 4,
];',
'error_message' => 'DuplicateArrayKey',
],
'duplicateImplicitIntArrayKey' => [
'<?php
$arr = [
1,
2,
3,
2 => 4,
];',
'error_message' => 'DuplicateArrayKey',
],
'mixedArrayAssignment' => [
'<?php
$_GET["foo"][0] = "5";',
'error_message' => 'MixedArrayAssignment',
],
];
}
2016-09-12 06:02:50 +02:00
}