1
0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
psalm/tests/PropertyTypeTest.php

1616 lines
52 KiB
PHP
Raw Normal View History

2016-07-12 06:53:36 +02:00
<?php
2016-07-26 00:37:44 +02:00
namespace Psalm\Tests;
2016-07-12 06:53:36 +02:00
2016-11-02 07:29:00 +01:00
use Psalm\Config;
use Psalm\Context;
2016-07-12 06:53:36 +02:00
class PropertyTypeTest extends TestCase
2016-07-12 06:53:36 +02:00
{
use Traits\FileCheckerInvalidCodeParseTestTrait;
use Traits\FileCheckerValidCodeParseTestTrait;
/**
* @expectedException \Psalm\Exception\CodeException
* @expectedExceptionMessage NullableReturnStatement
2017-05-27 02:16:18 +02:00
*
* @return void
*/
public function testForgetPropertyAssignments()
{
Config::getInstance()->remember_property_assignments_after_call = false;
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
$this->addFile(
'somefile.php',
'<?php
class X {
/** @var ?int **/
private $x;
public function getX(): int {
$this->x = 5;
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
$this->modifyX();
return $this->x;
}
private function modifyX(): void {
$this->x = null;
}
}'
);
$this->analyzeFile('somefile.php', new Context());
}
/**
* @return void
*/
public function testForgetPropertyAssignmentsInBranchWithThrow()
{
Config::getInstance()->remember_property_assignments_after_call = false;
$this->addFile(
'somefile.php',
'<?php
class X {
/** @var ?int **/
private $x;
public function getX(): int {
$this->x = 5;
if (rand(0, 1)) {
$this->modifyX();
throw new \Exception("bad");
}
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
return $this->x;
}
private function modifyX(): void {
$this->x = null;
}
}'
);
$this->analyzeFile('somefile.php', new Context());
}
/**
* @return void
*/
public function testRemovePropertyAfterReassignment()
{
Config::getInstance()->remember_property_assignments_after_call = false;
$this->addFile(
'somefile.php',
'<?php
class A {
/** @var A|null */
public $parent;
public function __construct() {
$this->parent = rand(0, 1) ? new A : null;
}
}
$a = new A();
if ($a->parent === null) {
throw new \Exception("bad");
}
$a = $a->parent;'
);
$context = new Context();
$this->analyzeFile('somefile.php', $context);
$this->assertSame('A', (string) $context->vars_in_scope['$a']);
$this->assertFalse(isset($context->vars_in_scope['$a->parent']));
}
/**
* @return void
*/
public function testRemoveClauseAfterReassignment()
{
Config::getInstance()->remember_property_assignments_after_call = false;
$this->addFile(
'somefile.php',
'<?php
class Test {
/** @var ?bool */
private $foo;
public function run(): void {
$this->foo = false;
$this->bar();
if ($this->foo === true) {}
}
private function bar(): void {
if (mt_rand(0, 1)) {
$this->foo = true;
}
}
}'
);
$context = new Context();
$this->analyzeFile('somefile.php', $context);
}
/**
* @return array
*/
public function providerFileCheckerValidCodeParse()
{
return [
'newVarInIf' => [
'<?php
class A {
/**
* @var mixed
*/
public $foo;
/** @return void */
public function barBar()
{
if (rand(0,10) === 5) {
$this->foo = [];
}
if (!is_array($this->foo)) {
// do something
}
}
2017-05-27 02:05:57 +02:00
}',
],
'propertyWithoutTypeSuppressingIssue' => [
'<?php
class A {
public $foo;
}
$a = (new A)->foo;',
'assertions' => [],
'error_levels' => [
'MissingPropertyType',
2017-05-27 02:05:57 +02:00
'MixedAssignment',
],
],
'propertyWithoutTypeSuppressingIssueAndAssertingNull' => [
'<?php
class A {
/** @return void */
function foo() {
$boop = $this->foo === null && rand(0,1);
echo $this->foo->baz;
}
}',
'assertions' => [],
'error_levels' => [
'UndefinedThisPropertyFetch',
'MixedAssignment',
2018-05-09 21:49:22 +02:00
'MixedArgument',
'MixedMethodCall',
2017-05-27 02:05:57 +02:00
'MixedPropertyFetch',
],
],
'sharedPropertyInIf' => [
'<?php
class A {
/** @var int */
public $foo = 0;
}
class B {
/** @var string */
public $foo = "";
}
2018-01-11 21:50:45 +01:00
$a = rand(0, 10) ? new A(): (rand(0, 10) ? new B(): null);
$b = null;
if ($a instanceof A || $a instanceof B) {
$b = $a->foo;
}',
'assertions' => [
'$b' => 'null|int|string',
2017-05-27 02:05:57 +02:00
],
],
'sharedPropertyInElseIf' => [
'<?php
class A {
/** @var int */
public $foo = 0;
}
class B {
/** @var string */
public $foo = "";
}
2018-01-11 21:50:45 +01:00
$a = rand(0, 10) ? new A(): new B();
if (rand(0, 1)) {
$a = null;
}
$b = null;
if (rand(0, 10) === 4) {
// do nothing
}
elseif ($a instanceof A || $a instanceof B) {
$b = $a->foo;
}',
'assertions' => [
'$b' => 'null|int|string',
2017-05-27 02:05:57 +02:00
],
],
'nullablePropertyCheck' => [
'<?php
class A {
/** @var string */
public $aa = "";
}
class B {
/** @var A|null */
public $bb;
}
2018-01-11 21:50:45 +01:00
$b = rand(0, 10) ? new A(): new B();
if ($b instanceof B && isset($b->bb) && $b->bb->aa === "aa") {
echo $b->bb->aa;
2017-05-27 02:05:57 +02:00
}',
],
'nullablePropertyAfterGuard' => [
'<?php
class A {
/** @var string|null */
public $aa;
}
$a = new A();
if (!$a->aa) {
$a->aa = "hello";
}
2017-05-27 02:05:57 +02:00
echo substr($a->aa, 1);',
],
'nullableStaticPropertyWithIfCheck' => [
'<?php
class A {
/** @var A|null */
public static $fooFoo;
2018-01-11 21:50:45 +01:00
public static function getFoo(): A {
if (!self::$fooFoo) {
self::$fooFoo = new A();
}
return self::$fooFoo;
}
2017-05-27 02:05:57 +02:00
}',
],
'reflectionProperties' => [
'<?php
class Foo {
}
$a = new \ReflectionMethod("Foo", "__construct");
2017-05-27 02:05:57 +02:00
echo $a->name . " - " . $a->class;',
],
'grandparentReflectedProperties' => [
'<?php
$a = new DOMElement("foo");
$owner = $a->ownerDocument;',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$owner' => 'DOMDocument',
2017-05-27 02:05:57 +02:00
],
],
'goodArrayProperties' => [
'<?php
interface I1 {}
class A1 implements I1{}
class B1 implements I1 {}
class C1 {
/** @var array<I1> */
public $is = [];
}
$c = new C1;
$c->is = [new A1];
$c->is = [new A1, new A1];
$c->is = [new A1, new B1];',
'assertions' => [],
2017-05-27 02:05:57 +02:00
'error_levels' => ['MixedAssignment'],
],
'issetPropertyDoesNotExist' => [
'<?php
class A {
}
$a = new A();
if (isset($a->bar)) {
2017-05-27 02:05:57 +02:00
}',
],
'notSetInConstructorButHasDefault' => [
'<?php
class A {
/** @var int */
public $a = 0;
public function __construct() { }
2017-05-27 02:05:57 +02:00
}',
],
'propertySetInPrivateMethod' => [
'<?php
class A {
/** @var int */
public $a;
public function __construct() {
$this->foo();
}
2018-01-11 21:50:45 +01:00
private function foo(): void {
$this->a = 5;
}
2017-05-27 02:05:57 +02:00
}',
],
'definedInTraitSetInConstructor' => [
'<?php
trait A {
/** @var string **/
public $a;
}
class B {
use A;
public function __construct() {
$this->a = "hello";
}
2017-05-27 02:05:57 +02:00
}',
],
'propertySetInNestedPrivateMethod' => [
'<?php
class A {
/** @var int */
public $a;
public function __construct() {
$this->foo();
}
2018-01-11 21:50:45 +01:00
private function foo(): void {
$this->bar();
}
2018-01-11 21:50:45 +01:00
private function bar(): void {
$this->a = 5;
}
2017-05-27 02:05:57 +02:00
}',
],
'propertyArrayIssetAssertion' => [
'<?php
2018-01-11 21:50:45 +01:00
function bar(string $s): void { }
class A {
/** @var array<string, string> */
public $a = [];
2018-01-11 21:50:45 +01:00
private function foo(): void {
if (isset($this->a["hello"])) {
bar($this->a["hello"]);
}
}
2017-05-27 02:05:57 +02:00
}',
],
'propertyArrayIssetAssertionWithVariableOffset' => [
'<?php
2018-01-11 21:50:45 +01:00
function bar(string $s): void { }
class A {
/** @var array<string, string> */
public $a = [];
2018-01-11 21:50:45 +01:00
private function foo(): void {
$b = "hello";
if (!isset($this->a[$b])) {
return;
}
bar($this->a[$b]);
}
2017-05-27 02:05:57 +02:00
}',
],
'staticPropertyArrayIssetAssertionWithVariableOffset' => [
'<?php
2018-01-11 21:50:45 +01:00
function bar(string $s): void { }
class A {
/** @var array<string, string> */
public static $a = [];
}
2018-01-11 21:50:45 +01:00
function foo(): void {
$b = "hello";
if (!isset(A::$a[$b])) {
return;
}
bar(A::$a[$b]);
2017-05-27 02:05:57 +02:00
}',
],
'staticPropertyArrayIssetAssertionWithVariableOffsetAndElse' => [
'<?php
2018-01-11 21:50:45 +01:00
function bar(string $s): void { }
class A {
/** @var array<string, string> */
public static $a = [];
}
2018-01-11 21:50:45 +01:00
function foo(): void {
$b = "hello";
if (!isset(A::$a[$b])) {
$g = "bar";
} else {
bar(A::$a[$b]);
$g = "foo";
}
bar($g);
}',
],
'traitConstructor' => [
'<?php
trait T {
/** @var string **/
public $foo;
public function __construct() {
$this->foo = "hello";
}
}
class A {
use T;
}',
],
'abstractClassWithNoConstructor' => [
'<?php
abstract class A {
/** @var string */
public $foo;
}',
],
'abstractClassConstructorAndChildConstructor' => [
'<?php
abstract class A {
/** @var string */
public $foo;
public function __construct() {
$this->foo = "";
}
}
class B extends A {
public function __construct() {
parent::__construct();
}
}',
],
2017-07-09 03:19:16 +02:00
'abstractClassConstructorAndImplicitChildConstructor' => [
'<?php
abstract class A {
/** @var string */
public $foo;
2017-07-09 03:19:16 +02:00
public function __construct(int $bar) {
$this->foo = (string)$bar;
}
}
2017-07-09 03:19:16 +02:00
class B extends A {}
class E extends \Exception{}',
],
'notSetInEmptyConstructor' => [
'<?php
/** @psalm-suppress PropertyNotSetInConstructor */
class A {
/** @var int */
public $a;
public function __construct() { }
}',
],
'extendsClassWithPrivateConstructorSet' => [
'<?php
namespace Q;
class Base
{
/**
* @var string
*/
private $aString;
public function __construct()
{
$this->aString = "aa";
echo($this->aString);
}
}
class Descendant extends Base
{
/**
* @var bool
*/
private $aBool;
public function __construct()
{
parent::__construct();
$this->aBool = true;
}
}',
],
'extendsClassWithPrivateAndException' => [
'<?php
abstract class A extends \Exception {
/** @var string **/
private $p;
/** @param string $p **/
final public function __construct($p) {
$this->p = $p;
}
}
final class B extends A {}',
],
'setInAbstractMethod' => [
'<?php
interface I {
2018-01-11 21:50:45 +01:00
public function foo(): void;
}
abstract class A implements I {
/** @var string */
public $bar;
public function __construct() {
$this->foo();
}
}
class B extends A {
2018-01-11 21:50:45 +01:00
public function foo(): void
{
$this->bar = "hello";
}
}',
'assertions' => [],
'error_levels' => [
'PropertyNotSetInConstructor' => Config::REPORT_INFO,
],
],
'setInFinalMethod' => [
'<?php
class C
{
/**
* @var string
*/
private $a;
/**
* @var string
*/
private $b;
/**
* @param string[] $opts
* @psalm-param array{a:string,b:string} $opts
*/
public function __construct(array $opts)
{
$this->setOptions($opts);
}
/**
* @param string[] $opts
* @psalm-param array{a:string,b:string} $opts
*/
final public function setOptions(array $opts): void
{
$this->a = $opts["a"] ?? "defaultA";
$this->b = $opts["b"] ?? "defaultB";
}
}',
],
'setInFinalClass' => [
'<?php
final class C
{
/**
* @var string
*/
private $a;
/**
* @var string
*/
private $b;
/**
* @param string[] $opts
* @psalm-param array{a:string,b:string} $opts
*/
public function __construct(array $opts)
{
$this->setOptions($opts);
}
/**
* @param string[] $opts
* @psalm-param array{a:string,b:string} $opts
*/
public function setOptions(array $opts): void
{
$this->a = $opts["a"] ?? "defaultA";
$this->b = $opts["b"] ?? "defaultB";
}
}',
],
2017-12-14 04:29:38 +01:00
'selfPropertyType' => [
'<?php
class Node
{
/** @var self|null */
public $next;
public function __construct() {
if (rand(0, 1)) {
$this->next = new Node();
}
}
}
$node = new Node();
$next = $node->next',
'assertions' => [
'$next' => 'Node|null',
],
],
'perPropertySuppress' => [
'<?php
class A {
/**
* @var int
* @psalm-suppress PropertyNotSetInConstructor
*/
public $a;
public function __construct() { }
}',
],
'analyzePropertyMappedClass' => [
'<?php
namespace PhpParser\Node\Stmt;
use PhpParser\Node;
class Finally_ extends Node\Stmt
{
/** @var Node[] Statements */
public $stmts;
/**
* Constructs a finally node.
*
* @param Node[] $stmts Statements
* @param array $attributes Additional attributes
*/
public function __construct(array $stmts = array(), array $attributes = array()) {
parent::__construct($attributes);
$this->stmts = $stmts;
}
public function getSubNodeNames() : array {
return array("stmts");
}
public function getType() : string {
return "Stmt_Finally";
}
}',
'assertions' => [],
'error_levels' => [
'MixedTypeCoercion',
'MissingReturnType',
],
],
'privatePropertyAccessible' => [
'<?php
class A {
/** @var string */
private $foo;
public function __construct(string $foo) {
$this->foo = $foo;
}
private function bar() : void {}
}
class B extends A {
/** @var string */
private $foo;
public function __construct(string $foo) {
$this->foo = $foo;
parent::__construct($foo);
}
}',
],
'privatePropertyAccessibleDifferentType' => [
'<?php
class A {
/** @var int */
private $foo;
public function __construct(string $foo) {
$this->foo = 5;
}
private function bar() : void {}
}
class B extends A {
/** @var string */
private $foo;
public function __construct(string $foo) {
$this->foo = $foo;
parent::__construct($foo);
}
}',
],
'privatePropertyAccessibleInTwoSubclasses' => [
'<?php
class A {
public function __construct() {}
}
class B extends A {
/**
* @var int
*/
private $prop;
public function __construct()
{
parent::__construct();
$this->prop = 1;
}
}
class C extends A {
/**
* @var int
*/
private $prop;
public function __construct()
{
parent::__construct();
$this->prop = 2;
}
}',
],
'noIssueWhenSuppressingMixedAssignmentForProperty' => [
'<?php
class A {
/** @var string|null */
public $foo;
/** @param mixed $a */
public function barBar($a): void
{
$this->foo = $a;
}
}',
'assertions' => [],
'error_levels' => [
'MixedAssignment',
],
],
'propertyAssignmentToMixed' => [
'<?php
class C {
/** @var string|null */
public $foo;
}
/** @param mixed $a */
function barBar(C $c, $a): void
{
$c->foo = $a;
}',
'assertions' => [],
'error_levels' => [
'MixedAssignment',
],
],
'propertySetInBothIfBranches' => [
'<?php
class Foo
{
/** @var int */
private $status;
public function __construct(int $in)
{
if (rand(0, 1)) {
$this->status = 1;
} else {
$this->status = $in;
}
}
}',
],
'propertySetInPrivateMethodWithIfAndElse' => [
'<?php
class A {
/** @var int */
public $a;
public function __construct() {
if (rand(0, 1)) {
$this->foo();
} else {
$this->bar();
}
}
private function foo(): void {
$this->a = 5;
}
private function bar(): void {
$this->a = 5;
}
}',
],
'allowMixedAssignmetWhenDesired' => [
'<?php
class A {
/**
* @var mixed
*/
private $mixed;
/**
* @param mixed $value
*/
public function setMixed($value): void
{
$this->mixed = $value;
}
}',
],
'suppressUndefinedThisPropertyFetch' => [
'<?php
class A {
public function __construct() {
/** @psalm-suppress UndefinedThisPropertyAssignment */
$this->bar = rand(0, 1) ? "hello" : null;
}
/** @psalm-suppress UndefinedThisPropertyFetch */
public function foo() : void {
if ($this->bar === null && rand(0, 1)) {}
}
}',
],
'suppressUndefinedPropertyFetch' => [
'<?php
class A {
public function __construct() {
/** @psalm-suppress UndefinedThisPropertyAssignment */
$this->bar = rand(0, 1) ? "hello" : null;
}
}
$a = new A();
/** @psalm-suppress UndefinedPropertyFetch */
if ($a->bar === null && rand(0, 1)) {}',
],
'setPropertiesOfSpecialObjects' => [
'<?php
$a = new stdClass();
$a->b = "c";
$d = new SimpleXMLElement("<person><child role=\"son\"></child></person>");
$d->e = "f";',
'assertions' => [
'$a' => 'stdClass',
'$a->b' => 'string',
'$d' => 'SimpleXMLElement',
'$d->e' => 'mixed',
],
],
'allowLessSpecificReturnTypeForOverriddenMethod' => [
'<?php
class A {
public function aa(): ?string {
return "bar";
}
}
class B extends A {
public static function aa(): ?string {
return rand(0, 1) ? "bar" : null;
}
}
class C extends A {
public static function aa(): ?string {
return "bar";
}
}'
],
'allowLessSpecificReturnTypeForInterfaceMethod' => [
'<?php
interface Foo {
public static function foo(): ?string;
}
class Bar implements Foo {
public static function foo(): ?string
{
return "bar";
}
}
class Baz implements Foo {
/**
* @return string $baz
*/
public static function foo(): ?string
{
return "baz";
}
}
class Bax implements Foo {
/**
* @return null|string $baz
*/
public static function foo(): ?string
{
return "bax";
}
}
class Baw implements Foo {
/**
* @return null|string $baz
*/
public static function foo(): ?string
{
/** @var null|string $val */
$val = "baw";
return $val;
}
}',
],
];
}
/**
* @return array
*/
public function providerFileCheckerInvalidCodeParse()
{
return [
'undefinedPropertyAssignment' => [
'<?php
class A {
}
(new A)->foo = "cool";',
2017-05-27 02:05:57 +02:00
'error_message' => 'UndefinedPropertyAssignment',
],
'undefinedPropertyFetch' => [
'<?php
class A {
}
echo (new A)->foo;',
2017-05-27 02:05:57 +02:00
'error_message' => 'UndefinedPropertyFetch',
],
'undefinedThisPropertyAssignment' => [
'<?php
class A {
2018-01-11 21:50:45 +01:00
public function fooFoo(): void {
$this->foo = "cool";
}
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'UndefinedThisPropertyAssignment',
],
'undefinedStaticPropertyAssignment' => [
'<?php
class A {
public static function barBar(): void
{
/** @psalm-suppress UndefinedPropertyFetch */
self::$foo = 5;
}
}',
'error_message' => 'UndefinedPropertyAssignment',
],
'undefinedThisPropertyFetch' => [
'<?php
class A {
2018-01-11 21:50:45 +01:00
public function fooFoo(): void {
echo $this->foo;
}
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'UndefinedThisPropertyFetch',
],
'missingPropertyType' => [
'<?php
class A {
public $foo;
2018-01-11 21:50:45 +01:00
public function assignToFoo(): void {
$this->foo = 5;
}
}',
'error_message' => 'MissingPropertyType - src' . DIRECTORY_SEPARATOR . 'somefile.php:3 - Property A::$foo does not have a ' .
'declared type - consider int|null',
],
'missingPropertyTypeWithConstructorInit' => [
'<?php
class A {
public $foo;
2018-04-21 23:20:21 +02:00
public function __construct() {
$this->foo = 5;
}
}',
'error_message' => 'MissingPropertyType - src' . DIRECTORY_SEPARATOR . 'somefile.php:3 - Property A::$foo does not have a ' .
2017-05-27 02:05:57 +02:00
'declared type - consider int',
],
'missingPropertyTypeWithConstructorInitAndNull' => [
'<?php
class A {
public $foo;
2018-04-21 23:20:21 +02:00
public function __construct() {
$this->foo = 5;
}
2018-01-11 21:50:45 +01:00
public function makeNull(): void {
$this->foo = null;
}
}',
'error_message' => 'MissingPropertyType - src' . DIRECTORY_SEPARATOR . 'somefile.php:3 - Property A::$foo does not have a ' .
'declared type - consider int|null',
],
'missingPropertyTypeWithConstructorInitAndNullDefault' => [
'<?php
class A {
public $foo = null;
2018-04-21 23:20:21 +02:00
public function __construct() {
$this->foo = 5;
}
}',
'error_message' => 'MissingPropertyType - src' . DIRECTORY_SEPARATOR . 'somefile.php:3 - Property A::$foo does not have a ' .
2017-05-27 02:05:57 +02:00
'declared type - consider int|null',
],
'badAssignment' => [
'<?php
class A {
/** @var string */
public $foo;
2018-01-11 21:50:45 +01:00
public function barBar(): void
{
$this->foo = 5;
}
}',
'error_message' => 'InvalidPropertyAssignmentValue',
],
'badStaticAssignment' => [
'<?php
class A {
/** @var string */
public static $foo = "a";
public static function barBar(): void
{
self::$foo = 5;
}
}',
'error_message' => 'InvalidPropertyAssignmentValue',
],
'typeCoercion' => [
'<?php
class A {
/** @var B|null */
public $foo;
public function barBar(A $a): void
{
$this->foo = $a;
}
}
class B extends A {}',
'error_message' => 'TypeCoercion',
],
'mixedTypeCoercion' => [
'<?php
class A {
/** @var array<int, A> */
public $foo = [];
/** @param A[] $arr */
public function barBar(array $arr): void
{
$this->foo = $arr;
}
}',
'error_message' => 'MixedTypeCoercion',
],
'staticTypeCoercion' => [
'<?php
class A {
/** @var B|null */
public static $foo;
public static function barBar(A $a): void
{
self::$foo = $a;
}
}
class B extends A {}',
'error_message' => 'TypeCoercion',
],
'staticMixedTypeCoercion' => [
'<?php
class A {
/** @var array<int, A> */
public static $foo = [];
/** @param A[] $arr */
public static function barBar(array $arr): void
{
self::$foo = $arr;
}
}',
'error_message' => 'MixedTypeCoercion',
],
2018-03-21 04:55:26 +01:00
'possiblyBadAssignment' => [
'<?php
class A {
/** @var string */
public $foo;
public function barBar(): void
{
$this->foo = rand(0, 1) ? 5 : "hello";
}
}',
'error_message' => 'PossiblyInvalidPropertyAssignmentValue',
],
'possiblyBadStaticAssignment' => [
'<?php
class A {
/** @var string */
public static $foo = "a";
public function barBar(): void
{
self::$foo = rand(0, 1) ? 5 : "hello";
}
}',
'error_message' => 'PossiblyInvalidPropertyAssignmentValue',
],
'badAssignmentAsWell' => [
'<?php
$a = "hello";
$a->foo = "bar";',
2017-05-27 02:05:57 +02:00
'error_message' => 'InvalidPropertyAssignment',
],
'badFetch' => [
'<?php
$a = "hello";
echo $a->foo;',
2017-05-27 02:05:57 +02:00
'error_message' => 'InvalidPropertyFetch',
],
'possiblyBadFetch' => [
'<?php
$a = rand(0, 5) > 3 ? "hello" : new stdClass;
echo $a->foo;',
'error_message' => 'PossiblyInvalidPropertyFetch',
],
'mixedPropertyFetch' => [
'<?php
class Foo {
/** @var string */
public $foo = "";
}
/** @var mixed */
$a = (new Foo());
echo $a->foo;',
'error_message' => 'MixedPropertyFetch',
'error_levels' => [
'MissingPropertyType',
2017-05-27 02:05:57 +02:00
'MixedAssignment',
],
],
'mixedPropertyAssignment' => [
'<?php
class Foo {
/** @var string */
public $foo = "";
}
/** @var mixed */
$a = (new Foo());
$a->foo = "hello";',
'error_message' => 'MixedPropertyAssignment',
'error_levels' => [
'MissingPropertyType',
2017-05-27 02:05:57 +02:00
'MixedAssignment',
],
],
'possiblyNullablePropertyAssignment' => [
'<?php
class Foo {
/** @var string */
public $foo = "";
}
2018-01-11 21:50:45 +01:00
$a = rand(0, 10) ? new Foo(): null;
$a->foo = "hello";',
2017-05-27 02:05:57 +02:00
'error_message' => 'PossiblyNullPropertyAssignment',
],
'nullablePropertyAssignment' => [
'<?php
$a = null;
$a->foo = "hello";',
2017-05-27 02:05:57 +02:00
'error_message' => 'NullPropertyAssignment',
],
'possiblyNullablePropertyFetch' => [
'<?php
class Foo {
/** @var string */
public $foo = "";
}
2018-01-11 21:50:45 +01:00
$a = rand(0, 10) ? new Foo(): null;
echo $a->foo;',
2017-05-27 02:05:57 +02:00
'error_message' => 'PossiblyNullPropertyFetch',
],
'nullablePropertyFetch' => [
'<?php
$a = null;
echo $a->foo;',
2017-05-27 02:05:57 +02:00
'error_message' => 'NullPropertyFetch',
],
'badArrayProperty' => [
'<?php
class A {}
class B {}
class C {
/** @var array<B> */
public $bb;
}
$c = new C;
$c->bb = [new A, new B];',
'error_message' => 'InvalidPropertyAssignmentValue',
],
'possiblyBadArrayProperty' => [
'<?php
class A {
/** @var int[] */
public $bb = [];
}
class B {
/** @var string[] */
public $bb;
}
$c = rand(0, 1) ? new A : new B;
$c->bb = ["hello", "world"];',
'error_message' => 'PossiblyInvalidPropertyAssignmentValue',
],
'notSetInEmptyConstructor' => [
'<?php
class A {
/** @var int */
public $a;
public function __construct() { }
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'PropertyNotSetInConstructor',
],
'noConstructor' => [
'<?php
class A {
/** @var int */
public $a;
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'MissingConstructor',
],
2017-07-09 03:19:16 +02:00
'abstractClassInheritsNoConstructor' => [
'<?php
abstract class A {
/** @var string */
public $foo;
}
class B extends A {}',
'error_message' => 'MissingConstructor',
],
'abstractClassInheritsPrivateConstructor' => [
'<?php
abstract class A {
/** @var string */
public $foo;
private function __construct() {
$this->foo = "hello";
}
}
class B extends A {}',
'error_message' => 'InaccessibleMethod',
],
'classInheritsPrivateConstructorWithImplementedConstructor' => [
'<?php
abstract class A {
/** @var string */
public $foo;
private function __construct() {
$this->foo = "hello";
}
}
class B extends A {
public function __construct() {}
}',
'error_message' => 'PropertyNotSetInConstructor',
],
'notSetInAllBranchesOfIf' => [
'<?php
class A {
/** @var int */
public $a;
public function __construct() {
if (rand(0, 1)) {
$this->a = 5;
}
}
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'PropertyNotSetInConstructor',
],
'propertySetInProtectedMethod' => [
'<?php
class A {
/** @var int */
public $a;
public function __construct() {
$this->foo();
}
2018-01-11 21:50:45 +01:00
protected function foo(): void {
$this->a = 5;
}
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'PropertyNotSetInConstructor',
],
'definedInTraitNotSetInEmptyConstructor' => [
'<?php
trait A {
/** @var string **/
public $a;
}
class B {
use A;
public function __construct() {
}
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'PropertyNotSetInConstructor',
],
'propertySetInPrivateMethodWithIf' => [
'<?php
class A {
/** @var int */
public $a;
public function __construct() {
if (rand(0, 1)) {
$this->foo();
}
}
2018-01-11 21:50:45 +01:00
private function foo(): void {
$this->a = 5;
}
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'PropertyNotSetInConstructor',
],
'undefinedPropertyClass' => [
'<?php
class A {
/** @var B */
public $foo;
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'UndefinedClass',
],
'abstractClassWithNoConstructorButChild' => [
'<?php
abstract class A {
/** @var string */
public $foo;
}
class B extends A {
public function __construct() {
}
}',
'error_message' => 'PropertyNotSetInConstructor',
],
'badAssignmentToUndefinedVars' => [
'<?php
$x->$y = 4;',
'error_message' => 'UndefinedGlobalVariable',
],
'echoUndefinedPropertyFetch' => [
'<?php
echo $x->$y;',
'error_message' => 'UndefinedGlobalVariable',
],
'toStringPropertyAssignment' => [
'<?php
class A {
/** @var ?string */
public $foo;
}
class B {
public function __toString() {
return "bar";
}
}
$a = new A();
$a->foo = new B;',
'error_message' => 'ImplicitToStringCast',
],
'noInfiniteLoop' => [
'<?php
class A {
/** @var string */
public $foo;
public function __construct() {
$this->doThing();
}
private function doThing(): void {
if (rand(0, 1)) {
$this->doOtherThing();
}
}
private function doOtherThing(): void {
if (rand(0, 1)) {
$this->doThing();
}
}
}',
'error_message' => 'PropertyNotSetInConstructor',
],
2018-01-29 03:43:26 +01:00
'invalidPropertyDefault' => [
'<?php
class A {
/** @var int */
public $a = "hello";
}',
'error_message' => 'InvalidPropertyAssignmentValue',
],
'prohibitMixedAssignmentNormally' => [
'<?php
class A {
/**
* @var string
*/
private $mixed;
/**
* @param mixed $value
*/
public function setMixed($value): void
{
$this->mixed = $value;
}
}',
'error_message' => 'MixedAssignment',
],
'assertPropertyTypeHasImpossibleType' => [
'<?php
class A {
/** @var ?B */
public $foo;
}
class B {}
$a = new A();
if (is_string($a->foo)) {}',
'error_message' => 'DocblockTypeContradiction',
],
'impossiblePropertyCheck' => [
'<?php
class Bar {}
class Foo {
/** @var Bar */
private $bar;
public function __construct() {
$this->bar = new Bar();
}
public function getBar(): void {
if (!$this->bar) {}
}
}',
'error_message' => 'DocblockTypeContradiction',
],
];
}
2016-07-12 06:53:36 +02:00
}