2016-12-28 21:52:44 +01:00
|
|
|
|
<?php
|
|
|
|
|
namespace Psalm\Checker\Statements\Expression;
|
|
|
|
|
|
|
|
|
|
use PhpParser;
|
|
|
|
|
use Psalm\Checker\ClassLikeChecker;
|
2018-05-28 21:07:42 +02:00
|
|
|
|
use Psalm\Checker\StatementsChecker;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
use Psalm\Checker\Statements\ExpressionChecker;
|
|
|
|
|
use Psalm\Checker\TypeChecker;
|
|
|
|
|
use Psalm\CodeLocation;
|
2018-02-23 21:39:33 +01:00
|
|
|
|
use Psalm\FileSource;
|
2018-04-18 18:01:13 +02:00
|
|
|
|
use Psalm\Issue\DocblockTypeContradiction;
|
2018-04-17 21:39:09 +02:00
|
|
|
|
use Psalm\Issue\RedundantCondition;
|
2017-04-06 21:36:22 +02:00
|
|
|
|
use Psalm\Issue\TypeDoesNotContainNull;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
use Psalm\Issue\TypeDoesNotContainType;
|
2017-10-23 01:53:53 +02:00
|
|
|
|
use Psalm\Issue\UnevaluatedCode;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
use Psalm\IssueBuffer;
|
2017-01-07 20:35:07 +01:00
|
|
|
|
use Psalm\StatementsSource;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
use Psalm\Type;
|
|
|
|
|
|
2017-01-07 20:35:07 +01:00
|
|
|
|
class AssertionFinder
|
2016-12-28 21:52:44 +01:00
|
|
|
|
{
|
|
|
|
|
const ASSIGNMENT_TO_RIGHT = 1;
|
|
|
|
|
const ASSIGNMENT_TO_LEFT = -1;
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Gets all the type assertions in a conditional
|
|
|
|
|
*
|
|
|
|
|
* @param PhpParser\Node\Expr $conditional
|
2017-01-07 20:35:07 +01:00
|
|
|
|
* @param string|null $this_class_name
|
2018-02-23 21:39:33 +01:00
|
|
|
|
* @param FileSource $source
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return array<string, string>
|
|
|
|
|
*/
|
|
|
|
|
public static function getAssertions(
|
|
|
|
|
PhpParser\Node\Expr $conditional,
|
|
|
|
|
$this_class_name,
|
2018-02-23 21:39:33 +01:00
|
|
|
|
FileSource $source
|
2016-12-28 21:52:44 +01:00
|
|
|
|
) {
|
|
|
|
|
$if_types = [];
|
|
|
|
|
|
2018-02-23 21:39:33 +01:00
|
|
|
|
$project_checker = $source instanceof StatementsSource
|
|
|
|
|
? $source->getFileChecker()->project_checker
|
|
|
|
|
: null;
|
2017-07-29 21:05:06 +02:00
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\Instanceof_) {
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$instanceof_type = self::getInstanceOfTypes($conditional, $this_class_name, $source);
|
2016-12-28 21:52:44 +01:00
|
|
|
|
|
|
|
|
|
if ($instanceof_type) {
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$conditional->expr,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source
|
2016-12-28 21:52:44 +01:00
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
|
|
|
|
$if_types[$var_name] = $instanceof_type;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
2018-05-07 07:26:06 +02:00
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
2016-12-28 21:52:44 +01:00
|
|
|
|
$conditional,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source
|
2018-05-07 07:26:06 +02:00
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
2017-10-22 17:57:41 +02:00
|
|
|
|
$if_types[$var_name] = '!falsy';
|
2016-12-28 21:52:44 +01:00
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\Assign) {
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$conditional->var,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source
|
2016-12-28 21:52:44 +01:00
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
2017-10-22 17:57:41 +02:00
|
|
|
|
$if_types[$var_name] = '!falsy';
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BooleanNot) {
|
|
|
|
|
$if_types_to_negate = self::getAssertions(
|
|
|
|
|
$conditional->expr,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source
|
2016-12-28 21:52:44 +01:00
|
|
|
|
);
|
|
|
|
|
|
2018-05-07 07:26:06 +02:00
|
|
|
|
return \Psalm\Type\Algebra::negateTypes($if_types_to_negate);
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\Identical ||
|
|
|
|
|
$conditional instanceof PhpParser\Node\Expr\BinaryOp\Equal
|
|
|
|
|
) {
|
|
|
|
|
$null_position = self::hasNullVariable($conditional);
|
|
|
|
|
$false_position = self::hasFalseVariable($conditional);
|
2017-10-22 18:09:22 +02:00
|
|
|
|
$true_position = self::hasTrueVariable($conditional);
|
2016-12-28 21:52:44 +01:00
|
|
|
|
$gettype_position = self::hasGetTypeCheck($conditional);
|
2017-10-23 01:53:53 +02:00
|
|
|
|
$getclass_position = self::hasGetClassCheck($conditional);
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$typed_value_position = self::hasTypedValueComparison($conditional);
|
2016-12-28 21:52:44 +01:00
|
|
|
|
|
|
|
|
|
if ($null_position !== null) {
|
|
|
|
|
if ($null_position === self::ASSIGNMENT_TO_RIGHT) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional = $conditional->left;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
} elseif ($null_position === self::ASSIGNMENT_TO_LEFT) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional = $conditional->right;
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('$null_position value');
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$base_conditional,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$var_type = isset($base_conditional->inferredType) ? $base_conditional->inferredType : null;
|
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
if ($var_name) {
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\Identical) {
|
|
|
|
|
$if_types[$var_name] = 'null';
|
|
|
|
|
} else {
|
2017-10-22 17:57:41 +02:00
|
|
|
|
$if_types[$var_name] = 'falsy';
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
2018-02-23 21:39:33 +01:00
|
|
|
|
} elseif ($var_type
|
|
|
|
|
&& $conditional instanceof PhpParser\Node\Expr\BinaryOp\Identical
|
|
|
|
|
&& $source instanceof StatementsSource
|
|
|
|
|
&& $project_checker
|
|
|
|
|
) {
|
2017-04-06 21:05:23 +02:00
|
|
|
|
$null_type = Type::getNull();
|
2017-04-06 20:53:45 +02:00
|
|
|
|
|
|
|
|
|
if (!TypeChecker::isContainedBy(
|
2018-02-01 06:50:01 +01:00
|
|
|
|
$project_checker->codebase,
|
2017-04-06 20:53:45 +02:00
|
|
|
|
$var_type,
|
2017-07-29 21:05:06 +02:00
|
|
|
|
$null_type
|
2017-04-06 20:53:45 +02:00
|
|
|
|
) && !TypeChecker::isContainedBy(
|
2018-02-01 06:50:01 +01:00
|
|
|
|
$project_checker->codebase,
|
2017-04-06 20:53:45 +02:00
|
|
|
|
$null_type,
|
2017-07-29 21:05:06 +02:00
|
|
|
|
$var_type
|
2017-04-06 20:53:45 +02:00
|
|
|
|
)) {
|
|
|
|
|
if (IssueBuffer::accepts(
|
2017-04-06 21:36:22 +02:00
|
|
|
|
new TypeDoesNotContainNull(
|
2017-04-06 20:53:45 +02:00
|
|
|
|
$var_type . ' does not contain ' . $null_type,
|
|
|
|
|
new CodeLocation($source, $conditional)
|
|
|
|
|
),
|
|
|
|
|
$source->getSuppressedIssues()
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 01:11:28 +02:00
|
|
|
|
if ($true_position) {
|
2017-10-22 18:09:22 +02:00
|
|
|
|
if ($true_position === self::ASSIGNMENT_TO_RIGHT) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional = $conditional->left;
|
2017-10-22 18:09:22 +02:00
|
|
|
|
} elseif ($true_position === self::ASSIGNMENT_TO_LEFT) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional = $conditional->right;
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('Unrecognised position');
|
|
|
|
|
}
|
2017-10-22 18:09:22 +02:00
|
|
|
|
|
2017-10-23 01:11:28 +02:00
|
|
|
|
if ($base_conditional instanceof PhpParser\Node\Expr\FuncCall) {
|
2017-10-23 01:53:53 +02:00
|
|
|
|
return self::processFunctionCall(
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source,
|
|
|
|
|
false
|
|
|
|
|
);
|
2017-10-22 18:09:22 +02:00
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 01:53:53 +02:00
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$base_conditional,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
2017-10-22 18:09:22 +02:00
|
|
|
|
if ($var_name) {
|
2018-05-19 06:41:07 +02:00
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\Identical) {
|
|
|
|
|
$if_types[$var_name] = 'true';
|
|
|
|
|
} else {
|
|
|
|
|
$if_types[$var_name] = '!falsy';
|
|
|
|
|
}
|
2017-10-23 01:11:28 +02:00
|
|
|
|
} else {
|
|
|
|
|
return self::getAssertions($base_conditional, $this_class_name, $source);
|
2017-10-22 18:09:22 +02:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
if ($false_position) {
|
|
|
|
|
if ($false_position === self::ASSIGNMENT_TO_RIGHT) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional = $conditional->left;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
} elseif ($false_position === self::ASSIGNMENT_TO_LEFT) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional = $conditional->right;
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('$false_position value');
|
|
|
|
|
}
|
2017-04-06 20:53:45 +02:00
|
|
|
|
|
2017-10-23 01:11:28 +02:00
|
|
|
|
if ($base_conditional instanceof PhpParser\Node\Expr\FuncCall) {
|
2017-10-23 01:53:53 +02:00
|
|
|
|
return self::processFunctionCall(
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source,
|
|
|
|
|
true
|
|
|
|
|
);
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 01:53:53 +02:00
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$base_conditional,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$var_type = isset($base_conditional->inferredType) ? $base_conditional->inferredType : null;
|
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
if ($var_name) {
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\Identical) {
|
|
|
|
|
$if_types[$var_name] = 'false';
|
|
|
|
|
} else {
|
2017-10-22 17:57:41 +02:00
|
|
|
|
$if_types[$var_name] = 'falsy';
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
2017-10-23 01:11:28 +02:00
|
|
|
|
} elseif ($var_type) {
|
2018-02-23 21:39:33 +01:00
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\Identical
|
|
|
|
|
&& $source instanceof StatementsSource
|
|
|
|
|
&& $project_checker
|
|
|
|
|
) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$false_type = Type::getFalse();
|
2017-04-06 20:53:45 +02:00
|
|
|
|
|
2017-10-23 01:11:28 +02:00
|
|
|
|
if (!TypeChecker::isContainedBy(
|
2018-02-01 06:50:01 +01:00
|
|
|
|
$project_checker->codebase,
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$var_type,
|
|
|
|
|
$false_type
|
|
|
|
|
) && !TypeChecker::isContainedBy(
|
2018-02-01 06:50:01 +01:00
|
|
|
|
$project_checker->codebase,
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$false_type,
|
|
|
|
|
$var_type
|
2017-04-06 20:53:45 +02:00
|
|
|
|
)) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new TypeDoesNotContainType(
|
|
|
|
|
$var_type . ' does not contain ' . $false_type,
|
|
|
|
|
new CodeLocation($source, $conditional)
|
|
|
|
|
),
|
|
|
|
|
$source->getSuppressedIssues()
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
|
|
|
|
}
|
2017-04-06 20:53:45 +02:00
|
|
|
|
}
|
|
|
|
|
}
|
2017-10-23 01:11:28 +02:00
|
|
|
|
|
|
|
|
|
$notif_types = self::getAssertions($base_conditional, $this_class_name, $source);
|
|
|
|
|
|
|
|
|
|
if (count($notif_types) === 1) {
|
2018-05-07 07:26:06 +02:00
|
|
|
|
$if_types = \Psalm\Type\Algebra::negateTypes($notif_types);
|
2017-10-23 01:11:28 +02:00
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($gettype_position) {
|
|
|
|
|
if ($gettype_position === self::ASSIGNMENT_TO_RIGHT) {
|
2017-10-23 01:53:53 +02:00
|
|
|
|
$string_expr = $conditional->left;
|
|
|
|
|
$gettype_expr = $conditional->right;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
} elseif ($gettype_position === self::ASSIGNMENT_TO_LEFT) {
|
2017-10-23 01:53:53 +02:00
|
|
|
|
$string_expr = $conditional->right;
|
|
|
|
|
$gettype_expr = $conditional->left;
|
2017-10-23 01:11:28 +02:00
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('$gettype_position value');
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 01:53:53 +02:00
|
|
|
|
/** @var PhpParser\Node\Expr\FuncCall $gettype_expr */
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$gettype_expr->args[0]->value,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
/** @var PhpParser\Node\Scalar\String_ $string_expr */
|
|
|
|
|
$var_type = $string_expr->value;
|
|
|
|
|
|
2018-02-23 21:39:33 +01:00
|
|
|
|
if (!isset(ClassLikeChecker::$GETTYPE_TYPES[$var_type])
|
|
|
|
|
&& $source instanceof StatementsSource
|
|
|
|
|
) {
|
2017-10-23 01:53:53 +02:00
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new UnevaluatedCode(
|
|
|
|
|
'gettype cannot return this value',
|
2018-02-23 21:39:33 +01:00
|
|
|
|
new CodeLocation($source, $string_expr)
|
2017-10-23 01:53:53 +02:00
|
|
|
|
)
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
if ($var_name && $var_type) {
|
|
|
|
|
$if_types[$var_name] = $var_type;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($getclass_position) {
|
|
|
|
|
if ($getclass_position === self::ASSIGNMENT_TO_RIGHT) {
|
2017-10-26 21:07:36 +02:00
|
|
|
|
$whichclass_expr = $conditional->left;
|
2017-10-23 01:53:53 +02:00
|
|
|
|
$getclass_expr = $conditional->right;
|
|
|
|
|
} elseif ($getclass_position === self::ASSIGNMENT_TO_LEFT) {
|
2017-10-26 21:07:36 +02:00
|
|
|
|
$whichclass_expr = $conditional->right;
|
2017-10-23 01:53:53 +02:00
|
|
|
|
$getclass_expr = $conditional->left;
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('$getclass_position value');
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/** @var PhpParser\Node\Expr\FuncCall $getclass_expr */
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$getclass_expr->args[0]->value,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
2017-10-26 21:07:36 +02:00
|
|
|
|
if ($whichclass_expr instanceof PhpParser\Node\Scalar\String_) {
|
|
|
|
|
$var_type = $whichclass_expr->value;
|
|
|
|
|
} elseif ($whichclass_expr instanceof PhpParser\Node\Expr\ClassConstFetch
|
|
|
|
|
&& $whichclass_expr->class instanceof PhpParser\Node\Name
|
|
|
|
|
) {
|
|
|
|
|
$var_type = ClassLikeChecker::getFQCLNFromNameObject(
|
|
|
|
|
$whichclass_expr->class,
|
|
|
|
|
$source->getAliases()
|
|
|
|
|
);
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('Shouldn’t get here');
|
|
|
|
|
}
|
2017-10-23 01:53:53 +02:00
|
|
|
|
|
2018-02-23 21:39:33 +01:00
|
|
|
|
if ($source instanceof StatementsSource
|
|
|
|
|
&& ClassLikeChecker::checkFullyQualifiedClassLikeName(
|
2018-02-23 21:41:07 +01:00
|
|
|
|
$source,
|
|
|
|
|
$var_type,
|
|
|
|
|
new CodeLocation($source, $whichclass_expr),
|
|
|
|
|
$source->getSuppressedIssues(),
|
|
|
|
|
false
|
|
|
|
|
) === false
|
2017-10-23 01:53:53 +02:00
|
|
|
|
) {
|
|
|
|
|
// fall through
|
|
|
|
|
} else {
|
|
|
|
|
if ($var_name && $var_type) {
|
2018-05-18 17:02:50 +02:00
|
|
|
|
$if_types[$var_name] = '^getclass-' . $var_type;
|
2017-10-23 01:53:53 +02:00
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
2017-01-07 20:35:07 +01:00
|
|
|
|
if ($typed_value_position) {
|
|
|
|
|
if ($typed_value_position === self::ASSIGNMENT_TO_RIGHT) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
/** @var PhpParser\Node\Expr $conditional->right */
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$conditional->left,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source
|
2016-12-28 21:52:44 +01:00
|
|
|
|
);
|
|
|
|
|
|
2017-04-06 20:57:00 +02:00
|
|
|
|
$other_type = isset($conditional->left->inferredType) ? $conditional->left->inferredType : null;
|
2018-05-03 19:56:30 +02:00
|
|
|
|
$var_type = $conditional->right->inferredType;
|
2017-01-07 20:35:07 +01:00
|
|
|
|
} elseif ($typed_value_position === self::ASSIGNMENT_TO_LEFT) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
/** @var PhpParser\Node\Expr $conditional->left */
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$conditional->right,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source
|
2016-12-28 21:52:44 +01:00
|
|
|
|
);
|
|
|
|
|
|
2018-05-03 19:56:30 +02:00
|
|
|
|
$var_type = $conditional->left->inferredType;
|
2017-04-06 20:57:00 +02:00
|
|
|
|
$other_type = isset($conditional->right->inferredType) ? $conditional->right->inferredType : null;
|
2017-10-23 01:11:28 +02:00
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('$typed_value_position value');
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
2018-05-03 19:56:30 +02:00
|
|
|
|
if ($var_name && $var_type) {
|
2018-05-13 00:46:47 +02:00
|
|
|
|
$identical = $conditional instanceof PhpParser\Node\Expr\BinaryOp\Identical
|
|
|
|
|
|| ($other_type
|
|
|
|
|
&& (($var_type->isString() && $other_type->isString())
|
|
|
|
|
|| ($var_type->isInt() && $other_type->isInt())
|
|
|
|
|
|| ($var_type->isFloat() && $other_type->isFloat())
|
|
|
|
|
)
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
if ($identical) {
|
|
|
|
|
$if_types[$var_name] = '^' . $var_type->getId();
|
|
|
|
|
} else {
|
|
|
|
|
$if_types[$var_name] = '~' . $var_type->getId();
|
|
|
|
|
}
|
2018-05-03 19:56:30 +02:00
|
|
|
|
}
|
2018-04-18 18:01:13 +02:00
|
|
|
|
|
2018-05-03 19:56:30 +02:00
|
|
|
|
if ($other_type
|
|
|
|
|
&& $var_type
|
|
|
|
|
&& $conditional instanceof PhpParser\Node\Expr\BinaryOp\Identical
|
|
|
|
|
&& $source instanceof StatementsSource
|
|
|
|
|
&& $project_checker
|
|
|
|
|
) {
|
|
|
|
|
if (!TypeChecker::isContainedBy(
|
|
|
|
|
$project_checker->codebase,
|
|
|
|
|
$var_type,
|
|
|
|
|
$other_type,
|
|
|
|
|
true,
|
2018-05-18 17:02:50 +02:00
|
|
|
|
true
|
2018-05-03 19:56:30 +02:00
|
|
|
|
) && !TypeChecker::isContainedBy(
|
|
|
|
|
$project_checker->codebase,
|
|
|
|
|
$other_type,
|
|
|
|
|
$var_type,
|
|
|
|
|
true,
|
2018-05-18 17:02:50 +02:00
|
|
|
|
true
|
2018-05-03 19:56:30 +02:00
|
|
|
|
)) {
|
|
|
|
|
if ($var_type->from_docblock || $other_type->from_docblock) {
|
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new DocblockTypeContradiction(
|
|
|
|
|
$var_type . ' does not contain ' . $other_type,
|
|
|
|
|
new CodeLocation($source, $conditional)
|
|
|
|
|
),
|
|
|
|
|
$source->getSuppressedIssues()
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
|
|
|
|
}
|
|
|
|
|
} else {
|
2018-05-18 17:02:50 +02:00
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new TypeDoesNotContainType(
|
|
|
|
|
$var_type->getId() . ' does not contain ' . $other_type->getId(),
|
|
|
|
|
new CodeLocation($source, $conditional)
|
|
|
|
|
),
|
|
|
|
|
$source->getSuppressedIssues()
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
2017-04-06 20:53:45 +02:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
2017-04-06 20:53:45 +02:00
|
|
|
|
$var_type = isset($conditional->left->inferredType) ? $conditional->left->inferredType : null;
|
|
|
|
|
$other_type = isset($conditional->right->inferredType) ? $conditional->right->inferredType : null;
|
|
|
|
|
|
2018-02-23 21:39:33 +01:00
|
|
|
|
if ($var_type
|
|
|
|
|
&& $other_type
|
|
|
|
|
&& $conditional instanceof PhpParser\Node\Expr\BinaryOp\Identical
|
|
|
|
|
&& $source instanceof StatementsSource
|
|
|
|
|
&& $project_checker
|
|
|
|
|
) {
|
2018-02-01 06:50:01 +01:00
|
|
|
|
if (!TypeChecker::canBeIdenticalTo($project_checker->codebase, $var_type, $other_type)) {
|
2017-04-06 20:53:45 +02:00
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new TypeDoesNotContainType(
|
|
|
|
|
$var_type . ' does not contain ' . $other_type,
|
|
|
|
|
new CodeLocation($source, $conditional)
|
|
|
|
|
),
|
|
|
|
|
$source->getSuppressedIssues()
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return [];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\NotIdentical ||
|
|
|
|
|
$conditional instanceof PhpParser\Node\Expr\BinaryOp\NotEqual
|
|
|
|
|
) {
|
|
|
|
|
$null_position = self::hasNullVariable($conditional);
|
|
|
|
|
$false_position = self::hasFalseVariable($conditional);
|
|
|
|
|
$true_position = self::hasTrueVariable($conditional);
|
2017-10-23 02:17:04 +02:00
|
|
|
|
$gettype_position = self::hasGetTypeCheck($conditional);
|
|
|
|
|
$getclass_position = self::hasGetClassCheck($conditional);
|
2018-04-17 21:39:09 +02:00
|
|
|
|
$typed_value_position = self::hasTypedValueComparison($conditional);
|
2016-12-28 21:52:44 +01:00
|
|
|
|
|
|
|
|
|
if ($null_position !== null) {
|
|
|
|
|
if ($null_position === self::ASSIGNMENT_TO_RIGHT) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional = $conditional->left;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
} elseif ($null_position === self::ASSIGNMENT_TO_LEFT) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional = $conditional->right;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
} else {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
throw new \UnexpectedValueException('Bad null variable position');
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$base_conditional,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
if ($var_name) {
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\NotIdentical) {
|
|
|
|
|
$if_types[$var_name] = '!null';
|
|
|
|
|
} else {
|
2017-10-22 17:57:41 +02:00
|
|
|
|
$if_types[$var_name] = '!falsy';
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($false_position) {
|
|
|
|
|
if ($false_position === self::ASSIGNMENT_TO_RIGHT) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional = $conditional->left;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
} elseif ($false_position === self::ASSIGNMENT_TO_LEFT) {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$base_conditional = $conditional->right;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
} else {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
throw new \UnexpectedValueException('Bad false variable position');
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 01:11:28 +02:00
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$base_conditional,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
if ($var_name) {
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\NotIdentical) {
|
|
|
|
|
$if_types[$var_name] = '!false';
|
|
|
|
|
} else {
|
2017-10-22 17:57:41 +02:00
|
|
|
|
$if_types[$var_name] = '!falsy';
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($true_position) {
|
|
|
|
|
if ($true_position === self::ASSIGNMENT_TO_RIGHT) {
|
|
|
|
|
if ($conditional->left instanceof PhpParser\Node\Expr\FuncCall) {
|
2017-10-23 01:53:53 +02:00
|
|
|
|
return self::processFunctionCall(
|
2016-12-28 21:52:44 +01:00
|
|
|
|
$conditional->left,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source,
|
2016-12-28 21:52:44 +01:00
|
|
|
|
true
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
} elseif ($true_position === self::ASSIGNMENT_TO_LEFT) {
|
|
|
|
|
if ($conditional->right instanceof PhpParser\Node\Expr\FuncCall) {
|
2017-10-23 01:53:53 +02:00
|
|
|
|
return self::processFunctionCall(
|
2016-12-28 21:52:44 +01:00
|
|
|
|
$conditional->right,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source,
|
2016-12-28 21:52:44 +01:00
|
|
|
|
true
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
} else {
|
2017-10-23 01:11:28 +02:00
|
|
|
|
throw new \UnexpectedValueException('Bad null variable position');
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 01:53:53 +02:00
|
|
|
|
return [];
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 02:17:04 +02:00
|
|
|
|
if ($gettype_position) {
|
|
|
|
|
if ($gettype_position === self::ASSIGNMENT_TO_RIGHT) {
|
2017-10-26 21:07:36 +02:00
|
|
|
|
$whichclass_expr = $conditional->left;
|
2017-10-23 02:17:04 +02:00
|
|
|
|
$gettype_expr = $conditional->right;
|
|
|
|
|
} elseif ($gettype_position === self::ASSIGNMENT_TO_LEFT) {
|
2017-10-26 21:07:36 +02:00
|
|
|
|
$whichclass_expr = $conditional->right;
|
2017-10-23 02:17:04 +02:00
|
|
|
|
$gettype_expr = $conditional->left;
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('$gettype_position value');
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/** @var PhpParser\Node\Expr\FuncCall $gettype_expr */
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$gettype_expr->args[0]->value,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
2017-10-26 21:07:36 +02:00
|
|
|
|
if ($whichclass_expr instanceof PhpParser\Node\Scalar\String_) {
|
|
|
|
|
$var_type = $whichclass_expr->value;
|
|
|
|
|
} elseif ($whichclass_expr instanceof PhpParser\Node\Expr\ClassConstFetch
|
|
|
|
|
&& $whichclass_expr->class instanceof PhpParser\Node\Name
|
|
|
|
|
) {
|
|
|
|
|
$var_type = ClassLikeChecker::getFQCLNFromNameObject(
|
|
|
|
|
$whichclass_expr->class,
|
|
|
|
|
$source->getAliases()
|
|
|
|
|
);
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('Shouldn’t get here');
|
|
|
|
|
}
|
2017-10-23 02:17:04 +02:00
|
|
|
|
|
|
|
|
|
if (!isset(ClassLikeChecker::$GETTYPE_TYPES[$var_type])) {
|
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new UnevaluatedCode(
|
|
|
|
|
'gettype cannot return this value',
|
2018-02-23 21:39:33 +01:00
|
|
|
|
new CodeLocation($source, $whichclass_expr)
|
2017-10-23 02:17:04 +02:00
|
|
|
|
)
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
if ($var_name && $var_type) {
|
|
|
|
|
$if_types[$var_name] = '!' . $var_type;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($getclass_position) {
|
|
|
|
|
if ($getclass_position === self::ASSIGNMENT_TO_RIGHT) {
|
2017-11-06 18:04:38 +01:00
|
|
|
|
$whichclass_expr = $conditional->left;
|
2017-10-23 02:17:04 +02:00
|
|
|
|
$getclass_expr = $conditional->right;
|
|
|
|
|
} elseif ($getclass_position === self::ASSIGNMENT_TO_LEFT) {
|
2017-11-06 18:04:38 +01:00
|
|
|
|
$whichclass_expr = $conditional->right;
|
2017-10-23 02:17:04 +02:00
|
|
|
|
$getclass_expr = $conditional->left;
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('$getclass_position value');
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/** @var PhpParser\Node\Expr\FuncCall $getclass_expr */
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$getclass_expr->args[0]->value,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
2017-11-06 18:04:38 +01:00
|
|
|
|
if ($whichclass_expr instanceof PhpParser\Node\Scalar\String_) {
|
|
|
|
|
$var_type = $whichclass_expr->value;
|
|
|
|
|
} elseif ($whichclass_expr instanceof PhpParser\Node\Expr\ClassConstFetch
|
|
|
|
|
&& $whichclass_expr->class instanceof PhpParser\Node\Name
|
|
|
|
|
) {
|
|
|
|
|
$var_type = ClassLikeChecker::getFQCLNFromNameObject(
|
|
|
|
|
$whichclass_expr->class,
|
|
|
|
|
$source->getAliases()
|
|
|
|
|
);
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('Shouldn’t get here');
|
|
|
|
|
}
|
2017-10-23 02:17:04 +02:00
|
|
|
|
|
2018-02-23 21:39:33 +01:00
|
|
|
|
if ($source instanceof StatementsSource
|
|
|
|
|
&& $project_checker
|
|
|
|
|
&& ClassLikeChecker::checkFullyQualifiedClassLikeName(
|
2018-02-23 21:41:07 +01:00
|
|
|
|
$source,
|
|
|
|
|
$var_type,
|
|
|
|
|
new CodeLocation($source, $whichclass_expr),
|
|
|
|
|
$source->getSuppressedIssues(),
|
|
|
|
|
false
|
|
|
|
|
) === false
|
2017-10-23 02:17:04 +02:00
|
|
|
|
) {
|
|
|
|
|
// fall through
|
|
|
|
|
} else {
|
|
|
|
|
if ($var_name && $var_type) {
|
2018-05-18 17:02:50 +02:00
|
|
|
|
$if_types[$var_name] = '!^getclass-' . $var_type;
|
2017-10-23 02:17:04 +02:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
2018-04-17 21:39:09 +02:00
|
|
|
|
if ($typed_value_position) {
|
|
|
|
|
if ($typed_value_position === self::ASSIGNMENT_TO_RIGHT) {
|
|
|
|
|
/** @var PhpParser\Node\Expr $conditional->right */
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$conditional->left,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$other_type = isset($conditional->left->inferredType) ? $conditional->left->inferredType : null;
|
|
|
|
|
$var_type = isset($conditional->right->inferredType) ? $conditional->right->inferredType : null;
|
|
|
|
|
} elseif ($typed_value_position === self::ASSIGNMENT_TO_LEFT) {
|
|
|
|
|
/** @var PhpParser\Node\Expr $conditional->left */
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$conditional->right,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
$var_type = isset($conditional->left->inferredType) ? $conditional->left->inferredType : null;
|
|
|
|
|
$other_type = isset($conditional->right->inferredType) ? $conditional->right->inferredType : null;
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('$typed_value_position value');
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($var_type) {
|
|
|
|
|
if ($var_name) {
|
2018-05-13 00:46:47 +02:00
|
|
|
|
$not_identical = $conditional instanceof PhpParser\Node\Expr\BinaryOp\NotIdentical
|
|
|
|
|
|| ($other_type
|
|
|
|
|
&& (($var_type->isString() && $other_type->isString())
|
|
|
|
|
|| ($var_type->isInt() && $other_type->isInt())
|
|
|
|
|
|| ($var_type->isFloat() && $other_type->isFloat())
|
|
|
|
|
)
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
if ($not_identical) {
|
|
|
|
|
$if_types[$var_name] = '!^' . $var_type->getId();
|
|
|
|
|
} else {
|
|
|
|
|
$if_types[$var_name] = '!~' . $var_type->getId();
|
|
|
|
|
}
|
2018-04-17 21:39:09 +02:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($other_type
|
|
|
|
|
&& $conditional instanceof PhpParser\Node\Expr\BinaryOp\NotIdentical
|
|
|
|
|
&& $source instanceof StatementsSource
|
|
|
|
|
&& $project_checker
|
|
|
|
|
) {
|
|
|
|
|
if (!TypeChecker::isContainedBy(
|
|
|
|
|
$project_checker->codebase,
|
|
|
|
|
$var_type,
|
|
|
|
|
$other_type,
|
2018-05-03 19:56:30 +02:00
|
|
|
|
true,
|
2018-05-18 17:02:50 +02:00
|
|
|
|
true
|
2018-04-17 21:39:09 +02:00
|
|
|
|
) && !TypeChecker::isContainedBy(
|
|
|
|
|
$project_checker->codebase,
|
|
|
|
|
$other_type,
|
|
|
|
|
$var_type,
|
2018-05-03 19:56:30 +02:00
|
|
|
|
true,
|
2018-05-18 17:02:50 +02:00
|
|
|
|
true
|
2018-04-17 21:39:09 +02:00
|
|
|
|
)) {
|
2018-04-18 18:01:13 +02:00
|
|
|
|
if ($var_type->from_docblock || $other_type->from_docblock) {
|
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new DocblockTypeContradiction(
|
|
|
|
|
$var_type . ' can never contain ' . $other_type,
|
|
|
|
|
new CodeLocation($source, $conditional)
|
|
|
|
|
),
|
|
|
|
|
$source->getSuppressedIssues()
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
|
|
|
|
}
|
|
|
|
|
} else {
|
2018-05-18 17:02:50 +02:00
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new RedundantCondition(
|
|
|
|
|
$var_type->getId() . ' can never contain ' . $other_type->getId(),
|
|
|
|
|
new CodeLocation($source, $conditional)
|
|
|
|
|
),
|
|
|
|
|
$source->getSuppressedIssues()
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
2018-04-18 18:01:13 +02:00
|
|
|
|
}
|
2018-04-17 21:39:09 +02:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return [];
|
|
|
|
|
}
|
|
|
|
|
|
2017-12-14 02:06:19 +01:00
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\Greater) {
|
|
|
|
|
$typed_value_position = self::hasTypedValueComparison($conditional);
|
|
|
|
|
|
|
|
|
|
if ($typed_value_position) {
|
|
|
|
|
if ($typed_value_position === self::ASSIGNMENT_TO_RIGHT) {
|
|
|
|
|
/** @var PhpParser\Node\Expr $conditional->right */
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$conditional->left,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
2017-12-14 02:48:01 +01:00
|
|
|
|
} elseif ($typed_value_position === self::ASSIGNMENT_TO_LEFT) {
|
|
|
|
|
$var_name = null;
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('$typed_value_position value');
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
|
|
|
|
$if_types[$var_name] = '^isset';
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return [];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\Smaller) {
|
|
|
|
|
$typed_value_position = self::hasTypedValueComparison($conditional);
|
|
|
|
|
|
|
|
|
|
if ($typed_value_position) {
|
|
|
|
|
if ($typed_value_position === self::ASSIGNMENT_TO_RIGHT) {
|
|
|
|
|
$var_name = null;
|
2017-12-14 02:06:19 +01:00
|
|
|
|
} elseif ($typed_value_position === self::ASSIGNMENT_TO_LEFT) {
|
|
|
|
|
/** @var PhpParser\Node\Expr $conditional->left */
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$conditional->right,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
} else {
|
|
|
|
|
throw new \UnexpectedValueException('$typed_value_position value');
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
|
|
|
|
$if_types[$var_name] = '^isset';
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return [];
|
|
|
|
|
}
|
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\FuncCall) {
|
2017-10-23 01:53:53 +02:00
|
|
|
|
return self::processFunctionCall($conditional, $this_class_name, $source, false);
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\Empty_) {
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$conditional->expr,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source
|
2016-12-28 21:52:44 +01:00
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
2017-12-05 18:14:10 +01:00
|
|
|
|
$if_types[$var_name] = 'empty';
|
|
|
|
|
} else {
|
|
|
|
|
// look for any variables we *can* use for an isset assertion
|
|
|
|
|
$array_root = $conditional->expr;
|
|
|
|
|
|
|
|
|
|
while ($array_root instanceof PhpParser\Node\Expr\ArrayDimFetch && !$var_name) {
|
|
|
|
|
$array_root = $array_root->var;
|
|
|
|
|
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$array_root,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
|
|
|
|
$if_types[$var_name] = '^empty';
|
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\Isset_) {
|
|
|
|
|
foreach ($conditional->vars as $isset_var) {
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$isset_var,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source
|
2016-12-28 21:52:44 +01:00
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
2017-01-31 06:34:06 +01:00
|
|
|
|
$if_types[$var_name] = 'isset';
|
2017-01-31 07:35:44 +01:00
|
|
|
|
} else {
|
|
|
|
|
// look for any variables we *can* use for an isset assertion
|
|
|
|
|
$array_root = $isset_var;
|
|
|
|
|
|
|
|
|
|
while ($array_root instanceof PhpParser\Node\Expr\ArrayDimFetch && !$var_name) {
|
|
|
|
|
$array_root = $array_root->var;
|
|
|
|
|
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$array_root,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
|
|
|
|
$if_types[$var_name] = '^isset';
|
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
}
|
2017-02-18 02:50:47 +01:00
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($conditional instanceof PhpParser\Node\Expr\BinaryOp\Coalesce) {
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$conditional->left,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
|
|
|
|
$if_types[$var_name] = 'isset';
|
|
|
|
|
} else {
|
|
|
|
|
// look for any variables we *can* use for an isset assertion
|
|
|
|
|
$array_root = $conditional->left;
|
|
|
|
|
|
|
|
|
|
while ($array_root instanceof PhpParser\Node\Expr\ArrayDimFetch && !$var_name) {
|
|
|
|
|
$array_root = $array_root->var;
|
|
|
|
|
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$array_root,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
|
|
|
|
$if_types[$var_name] = '^isset';
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return [];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $expr
|
2017-01-07 20:35:07 +01:00
|
|
|
|
* @param string|null $this_class_name
|
2018-02-23 21:39:33 +01:00
|
|
|
|
* @param FileSource $source
|
|
|
|
|
* @param bool $negate
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2017-10-23 01:53:53 +02:00
|
|
|
|
* @return array<string, string>
|
2016-12-28 21:52:44 +01:00
|
|
|
|
*/
|
|
|
|
|
protected static function processFunctionCall(
|
|
|
|
|
PhpParser\Node\Expr\FuncCall $expr,
|
|
|
|
|
$this_class_name,
|
2018-02-23 21:39:33 +01:00
|
|
|
|
FileSource $source,
|
2016-12-28 21:52:44 +01:00
|
|
|
|
$negate = false
|
|
|
|
|
) {
|
|
|
|
|
$prefix = $negate ? '!' : '';
|
|
|
|
|
|
|
|
|
|
$first_var_name = isset($expr->args[0]->value)
|
|
|
|
|
? ExpressionChecker::getArrayVarId(
|
|
|
|
|
$expr->args[0]->value,
|
|
|
|
|
$this_class_name,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$source
|
2016-12-28 21:52:44 +01:00
|
|
|
|
)
|
|
|
|
|
: null;
|
|
|
|
|
|
2017-10-23 01:53:53 +02:00
|
|
|
|
$if_types = [];
|
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
if (self::hasNullCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'null';
|
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasIsACheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
2018-01-23 21:46:14 +01:00
|
|
|
|
$first_arg = $expr->args[1]->value;
|
|
|
|
|
|
2018-04-04 05:14:23 +02:00
|
|
|
|
$is_a_prefix = '';
|
|
|
|
|
|
|
|
|
|
if (isset($expr->args[2]->value)) {
|
|
|
|
|
$third_arg = $expr->args[2]->value;
|
|
|
|
|
|
|
|
|
|
if (!$third_arg instanceof PhpParser\Node\Expr\ConstFetch
|
|
|
|
|
|| !in_array(strtolower($third_arg->name->parts[0]), ['true', 'false'])
|
|
|
|
|
) {
|
|
|
|
|
return $if_types;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$is_a_prefix = strtolower($third_arg->name->parts[0]) === 'true' ? 'isa-' : '';
|
|
|
|
|
}
|
|
|
|
|
|
2018-01-23 21:46:14 +01:00
|
|
|
|
if ($first_arg instanceof PhpParser\Node\Scalar\String_) {
|
2018-04-05 18:03:36 +02:00
|
|
|
|
$if_types[$first_var_name] = $prefix . $is_a_prefix . $first_arg->value;
|
2018-01-23 21:46:14 +01:00
|
|
|
|
} elseif ($first_arg instanceof PhpParser\Node\Expr\ClassConstFetch
|
|
|
|
|
&& $first_arg->class instanceof PhpParser\Node\Name
|
2018-04-17 18:16:25 +02:00
|
|
|
|
&& $first_arg->name instanceof PhpParser\Node\Identifier
|
|
|
|
|
&& strtolower($first_arg->name->name) === 'class'
|
2018-01-23 21:46:14 +01:00
|
|
|
|
) {
|
|
|
|
|
$class_node = $first_arg->class;
|
|
|
|
|
|
|
|
|
|
if ($class_node->parts === ['static'] || $class_node->parts === ['self']) {
|
2018-04-04 05:14:23 +02:00
|
|
|
|
$if_types[$first_var_name] = $prefix . $is_a_prefix . $this_class_name;
|
2018-01-23 21:46:14 +01:00
|
|
|
|
} elseif ($class_node->parts === ['parent']) {
|
|
|
|
|
// do nothing
|
|
|
|
|
} else {
|
2018-04-04 05:14:23 +02:00
|
|
|
|
$if_types[$first_var_name] = $prefix . $is_a_prefix . ClassLikeChecker::getFQCLNFromNameObject(
|
2018-01-23 21:46:14 +01:00
|
|
|
|
$class_node,
|
|
|
|
|
$source->getAliases()
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasArrayCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'array';
|
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasBoolCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'bool';
|
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasStringCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'string';
|
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasObjectCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'object';
|
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasNumericCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'numeric';
|
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasIntCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'int';
|
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasFloatCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'float';
|
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasResourceCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'resource';
|
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasScalarCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'scalar';
|
|
|
|
|
}
|
|
|
|
|
} elseif (self::hasCallableCheck($expr)) {
|
|
|
|
|
if ($first_var_name) {
|
|
|
|
|
$if_types[$first_var_name] = $prefix . 'callable';
|
|
|
|
|
}
|
2018-03-18 00:03:46 +01:00
|
|
|
|
} elseif (self::hasArrayKeyExistsCheck($expr)) {
|
|
|
|
|
$array_root = isset($expr->args[1]->value)
|
|
|
|
|
? ExpressionChecker::getArrayVarId(
|
|
|
|
|
$expr->args[1]->value,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
)
|
|
|
|
|
: null;
|
|
|
|
|
|
2018-03-18 00:28:01 +01:00
|
|
|
|
if ($first_var_name === null && isset($expr->args[0])) {
|
|
|
|
|
$first_arg = $expr->args[0];
|
|
|
|
|
|
|
|
|
|
if ($first_arg->value instanceof PhpParser\Node\Scalar\String_) {
|
|
|
|
|
$first_var_name = '"' . $first_arg->value->value . '"';
|
|
|
|
|
} elseif ($first_arg->value instanceof PhpParser\Node\Scalar\LNumber) {
|
|
|
|
|
$first_var_name = (string) $first_arg->value->value;
|
2018-03-18 00:03:46 +01:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-03-20 00:14:55 +01:00
|
|
|
|
if ($first_var_name !== null
|
|
|
|
|
&& $array_root
|
|
|
|
|
&& !strpos($first_var_name, '->')
|
|
|
|
|
&& !strpos($first_var_name, '[')
|
|
|
|
|
) {
|
2018-03-18 00:03:46 +01:00
|
|
|
|
$if_types[$array_root . '[' . $first_var_name . ']'] = $prefix . 'array-key-exists';
|
|
|
|
|
}
|
2018-05-28 21:07:42 +02:00
|
|
|
|
} elseif ($source instanceof StatementsChecker
|
|
|
|
|
&& $expr->name instanceof PhpParser\Node\Name
|
|
|
|
|
&& isset($expr->conditionalAssertion)
|
|
|
|
|
) {
|
|
|
|
|
$codebase = $source->getFileChecker()->project_checker->codebase;
|
|
|
|
|
|
|
|
|
|
$function_id = ClassLikeChecker::getFQCLNFromNameObject($expr->name, $source->getAliases());
|
|
|
|
|
|
|
|
|
|
$function_storage = $codebase->functions->getStorage(
|
|
|
|
|
$source,
|
|
|
|
|
strtolower($function_id)
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
foreach ($function_storage->if_true_assertions as $assertion) {
|
|
|
|
|
if (is_int($assertion->var_id) && isset($expr->args[$assertion->var_id])) {
|
|
|
|
|
if ($assertion->var_id === 0) {
|
|
|
|
|
$var_name = $first_var_name;
|
|
|
|
|
} else {
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$expr->args[$assertion->var_id]->value,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
|
|
|
|
$if_types[$var_name] = $prefix . $assertion->rule[0][0];
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$negated_prefix = !$negate ? '!' : '';
|
|
|
|
|
|
|
|
|
|
foreach ($function_storage->if_false_assertions as $assertion) {
|
|
|
|
|
if (is_int($assertion->var_id) && isset($expr->args[$assertion->var_id])) {
|
|
|
|
|
if ($assertion->var_id === 0) {
|
|
|
|
|
$var_name = $first_var_name;
|
|
|
|
|
} else {
|
|
|
|
|
$var_name = ExpressionChecker::getArrayVarId(
|
|
|
|
|
$expr->args[$assertion->var_id]->value,
|
|
|
|
|
$this_class_name,
|
|
|
|
|
$source
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($var_name) {
|
|
|
|
|
$if_types[$var_name] = $negated_prefix . $assertion->rule[0][0];
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
2017-10-23 01:53:53 +02:00
|
|
|
|
|
|
|
|
|
return $if_types;
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\Instanceof_ $stmt
|
2017-01-07 20:35:07 +01:00
|
|
|
|
* @param string|null $this_class_name
|
2018-02-23 21:39:33 +01:00
|
|
|
|
* @param FileSource $source
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return string|null
|
|
|
|
|
*/
|
|
|
|
|
protected static function getInstanceOfTypes(
|
|
|
|
|
PhpParser\Node\Expr\Instanceof_ $stmt,
|
|
|
|
|
$this_class_name,
|
2018-02-23 21:39:33 +01:00
|
|
|
|
FileSource $source
|
2016-12-28 21:52:44 +01:00
|
|
|
|
) {
|
|
|
|
|
if ($stmt->class instanceof PhpParser\Node\Name) {
|
2017-11-15 03:56:29 +01:00
|
|
|
|
if (!in_array(strtolower($stmt->class->parts[0]), ['self', 'static', 'parent'], true)) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
$instanceof_class = ClassLikeChecker::getFQCLNFromNameObject(
|
|
|
|
|
$stmt->class,
|
2017-07-25 22:11:02 +02:00
|
|
|
|
$source->getAliases()
|
2016-12-28 21:52:44 +01:00
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
return $instanceof_class;
|
2018-01-23 20:46:46 +01:00
|
|
|
|
} elseif ($this_class_name
|
|
|
|
|
&& (in_array(strtolower($stmt->class->parts[0]), ['self', 'static'], true))
|
|
|
|
|
) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return $this_class_name;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return null;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\BinaryOp $conditional
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return int|null
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasNullVariable(PhpParser\Node\Expr\BinaryOp $conditional)
|
|
|
|
|
{
|
2018-02-07 19:57:45 +01:00
|
|
|
|
if ($conditional->right instanceof PhpParser\Node\Expr\ConstFetch
|
|
|
|
|
&& strtolower($conditional->right->name->parts[0]) === 'null'
|
|
|
|
|
) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return self::ASSIGNMENT_TO_RIGHT;
|
|
|
|
|
}
|
|
|
|
|
|
2018-02-07 19:57:45 +01:00
|
|
|
|
if ($conditional->left instanceof PhpParser\Node\Expr\ConstFetch
|
|
|
|
|
&& strtolower($conditional->left->name->parts[0]) === 'null'
|
|
|
|
|
) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return self::ASSIGNMENT_TO_LEFT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return null;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\BinaryOp $conditional
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return int|null
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasFalseVariable(PhpParser\Node\Expr\BinaryOp $conditional)
|
|
|
|
|
{
|
2018-02-07 19:57:45 +01:00
|
|
|
|
if ($conditional->right instanceof PhpParser\Node\Expr\ConstFetch
|
|
|
|
|
&& strtolower($conditional->right->name->parts[0]) === 'false'
|
|
|
|
|
) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return self::ASSIGNMENT_TO_RIGHT;
|
|
|
|
|
}
|
|
|
|
|
|
2018-02-07 19:57:45 +01:00
|
|
|
|
if ($conditional->left instanceof PhpParser\Node\Expr\ConstFetch
|
|
|
|
|
&& strtolower($conditional->left->name->parts[0]) === 'false'
|
|
|
|
|
) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return self::ASSIGNMENT_TO_LEFT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return null;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\BinaryOp $conditional
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return int|null
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasTrueVariable(PhpParser\Node\Expr\BinaryOp $conditional)
|
|
|
|
|
{
|
2018-02-07 19:57:45 +01:00
|
|
|
|
if ($conditional->right instanceof PhpParser\Node\Expr\ConstFetch
|
|
|
|
|
&& strtolower($conditional->right->name->parts[0]) === 'true'
|
|
|
|
|
) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return self::ASSIGNMENT_TO_RIGHT;
|
|
|
|
|
}
|
|
|
|
|
|
2018-02-07 19:57:45 +01:00
|
|
|
|
if ($conditional->left instanceof PhpParser\Node\Expr\ConstFetch
|
|
|
|
|
&& strtolower($conditional->left->name->parts[0]) === 'true'
|
|
|
|
|
) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return self::ASSIGNMENT_TO_LEFT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return null;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\BinaryOp $conditional
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return false|int
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasGetTypeCheck(PhpParser\Node\Expr\BinaryOp $conditional)
|
|
|
|
|
{
|
|
|
|
|
if ($conditional->right instanceof PhpParser\Node\Expr\FuncCall &&
|
|
|
|
|
$conditional->right->name instanceof PhpParser\Node\Name &&
|
|
|
|
|
strtolower($conditional->right->name->parts[0]) === 'gettype' &&
|
|
|
|
|
$conditional->left instanceof PhpParser\Node\Scalar\String_) {
|
|
|
|
|
return self::ASSIGNMENT_TO_RIGHT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($conditional->left instanceof PhpParser\Node\Expr\FuncCall &&
|
|
|
|
|
$conditional->left->name instanceof PhpParser\Node\Name &&
|
|
|
|
|
strtolower($conditional->left->name->parts[0]) === 'gettype' &&
|
|
|
|
|
$conditional->right instanceof PhpParser\Node\Scalar\String_) {
|
|
|
|
|
return self::ASSIGNMENT_TO_LEFT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 01:53:53 +02:00
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\BinaryOp $conditional
|
|
|
|
|
*
|
|
|
|
|
* @return false|int
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasGetClassCheck(PhpParser\Node\Expr\BinaryOp $conditional)
|
|
|
|
|
{
|
|
|
|
|
if ($conditional->right instanceof PhpParser\Node\Expr\FuncCall &&
|
|
|
|
|
$conditional->right->name instanceof PhpParser\Node\Name &&
|
|
|
|
|
strtolower($conditional->right->name->parts[0]) === 'get_class' &&
|
2017-12-01 01:00:09 +01:00
|
|
|
|
(
|
|
|
|
|
$conditional->left instanceof PhpParser\Node\Scalar\String_
|
2017-10-26 21:07:36 +02:00
|
|
|
|
|| ($conditional->left instanceof PhpParser\Node\Expr\ClassConstFetch
|
2017-11-06 18:04:38 +01:00
|
|
|
|
&& $conditional->left->class instanceof PhpParser\Node\Name
|
2018-04-17 18:16:25 +02:00
|
|
|
|
&& $conditional->left->name instanceof PhpParser\Node\Identifier
|
|
|
|
|
&& strtolower($conditional->left->name->name) === 'class')
|
2017-10-26 21:07:36 +02:00
|
|
|
|
)
|
|
|
|
|
) {
|
2017-10-23 01:53:53 +02:00
|
|
|
|
return self::ASSIGNMENT_TO_RIGHT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($conditional->left instanceof PhpParser\Node\Expr\FuncCall &&
|
|
|
|
|
$conditional->left->name instanceof PhpParser\Node\Name &&
|
|
|
|
|
strtolower($conditional->left->name->parts[0]) === 'get_class' &&
|
2017-12-01 01:00:09 +01:00
|
|
|
|
(
|
|
|
|
|
$conditional->right instanceof PhpParser\Node\Scalar\String_
|
2017-10-26 21:07:36 +02:00
|
|
|
|
|| ($conditional->right instanceof PhpParser\Node\Expr\ClassConstFetch
|
2017-11-06 18:04:38 +01:00
|
|
|
|
&& $conditional->right->class instanceof PhpParser\Node\Name
|
2018-04-17 18:16:25 +02:00
|
|
|
|
&& $conditional->right->name instanceof PhpParser\Node\Identifier
|
|
|
|
|
&& strtolower($conditional->right->name->name) === 'class')
|
2017-10-26 21:07:36 +02:00
|
|
|
|
)
|
|
|
|
|
) {
|
2017-10-23 01:53:53 +02:00
|
|
|
|
return self::ASSIGNMENT_TO_LEFT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
2016-12-28 21:52:44 +01:00
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\BinaryOp $conditional
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return false|int
|
|
|
|
|
*/
|
2017-01-07 20:35:07 +01:00
|
|
|
|
protected static function hasTypedValueComparison(PhpParser\Node\Expr\BinaryOp $conditional)
|
2016-12-28 21:52:44 +01:00
|
|
|
|
{
|
2018-01-09 21:05:48 +01:00
|
|
|
|
if (isset($conditional->right->inferredType)
|
|
|
|
|
&& count($conditional->right->inferredType->getTypes()) === 1
|
|
|
|
|
) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return self::ASSIGNMENT_TO_RIGHT;
|
|
|
|
|
}
|
|
|
|
|
|
2018-01-09 21:05:48 +01:00
|
|
|
|
if (isset($conditional->left->inferredType)
|
|
|
|
|
&& count($conditional->left->inferredType->getTypes()) === 1
|
|
|
|
|
) {
|
2016-12-28 21:52:44 +01:00
|
|
|
|
return self::ASSIGNMENT_TO_LEFT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasNullCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name && strtolower($stmt->name->parts[0]) === 'is_null') {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasIsACheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
2018-01-23 21:46:14 +01:00
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name
|
|
|
|
|
&& strtolower($stmt->name->parts[0]) === 'is_a'
|
|
|
|
|
&& isset($stmt->args[1])
|
|
|
|
|
) {
|
2018-01-30 22:45:29 +01:00
|
|
|
|
$second_arg = $stmt->args[1]->value;
|
2018-01-23 21:46:14 +01:00
|
|
|
|
|
2018-01-30 22:45:29 +01:00
|
|
|
|
if ($second_arg instanceof PhpParser\Node\Scalar\String_
|
2018-01-23 21:46:14 +01:00
|
|
|
|
|| (
|
2018-01-30 22:45:29 +01:00
|
|
|
|
$second_arg instanceof PhpParser\Node\Expr\ClassConstFetch
|
|
|
|
|
&& $second_arg->class instanceof PhpParser\Node\Name
|
2018-04-17 18:16:25 +02:00
|
|
|
|
&& $second_arg->name instanceof PhpParser\Node\Identifier
|
|
|
|
|
&& strtolower($second_arg->name->name) === 'class'
|
2018-01-23 21:46:14 +01:00
|
|
|
|
)
|
|
|
|
|
) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasArrayCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name && strtolower($stmt->name->parts[0]) === 'is_array') {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasStringCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name && strtolower($stmt->name->parts[0]) === 'is_string') {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasBoolCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name && strtolower($stmt->name->parts[0]) === 'is_bool') {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasObjectCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name && $stmt->name->parts === ['is_object']) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasNumericCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name && $stmt->name->parts === ['is_numeric']) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasIntCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name &&
|
|
|
|
|
($stmt->name->parts === ['is_int'] ||
|
2017-05-25 04:07:49 +02:00
|
|
|
|
$stmt->name->parts === ['is_integer'] ||
|
2016-12-28 21:52:44 +01:00
|
|
|
|
$stmt->name->parts === ['is_long'])
|
|
|
|
|
) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasFloatCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name &&
|
|
|
|
|
($stmt->name->parts === ['is_float'] ||
|
|
|
|
|
$stmt->name->parts === ['is_real'] ||
|
|
|
|
|
$stmt->name->parts === ['is_double'])
|
|
|
|
|
) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasResourceCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name && $stmt->name->parts === ['is_resource']) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasScalarCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name && $stmt->name->parts === ['is_scalar']) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-28 21:52:44 +01:00
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasCallableCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name && $stmt->name->parts === ['is_callable']) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
2018-03-18 00:03:46 +01:00
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param PhpParser\Node\Expr\FuncCall $stmt
|
|
|
|
|
*
|
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
|
|
|
|
protected static function hasArrayKeyExistsCheck(PhpParser\Node\Expr\FuncCall $stmt)
|
|
|
|
|
{
|
|
|
|
|
if ($stmt->name instanceof PhpParser\Node\Name && $stmt->name->parts === ['array_key_exists']) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
2016-12-28 21:52:44 +01:00
|
|
|
|
}
|