1
0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 12:55:26 +01:00
psalm/tests/PropertiesOfTest.php

408 lines
14 KiB
PHP
Raw Normal View History

2022-01-09 21:17:42 +01:00
<?php
namespace Psalm\Tests;
use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;
class PropertiesOfTest extends TestCase
{
use ValidCodeAnalysisTestTrait;
use InvalidCodeAnalysisTestTrait;
public function providerValidCodeParse(): iterable
{
return [
'propertiesOfIntersection' => [
'code' => '<?php
interface i {
}
class b {
public int $a = 123;
}
/**
* @psalm-suppress InvalidReturnType
* @return properties-of<$a>
*/
function test1($a) {}
/**
* @psalm-suppress InvalidReturnType
* @return properties-of<i&b>
*/
function test2() {}
/**
* @psalm-suppress InvalidReturnType
* @return properties-of<b&i>
*/
function test3() {}
/** @var i $i */
assert($i instanceof b);
$result1 = test1($i);
$result2 = test2();
$result3 = test3();
',
'assertions' => [
'$result1===' => 'array{a: int, ...<string, mixed>}',
'$result2===' => 'array{a: int, ...<string, mixed>}',
'$result3===' => 'array{a: int, ...<string, mixed>}',
2022-12-18 17:15:15 +01:00
],
],
2022-01-09 21:17:42 +01:00
'publicPropertiesOf' => [
'code' => '<?php
class A {
/** @var bool */
public $foo = false;
/** @var string */
private $bar = "";
/** @var int */
protected $adams = 42;
}
2022-01-09 21:17:42 +01:00
/** @return public-properties-of<A> */
function returnPropertyOfA() {
return ["foo" => true];
}
2022-01-09 21:17:42 +01:00
',
],
'protectedPropertiesOf' => [
'code' => '<?php
class A {
/** @var bool */
public $foo = false;
/** @var string */
private $bar = "";
/** @var int */
protected $adams = 42;
}
2022-01-09 21:17:42 +01:00
/** @return protected-properties-of<A> */
function returnPropertyOfA() {
return ["adams" => 42];
}
2022-01-09 21:17:42 +01:00
',
],
'privatePropertiesOf' => [
'code' => '<?php
class A {
/** @var bool */
public $foo = false;
/** @var string */
private $bar = "";
/** @var int */
protected $adams = 42;
}
2022-01-09 21:17:42 +01:00
/** @return private-properties-of<A> */
function returnPropertyOfA() {
return ["bar" => "foo"];
}
2022-01-09 21:17:42 +01:00
',
],
'allPropertiesOf' => [
'code' => '<?php
class A {
/** @var bool */
public $foo = false;
/** @var string */
private $bar = "";
/** @var int */
protected $adams = 42;
}
2022-01-09 21:17:42 +01:00
/** @return properties-of<A> */
function returnPropertyOfA(int $visibility) {
return [
"foo" => true,
"bar" => "foo",
"adams" => 1
];
2022-01-09 21:17:42 +01:00
}
',
],
Add support for strict arrays, fix type alias intersection, fix array_is_list assertion on non-lists (#8395) * Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
2022-11-05 22:34:42 +01:00
'finalPropertiesOf' => [
'code' => '<?php
class A {
/** @var bool */
public $foo = false;
}
/** @return properties-of<A> */
function returnPropertyOfA() {
return ["foo" => true];
}
',
],
'allPropertiesOfContainsNoStatic' => [
'code' => '<?php
class A {
/** @var bool */
public static $imStatic = true;
/** @var bool */
public $foo = false;
/** @var string */
private $bar = "";
/** @var int */
protected $adams = 42;
}
/** @return properties-of<A> */
function returnPropertyOfA(int $visibility) {
return [
"foo" => true,
"bar" => "foo",
"adams" => 1
];
}
',
],
2022-01-09 21:17:42 +01:00
'usePropertiesOfSelfAsArrayKey' => [
'code' => '<?php
class A {
/** @var int */
public $a = 1;
/** @var int */
public $b = 2;
2022-01-09 21:17:42 +01:00
/** @return properties-of<self> */
public function asArray() {
return [
"a" => $this->a,
"b" => $this->b
];
}
2022-01-09 21:17:42 +01:00
}
',
2022-01-09 21:17:42 +01:00
],
'usePropertiesOfStaticAsArrayKey' => [
'code' => '<?php
class A {
/** @var int */
public $a = 1;
/** @var int */
public $b = 2;
2022-01-09 21:17:42 +01:00
/** @return properties-of<static> */
public function asArray() {
return [
"a" => $this->a,
"b" => $this->b
];
}
2022-01-09 21:17:42 +01:00
}
class B extends A {
/** @var int */
public $c = 3;
2022-01-09 21:17:42 +01:00
public function asArray() {
return [
"a" => $this->a,
"b" => $this->b,
"c" => $this->c,
];
}
2022-01-09 21:17:42 +01:00
}
',
],
'propertiesOfMultipleInheritanceStaticAsArrayKey' => [
'code' => '<?php
class A {
/** @var int */
public $a = 1;
/** @var int */
public $b = 2;
2022-01-09 21:17:42 +01:00
/** @return properties-of<static> */
public function asArray() {
return [
"a" => $this->a,
"b" => $this->b
];
}
2022-01-09 21:17:42 +01:00
}
class B extends A {
/** @var int */
public $c = 3;
}
2022-01-09 21:17:42 +01:00
class C extends B {
/** @var int */
public $d = 4;
2022-01-09 21:17:42 +01:00
public function asArray() {
return [
"a" => $this->a,
"b" => $this->b,
"c" => $this->c,
"d" => $this->d,
];
}
2022-01-09 21:17:42 +01:00
}
',
],
];
}
public function providerInvalidCodeParse(): iterable
{
return [
'onlyOneTemplateParam' => [
'code' => '<?php
class A {}
class B {}
2022-01-09 21:17:42 +01:00
/** @var properties-of<A, B> */
$test = "foobar";
2022-01-09 21:17:42 +01:00
',
'error_message' => 'InvalidDocblock',
],
'propertiesOfPicksNoStatic' => [
'code' => '<?php
class A {
/** @var mixed */
public static $foo;
}
/** @return properties-of<A> */
function returnPropertyOfA() {
return ["foo" => true];
}
',
2022-12-18 17:15:15 +01:00
'error_message' => 'InvalidReturnStatement',
],
2022-01-09 21:17:42 +01:00
'publicPropertiesOfPicksNoPrivate' => [
'code' => '<?php
class A {
/** @var mixed */
public $foo;
/** @var mixed */
private $bar;
/** @var mixed */
protected $adams;
}
2022-01-09 21:17:42 +01:00
/** @return public-properties-of<A> */
function returnPropertyOfA() {
return ["bar" => true];
}
2022-01-09 21:17:42 +01:00
',
2022-12-18 17:15:15 +01:00
'error_message' => 'InvalidReturnStatement',
2022-01-09 21:17:42 +01:00
],
'publicPropertiesOfPicksNoProtected' => [
'code' => '<?php
class A {
/** @var mixed */
public $foo;
/** @var mixed */
private $bar;
/** @var mixed */
protected $adams;
}
2022-01-09 21:17:42 +01:00
/** @return public-properties-of<A> */
function returnPropertyOfA() {
return ["adams" => true];
}
2022-01-09 21:17:42 +01:00
',
2022-12-18 17:15:15 +01:00
'error_message' => 'InvalidReturnStatement',
2022-01-09 21:17:42 +01:00
],
'protectedPropertiesOfPicksNoPublic' => [
'code' => '<?php
class A {
/** @var mixed */
public $foo;
/** @var mixed */
private $bar;
/** @var mixed */
protected $adams;
}
2022-01-09 21:17:42 +01:00
/** @return protected-properties-of<A> */
function returnPropertyOfA() {
return ["foo" => true];
}
2022-01-09 21:17:42 +01:00
',
2022-12-18 17:15:15 +01:00
'error_message' => 'InvalidReturnStatement',
2022-01-09 21:17:42 +01:00
],
'protectedPropertiesOfPicksNoPrivate' => [
'code' => '<?php
class A {
/** @var mixed */
public $foo;
/** @var mixed */
private $bar;
/** @var mixed */
protected $adams;
}
2022-01-09 21:17:42 +01:00
/** @return protected-properties-of<A> */
function returnPropertyOfA() {
return ["bar" => true];
}
2022-01-09 21:17:42 +01:00
',
2022-12-18 17:15:15 +01:00
'error_message' => 'InvalidReturnStatement',
2022-01-09 21:17:42 +01:00
],
'privatePropertiesOfPicksNoPublic' => [
'code' => '<?php
class A {
/** @var mixed */
public $foo;
/** @var mixed */
private $bar;
/** @var mixed */
protected $adams;
}
2022-01-09 21:17:42 +01:00
/** @return private-properties-of<A> */
function returnPropertyOfA() {
return ["foo" => true];
}
2022-01-09 21:17:42 +01:00
',
2022-12-18 17:15:15 +01:00
'error_message' => 'InvalidReturnStatement',
2022-01-09 21:17:42 +01:00
],
'privatePropertiesOfPicksNoProtected' => [
'code' => '<?php
class A {
/** @var mixed */
public $foo;
/** @var mixed */
private $bar;
/** @var mixed */
protected $adams;
}
2022-01-09 21:17:42 +01:00
/** @return private-properties-of<A> */
function returnPropertyOfA() {
return ["adams" => true];
}
2022-01-09 21:17:42 +01:00
',
2022-12-18 17:15:15 +01:00
'error_message' => 'InvalidReturnStatement',
2022-01-09 21:17:42 +01:00
],
Add support for strict arrays, fix type alias intersection, fix array_is_list assertion on non-lists (#8395) * Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
2022-11-05 22:34:42 +01:00
'finalPropertiesOfInexact' => [
'code' => '<?php
final class A {
/** @var bool */
public $foo = false;
/** @var string */
private $bar = "";
/** @var int */
protected $adams = 42;
}
/** @return properties-of<A> */
function returnPropertyOfA() {
return ["foo" => true];
}
',
2022-12-18 17:15:15 +01:00
'error_message' => 'InvalidReturnStatement',
Add support for strict arrays, fix type alias intersection, fix array_is_list assertion on non-lists (#8395) * Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
2022-11-05 22:34:42 +01:00
],
2022-01-09 21:17:42 +01:00
];
}
}