1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-11 08:49:52 +01:00
psalm/src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php

1332 lines
45 KiB
PHP
Raw Normal View History

2016-08-14 05:26:45 +02:00
<?php
2018-11-06 03:57:36 +01:00
namespace Psalm\Internal\Analyzer;
2016-08-14 05:26:45 +02:00
use PhpParser;
2016-10-15 06:12:57 +02:00
use PhpParser\Node\Expr\Closure;
use PhpParser\Node\Stmt\ClassMethod;
2016-11-02 07:29:00 +01:00
use PhpParser\Node\Stmt\Function_;
2018-11-06 03:57:36 +01:00
use Psalm\Codebase;
use Psalm\Internal\Analyzer\FunctionLike\ReturnTypeAnalyzer;
use Psalm\Internal\Analyzer\FunctionLike\ReturnTypeCollector;
use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
use Psalm\Internal\Codebase\CallMap;
use Psalm\CodeLocation;
2016-11-02 07:29:00 +01:00
use Psalm\Context;
use Psalm\Internal\FileManipulation\FunctionDocblockManipulator;
use Psalm\Issue\InvalidParamDefault;
use Psalm\Issue\MismatchingDocblockParamType;
use Psalm\Issue\MissingClosureParamType;
use Psalm\Issue\MissingParamType;
use Psalm\Issue\MissingThrowsDocblock;
use Psalm\Issue\ReservedWord;
use Psalm\Issue\UnusedParam;
2016-11-02 07:29:00 +01:00
use Psalm\IssueBuffer;
2016-08-14 05:26:45 +02:00
use Psalm\StatementsSource;
use Psalm\Storage\FunctionLikeParameter;
2017-09-04 02:52:54 +02:00
use Psalm\Storage\FunctionLikeStorage;
use Psalm\Storage\MethodStorage;
2016-08-14 05:26:45 +02:00
use Psalm\Type;
use Psalm\Type\Atomic\TNamedObject;
2016-08-14 05:26:45 +02:00
/**
* @internal
*/
2018-11-06 03:57:36 +01:00
abstract class FunctionLikeAnalyzer extends SourceAnalyzer implements StatementsSource
2016-08-14 05:26:45 +02:00
{
2016-10-14 06:53:43 +02:00
/**
2016-10-15 06:12:57 +02:00
* @var Closure|Function_|ClassMethod
2016-10-14 06:53:43 +02:00
*/
2016-08-14 05:26:45 +02:00
protected $function;
2016-10-14 06:53:43 +02:00
2018-11-06 03:57:36 +01:00
/**
* @var Codebase
*/
protected $codebase;
2016-10-14 06:53:43 +02:00
/**
2017-01-07 20:35:07 +01:00
* @var array<string>
2016-10-14 06:53:43 +02:00
*/
2017-01-07 20:35:07 +01:00
protected $suppressed_issues;
2016-10-14 06:53:43 +02:00
/**
* @var bool
*/
2016-08-14 05:26:45 +02:00
protected $is_static = false;
2016-10-14 06:53:43 +02:00
/**
* @var StatementsSource
*/
2016-08-14 05:26:45 +02:00
protected $source;
2016-10-14 06:53:43 +02:00
2016-10-15 06:12:57 +02:00
/**
* @var array<string, array<string, Type\Union>>
2016-10-15 06:12:57 +02:00
*/
2016-08-14 05:26:45 +02:00
protected $return_vars_in_scope = [];
2016-10-15 06:12:57 +02:00
/**
* @var array<string, Type\Union>
*/
protected $possible_param_types = [];
2016-10-15 06:12:57 +02:00
/**
2017-12-02 19:32:20 +01:00
* @var array<string, array<string, bool>>
2016-10-15 06:12:57 +02:00
*/
2016-08-14 05:26:45 +02:00
protected $return_vars_possibly_in_scope = [];
2016-11-01 05:39:41 +01:00
2018-01-14 18:09:40 +01:00
/**
* @var Type\Union|null
*/
private $local_return_type;
2016-11-01 05:39:41 +01:00
/**
* @var array<string, bool>
2016-11-01 05:39:41 +01:00
*/
2016-08-14 05:26:45 +02:00
protected static $no_effects_hashes = [];
/**
* @var FunctionLikeStorage $storage
*/
protected $storage;
2016-10-15 06:12:57 +02:00
/**
* @param Closure|Function_|ClassMethod $function
2018-11-06 03:57:36 +01:00
* @param SourceAnalyzer $source
2016-10-15 06:12:57 +02:00
*/
protected function __construct($function, SourceAnalyzer $source, FunctionLikeStorage $storage)
2016-08-14 05:26:45 +02:00
{
$this->function = $function;
$this->source = $source;
$this->suppressed_issues = $source->getSuppressedIssues();
2018-11-06 03:57:36 +01:00
$this->codebase = $source->getCodebase();
$this->storage = $storage;
2016-08-14 05:26:45 +02:00
}
2016-11-02 07:29:00 +01:00
/**
* @param Context $context
* @param Context|null $global_context
2017-01-12 03:37:53 +01:00
* @param bool $add_mutations whether or not to add mutations to this method
2017-05-27 02:16:18 +02:00
*
2016-11-02 07:29:00 +01:00
* @return false|null
*/
2017-01-12 03:37:53 +01:00
public function analyze(Context $context, Context $global_context = null, $add_mutations = false)
2016-08-14 05:26:45 +02:00
{
$storage = $this->storage;
2016-12-07 20:13:39 +01:00
$function_stmts = $this->function->getStmts() ?: [];
2016-09-02 00:02:09 +02:00
2016-12-07 20:13:39 +01:00
$hash = null;
2018-04-25 20:45:51 +02:00
$real_method_id = null;
2016-08-14 05:26:45 +02:00
$cased_method_id = null;
2016-11-02 07:29:00 +01:00
2017-02-10 02:35:17 +01:00
$class_storage = null;
if ($global_context) {
foreach ($global_context->constants as $const_name => $var_type) {
if (!$context->hasVariable($const_name)) {
$context->vars_in_scope[$const_name] = clone $var_type;
}
}
}
2018-11-06 03:57:36 +01:00
$codebase = $this->codebase;
2018-11-11 18:01:14 +01:00
$project_analyzer = $this->getProjectAnalyzer();
$implemented_docblock_param_types = [];
2018-11-06 03:57:36 +01:00
$classlike_storage_provider = $codebase->classlike_storage_provider;
if ($this->function instanceof ClassMethod) {
if (!$storage instanceof MethodStorage) {
throw new \UnexpectedValueException('$storage must be MethodStorage');
}
2017-01-12 06:54:41 +01:00
$real_method_id = (string)$this->getMethodId();
$method_id = (string)$this->getMethodId($context->self);
2017-01-12 03:37:53 +01:00
if ($add_mutations) {
$hash = md5($real_method_id . '::' . $context->getScopeSummary());
2016-08-14 05:26:45 +02:00
2016-12-07 20:13:39 +01:00
// if we know that the function has no effects on vars, we don't bother rechecking
if (isset(self::$no_effects_hashes[$hash])) {
return null;
2016-11-07 05:29:54 +01:00
}
2016-12-07 20:13:39 +01:00
} elseif ($context->self) {
$context->vars_in_scope['$this'] = new Type\Union([new TNamedObject($context->self)]);
2017-02-08 08:23:17 +01:00
$context->vars_possibly_in_scope['$this'] = true;
2016-12-07 20:13:39 +01:00
}
2016-11-07 05:29:54 +01:00
$fq_class_name = (string)$context->self;
2016-11-05 03:04:55 +01:00
$class_storage = $classlike_storage_provider->get($fq_class_name);
if ($class_storage->has_visitor_issues) {
return null;
}
$cased_method_id = $fq_class_name . '::' . $storage->cased_name;
2018-02-04 00:52:35 +01:00
$overridden_method_ids = $codebase->methods->getOverriddenMethodIds($method_id);
if ($this->function->name->name === '__construct') {
$context->inside_constructor = true;
}
$codeLocation = new CodeLocation(
$this,
$this->function,
null,
true
);
if ($overridden_method_ids
&& $this->function->name->name !== '__construct'
&& !$context->collect_initializations
&& !$context->collect_mutations
) {
foreach ($overridden_method_ids as $overridden_method_id) {
2018-02-04 00:52:35 +01:00
$parent_method_storage = $codebase->methods->getStorage($overridden_method_id);
list($overridden_fq_class_name) = explode('::', $overridden_method_id);
2016-12-07 20:13:39 +01:00
$parent_storage = $classlike_storage_provider->get($overridden_fq_class_name);
2016-12-07 20:13:39 +01:00
$implementer_visibility = $storage->visibility;
$implementer_appearing_method_id = $codebase->methods->getAppearingMethodId($cased_method_id);
$implementer_declaring_method_id = $real_method_id;
if ($implementer_appearing_method_id
&& $implementer_appearing_method_id !== $implementer_declaring_method_id
) {
list($appearing_fq_class_name, $appearing_method_name) = explode(
'::',
$implementer_appearing_method_id
);
$appearing_class_storage = $classlike_storage_provider->get(
$appearing_fq_class_name
);
if (isset($appearing_class_storage->trait_visibility_map[$appearing_method_name])) {
$implementer_visibility
= $appearing_class_storage->trait_visibility_map[$appearing_method_name];
}
}
// we've already checked this in the class checker
if (!isset($class_storage->class_implements[strtolower($overridden_fq_class_name)])) {
MethodAnalyzer::compareMethods(
$codebase,
$class_storage,
$parent_storage,
$storage,
$parent_method_storage,
$fq_class_name,
$implementer_visibility,
$codeLocation,
$storage->suppressed_issues
);
}
foreach ($parent_method_storage->params as $i => $guide_param) {
2018-12-21 17:01:24 +01:00
if ($guide_param->type
&& (!$guide_param->signature_type
|| ($guide_param->signature_type !== $guide_param->type
&& $storage->inheritdoc)
|| !$parent_storage->user_defined
)
) {
if (!isset($implemented_docblock_param_types[$i])) {
$implemented_docblock_param_types[$i] = $guide_param->type;
}
}
}
}
2016-12-07 20:13:39 +01:00
}
2018-11-06 03:57:36 +01:00
MethodAnalyzer::checkMethodSignatureMustOmitReturnType($storage, $codeLocation);
$context->calling_method_id = strtolower($method_id);
} elseif ($this->function instanceof Function_) {
$cased_method_id = $this->function->name;
} else { // Closure
if ($storage->return_type) {
2018-11-06 03:57:36 +01:00
$closure_return_type = ExpressionAnalyzer::fleshOutType(
$codebase,
$storage->return_type,
$context->self,
2018-01-26 19:51:00 +01:00
$context->self
);
} else {
$closure_return_type = Type::getMixed();
}
2016-12-15 01:19:25 +01:00
/** @var PhpParser\Node\Expr\Closure $this->function */
2016-12-07 20:13:39 +01:00
$this->function->inferredType = new Type\Union([
new Type\Atomic\Fn(
2016-12-07 20:13:39 +01:00
'Closure',
$storage->params,
$closure_return_type
2017-05-27 02:05:57 +02:00
),
2016-12-07 20:13:39 +01:00
]);
}
2016-09-02 00:02:09 +02:00
$this->suppressed_issues = array_merge(
$this->getSource()->getSuppressedIssues(),
$storage->suppressed_issues
);
if ($storage instanceof MethodStorage && $storage->is_static) {
$this->is_static = true;
}
2018-11-11 18:01:14 +01:00
$statements_analyzer = new StatementsAnalyzer($this);
2017-02-10 02:35:17 +01:00
$template_types = $storage->template_types;
if ($class_storage && $class_storage->template_types) {
$template_types = array_merge($template_types ?: [], $class_storage->template_types);
}
2019-01-31 23:48:48 +01:00
if ($storage instanceof MethodStorage && $storage->inheritdoc) {
$non_null_param_types = array_filter(
$storage->params,
/** @return bool */
function (FunctionLikeParameter $p) {
return $p->type !== null && $p->has_docblock_type;
}
);
} else {
$non_null_param_types = array_filter(
$storage->params,
/** @return bool */
function (FunctionLikeParameter $p) {
return $p->type !== null;
}
);
}
$check_stmts = true;
foreach ($storage->params as $offset => $function_param) {
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
$signature_type = $function_param->signature_type;
$signature_type_location = $function_param->signature_type_location;
if ($signature_type && $signature_type_location) {
list($start, $end) = $signature_type_location->getSelectionBounds();
$codebase->analyzer->addOffsetReference(
$this->getFilePath(),
$start,
$end,
(string) $signature_type
);
}
2018-02-01 05:27:25 +01:00
if ($function_param->type) {
if ($function_param->type_location) {
if ($function_param->type->check(
$this,
$function_param->type_location,
$storage->suppressed_issues,
[],
false
) === false) {
$check_stmts = false;
}
}
2018-12-21 17:01:24 +01:00
$is_signature_type = $function_param->type === $function_param->signature_type;
if ($is_signature_type
&& $storage instanceof MethodStorage
&& $storage->inheritdoc
&& isset($implemented_docblock_param_types[$offset])
) {
$param_type = clone $implemented_docblock_param_types[$offset];
} else {
$param_type = clone $function_param->type;
}
2018-11-06 03:57:36 +01:00
$param_type = ExpressionAnalyzer::fleshOutType(
$codebase,
$param_type,
$context->self,
2018-01-26 19:51:00 +01:00
$context->self
);
} else {
if (!$non_null_param_types && isset($implemented_docblock_param_types[$offset])) {
$param_type = clone $implemented_docblock_param_types[$offset];
2018-11-06 03:57:36 +01:00
$param_type = ExpressionAnalyzer::fleshOutType(
$codebase,
$param_type,
$context->self,
$context->self
);
} else {
$param_type = Type::getMixed();
}
}
2017-07-09 03:19:16 +02:00
$context->vars_in_scope['$' . $function_param->name] = $param_type;
$context->vars_possibly_in_scope['$' . $function_param->name] = true;
if ($context->collect_references && $function_param->location) {
2018-06-17 02:01:33 +02:00
$context->unreferenced_vars['$' . $function_param->name] = [
$function_param->location->getHash() => $function_param->location
];
}
2017-12-30 03:28:21 +01:00
if (!$function_param->type_location || !$function_param->location) {
2017-07-09 03:19:16 +02:00
continue;
2016-12-07 20:13:39 +01:00
}
/**
* @psalm-suppress MixedArrayAccess
*
* @var PhpParser\Node\Param
*/
$parser_param = $this->function->getParams()[$offset];
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
if ($signature_type) {
2018-11-06 03:57:36 +01:00
if (!TypeAnalyzer::isContainedBy(
2018-06-09 05:54:07 +02:00
$codebase,
$param_type,
$signature_type,
false,
false,
$has_scalar_match,
$type_coerced,
$type_coerced_from_mixed
) && !$type_coerced_from_mixed
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
) {
2018-11-06 03:57:36 +01:00
if ($codebase->alter_code
2018-11-11 18:01:14 +01:00
&& isset($project_analyzer->getIssuesToFix()['MismatchingDocblockParamType'])
2018-01-07 16:23:02 +01:00
) {
2018-11-11 18:01:14 +01:00
$this->addOrUpdateParamType($project_analyzer, $function_param->name, $signature_type, true);
2018-01-07 16:23:02 +01:00
2018-01-07 18:53:25 +01:00
continue;
2018-01-07 16:23:02 +01:00
}
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
if (IssueBuffer::accepts(
new MismatchingDocblockParamType(
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
'Parameter $' . $function_param->name . ' has wrong type \'' . $param_type .
'\', should be \'' . $signature_type . '\'',
$function_param->type_location
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
),
$storage->suppressed_issues
)) {
return false;
}
if ($signature_type->check(
2018-01-10 04:46:55 +01:00
$this,
$function_param->type_location,
$storage->suppressed_issues,
[],
false
) === false) {
$check_stmts = false;
}
2018-01-10 04:46:55 +01:00
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
continue;
}
}
if ($parser_param->default) {
2018-11-11 18:01:14 +01:00
ExpressionAnalyzer::analyze($statements_analyzer, $parser_param->default, $context);
$default_type = isset($parser_param->default->inferredType)
? $parser_param->default->inferredType
: null;
2018-03-21 04:55:26 +01:00
if ($default_type
&& !$default_type->hasMixed()
2018-11-06 03:57:36 +01:00
&& !TypeAnalyzer::isContainedBy(
2018-02-01 06:50:01 +01:00
$codebase,
$default_type,
$param_type
)
) {
if (IssueBuffer::accepts(
new InvalidParamDefault(
2018-03-21 04:55:26 +01:00
'Default value type ' . $default_type . ' for argument ' . ($offset + 1)
. ' of method ' . $cased_method_id
. ' does not match the given type ' . $param_type,
2017-12-30 03:28:21 +01:00
$function_param->type_location
)
)) {
2016-12-31 06:14:00 +01:00
// fall through
}
}
}
2017-02-10 02:35:17 +01:00
if ($template_types) {
2017-02-10 06:14:44 +01:00
$substituted_type = clone $param_type;
if ($substituted_type->check(
2017-12-30 03:28:21 +01:00
$this->source,
$function_param->type_location,
$this->suppressed_issues,
[],
false
) === false) {
$check_stmts = false;
}
2017-02-10 02:35:17 +01:00
} else {
if ($param_type->isVoid()) {
if (IssueBuffer::accepts(
new ReservedWord(
'Parameter cannot be void',
$function_param->type_location,
'void'
),
$this->suppressed_issues
)) {
// fall through
}
}
if ($param_type->check(
$this->source,
$function_param->type_location,
$this->suppressed_issues,
[],
false
) === false) {
$check_stmts = false;
}
2017-03-02 00:36:04 +01:00
}
if ($codebase->collect_references) {
2017-12-30 03:28:21 +01:00
if ($function_param->type_location !== $function_param->signature_type_location &&
$function_param->signature_type_location &&
2017-03-02 00:36:04 +01:00
$function_param->signature_type
) {
if ($function_param->signature_type->check(
2017-03-02 00:36:04 +01:00
$this->source,
2017-12-30 03:28:21 +01:00
$function_param->signature_type_location,
$this->suppressed_issues,
[],
false
) === false) {
$check_stmts = false;
}
2017-03-02 00:36:04 +01:00
}
2017-02-10 02:35:17 +01:00
}
2016-09-02 00:02:09 +02:00
if ($function_param->by_ref) {
$context->byref_constraints['$' . $function_param->name]
= new \Psalm\Internal\ReferenceConstraint(!$param_type->hasMixed() ? $param_type : null);
}
2017-02-08 08:23:17 +01:00
if ($function_param->by_ref) {
// register by ref params as having been used, to avoid false positives
// @todo change the assignment analysis *just* for byref params
// so that we don't have to do this
$context->hasVariable('$' . $function_param->name);
}
2016-09-02 00:02:09 +02:00
2018-11-11 18:01:14 +01:00
$statements_analyzer->registerVariable(
2017-02-08 08:23:17 +01:00
'$' . $function_param->name,
$function_param->location,
null
2016-12-07 20:13:39 +01:00
);
}
2016-08-14 05:26:45 +02:00
if (ReturnTypeAnalyzer::checkReturnType(
2018-02-22 00:59:31 +01:00
$this->function,
2018-11-11 18:01:14 +01:00
$project_analyzer,
2018-02-22 00:59:31 +01:00
$this,
$storage,
$context
) === false) {
$check_stmts = false;
}
if (!$check_stmts) {
2018-02-22 00:59:31 +01:00
return false;
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
}
if ($context->collect_initializations) {
$statements_analyzer->addSuppressedIssues([
'DocblockTypeContradiction',
2019-02-19 03:31:08 +01:00
'InvalidReturnStatement',
'RedundantCondition',
'RedundantConditionGivenDocblockType',
2019-02-19 03:31:08 +01:00
'TypeDoesNotContainNull',
'TypeDoesNotContainType',
]);
}
2018-11-11 18:01:14 +01:00
$statements_analyzer->analyze($function_stmts, $context, $global_context, true);
2016-08-14 05:26:45 +02:00
$this->addPossibleParamTypes($context, $codebase);
foreach ($storage->params as $offset => $function_param) {
// only complain if there's no type defined by a parent type
if (!$function_param->type
&& $function_param->location
&& !isset($implemented_docblock_param_types[$offset])
) {
if ($codebase->alter_code
&& isset($project_analyzer->getIssuesToFix()['MissingParamType'])
) {
$possible_type = $this->possible_param_types[$function_param->name] ?? null;
if (!$possible_type || $possible_type->hasMixed() || $possible_type->isNull()) {
continue;
}
self::addOrUpdateParamType(
$project_analyzer,
$function_param->name,
$possible_type
);
continue;
}
if ($this->function instanceof Closure) {
IssueBuffer::accepts(
new MissingClosureParamType(
'Parameter $' . $function_param->name . ' has no provided type',
$function_param->location
),
array_merge($this->suppressed_issues, $storage->suppressed_issues)
);
} else {
IssueBuffer::accepts(
new MissingParamType(
'Parameter $' . $function_param->name . ' has no provided type',
$function_param->location
),
array_merge($this->suppressed_issues, $storage->suppressed_issues)
);
}
}
}
if ($storage->signature_return_type && $storage->signature_return_type_location) {
list($start, $end) = $storage->signature_return_type_location->getSelectionBounds();
$codebase->analyzer->addOffsetReference(
$this->getFilePath(),
$start,
$end,
(string) $storage->signature_return_type
);
}
2016-12-07 20:13:39 +01:00
if ($this->function instanceof Closure) {
$this->verifyReturnType(
2018-11-11 18:01:14 +01:00
$statements_analyzer,
$storage->return_type,
2017-01-07 20:35:07 +01:00
$this->source->getFQCLN(),
$storage->return_type_location
2016-12-07 20:13:39 +01:00
);
$closure_yield_types = [];
$ignore_nullable_issues = false;
$ignore_falsable_issues = false;
$closure_return_types = ReturnTypeCollector::getReturnTypes(
$this->function->stmts,
$closure_yield_types,
$ignore_nullable_issues,
$ignore_falsable_issues,
true
);
if ($closure_return_types) {
$closure_return_type = new Type\Union($closure_return_types);
if (!$storage->return_type
|| $storage->return_type->hasMixed()
2018-11-06 03:57:36 +01:00
|| TypeAnalyzer::isContainedBy(
$codebase,
$closure_return_type,
2018-04-10 04:00:36 +02:00
$storage->return_type
)
) {
if ($this->function->inferredType) {
/** @var Type\Atomic\Fn */
$closure_atomic = $this->function->inferredType->getTypes()['Closure'];
$closure_atomic->return_type = $closure_return_type;
}
2016-08-14 05:26:45 +02:00
}
}
2016-12-07 20:13:39 +01:00
}
2016-08-14 05:26:45 +02:00
if ($context->collect_references
&& !$context->collect_initializations
2018-11-06 03:57:36 +01:00
&& $codebase->find_unused_code
&& $context->check_variables
) {
2018-11-11 18:01:14 +01:00
foreach ($statements_analyzer->getUnusedVarLocations() as list($var_name, $original_location)) {
if (!array_key_exists(substr($var_name, 1), $storage->param_types)) {
continue;
}
if (strpos($var_name, '$_') === 0 || (strpos($var_name, '$unused') === 0 && $var_name !== '$unused')) {
continue;
}
$position = array_search(substr($var_name, 1), array_keys($storage->param_types), true);
if ($position === false) {
throw new \UnexpectedValueException('$position should not be false here');
}
if ($storage->params[$position]->by_ref) {
continue;
}
if (!($storage instanceof MethodStorage)
2018-11-06 03:57:36 +01:00
|| $storage->visibility === ClassLikeAnalyzer::VISIBILITY_PRIVATE
) {
if (IssueBuffer::accepts(
new UnusedParam(
'Param ' . $var_name . ' is never referenced in this method',
$original_location
),
$this->getSuppressedIssues()
)) {
// fall through
}
} else {
$fq_class_name = (string)$context->self;
$class_storage = $codebase->classlike_storage_provider->get($fq_class_name);
$method_name_lc = strtolower($storage->cased_name);
if ($storage->abstract || !isset($class_storage->overridden_method_ids[$method_name_lc])) {
continue;
}
$parent_method_id = end($class_storage->overridden_method_ids[$method_name_lc]);
if ($parent_method_id) {
2018-02-04 00:52:35 +01:00
$parent_method_storage = $codebase->methods->getStorage($parent_method_id);
// if the parent method has a param at that position and isn't abstract
if (!$parent_method_storage->abstract
&& isset($parent_method_storage->params[$position])
) {
continue;
}
}
$storage->unused_params[$position] = $original_location;
}
}
if ($storage instanceof MethodStorage && $class_storage) {
foreach ($storage->params as $i => $_) {
if (!isset($storage->unused_params[$i])) {
$storage->used_params[$i] = true;
/** @var ClassMethod $this->function */
$method_name_lc = strtolower($storage->cased_name);
if (!isset($class_storage->overridden_method_ids[$method_name_lc])) {
continue;
}
foreach ($class_storage->overridden_method_ids[$method_name_lc] as $parent_method_id) {
2018-02-04 00:52:35 +01:00
$parent_method_storage = $codebase->methods->getStorage($parent_method_id);
$parent_method_storage->used_params[$i] = true;
2017-02-08 00:18:33 +01:00
}
}
}
}
}
if ($context->collect_exceptions) {
if ($context->possibly_thrown_exceptions) {
$ignored_exceptions = array_change_key_case(
$codebase->config->ignored_exceptions
);
$ignored_exceptions_and_descendants = array_change_key_case(
$codebase->config->ignored_exceptions_and_descendants
);
2018-06-22 07:26:10 +02:00
$undocumented_throws = [];
foreach ($context->possibly_thrown_exceptions as $possibly_thrown_exception => $_) {
$is_expected = false;
foreach ($storage->throws as $expected_exception => $_) {
if ($expected_exception === $possibly_thrown_exception
|| $codebase->classExtends($possibly_thrown_exception, $expected_exception)
) {
$is_expected = true;
break;
}
}
foreach ($ignored_exceptions_and_descendants as $expected_exception => $_) {
if ($expected_exception === $possibly_thrown_exception
|| $codebase->classExtends($possibly_thrown_exception, $expected_exception)
) {
$is_expected = true;
break;
}
}
if (!$is_expected) {
$undocumented_throws[$possibly_thrown_exception] = true;
}
}
foreach ($undocumented_throws as $possibly_thrown_exception => $_) {
2018-06-22 07:26:10 +02:00
if (isset($ignored_exceptions[strtolower($possibly_thrown_exception)])) {
continue;
}
if (IssueBuffer::accepts(
new MissingThrowsDocblock(
$possibly_thrown_exception . ' is thrown but not caught - please either catch'
. ' or add a @throws annotation',
new CodeLocation(
$this,
$this->function,
null,
true
)
),
$this->getSuppressedIssues()
)) {
// fall through
}
}
}
}
2017-01-12 03:37:53 +01:00
if ($add_mutations) {
if (isset($this->return_vars_in_scope[''])) {
2018-11-06 03:57:36 +01:00
$context->vars_in_scope = TypeAnalyzer::combineKeyedTypes(
2017-01-12 03:37:53 +01:00
$context->vars_in_scope,
$this->return_vars_in_scope['']
);
}
2016-12-07 20:13:39 +01:00
2017-01-12 03:37:53 +01:00
if (isset($this->return_vars_possibly_in_scope[''])) {
$context->vars_possibly_in_scope = array_merge(
$context->vars_possibly_in_scope,
$this->return_vars_possibly_in_scope['']
);
}
2016-12-07 20:13:39 +01:00
2017-02-11 01:10:13 +01:00
foreach ($context->vars_in_scope as $var => $_) {
if (strpos($var, '$this->') !== 0 && $var !== '$this') {
2017-01-12 03:37:53 +01:00
unset($context->vars_in_scope[$var]);
}
2016-08-14 05:26:45 +02:00
}
2017-02-11 01:10:13 +01:00
foreach ($context->vars_possibly_in_scope as $var => $_) {
if (strpos($var, '$this->') !== 0 && $var !== '$this') {
2017-01-12 03:37:53 +01:00
unset($context->vars_possibly_in_scope[$var]);
}
2016-08-14 05:26:45 +02:00
}
2016-11-02 07:29:00 +01:00
2018-11-06 03:57:36 +01:00
if ($hash && $real_method_id && $this instanceof MethodAnalyzer) {
$new_hash = md5($real_method_id . '::' . $context->getScopeSummary());
if ($new_hash === $hash) {
self::$no_effects_hashes[$hash] = true;
}
2017-01-12 03:37:53 +01:00
}
2016-12-07 20:13:39 +01:00
}
2016-11-02 07:29:00 +01:00
return null;
2016-08-14 05:26:45 +02:00
}
/**
2018-02-22 00:59:31 +01:00
* @param Type\Union|null $return_type
* @param string $fq_class_name
* @param CodeLocation|null $return_type_location
*
2018-02-22 00:59:31 +01:00
* @return false|null
*/
2018-02-22 00:59:31 +01:00
public function verifyReturnType(
2018-11-11 18:01:14 +01:00
StatementsAnalyzer $statements_analyzer,
2018-02-22 00:59:31 +01:00
Type\Union $return_type = null,
$fq_class_name = null,
CodeLocation $return_type_location = null
) {
2018-11-06 03:57:36 +01:00
ReturnTypeAnalyzer::verifyReturnType(
2018-02-22 00:59:31 +01:00
$this->function,
2018-11-11 18:01:14 +01:00
$statements_analyzer,
2018-02-22 00:59:31 +01:00
$this,
$return_type,
$fq_class_name,
$return_type_location
);
}
2018-02-22 00:59:31 +01:00
/**
* @param string $param_name
* @param bool $docblock_only
*
* @return void
*/
private function addOrUpdateParamType(
2018-11-11 18:01:14 +01:00
ProjectAnalyzer $project_analyzer,
2018-02-22 00:59:31 +01:00
$param_name,
Type\Union $inferred_return_type,
$docblock_only = false
) {
$manipulator = FunctionDocblockManipulator::getForFunction(
2018-11-11 18:01:14 +01:00
$project_analyzer,
2018-02-22 00:59:31 +01:00
$this->source->getFilePath(),
$this->getMethodId(),
$this->function
);
$manipulator->setParamType(
$param_name,
!$docblock_only && $project_analyzer->getCodebase()->php_major_version >= 7
2018-02-22 00:59:31 +01:00
? $inferred_return_type->toPhpString(
$this->source->getNamespace(),
$this->source->getAliasedClassesFlipped(),
$this->source->getFQCLN(),
$project_analyzer->getCodebase()->php_major_version,
$project_analyzer->getCodebase()->php_minor_version
2018-02-22 00:59:31 +01:00
) : null,
$inferred_return_type->toNamespacedString(
$this->source->getNamespace(),
$this->source->getAliasedClassesFlipped(),
$this->source->getFQCLN(),
false
),
$inferred_return_type->toNamespacedString(
$this->source->getNamespace(),
$this->source->getAliasedClassesFlipped(),
$this->source->getFQCLN(),
true
),
$inferred_return_type->canBeFullyExpressedInPhp()
);
}
2016-08-14 05:26:45 +02:00
/**
* Adds return types for the given function
2016-11-02 07:29:00 +01:00
*
* @param string $return_type
* @param Context $context
2017-05-27 02:16:18 +02:00
*
2016-11-02 07:29:00 +01:00
* @return void
2016-08-14 05:26:45 +02:00
*/
public function addReturnTypes($return_type, Context $context)
{
if (isset($this->return_vars_in_scope[$return_type])) {
2018-11-06 03:57:36 +01:00
$this->return_vars_in_scope[$return_type] = TypeAnalyzer::combineKeyedTypes(
2016-11-02 07:29:00 +01:00
$context->vars_in_scope,
$this->return_vars_in_scope[$return_type]
);
} else {
2016-08-14 05:26:45 +02:00
$this->return_vars_in_scope[$return_type] = $context->vars_in_scope;
}
if (isset($this->return_vars_possibly_in_scope[$return_type])) {
2016-11-02 07:29:00 +01:00
$this->return_vars_possibly_in_scope[$return_type] = array_merge(
$context->vars_possibly_in_scope,
$this->return_vars_possibly_in_scope[$return_type]
);
} else {
2016-08-14 05:26:45 +02:00
$this->return_vars_possibly_in_scope[$return_type] = $context->vars_possibly_in_scope;
}
}
/**
* @return void
*/
public function addPossibleParamTypes(Context $context, Codebase $codebase)
{
if ($context->infer_types) {
foreach ($context->possible_param_types as $var_id => $type) {
if (isset($this->possible_param_types[$var_id])) {
$this->possible_param_types[$var_id] = Type::combineUnionTypes(
$this->possible_param_types[$var_id],
$type,
$codebase
);
} else {
$this->possible_param_types[$var_id] = clone $type;
}
}
}
}
/**
* @return null|string
*/
public function getMethodName()
{
if ($this->function instanceof ClassMethod) {
return (string)$this->function->name;
}
}
2016-08-14 05:26:45 +02:00
/**
* @param string|null $context_self
2017-05-27 02:16:18 +02:00
*
* @return string
2016-08-14 05:26:45 +02:00
*/
public function getMethodId($context_self = null)
2016-08-14 05:26:45 +02:00
{
2016-11-21 03:49:06 +01:00
if ($this->function instanceof ClassMethod) {
$function_name = (string)$this->function->name;
2016-11-21 20:36:06 +01:00
2017-01-07 20:35:07 +01:00
return ($context_self ?: $this->source->getFQCLN()) . '::' . strtolower($function_name);
2016-11-21 03:49:06 +01:00
}
if ($this->function instanceof Function_) {
$namespace = $this->source->getNamespace();
return ($namespace ? strtolower($namespace) . '\\' : '') . strtolower($this->function->name->name);
2016-08-14 05:26:45 +02:00
}
2016-11-02 07:29:00 +01:00
return $this->getFilePath()
. ':' . $this->function->getLine()
. ':' . (int)$this->function->getAttribute('startFilePos')
. ':-:closure';
2016-08-14 05:26:45 +02:00
}
/**
* @param string|null $context_self
*
* @return string
*/
public function getCorrectlyCasedMethodId($context_self = null)
{
if ($this->function instanceof ClassMethod) {
$function_name = (string)$this->function->name;
return ($context_self ?: $this->source->getFQCLN()) . '::' . $function_name;
}
if ($this->function instanceof Function_) {
$namespace = $this->source->getNamespace();
return ($namespace ? $namespace . '\\' : '') . $this->function->name;
}
return $this->getMethodId();
}
2017-09-04 02:52:54 +02:00
/**
* @return FunctionLikeStorage
*/
2018-11-11 18:01:14 +01:00
public function getFunctionLikeStorage(StatementsAnalyzer $statements_analyzer = null)
2017-09-04 02:52:54 +02:00
{
2018-11-06 03:57:36 +01:00
$codebase = $this->codebase;
2017-09-04 02:52:54 +02:00
if ($this->function instanceof ClassMethod) {
$method_id = (string) $this->getMethodId();
2018-02-04 00:52:35 +01:00
$codebase_methods = $codebase->methods;
try {
2018-02-04 00:52:35 +01:00
return $codebase_methods->getStorage($method_id);
} catch (\UnexpectedValueException $e) {
$declaring_method_id = $codebase_methods->getDeclaringMethodId($method_id);
if (!$declaring_method_id) {
throw new \UnexpectedValueException('Cannot get storage for function that doesnt exist');
}
2017-09-04 02:52:54 +02:00
// happens for fake constructors
2018-02-04 00:52:35 +01:00
return $codebase_methods->getStorage($declaring_method_id);
2017-09-04 02:52:54 +02:00
}
}
2018-11-11 18:01:14 +01:00
return $codebase->functions->getStorage($statements_analyzer, (string) $this->getMethodId());
2017-09-04 02:52:54 +02:00
}
2016-11-13 00:51:48 +01:00
/**
* @return array<string, string>
*/
public function getAliasedClassesFlipped()
{
2018-11-06 03:57:36 +01:00
if ($this->source instanceof NamespaceAnalyzer ||
$this->source instanceof FileAnalyzer ||
$this->source instanceof ClassLikeAnalyzer
) {
2016-11-13 17:24:46 +01:00
return $this->source->getAliasedClassesFlipped();
}
return [];
2016-11-13 00:51:48 +01:00
}
2016-11-02 07:29:00 +01:00
/**
2017-01-07 20:35:07 +01:00
* @return string|null
2016-11-02 07:29:00 +01:00
*/
2016-11-08 01:16:51 +01:00
public function getFQCLN()
2016-08-14 05:26:45 +02:00
{
2017-01-07 20:35:07 +01:00
return $this->source->getFQCLN();
2016-08-14 05:26:45 +02:00
}
2016-11-02 07:29:00 +01:00
/**
* @return null|string
*/
2016-08-14 05:26:45 +02:00
public function getClassName()
{
2017-01-07 20:35:07 +01:00
return $this->source->getClassName();
2016-08-14 05:26:45 +02:00
}
/**
* @return array<string,array{Type\Union, ?string}>|null
*/
public function getTemplateTypeMap()
{
if ($this->source instanceof ClassLikeAnalyzer) {
return ($this->source->getTemplateTypeMap() ?: [])
+ ($this->storage->template_types ?: []);
}
return $this->storage->template_types;
}
/**
* @return string|null
*/
2017-01-07 20:35:07 +01:00
public function getParentFQCLN()
2016-08-14 05:26:45 +02:00
{
2017-01-07 20:35:07 +01:00
return $this->source->getParentFQCLN();
2016-08-14 05:26:45 +02:00
}
2016-11-02 07:29:00 +01:00
/**
* @return bool
*/
2016-08-14 05:26:45 +02:00
public function isStatic()
{
return $this->is_static;
}
2016-10-15 06:12:57 +02:00
/**
* @return StatementsSource
*/
2016-08-14 05:26:45 +02:00
public function getSource()
{
return $this->source;
}
2018-11-06 03:57:36 +01:00
public function getCodebase() : Codebase
{
return $this->codebase;
}
/**
2016-12-17 06:48:31 +01:00
* @param string $method_id
* @param array<int, PhpParser\Node\Arg> $args
2017-05-27 02:16:18 +02:00
*
* @return array<int, FunctionLikeParameter>
*/
public static function getMethodParamsById(Codebase $codebase, $method_id, array $args)
2016-08-22 21:00:12 +02:00
{
$fq_class_name = strpos($method_id, '::') !== false ? explode('::', $method_id)[0] : null;
2018-02-01 05:27:25 +01:00
if ($fq_class_name) {
$fq_class_name = $codebase->classlikes->getUnAliasedName($fq_class_name);
2018-11-06 03:57:36 +01:00
$class_storage = $codebase->classlike_storage_provider->get($fq_class_name);
2018-02-01 05:27:25 +01:00
if ($class_storage->user_defined || $class_storage->stubbed) {
2018-02-04 00:52:35 +01:00
$method_params = $codebase->methods->getMethodParams($method_id);
2018-02-01 05:27:25 +01:00
return $method_params;
}
}
2018-02-04 00:52:35 +01:00
$declaring_method_id = $codebase->methods->getDeclaringMethodId($method_id);
2018-02-04 00:52:35 +01:00
if (CallMap::inCallMap($declaring_method_id ?: $method_id)) {
$function_param_options = CallMap::getParamsFromCallMap($declaring_method_id ?: $method_id);
2016-12-23 21:06:20 +01:00
if ($function_param_options === null) {
throw new \UnexpectedValueException(
'Not expecting $function_param_options to be null for ' . $method_id
);
2016-12-23 21:06:20 +01:00
}
2016-11-07 05:29:54 +01:00
return self::getMatchingParamsFromCallMapOptions($codebase, $function_param_options, $args);
}
2016-12-23 21:06:20 +01:00
2018-02-04 00:52:35 +01:00
return $codebase->methods->getMethodParams($method_id);
}
/**
* @param string $method_id
* @param array<int, PhpParser\Node\Arg> $args
2017-05-27 02:16:18 +02:00
*
* @return array<int, FunctionLikeParameter>
*/
public static function getFunctionParamsFromCallMapById(Codebase $codebase, $method_id, array $args)
{
2018-02-04 00:52:35 +01:00
$function_param_options = CallMap::getParamsFromCallMap($method_id);
2017-02-10 02:35:17 +01:00
if ($function_param_options === null) {
throw new \UnexpectedValueException(
'Not expecting $function_param_options to be null for ' . $method_id
);
2016-08-22 21:00:12 +02:00
}
return self::getMatchingParamsFromCallMapOptions($codebase, $function_param_options, $args);
}
2017-05-25 04:07:49 +02:00
/**
* @param array<int, array<int, FunctionLikeParameter>> $function_param_options
* @param array<int, PhpParser\Node\Arg> $args
2017-05-27 02:16:18 +02:00
*
* @return array<int, FunctionLikeParameter>
*/
protected static function getMatchingParamsFromCallMapOptions(
Codebase $codebase,
array $function_param_options,
array $args
) {
2016-08-22 21:00:12 +02:00
if (count($function_param_options) === 1) {
return $function_param_options[0];
}
foreach ($function_param_options as $possible_function_params) {
$all_args_match = true;
2016-11-02 07:29:00 +01:00
$last_param = count($possible_function_params)
? $possible_function_params[count($possible_function_params) - 1]
: null;
2016-10-26 17:51:59 +02:00
$mandatory_param_count = count($possible_function_params);
foreach ($possible_function_params as $i => $possible_function_param) {
if ($possible_function_param->is_optional) {
$mandatory_param_count = $i;
break;
}
}
if ($mandatory_param_count > count($args)) {
continue;
}
2016-08-22 21:00:12 +02:00
foreach ($args as $argument_offset => $arg) {
if ($argument_offset >= count($possible_function_params)) {
if (!$last_param || !$last_param->is_variadic) {
$all_args_match = false;
}
2016-08-22 21:00:12 +02:00
break;
}
$param_type = $possible_function_params[$argument_offset]->type;
2016-08-22 21:00:12 +02:00
if (!$param_type) {
continue;
}
2016-08-22 21:00:12 +02:00
if (!isset($arg->value->inferredType)) {
continue;
}
if ($arg->value->inferredType->hasMixed()) {
2016-10-11 04:49:43 +02:00
continue;
}
2018-11-06 03:57:36 +01:00
if (TypeAnalyzer::isContainedBy(
$codebase,
$arg->value->inferredType,
$param_type,
true,
true
)) {
2016-10-11 04:49:43 +02:00
continue;
2016-08-22 21:00:12 +02:00
}
$all_args_match = false;
break;
}
if ($all_args_match) {
return $possible_function_params;
}
}
// if we don't succeed in finding a match, set to the first possible and wait for issues below
return $function_param_options[0];
}
2017-01-07 20:35:07 +01:00
/**
* Get a list of suppressed issues
*
* @return array<string>
*/
public function getSuppressedIssues()
{
return $this->suppressed_issues;
}
/**
* @param array<int, string> $new_issues
*
* @return void
*/
public function addSuppressedIssues(array $new_issues)
{
$this->suppressed_issues = array_merge($new_issues, $this->suppressed_issues);
}
/**
* @param array<int, string> $new_issues
*
* @return void
*/
public function removeSuppressedIssues(array $new_issues)
{
$this->suppressed_issues = array_diff($this->suppressed_issues, $new_issues);
}
2017-07-26 22:09:09 +02:00
/**
* Adds a suppressed issue, useful when creating a method checker from scratch
*
2017-07-27 05:47:29 +02:00
* @param string $issue_name
*
2017-07-26 22:09:09 +02:00
* @return void
*/
2017-07-27 05:47:29 +02:00
public function addSuppressedIssue($issue_name)
2017-07-26 22:09:09 +02:00
{
$this->suppressed_issues[] = $issue_name;
}
/**
* @return void
*/
public static function clearCache()
{
self::$no_effects_hashes = [];
}
2018-01-14 18:09:40 +01:00
/**
* @return Type\Union
*/
public function getLocalReturnType(Type\Union $storage_return_type)
{
if ($this->local_return_type) {
return $this->local_return_type;
}
2018-11-06 03:57:36 +01:00
$this->local_return_type = ExpressionAnalyzer::fleshOutType(
$this->codebase,
2018-01-14 18:09:40 +01:00
$storage_return_type,
$this->getFQCLN(),
2018-01-26 19:51:00 +01:00
$this->getFQCLN()
2018-01-14 18:09:40 +01:00
);
return $this->local_return_type;
}
2016-08-14 05:26:45 +02:00
}