1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-02 17:52:45 +01:00
psalm/tests/FileUpdates/AnalyzedMethodTest.php

1364 lines
50 KiB
PHP
Raw Normal View History

<?php
2018-10-10 22:24:10 +02:00
namespace Psalm\Tests\FileUpdates;
2021-12-03 20:11:20 +01:00
use Psalm\Config;
2018-11-06 03:57:36 +01:00
use Psalm\Internal\Analyzer\ProjectAnalyzer;
use Psalm\Internal\Provider\FakeFileProvider;
2018-11-06 03:57:36 +01:00
use Psalm\Internal\Provider\Providers;
2021-12-04 21:55:53 +01:00
use Psalm\Tests\Internal\Provider\FakeFileReferenceCacheProvider;
2021-12-03 20:11:20 +01:00
use Psalm\Tests\Internal\Provider\ParserInstanceCacheProvider;
use Psalm\Tests\Internal\Provider\ProjectCacheProvider;
use Psalm\Tests\TestCase;
2019-03-23 19:27:54 +01:00
use Psalm\Tests\TestConfig;
2021-06-08 04:55:21 +02:00
use function array_keys;
use function getcwd;
use function strpos;
2021-06-08 04:55:21 +02:00
use const DIRECTORY_SEPARATOR;
2021-12-03 20:11:20 +01:00
class AnalyzedMethodTest extends TestCase
{
public function setUp(): void
{
parent::setUp();
$this->file_provider = new FakeFileProvider();
$config = new TestConfig();
$providers = new Providers(
$this->file_provider,
2021-12-03 20:11:20 +01:00
new ParserInstanceCacheProvider(),
2018-09-30 05:51:06 +02:00
null,
null,
2021-12-04 21:55:53 +01:00
new FakeFileReferenceCacheProvider(),
2021-12-03 20:11:20 +01:00
new ProjectCacheProvider()
);
2018-11-11 18:01:14 +01:00
$this->project_analyzer = new ProjectAnalyzer(
$config,
$providers
);
$this->project_analyzer->setPhpVersion('7.3', 'tests');
}
/**
2018-09-30 05:51:06 +02:00
* @dataProvider providerTestValidUpdates
* @param array<string, string> $start_files
* @param array<string, string> $end_files
Add support for strict arrays, fix type alias intersection, fix array_is_list assertion on non-lists (#8395) * Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
2022-11-05 22:34:42 +01:00
* @param array<string, string> $ignored_issues
*/
public function testValidInclude(
array $start_files,
array $end_files,
2018-11-02 02:52:39 +01:00
array $initial_analyzed_methods,
array $unaffected_analyzed_methods,
Add support for strict arrays, fix type alias intersection, fix array_is_list assertion on non-lists (#8395) * Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
2022-11-05 22:34:42 +01:00
array $ignored_issues = []
): void {
2018-10-03 23:11:08 +02:00
$test_name = $this->getTestName();
if (strpos($test_name, 'SKIPPED-') !== false) {
$this->markTestSkipped('Skipped due to a bug.');
}
2018-11-11 18:01:14 +01:00
$this->project_analyzer->getCodebase()->diff_methods = true;
2018-11-11 18:01:14 +01:00
$codebase = $this->project_analyzer->getCodebase();
$config = $codebase->config;
2018-10-17 21:52:58 +02:00
$config->throw_exception = false;
Add support for strict arrays, fix type alias intersection, fix array_is_list assertion on non-lists (#8395) * Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
2022-11-05 22:34:42 +01:00
foreach ($ignored_issues as $error_type => $error_level) {
2018-09-28 23:51:00 +02:00
$config->setCustomErrorLevel($error_type, $error_level);
}
foreach ($start_files as $file_path => $contents) {
$this->file_provider->registerFile($file_path, $contents);
$codebase->addFilesToAnalyze([$file_path => $file_path]);
}
$codebase->scanFiles();
2018-11-02 02:52:39 +01:00
$this->assertSame([], $codebase->analyzer->getAnalyzedMethods());
2018-11-11 18:01:14 +01:00
$codebase->analyzer->analyzeFiles($this->project_analyzer, 1, false);
$this->assertSame(
2018-11-02 02:52:39 +01:00
$initial_analyzed_methods,
$codebase->analyzer->getAnalyzedMethods(),
'initial analyzed methods are not the same'
);
foreach ($end_files as $file_path => $contents) {
$this->file_provider->registerFile($file_path, $contents);
}
2018-11-11 18:01:14 +01:00
$codebase->reloadFiles($this->project_analyzer, array_keys($end_files));
2018-11-11 18:01:14 +01:00
$codebase->analyzer->loadCachedResults($this->project_analyzer);
$this->assertSame(
2018-11-02 02:52:39 +01:00
$unaffected_analyzed_methods,
$codebase->analyzer->getAnalyzedMethods(),
'unaffected analyzed methods are not the same'
);
}
/**
* @return array<string,array{start_files:array<string,string>,end_files:array<string,string>,initial_analyzed_methods:array<string,array<string,int>>,unaffected_analyzed_methods:array<string,array<string,int>>,0?:array<string,string>}>
*/
public function providerTestValidUpdates(): array
{
return [
'basicRequire' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A{
public function fooFoo(): void {
}
public function barBar(): string {
return "hello";
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo(): void {
(new A)->fooFoo();
}
public function bar() : void {
echo (new A)->barBar();
}
2018-09-28 23:51:00 +02:00
public function noReturnType() {}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A{
public function fooFoo(?string $foo = null): void {
}
public function barBar(): string {
return "hello";
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo(): void {
(new A)->fooFoo();
}
public function bar() : void {
echo (new A)->barBar();
}
2018-09-28 23:51:00 +02:00
public function noReturnType() {}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::foofoo' => 1,
'foo\a::barbar' => 1,
],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::foo' => 1,
'foo\b::bar' => 1,
'foo\b::noreturntype' => 1,
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
2019-03-23 19:27:54 +01:00
'foo\a::barbar' => 1,
],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::bar' => 1,
'foo\b::noreturntype' => 1,
],
],
2018-09-28 23:51:00 +02:00
[
2021-12-03 20:11:20 +01:00
'MissingReturnType' => Config::REPORT_INFO,
2019-03-23 19:27:54 +01:00
],
],
2018-09-30 17:33:40 +02:00
'invalidateAfterPropertyChange' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
public $foo = "bar";
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo() : string {
return (new A)->foo;
}
public function bar() : void {
$a = new A();
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var int */
public $foo = 5;
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo() : string {
return (new A)->foo;
}
public function bar() : void {
$a = new A();
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2018-09-30 17:33:40 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::foo' => 1,
'foo\b::bar' => 1,
2018-09-30 17:33:40 +02:00
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2018-09-30 17:33:40 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::bar' => 1,
2018-09-30 17:33:40 +02:00
],
2019-03-23 19:27:54 +01:00
],
2018-09-30 17:33:40 +02:00
],
'invalidateAfterStaticPropertyChange' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
public static $foo = "bar";
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo() : string {
return A::$foo;
}
public function bar() : void {
$a = new A();
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var int */
public static $foo = 5;
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo() : string {
return A::$foo;
}
public function bar() : void {
$a = new A();
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2018-09-30 17:33:40 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::foo' => 1,
'foo\b::bar' => 1,
2018-09-30 17:33:40 +02:00
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2018-09-30 17:33:40 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::bar' => 1,
2018-09-30 17:33:40 +02:00
],
2019-03-23 19:27:54 +01:00
],
2018-09-30 17:33:40 +02:00
],
'invalidateAfterStaticFlipPropertyChange' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
public static $foo = "bar";
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo() : string {
return A::$foo;
}
public function bar() : void {
$a = new A();
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
public $foo = "bar";
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo() : string {
return A::$foo;
}
public function bar() : void {
$a = new A();
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2018-09-30 17:33:40 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::foo' => 1,
'foo\b::bar' => 1,
2018-09-30 17:33:40 +02:00
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2018-09-30 17:33:40 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::bar' => 1,
2018-09-30 17:33:40 +02:00
],
2019-03-23 19:27:54 +01:00
],
2018-09-30 17:33:40 +02:00
],
'invalidateAfterConstantChange' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
public const FOO = "bar";
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo() : string {
return A::FOO;
}
public function bar() : void {
$a = new A();
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
public const FOO = 5;
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo() : string {
return A::FOO;
}
public function bar() : void {
$a = new A();
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2018-09-30 17:33:40 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::foo' => 1,
'foo\b::bar' => 1,
2018-09-30 17:33:40 +02:00
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2018-09-30 17:33:40 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::bar' => 1,
2018-09-30 17:33:40 +02:00
],
2019-03-23 19:27:54 +01:00
],
2018-09-30 17:33:40 +02:00
],
2018-10-04 00:16:33 +02:00
'dontInvalidateTraitMethods' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
use T;
public function fooFoo(): void { }
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo(): void {
(new A)->fooFoo();
}
public function bar() : void {
echo (new A)->barBar();
}
public function noReturnType() {}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
public function barBar(): string {
return "hello";
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
use T;
public function fooFoo(?string $foo = null): void { }
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo(): void {
(new A)->fooFoo();
}
public function bar() : void {
echo (new A)->barBar();
}
public function noReturnType() {}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
public function barBar(): string {
return "hello";
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [
'foo\a::barbar&foo\t::barbar' => 1,
2020-03-27 05:37:33 +01:00
],
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::foofoo' => 1,
],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::foo' => 1,
'foo\b::bar' => 1,
'foo\b::noreturntype' => 1,
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [
'foo\a::barbar&foo\t::barbar' => 1,
],
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::bar' => 1,
'foo\b::noreturntype' => 1,
],
],
[
2021-12-03 20:11:20 +01:00
'MissingReturnType' => Config::REPORT_INFO,
2019-03-23 19:27:54 +01:00
],
],
'invalidateTraitMethodsWhenTraitRemoved' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
use T;
public function fooFoo(?string $foo = null): void { }
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo(): void {
(new A)->fooFoo();
}
public function bar() : void {
echo (new A)->barBar();
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
public function barBar(): string {
return "hello";
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
public function fooFoo(): void { }
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo(): void {
(new A)->fooFoo();
}
public function bar() : void {
echo (new A)->barBar();
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
public function barBar(): string {
return "hello";
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [
'foo\a::barbar&foo\t::barbar' => 1,
2020-03-27 05:37:33 +01:00
],
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::foofoo' => 1,
],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::foo' => 1,
'foo\b::bar' => 1,
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [],
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [],
2019-03-23 19:27:54 +01:00
],
],
'invalidateTraitMethodsWhenTraitReplaced' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
use T;
public function fooFoo(): void { }
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo(): void {
(new A)->fooFoo();
}
public function bar() : void {
echo (new A)->barBar();
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
public function barBar(): string {
return "hello";
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
public function fooFoo(?string $foo = null): void { }
public function barBar(): int {
return 5;
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo(): void {
(new A)->fooFoo();
}
public function bar() : void {
echo (new A)->barBar();
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
public function barBar(): string {
return "hello";
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [
'foo\a::barbar&foo\t::barbar' => 1,
2020-03-27 05:37:33 +01:00
],
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::foofoo' => 1,
2018-10-03 23:11:08 +02:00
],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::foo' => 1,
'foo\b::bar' => 1,
],
2018-10-03 23:11:08 +02:00
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [],
2018-10-03 23:11:08 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [],
2019-03-23 19:27:54 +01:00
],
2018-10-03 23:11:08 +02:00
],
2018-10-04 00:16:33 +02:00
'invalidateTraitMethodsWhenMethodChanged' => [
2018-10-03 23:11:08 +02:00
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
use T;
public function fooFoo(): void { }
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo(): void {
(new A)->fooFoo();
}
public function bar() : void {
echo (new A)->barBar();
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
2018-10-03 23:11:08 +02:00
namespace Foo;
trait T {
public function barBar(): string {
return "hello";
}
public function bat(): string {
return "hello";
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
use T;
public function fooFoo(?string $foo = null): void { }
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function foo(): void {
(new A)->fooFoo();
}
public function bar() : void {
echo (new A)->barBar();
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
public function barBar(): int {
return 5;
}
public function bat(): string {
return "hello";
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [
'foo\a::barbar&foo\t::barbar' => 1,
'foo\a::bat&foo\t::bat' => 1,
2020-03-27 05:37:33 +01:00
],
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::foofoo' => 1,
],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::foo' => 1,
'foo\b::bar' => 1,
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [
'foo\a::bat&foo\t::bat' => 1,
2018-10-04 00:16:33 +02:00
],
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [],
2018-10-04 00:16:33 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [],
2019-03-23 19:27:54 +01:00
],
2018-10-04 00:16:33 +02:00
],
'invalidateTraitMethodsWhenMethodSuperimposed' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
use T;
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function bar() : string {
return (new A)->barBar();
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
public function barBar(): string {
return "hello";
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
use T;
public function barBar(): int {
return 5;
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => '<?php
namespace Foo;
class B {
public function bar() : string {
return (new A)->barBar();
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
public function barBar(): string {
return "hello";
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [
'foo\a::barbar&foo\t::barbar' => 1,
2018-10-04 00:16:33 +02:00
],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [
'foo\b::bar' => 1,
],
2018-10-04 00:16:33 +02:00
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [],
getcwd() . DIRECTORY_SEPARATOR . 'B.php' => [],
2019-03-23 19:27:54 +01:00
],
],
'dontInvalidateConstructor' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
public $foo;
public function __construct() {
$this->setFoo();
}
private function setFoo() : void {
$this->reallySetFoo();
}
private function reallySetFoo() : void {
$this->foo = "bar";
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
public $foo;
public function __construct() {
$this->setFoo();
}
private function setFoo() : void {
$this->reallySetFoo();
}
private function reallySetFoo() : void {
$this->foo = "bar";
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 2,
'foo\a::setfoo' => 1,
'foo\a::reallysetfoo' => 1,
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 2,
'foo\a::setfoo' => 1,
'foo\a::reallysetfoo' => 1,
],
2019-03-23 19:27:54 +01:00
],
],
'invalidateConstructorWhenDependentMethodChanges' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
public $foo;
public function __construct() {
$this->setFoo();
}
private function setFoo() : void {
$this->reallySetFoo();
}
private function reallySetFoo() : void {
$this->foo = "bar";
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
public $foo;
public function __construct() {
$this->setFoo();
}
private function setFoo() : void {
$this->reallySetFoo();
}
private function reallySetFoo() : void {
//$this->foo = "bar";
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 2,
'foo\a::setfoo' => 1,
'foo\a::reallysetfoo' => 1,
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::setfoo' => 1,
],
2019-03-23 19:27:54 +01:00
],
],
'invalidateConstructorWhenDependentMethodInSubclassChanges' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
abstract class A {
public function __construct() {
$this->setFoo();
}
abstract protected function setFoo() : void;
}',
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => '<?php
namespace Foo;
class AChild extends A {
/** @var string */
public $foo;
protected function setFoo() : void {
$this->reallySetFoo();
}
private function reallySetFoo() : void {
$this->foo = "bar";
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
abstract class A {
public function __construct() {
$this->setFoo();
}
abstract protected function setFoo() : void;
}',
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => '<?php
namespace Foo;
class AChild extends A {
/** @var string */
public $foo;
protected function setFoo() : void {
$this->reallySetFoo();
}
private function reallySetFoo() : void {
//$this->foo = "bar";
}
}',
],
'initial_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 1,
'foo\a::setfoo' => 1,
],
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => [
'foo\achild::setfoo' => 1,
'foo\achild::reallysetfoo' => 1,
'foo\achild::__construct' => 2,
],
],
'unaffected_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 1,
'foo\a::setfoo' => 1,
],
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => [
'foo\achild::setfoo' => 1,
],
],
],
2020-03-02 18:27:23 +01:00
'invalidateConstructorWhenDependentMethodInSubclassChanges2' => [
2020-03-02 17:44:54 +01:00
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
public $foo;
public function __construct() {
$this->setFoo();
}
protected function setFoo() : void {
$this->foo = "bar";
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => '<?php
namespace Foo;
class AChild extends A {
public function __construct() {
parent::__construct();
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
public $foo;
public function __construct() {
$this->setFoo();
}
protected function setFoo() : void {
$this->foo = "baz";
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => '<?php
namespace Foo;
class AChild extends A {
public function __construct() {
parent::__construct();
}
}',
],
'initial_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 2,
'foo\a::setfoo' => 1,
],
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => [
'foo\achild::__construct' => 2,
],
],
'unaffected_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [],
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => [],
],
],
'invalidateConstructorWhenDependentTraitMethodChanges' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
use T;
/** @var string */
public $foo;
public function __construct() {
$this->setFoo();
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
private function setFoo() : void {
$this->foo = "bar";
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
use T;
/** @var string */
public $foo;
public function __construct() {
$this->setFoo();
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => '<?php
namespace Foo;
trait T {
private function setFoo() : void {
//$this->foo = "bar";
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [
'foo\a::setfoo&foo\t::setfoo' => 1,
2020-03-27 05:37:33 +01:00
],
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 2,
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2020-03-27 05:37:33 +01:00
getcwd() . DIRECTORY_SEPARATOR . 'T.php' => [],
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [],
2019-03-23 19:27:54 +01:00
],
],
'rescanPropertyAssertingMethod' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string */
private $foo;
public function __construct() {}
public function bar() : void {
if ($this->foo === null) {}
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
/** @var string|null */
private $foo;
public function __construct() {}
public function bar() : void {
if ($this->foo === null) {}
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 2,
'foo\a::bar' => 1,
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 2,
],
],
[
2021-12-03 20:11:20 +01:00
'PropertyNotSetInConstructor' => Config::REPORT_INFO,
'DocblockTypeContradiction' => Config::REPORT_INFO,
'RedundantConditionGivenDocblockType' => Config::REPORT_INFO,
2019-03-23 19:27:54 +01:00
],
],
2018-10-17 21:52:58 +02:00
'noChangeAfterSyntaxError' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
2020-09-19 23:04:35 +02:00
private ?string $foo;
2018-10-17 21:52:58 +02:00
public function __construct() {}
public function bar() : void {
if ($this->foo === null) {}
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
2020-09-19 23:04:35 +02:00
private ?string $foo
2018-10-17 21:52:58 +02:00
public function __construct() {}
public function bar() : void {
if ($this->foo === null) {}
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2018-10-17 21:52:58 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
2020-09-19 23:04:35 +02:00
'foo\a::__construct' => 2,
2018-10-17 21:52:58 +02:00
'foo\a::bar' => 1,
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2018-10-17 21:52:58 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
2020-09-19 23:04:35 +02:00
'foo\a::__construct' => 2,
2020-09-25 14:42:27 +02:00
'foo\a::bar' => 1
2018-10-17 21:52:58 +02:00
],
2019-03-23 19:27:54 +01:00
],
2018-10-17 21:52:58 +02:00
],
'nothingBeforeSyntaxError' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
2020-09-19 23:04:35 +02:00
private ?string $foo
2018-10-17 21:52:58 +02:00
public function __construct() {}
public function bar() : void {
if ($this->foo === null) {}
}
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
class A {
2020-09-19 23:04:35 +02:00
private ?string $foo;
2018-10-17 21:52:58 +02:00
public function __construct() {}
public function bar() : void {
if ($this->foo === null) {}
}
}',
],
2018-11-02 02:52:39 +01:00
'initial_analyzed_methods' => [
2018-10-17 21:52:58 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
2020-09-25 14:42:27 +02:00
'foo\a::__construct' => 2,
2018-11-02 02:52:39 +01:00
'foo\a::bar' => 1,
2018-10-17 21:52:58 +02:00
],
],
2018-11-02 02:52:39 +01:00
'unaffected_analyzed_methods' => [
2018-10-17 21:52:58 +02:00
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
2020-09-25 14:42:27 +02:00
'foo\a::__construct' => 2,
'foo\a::bar' => 1
2018-10-17 21:52:58 +02:00
],
2019-03-23 19:27:54 +01:00
],
2018-10-17 21:52:58 +02:00
],
'modifyPropertyOfChildClass' => [
'start_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
abstract class A {
protected $arr = [1, 2, 3];
protected string $b;
public function __construct(int $a, string $b) {
echo $this->arr[$a];
$this->b = $b;
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => '<?php
namespace Foo;
class AChild extends A {
public $arr = [1, 2, 3, 4];
}',
],
'end_files' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => '<?php
namespace Foo;
abstract class A {
protected $arr = [1, 2, 3];
protected string $b;
public function __construct(int $a, string $b) {
echo $this->arr[$a];
$this->b = $b;
}
}',
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => '<?php
namespace Foo;
class AChild extends A {
protected $arr;
}',
],
'initial_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 2,
],
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => [
'foo\achild::__construct' => 2,
],
],
'unaffected_analyzed_methods' => [
getcwd() . DIRECTORY_SEPARATOR . 'A.php' => [
'foo\a::__construct' => 2,
],
getcwd() . DIRECTORY_SEPARATOR . 'AChild.php' => []
],
],
];
}
public function testFileMapsUpdated(): void
{
$codebase = $this->project_analyzer->getCodebase();
$config = $codebase->config;
$config->throw_exception = false;
$this->file_provider->registerFile('somefile.php', '
<?php
function foo() : void {
}
foo();
');
$codebase->addFilesToAnalyze(['somefile.php' => 'somefile.php']);
$codebase->scanFiles();
$codebase->analyzer->analyzeFiles($this->project_analyzer, 1, false);
$maps = $codebase->analyzer->getMapsForFile('somefile.php');
$this->assertNotEmpty($maps[0]);
$this->file_provider->setOpenContents('somefile.php', '');
$codebase->reloadFiles($this->project_analyzer, ['somefile.php']);
$codebase->analyzer->analyzeFiles($this->project_analyzer, 1, false);
$updated_maps = $codebase->analyzer->getMapsForFile('somefile.php');
$this->assertSame([], $updated_maps[0]);
$this->assertSame([], $updated_maps[1]);
$this->assertSame([], $updated_maps[2]);
}
}