2016-08-14 05:26:45 +02:00
|
|
|
|
<?php
|
|
|
|
|
namespace Psalm\Checker;
|
|
|
|
|
|
2017-05-19 06:48:26 +02:00
|
|
|
|
use PhpParser;
|
2016-10-15 06:12:57 +02:00
|
|
|
|
use PhpParser\Node\Expr\Closure;
|
|
|
|
|
use PhpParser\Node\Stmt\ClassMethod;
|
2016-11-02 07:29:00 +01:00
|
|
|
|
use PhpParser\Node\Stmt\Function_;
|
2018-02-22 00:59:31 +01:00
|
|
|
|
use Psalm\Checker\FunctionLike\ReturnTypeChecker;
|
2018-05-12 00:35:02 +02:00
|
|
|
|
use Psalm\Checker\FunctionLike\ReturnTypeCollector;
|
2016-10-22 19:23:18 +02:00
|
|
|
|
use Psalm\Checker\Statements\ExpressionChecker;
|
2018-02-04 00:52:35 +01:00
|
|
|
|
use Psalm\Codebase\CallMap;
|
2017-05-19 06:48:26 +02:00
|
|
|
|
use Psalm\CodeLocation;
|
2016-11-02 07:29:00 +01:00
|
|
|
|
use Psalm\Context;
|
2017-09-16 18:45:11 +02:00
|
|
|
|
use Psalm\FileManipulation\FunctionDocblockManipulator;
|
2016-12-31 05:40:32 +01:00
|
|
|
|
use Psalm\Issue\InvalidParamDefault;
|
2018-01-05 18:11:12 +01:00
|
|
|
|
use Psalm\Issue\MismatchingDocblockParamType;
|
2018-01-29 02:03:47 +01:00
|
|
|
|
use Psalm\Issue\MissingClosureParamType;
|
|
|
|
|
use Psalm\Issue\MissingParamType;
|
2018-06-22 07:13:49 +02:00
|
|
|
|
use Psalm\Issue\MissingThrowsDocblock;
|
2018-01-10 06:07:47 +01:00
|
|
|
|
use Psalm\Issue\ReservedWord;
|
2017-12-29 23:27:16 +01:00
|
|
|
|
use Psalm\Issue\UnusedParam;
|
2016-11-02 07:29:00 +01:00
|
|
|
|
use Psalm\IssueBuffer;
|
2016-08-14 05:26:45 +02:00
|
|
|
|
use Psalm\StatementsSource;
|
2018-05-12 00:35:02 +02:00
|
|
|
|
use Psalm\Storage\FunctionLikeParameter;
|
2017-09-04 02:52:54 +02:00
|
|
|
|
use Psalm\Storage\FunctionLikeStorage;
|
2017-01-06 07:07:11 +01:00
|
|
|
|
use Psalm\Storage\MethodStorage;
|
2016-08-14 05:26:45 +02:00
|
|
|
|
use Psalm\Type;
|
2017-01-15 01:06:58 +01:00
|
|
|
|
use Psalm\Type\Atomic\TNamedObject;
|
2016-08-14 05:26:45 +02:00
|
|
|
|
|
2016-11-21 03:49:06 +01:00
|
|
|
|
abstract class FunctionLikeChecker extends SourceChecker implements StatementsSource
|
2016-08-14 05:26:45 +02:00
|
|
|
|
{
|
2016-10-14 06:53:43 +02:00
|
|
|
|
/**
|
2016-10-15 06:12:57 +02:00
|
|
|
|
* @var Closure|Function_|ClassMethod
|
2016-10-14 06:53:43 +02:00
|
|
|
|
*/
|
2016-08-14 05:26:45 +02:00
|
|
|
|
protected $function;
|
2016-10-14 06:53:43 +02:00
|
|
|
|
|
|
|
|
|
/**
|
2017-01-07 20:35:07 +01:00
|
|
|
|
* @var array<string>
|
2016-10-14 06:53:43 +02:00
|
|
|
|
*/
|
2017-01-07 20:35:07 +01:00
|
|
|
|
protected $suppressed_issues;
|
2016-10-14 06:53:43 +02:00
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @var bool
|
|
|
|
|
*/
|
2016-08-14 05:26:45 +02:00
|
|
|
|
protected $is_static = false;
|
2016-10-14 06:53:43 +02:00
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @var StatementsSource
|
|
|
|
|
*/
|
2016-08-14 05:26:45 +02:00
|
|
|
|
protected $source;
|
2016-10-14 06:53:43 +02:00
|
|
|
|
|
2018-01-14 18:09:40 +01:00
|
|
|
|
/**
|
|
|
|
|
* @var FileChecker
|
|
|
|
|
*/
|
2017-07-29 21:05:06 +02:00
|
|
|
|
public $file_checker;
|
|
|
|
|
|
2016-10-15 06:12:57 +02:00
|
|
|
|
/**
|
2016-12-24 19:23:22 +01:00
|
|
|
|
* @var array<string, array<string, Type\Union>>
|
2016-10-15 06:12:57 +02:00
|
|
|
|
*/
|
2016-08-14 05:26:45 +02:00
|
|
|
|
protected $return_vars_in_scope = [];
|
2016-10-15 06:12:57 +02:00
|
|
|
|
|
|
|
|
|
/**
|
2017-12-02 19:32:20 +01:00
|
|
|
|
* @var array<string, array<string, bool>>
|
2016-10-15 06:12:57 +02:00
|
|
|
|
*/
|
2016-08-14 05:26:45 +02:00
|
|
|
|
protected $return_vars_possibly_in_scope = [];
|
2016-11-01 05:39:41 +01:00
|
|
|
|
|
2018-01-14 18:09:40 +01:00
|
|
|
|
/**
|
|
|
|
|
* @var Type\Union|null
|
|
|
|
|
*/
|
|
|
|
|
private $local_return_type;
|
|
|
|
|
|
2016-11-01 05:39:41 +01:00
|
|
|
|
/**
|
|
|
|
|
* @var array<string, array>
|
|
|
|
|
*/
|
2016-08-14 05:26:45 +02:00
|
|
|
|
protected static $no_effects_hashes = [];
|
|
|
|
|
|
2016-10-15 06:12:57 +02:00
|
|
|
|
/**
|
|
|
|
|
* @param Closure|Function_|ClassMethod $function
|
|
|
|
|
* @param StatementsSource $source
|
|
|
|
|
*/
|
|
|
|
|
public function __construct($function, StatementsSource $source)
|
2016-08-14 05:26:45 +02:00
|
|
|
|
{
|
|
|
|
|
$this->function = $function;
|
|
|
|
|
$this->source = $source;
|
2017-03-20 04:30:20 +01:00
|
|
|
|
$this->file_checker = $source->getFileChecker();
|
2016-08-14 05:26:45 +02:00
|
|
|
|
$this->suppressed_issues = $source->getSuppressedIssues();
|
|
|
|
|
}
|
|
|
|
|
|
2016-11-02 07:29:00 +01:00
|
|
|
|
/**
|
2016-11-05 22:53:30 +01:00
|
|
|
|
* @param Context $context
|
|
|
|
|
* @param Context|null $global_context
|
2017-01-12 03:37:53 +01:00
|
|
|
|
* @param bool $add_mutations whether or not to add mutations to this method
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-11-02 07:29:00 +01:00
|
|
|
|
* @return false|null
|
|
|
|
|
*/
|
2017-01-12 03:37:53 +01:00
|
|
|
|
public function analyze(Context $context, Context $global_context = null, $add_mutations = false)
|
2016-08-14 05:26:45 +02:00
|
|
|
|
{
|
2016-12-07 20:13:39 +01:00
|
|
|
|
$function_stmts = $this->function->getStmts() ?: [];
|
2016-09-02 00:02:09 +02:00
|
|
|
|
|
2016-12-07 20:13:39 +01:00
|
|
|
|
$hash = null;
|
2018-04-25 20:45:51 +02:00
|
|
|
|
$real_method_id = null;
|
2016-08-14 05:26:45 +02:00
|
|
|
|
|
2017-01-06 07:07:11 +01:00
|
|
|
|
$cased_method_id = null;
|
2016-11-02 07:29:00 +01:00
|
|
|
|
|
2017-02-10 02:35:17 +01:00
|
|
|
|
$class_storage = null;
|
|
|
|
|
|
2017-01-15 21:58:40 +01:00
|
|
|
|
if ($global_context) {
|
|
|
|
|
foreach ($global_context->constants as $const_name => $var_type) {
|
2017-02-01 05:24:33 +01:00
|
|
|
|
if (!$context->hasVariable($const_name)) {
|
2017-01-15 21:58:40 +01:00
|
|
|
|
$context->vars_in_scope[$const_name] = clone $var_type;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2017-07-29 21:05:06 +02:00
|
|
|
|
$project_checker = $this->file_checker->project_checker;
|
|
|
|
|
|
|
|
|
|
$file_storage_provider = $project_checker->file_storage_provider;
|
|
|
|
|
|
2017-12-03 18:44:08 +01:00
|
|
|
|
$implemented_docblock_param_types = [];
|
|
|
|
|
|
2017-12-29 23:27:16 +01:00
|
|
|
|
$project_checker = $this->file_checker->project_checker;
|
2018-01-21 19:38:51 +01:00
|
|
|
|
$codebase = $project_checker->codebase;
|
2017-12-29 23:27:16 +01:00
|
|
|
|
|
|
|
|
|
$classlike_storage_provider = $project_checker->classlike_storage_provider;
|
|
|
|
|
|
2017-01-06 07:07:11 +01:00
|
|
|
|
if ($this->function instanceof ClassMethod) {
|
2017-01-12 06:54:41 +01:00
|
|
|
|
$real_method_id = (string)$this->getMethodId();
|
|
|
|
|
|
|
|
|
|
$method_id = (string)$this->getMethodId($context->self);
|
|
|
|
|
|
2017-01-12 03:37:53 +01:00
|
|
|
|
if ($add_mutations) {
|
2017-05-13 01:15:08 +02:00
|
|
|
|
$hash = $real_method_id . json_encode([
|
2016-12-07 20:13:39 +01:00
|
|
|
|
$context->vars_in_scope,
|
2018-04-25 20:33:39 +02:00
|
|
|
|
$context->vars_possibly_in_scope,
|
|
|
|
|
]);
|
2016-08-14 05:26:45 +02:00
|
|
|
|
|
2016-12-07 20:13:39 +01:00
|
|
|
|
// if we know that the function has no effects on vars, we don't bother rechecking
|
|
|
|
|
if (isset(self::$no_effects_hashes[$hash])) {
|
|
|
|
|
list(
|
|
|
|
|
$context->vars_in_scope,
|
|
|
|
|
$context->vars_possibly_in_scope
|
|
|
|
|
) = self::$no_effects_hashes[$hash];
|
2016-10-16 00:01:04 +02:00
|
|
|
|
|
2016-12-07 20:13:39 +01:00
|
|
|
|
return null;
|
2016-11-07 05:29:54 +01:00
|
|
|
|
}
|
2016-12-07 20:13:39 +01:00
|
|
|
|
} elseif ($context->self) {
|
2017-01-15 01:06:58 +01:00
|
|
|
|
$context->vars_in_scope['$this'] = new Type\Union([new TNamedObject($context->self)]);
|
2017-02-08 08:23:17 +01:00
|
|
|
|
$context->vars_possibly_in_scope['$this'] = true;
|
2016-12-07 20:13:39 +01:00
|
|
|
|
}
|
2016-11-07 05:29:54 +01:00
|
|
|
|
|
2017-01-06 07:07:11 +01:00
|
|
|
|
$fq_class_name = (string)$context->self;
|
2016-11-05 03:04:55 +01:00
|
|
|
|
|
2017-07-29 21:05:06 +02:00
|
|
|
|
$class_storage = $classlike_storage_provider->get($fq_class_name);
|
|
|
|
|
|
2018-01-25 07:04:26 +01:00
|
|
|
|
try {
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$storage = $codebase->methods->getStorage($real_method_id);
|
2018-01-25 07:04:26 +01:00
|
|
|
|
} catch (\UnexpectedValueException $e) {
|
2018-09-04 20:34:14 +02:00
|
|
|
|
if ($class_storage->has_visitor_issues) {
|
|
|
|
|
return null;
|
|
|
|
|
}
|
|
|
|
|
|
2018-01-25 07:04:26 +01:00
|
|
|
|
if (!$class_storage->parent_classes) {
|
|
|
|
|
throw $e;
|
|
|
|
|
}
|
|
|
|
|
|
2018-04-05 20:28:33 +02:00
|
|
|
|
$declaring_method_id = $codebase->methods->getDeclaringMethodId($method_id);
|
|
|
|
|
|
|
|
|
|
if (!$declaring_method_id) {
|
|
|
|
|
throw $e;
|
|
|
|
|
}
|
2018-01-25 07:04:26 +01:00
|
|
|
|
|
|
|
|
|
// happens for fake constructors
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$storage = $codebase->methods->getStorage($declaring_method_id);
|
2018-01-25 07:04:26 +01:00
|
|
|
|
}
|
2017-01-06 07:07:11 +01:00
|
|
|
|
|
|
|
|
|
$cased_method_id = $fq_class_name . '::' . $storage->cased_name;
|
2016-12-30 18:41:14 +01:00
|
|
|
|
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$overridden_method_ids = $codebase->methods->getOverriddenMethodIds($method_id);
|
2016-10-18 22:00:03 +02:00
|
|
|
|
|
2018-04-17 18:16:25 +02:00
|
|
|
|
if ($this->function->name->name === '__construct') {
|
2017-04-15 05:26:58 +02:00
|
|
|
|
$context->inside_constructor = true;
|
|
|
|
|
}
|
|
|
|
|
|
2018-04-21 19:36:18 +02:00
|
|
|
|
$codeLocation = new CodeLocation(
|
|
|
|
|
$this,
|
|
|
|
|
$this->function,
|
|
|
|
|
null,
|
|
|
|
|
true
|
|
|
|
|
);
|
|
|
|
|
|
2018-03-13 23:11:57 +01:00
|
|
|
|
if ($overridden_method_ids
|
2018-04-17 18:16:25 +02:00
|
|
|
|
&& $this->function->name->name !== '__construct'
|
2018-03-13 23:11:57 +01:00
|
|
|
|
&& !$context->collect_initializations
|
|
|
|
|
&& !$context->collect_mutations
|
|
|
|
|
) {
|
2017-11-26 22:03:17 +01:00
|
|
|
|
foreach ($overridden_method_ids as $overridden_method_id) {
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$parent_method_storage = $codebase->methods->getStorage($overridden_method_id);
|
2017-01-13 18:03:22 +01:00
|
|
|
|
|
2017-11-26 22:03:17 +01:00
|
|
|
|
list($overridden_fq_class_name) = explode('::', $overridden_method_id);
|
2016-12-07 20:13:39 +01:00
|
|
|
|
|
2017-11-26 22:03:17 +01:00
|
|
|
|
$parent_storage = $classlike_storage_provider->get($overridden_fq_class_name);
|
2016-12-07 20:13:39 +01:00
|
|
|
|
|
2018-02-22 00:59:31 +01:00
|
|
|
|
MethodChecker::compareMethods(
|
2017-11-26 22:03:17 +01:00
|
|
|
|
$project_checker,
|
|
|
|
|
$class_storage,
|
|
|
|
|
$parent_storage,
|
|
|
|
|
$storage,
|
|
|
|
|
$parent_method_storage,
|
2018-04-21 19:36:18 +02:00
|
|
|
|
$codeLocation,
|
2017-11-26 22:03:17 +01:00
|
|
|
|
$storage->suppressed_issues
|
|
|
|
|
);
|
2017-02-09 23:49:13 +01:00
|
|
|
|
|
2017-11-26 22:03:17 +01:00
|
|
|
|
foreach ($parent_method_storage->params as $i => $guide_param) {
|
2018-10-06 20:00:45 +02:00
|
|
|
|
if ($guide_param->type && !($guide_param->signature_type && $parent_storage->user_defined)) {
|
|
|
|
|
$implemented_docblock_param_types[$i] = $guide_param->type;
|
2017-09-02 17:18:56 +02:00
|
|
|
|
}
|
2017-01-13 18:03:22 +01:00
|
|
|
|
}
|
2016-10-16 00:01:04 +02:00
|
|
|
|
}
|
2016-12-07 20:13:39 +01:00
|
|
|
|
}
|
2018-04-21 19:36:18 +02:00
|
|
|
|
|
|
|
|
|
MethodChecker::checkMethodSignatureMustOmitReturnType($storage, $codeLocation);
|
2018-09-26 00:37:24 +02:00
|
|
|
|
|
|
|
|
|
$context->calling_method_id = strtolower($method_id);
|
2017-01-06 07:07:11 +01:00
|
|
|
|
} elseif ($this->function instanceof Function_) {
|
2018-05-30 22:19:18 +02:00
|
|
|
|
$file_storage = $file_storage_provider->get($this->source->getFilePath());
|
2017-07-25 22:11:02 +02:00
|
|
|
|
|
2018-07-03 14:09:00 +02:00
|
|
|
|
$function_id = (string)$this->getMethodId();
|
|
|
|
|
|
|
|
|
|
if (!isset($file_storage->functions[$function_id])) {
|
|
|
|
|
throw new \UnexpectedValueException(
|
|
|
|
|
'Function ' . $function_id . ' should be defined in ' . $this->source->getFilePath()
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$storage = $file_storage->functions[$function_id];
|
2016-12-07 20:13:39 +01:00
|
|
|
|
|
2017-01-06 07:07:11 +01:00
|
|
|
|
$cased_method_id = $this->function->name;
|
|
|
|
|
} else { // Closure
|
2017-11-09 05:27:51 +01:00
|
|
|
|
$function_id = $this->getMethodId();
|
2017-07-25 22:11:02 +02:00
|
|
|
|
|
2018-01-31 23:09:09 +01:00
|
|
|
|
$storage = $codebase->getClosureStorage($this->source->getFilePath(), $function_id);
|
2016-09-02 00:02:09 +02:00
|
|
|
|
|
2017-11-22 03:50:39 +01:00
|
|
|
|
if ($storage->return_type) {
|
|
|
|
|
$closure_return_type = ExpressionChecker::fleshOutType(
|
|
|
|
|
$project_checker,
|
|
|
|
|
$storage->return_type,
|
|
|
|
|
$context->self,
|
2018-01-26 19:51:00 +01:00
|
|
|
|
$context->self
|
2017-11-22 03:50:39 +01:00
|
|
|
|
);
|
|
|
|
|
} else {
|
|
|
|
|
$closure_return_type = Type::getMixed();
|
|
|
|
|
}
|
|
|
|
|
|
2016-12-15 01:19:25 +01:00
|
|
|
|
/** @var PhpParser\Node\Expr\Closure $this->function */
|
2016-12-07 20:13:39 +01:00
|
|
|
|
$this->function->inferredType = new Type\Union([
|
2017-01-15 01:06:58 +01:00
|
|
|
|
new Type\Atomic\Fn(
|
2016-12-07 20:13:39 +01:00
|
|
|
|
'Closure',
|
2017-01-06 07:07:11 +01:00
|
|
|
|
$storage->params,
|
2017-11-22 03:50:39 +01:00
|
|
|
|
$closure_return_type
|
2017-05-27 02:05:57 +02:00
|
|
|
|
),
|
2016-12-07 20:13:39 +01:00
|
|
|
|
]);
|
|
|
|
|
}
|
2016-09-02 00:02:09 +02:00
|
|
|
|
|
2017-01-19 23:58:08 +01:00
|
|
|
|
$this->suppressed_issues = array_merge(
|
|
|
|
|
$this->getSource()->getSuppressedIssues(),
|
|
|
|
|
$storage->suppressed_issues
|
|
|
|
|
);
|
2017-01-06 07:07:11 +01:00
|
|
|
|
|
|
|
|
|
if ($storage instanceof MethodStorage && $storage->is_static) {
|
|
|
|
|
$this->is_static = true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$statements_checker = new StatementsChecker($this);
|
|
|
|
|
|
2017-02-10 02:35:17 +01:00
|
|
|
|
$template_types = $storage->template_types;
|
|
|
|
|
|
|
|
|
|
if ($class_storage && $class_storage->template_types) {
|
|
|
|
|
$template_types = array_merge($template_types ?: [], $class_storage->template_types);
|
|
|
|
|
}
|
|
|
|
|
|
2018-10-08 19:07:28 +02:00
|
|
|
|
$non_null_param_types = array_filter(
|
|
|
|
|
$storage->params,
|
|
|
|
|
/** @return bool */
|
|
|
|
|
function (FunctionLikeParameter $p) {
|
|
|
|
|
return $p->type !== null;
|
|
|
|
|
}
|
|
|
|
|
);
|
|
|
|
|
|
2017-01-06 07:07:11 +01:00
|
|
|
|
foreach ($storage->params as $offset => $function_param) {
|
2017-07-25 22:11:02 +02:00
|
|
|
|
$signature_type = $function_param->signature_type;
|
2018-02-01 05:27:25 +01:00
|
|
|
|
|
2017-09-02 17:18:56 +02:00
|
|
|
|
if ($function_param->type) {
|
2018-05-21 06:46:56 +02:00
|
|
|
|
if ($function_param->type_location) {
|
|
|
|
|
$function_param->type->check(
|
|
|
|
|
$this,
|
|
|
|
|
$function_param->type_location,
|
|
|
|
|
$storage->suppressed_issues,
|
|
|
|
|
[],
|
|
|
|
|
false
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2017-09-02 17:18:56 +02:00
|
|
|
|
$param_type = clone $function_param->type;
|
|
|
|
|
|
|
|
|
|
$param_type = ExpressionChecker::fleshOutType(
|
|
|
|
|
$project_checker,
|
|
|
|
|
$param_type,
|
|
|
|
|
$context->self,
|
2018-01-26 19:51:00 +01:00
|
|
|
|
$context->self
|
2017-09-02 17:18:56 +02:00
|
|
|
|
);
|
|
|
|
|
} else {
|
2018-10-08 19:07:28 +02:00
|
|
|
|
if (!$non_null_param_types && isset($implemented_docblock_param_types[$offset])) {
|
2018-10-06 20:00:45 +02:00
|
|
|
|
$param_type = clone $implemented_docblock_param_types[$offset];
|
|
|
|
|
|
|
|
|
|
$param_type = ExpressionChecker::fleshOutType(
|
|
|
|
|
$project_checker,
|
|
|
|
|
$param_type,
|
|
|
|
|
$context->self,
|
|
|
|
|
$context->self
|
|
|
|
|
);
|
|
|
|
|
} else {
|
|
|
|
|
$param_type = Type::getMixed();
|
|
|
|
|
}
|
2017-09-02 17:18:56 +02:00
|
|
|
|
}
|
2016-12-04 01:11:30 +01:00
|
|
|
|
|
2017-07-09 03:19:16 +02:00
|
|
|
|
$context->vars_in_scope['$' . $function_param->name] = $param_type;
|
|
|
|
|
$context->vars_possibly_in_scope['$' . $function_param->name] = true;
|
|
|
|
|
|
2018-01-25 07:04:26 +01:00
|
|
|
|
if ($context->collect_references && $function_param->location) {
|
2018-06-17 02:01:33 +02:00
|
|
|
|
$context->unreferenced_vars['$' . $function_param->name] = [
|
|
|
|
|
$function_param->location->getHash() => $function_param->location
|
|
|
|
|
];
|
2018-01-25 07:04:26 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-12-30 03:28:21 +01:00
|
|
|
|
if (!$function_param->type_location || !$function_param->location) {
|
2017-07-09 03:19:16 +02:00
|
|
|
|
continue;
|
2016-12-07 20:13:39 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-11-26 22:03:17 +01:00
|
|
|
|
/**
|
|
|
|
|
* @psalm-suppress MixedArrayAccess
|
|
|
|
|
*
|
|
|
|
|
* @var PhpParser\Node\Param
|
|
|
|
|
*/
|
2016-12-31 05:40:32 +01:00
|
|
|
|
$parser_param = $this->function->getParams()[$offset];
|
|
|
|
|
|
2017-07-25 22:11:02 +02:00
|
|
|
|
if ($signature_type) {
|
|
|
|
|
if (!TypeChecker::isContainedBy(
|
2018-06-09 05:54:07 +02:00
|
|
|
|
$codebase,
|
|
|
|
|
$param_type,
|
|
|
|
|
$signature_type,
|
|
|
|
|
false,
|
|
|
|
|
false,
|
|
|
|
|
$has_scalar_match,
|
|
|
|
|
$type_coerced,
|
|
|
|
|
$type_coerced_from_mixed
|
|
|
|
|
) && !$type_coerced_from_mixed
|
2017-07-25 22:11:02 +02:00
|
|
|
|
) {
|
2018-01-07 16:23:02 +01:00
|
|
|
|
if ($project_checker->alter_code
|
|
|
|
|
&& isset($project_checker->getIssuesToFix()['MismatchingDocblockParamType'])
|
|
|
|
|
) {
|
|
|
|
|
$this->addOrUpdateParamType($project_checker, $function_param->name, $signature_type, true);
|
|
|
|
|
|
2018-01-07 18:53:25 +01:00
|
|
|
|
continue;
|
2018-01-07 16:23:02 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-07-25 22:11:02 +02:00
|
|
|
|
if (IssueBuffer::accepts(
|
2018-01-05 18:11:12 +01:00
|
|
|
|
new MismatchingDocblockParamType(
|
2017-07-25 22:11:02 +02:00
|
|
|
|
'Parameter $' . $function_param->name . ' has wrong type \'' . $param_type .
|
|
|
|
|
'\', should be \'' . $signature_type . '\'',
|
2018-01-07 06:11:23 +01:00
|
|
|
|
$function_param->type_location
|
2017-07-25 22:11:02 +02:00
|
|
|
|
),
|
|
|
|
|
$storage->suppressed_issues
|
|
|
|
|
)) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
2018-01-10 04:46:55 +01:00
|
|
|
|
$signature_type->check(
|
|
|
|
|
$this,
|
|
|
|
|
$function_param->type_location,
|
|
|
|
|
$storage->suppressed_issues,
|
|
|
|
|
[],
|
|
|
|
|
false
|
|
|
|
|
);
|
|
|
|
|
|
2017-07-25 22:11:02 +02:00
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-12-31 05:40:32 +01:00
|
|
|
|
if ($parser_param->default) {
|
2018-02-16 02:27:42 +01:00
|
|
|
|
ExpressionChecker::analyze($statements_checker, $parser_param->default, $context);
|
|
|
|
|
|
|
|
|
|
$default_type = isset($parser_param->default->inferredType)
|
|
|
|
|
? $parser_param->default->inferredType
|
|
|
|
|
: null;
|
2016-12-31 05:40:32 +01:00
|
|
|
|
|
2018-03-21 04:55:26 +01:00
|
|
|
|
if ($default_type
|
|
|
|
|
&& !$default_type->isMixed()
|
|
|
|
|
&& !TypeChecker::isContainedBy(
|
2018-02-01 06:50:01 +01:00
|
|
|
|
$codebase,
|
2017-01-02 21:31:18 +01:00
|
|
|
|
$default_type,
|
2017-07-29 21:05:06 +02:00
|
|
|
|
$param_type
|
2017-01-02 21:31:18 +01:00
|
|
|
|
)
|
|
|
|
|
) {
|
2016-12-31 05:40:32 +01:00
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new InvalidParamDefault(
|
2018-03-21 04:55:26 +01:00
|
|
|
|
'Default value type ' . $default_type . ' for argument ' . ($offset + 1)
|
|
|
|
|
. ' of method ' . $cased_method_id
|
|
|
|
|
. ' does not match the given type ' . $param_type,
|
2017-12-30 03:28:21 +01:00
|
|
|
|
$function_param->type_location
|
2016-12-31 05:40:32 +01:00
|
|
|
|
)
|
|
|
|
|
)) {
|
2016-12-31 06:14:00 +01:00
|
|
|
|
// fall through
|
2016-12-31 05:40:32 +01:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2017-02-10 02:35:17 +01:00
|
|
|
|
if ($template_types) {
|
2017-02-10 06:14:44 +01:00
|
|
|
|
$substituted_type = clone $param_type;
|
2017-02-10 04:57:23 +01:00
|
|
|
|
$generic_types = [];
|
2018-05-28 23:26:43 +02:00
|
|
|
|
$substituted_type->replaceTemplateTypesWithStandins($template_types, $generic_types);
|
2017-12-30 03:28:21 +01:00
|
|
|
|
$substituted_type->check(
|
|
|
|
|
$this->source,
|
|
|
|
|
$function_param->type_location,
|
|
|
|
|
$this->suppressed_issues,
|
|
|
|
|
[],
|
|
|
|
|
false
|
|
|
|
|
);
|
2017-02-10 02:35:17 +01:00
|
|
|
|
} else {
|
2018-01-10 06:07:47 +01:00
|
|
|
|
if ($param_type->isVoid()) {
|
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new ReservedWord(
|
|
|
|
|
'Parameter cannot be void',
|
2018-03-21 15:17:57 +01:00
|
|
|
|
$function_param->type_location,
|
|
|
|
|
'void'
|
2018-01-10 06:07:47 +01:00
|
|
|
|
),
|
|
|
|
|
$this->suppressed_issues
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$param_type->check(
|
|
|
|
|
$this->source,
|
|
|
|
|
$function_param->type_location,
|
|
|
|
|
$this->suppressed_issues,
|
|
|
|
|
[],
|
|
|
|
|
false
|
|
|
|
|
);
|
2017-03-02 00:36:04 +01:00
|
|
|
|
}
|
|
|
|
|
|
2018-01-21 19:38:51 +01:00
|
|
|
|
if ($codebase->collect_references) {
|
2017-12-30 03:28:21 +01:00
|
|
|
|
if ($function_param->type_location !== $function_param->signature_type_location &&
|
|
|
|
|
$function_param->signature_type_location &&
|
2017-03-02 00:36:04 +01:00
|
|
|
|
$function_param->signature_type
|
|
|
|
|
) {
|
|
|
|
|
$function_param->signature_type->check(
|
|
|
|
|
$this->source,
|
2017-12-30 03:28:21 +01:00
|
|
|
|
$function_param->signature_type_location,
|
2017-03-02 18:19:18 +01:00
|
|
|
|
$this->suppressed_issues,
|
|
|
|
|
[],
|
|
|
|
|
false
|
2017-03-02 00:36:04 +01:00
|
|
|
|
);
|
|
|
|
|
}
|
2017-02-10 02:35:17 +01:00
|
|
|
|
}
|
2016-09-02 00:02:09 +02:00
|
|
|
|
|
2018-01-25 07:04:26 +01:00
|
|
|
|
if ($function_param->by_ref) {
|
|
|
|
|
$context->byref_constraints['$' . $function_param->name]
|
|
|
|
|
= new \Psalm\ReferenceConstraint(!$param_type->isMixed() ? $param_type : null);
|
2017-02-23 06:25:28 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-02-08 08:23:17 +01:00
|
|
|
|
if ($function_param->by_ref) {
|
|
|
|
|
// register by ref params as having been used, to avoid false positives
|
|
|
|
|
// @todo change the assignment analysis *just* for byref params
|
|
|
|
|
// so that we don't have to do this
|
|
|
|
|
$context->hasVariable('$' . $function_param->name);
|
|
|
|
|
}
|
2016-09-02 00:02:09 +02:00
|
|
|
|
|
2016-12-07 20:13:39 +01:00
|
|
|
|
$statements_checker->registerVariable(
|
2017-02-08 08:23:17 +01:00
|
|
|
|
'$' . $function_param->name,
|
2018-01-21 22:24:20 +01:00
|
|
|
|
$function_param->location,
|
|
|
|
|
null
|
2016-12-07 20:13:39 +01:00
|
|
|
|
);
|
|
|
|
|
}
|
2016-08-14 05:26:45 +02:00
|
|
|
|
|
2018-02-22 00:59:31 +01:00
|
|
|
|
if (ReturnTypeChecker::checkSignatureReturnType(
|
|
|
|
|
$this->function,
|
|
|
|
|
$project_checker,
|
|
|
|
|
$this,
|
|
|
|
|
$storage,
|
|
|
|
|
$context
|
|
|
|
|
) === false) {
|
|
|
|
|
return false;
|
2017-07-25 22:11:02 +02:00
|
|
|
|
}
|
|
|
|
|
|
2018-06-17 03:54:44 +02:00
|
|
|
|
$statements_checker->analyze($function_stmts, $context, $global_context, true);
|
2016-08-14 05:26:45 +02:00
|
|
|
|
|
2017-09-03 00:15:52 +02:00
|
|
|
|
foreach ($storage->params as $offset => $function_param) {
|
|
|
|
|
// only complain if there's no type defined by a parent type
|
|
|
|
|
if (!$function_param->type
|
|
|
|
|
&& $function_param->location
|
|
|
|
|
&& !isset($implemented_docblock_param_types[$offset])
|
|
|
|
|
) {
|
|
|
|
|
$possible_type = null;
|
|
|
|
|
|
|
|
|
|
if (isset($context->possible_param_types[$function_param->name])) {
|
|
|
|
|
$possible_type = $context->possible_param_types[$function_param->name];
|
|
|
|
|
}
|
|
|
|
|
|
2017-09-03 00:26:19 +02:00
|
|
|
|
$infer_text = $project_checker->infer_types_from_usage
|
|
|
|
|
? ', ' . ($possible_type ? 'should be ' . $possible_type : 'could not infer type')
|
|
|
|
|
: '';
|
|
|
|
|
|
2018-01-29 02:03:47 +01:00
|
|
|
|
if ($this->function instanceof Closure) {
|
|
|
|
|
IssueBuffer::accepts(
|
|
|
|
|
new MissingClosureParamType(
|
|
|
|
|
'Parameter $' . $function_param->name . ' has no provided type' . $infer_text,
|
|
|
|
|
$function_param->location
|
|
|
|
|
),
|
|
|
|
|
$storage->suppressed_issues
|
|
|
|
|
);
|
|
|
|
|
} else {
|
|
|
|
|
IssueBuffer::accepts(
|
|
|
|
|
new MissingParamType(
|
|
|
|
|
'Parameter $' . $function_param->name . ' has no provided type' . $infer_text,
|
|
|
|
|
$function_param->location
|
|
|
|
|
),
|
|
|
|
|
$storage->suppressed_issues
|
|
|
|
|
);
|
|
|
|
|
}
|
2017-09-03 00:15:52 +02:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-12-07 20:13:39 +01:00
|
|
|
|
if ($this->function instanceof Closure) {
|
2017-01-07 21:09:47 +01:00
|
|
|
|
$this->verifyReturnType(
|
2018-09-14 05:39:24 +02:00
|
|
|
|
$statements_checker,
|
2017-01-06 07:07:11 +01:00
|
|
|
|
$storage->return_type,
|
2017-01-07 20:35:07 +01:00
|
|
|
|
$this->source->getFQCLN(),
|
2017-01-06 07:07:11 +01:00
|
|
|
|
$storage->return_type_location
|
2016-12-07 20:13:39 +01:00
|
|
|
|
);
|
|
|
|
|
|
2018-04-10 19:05:31 +02:00
|
|
|
|
$closure_yield_types = [];
|
|
|
|
|
|
2018-05-12 00:35:02 +02:00
|
|
|
|
$closure_return_types = ReturnTypeCollector::getReturnTypes(
|
2018-04-10 19:05:31 +02:00
|
|
|
|
$this->function->stmts,
|
|
|
|
|
$closure_yield_types,
|
|
|
|
|
$ignore_nullable_issues,
|
|
|
|
|
$ignore_falsable_issues,
|
|
|
|
|
true
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
if ($closure_return_types) {
|
|
|
|
|
$closure_return_type = new Type\Union($closure_return_types);
|
|
|
|
|
|
|
|
|
|
if (!$storage->return_type
|
2018-04-10 04:00:36 +02:00
|
|
|
|
|| $storage->return_type->isMixed()
|
|
|
|
|
|| TypeChecker::isContainedBy(
|
|
|
|
|
$project_checker->codebase,
|
2018-04-10 19:05:31 +02:00
|
|
|
|
$closure_return_type,
|
2018-04-10 04:00:36 +02:00
|
|
|
|
$storage->return_type
|
|
|
|
|
)
|
2018-04-10 19:05:31 +02:00
|
|
|
|
) {
|
|
|
|
|
if ($this->function->inferredType) {
|
|
|
|
|
/** @var Type\Atomic\Fn */
|
|
|
|
|
$closure_atomic = $this->function->inferredType->getTypes()['Closure'];
|
|
|
|
|
$closure_atomic->return_type = $closure_return_type;
|
|
|
|
|
}
|
2016-08-14 05:26:45 +02:00
|
|
|
|
}
|
|
|
|
|
}
|
2016-12-07 20:13:39 +01:00
|
|
|
|
}
|
2016-08-14 05:26:45 +02:00
|
|
|
|
|
2018-01-25 07:04:26 +01:00
|
|
|
|
if ($context->collect_references
|
2018-02-17 18:02:31 +01:00
|
|
|
|
&& !$context->collect_initializations
|
2018-02-17 23:45:30 +01:00
|
|
|
|
&& $project_checker->codebase->find_unused_code
|
2018-01-25 07:04:26 +01:00
|
|
|
|
&& $context->check_variables
|
2017-02-27 07:30:44 +01:00
|
|
|
|
) {
|
2018-01-28 23:28:34 +01:00
|
|
|
|
foreach ($statements_checker->getUnusedVarLocations() as list($var_name, $original_location)) {
|
2018-01-25 07:04:26 +01:00
|
|
|
|
if (!array_key_exists(substr($var_name, 1), $storage->param_types)) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2018-03-02 17:32:34 +01:00
|
|
|
|
if (strpos($var_name, '$_') === 0 || (strpos($var_name, '$unused') === 0 && $var_name !== '$unused')) {
|
2018-02-27 17:39:26 +01:00
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2018-01-28 18:01:51 +01:00
|
|
|
|
$position = array_search(substr($var_name, 1), array_keys($storage->param_types), true);
|
|
|
|
|
|
|
|
|
|
if ($position === false) {
|
|
|
|
|
throw new \UnexpectedValueException('$position should not be false here');
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($storage->params[$position]->by_ref) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2018-01-25 07:04:26 +01:00
|
|
|
|
if (!($storage instanceof MethodStorage)
|
|
|
|
|
|| $storage->visibility === ClassLikeChecker::VISIBILITY_PRIVATE
|
2017-02-01 05:24:33 +01:00
|
|
|
|
) {
|
2018-01-25 07:04:26 +01:00
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new UnusedParam(
|
|
|
|
|
'Param ' . $var_name . ' is never referenced in this method',
|
|
|
|
|
$original_location
|
|
|
|
|
),
|
|
|
|
|
$this->getSuppressedIssues()
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
$fq_class_name = (string)$context->self;
|
|
|
|
|
|
|
|
|
|
$class_storage = $codebase->classlike_storage_provider->get($fq_class_name);
|
|
|
|
|
|
2018-01-25 21:40:01 +01:00
|
|
|
|
$method_name_lc = strtolower($storage->cased_name);
|
|
|
|
|
|
2018-02-06 19:40:28 +01:00
|
|
|
|
if ($storage->abstract || !isset($class_storage->overridden_method_ids[$method_name_lc])) {
|
2018-01-25 07:04:26 +01:00
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$parent_method_id = end($class_storage->overridden_method_ids[$method_name_lc]);
|
|
|
|
|
|
|
|
|
|
if ($parent_method_id) {
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$parent_method_storage = $codebase->methods->getStorage($parent_method_id);
|
2018-01-25 07:04:26 +01:00
|
|
|
|
|
|
|
|
|
// if the parent method has a param at that position and isn't abstract
|
|
|
|
|
if (!$parent_method_storage->abstract
|
|
|
|
|
&& isset($parent_method_storage->params[$position])
|
2017-12-29 23:27:16 +01:00
|
|
|
|
) {
|
2018-01-25 07:04:26 +01:00
|
|
|
|
continue;
|
2017-12-30 14:47:00 +01:00
|
|
|
|
}
|
|
|
|
|
}
|
2018-01-25 07:04:26 +01:00
|
|
|
|
|
|
|
|
|
$storage->unused_params[$position] = $original_location;
|
2017-12-30 14:47:00 +01:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($storage instanceof MethodStorage && $class_storage) {
|
|
|
|
|
foreach ($storage->params as $i => $_) {
|
|
|
|
|
if (!isset($storage->unused_params[$i])) {
|
|
|
|
|
$storage->used_params[$i] = true;
|
|
|
|
|
|
|
|
|
|
/** @var ClassMethod $this->function */
|
2018-01-25 07:04:26 +01:00
|
|
|
|
$method_name_lc = strtolower($storage->cased_name);
|
2017-12-30 14:47:00 +01:00
|
|
|
|
|
|
|
|
|
if (!isset($class_storage->overridden_method_ids[$method_name_lc])) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
foreach ($class_storage->overridden_method_ids[$method_name_lc] as $parent_method_id) {
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$parent_method_storage = $codebase->methods->getStorage($parent_method_id);
|
2017-12-30 14:47:00 +01:00
|
|
|
|
|
|
|
|
|
$parent_method_storage->used_params[$i] = true;
|
2017-02-08 00:18:33 +01:00
|
|
|
|
}
|
2017-02-01 05:24:33 +01:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-06-22 07:13:49 +02:00
|
|
|
|
if ($context->collect_exceptions) {
|
|
|
|
|
if ($context->possibly_thrown_exceptions) {
|
2018-06-22 07:26:10 +02:00
|
|
|
|
$ignored_exceptions = array_change_key_case($codebase->config->ignored_exceptions);
|
|
|
|
|
|
2018-06-22 07:13:49 +02:00
|
|
|
|
$undocumented_throws = array_diff_key($context->possibly_thrown_exceptions, $storage->throws);
|
|
|
|
|
|
|
|
|
|
foreach ($undocumented_throws as $possibly_thrown_exception => $_) {
|
2018-06-22 07:26:10 +02:00
|
|
|
|
if (isset($ignored_exceptions[strtolower($possibly_thrown_exception)])) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2018-06-22 07:13:49 +02:00
|
|
|
|
if (IssueBuffer::accepts(
|
|
|
|
|
new MissingThrowsDocblock(
|
|
|
|
|
$possibly_thrown_exception . ' is thrown but not caught - please either catch'
|
|
|
|
|
. ' or add a @throws annotation',
|
|
|
|
|
new CodeLocation(
|
|
|
|
|
$this,
|
|
|
|
|
$this->function,
|
|
|
|
|
null,
|
|
|
|
|
true
|
|
|
|
|
)
|
|
|
|
|
)
|
|
|
|
|
)) {
|
|
|
|
|
// fall through
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2017-01-12 03:37:53 +01:00
|
|
|
|
if ($add_mutations) {
|
|
|
|
|
if (isset($this->return_vars_in_scope[''])) {
|
|
|
|
|
$context->vars_in_scope = TypeChecker::combineKeyedTypes(
|
|
|
|
|
$context->vars_in_scope,
|
|
|
|
|
$this->return_vars_in_scope['']
|
|
|
|
|
);
|
|
|
|
|
}
|
2016-12-07 20:13:39 +01:00
|
|
|
|
|
2017-01-12 03:37:53 +01:00
|
|
|
|
if (isset($this->return_vars_possibly_in_scope[''])) {
|
|
|
|
|
$context->vars_possibly_in_scope = array_merge(
|
|
|
|
|
$context->vars_possibly_in_scope,
|
|
|
|
|
$this->return_vars_possibly_in_scope['']
|
|
|
|
|
);
|
|
|
|
|
}
|
2016-12-07 20:13:39 +01:00
|
|
|
|
|
2017-02-11 01:10:13 +01:00
|
|
|
|
foreach ($context->vars_in_scope as $var => $_) {
|
2017-01-28 02:54:27 +01:00
|
|
|
|
if (strpos($var, '$this->') !== 0 && $var !== '$this') {
|
2017-01-12 03:37:53 +01:00
|
|
|
|
unset($context->vars_in_scope[$var]);
|
|
|
|
|
}
|
2016-08-14 05:26:45 +02:00
|
|
|
|
}
|
|
|
|
|
|
2017-02-11 01:10:13 +01:00
|
|
|
|
foreach ($context->vars_possibly_in_scope as $var => $_) {
|
2017-01-28 02:54:27 +01:00
|
|
|
|
if (strpos($var, '$this->') !== 0 && $var !== '$this') {
|
2017-01-12 03:37:53 +01:00
|
|
|
|
unset($context->vars_possibly_in_scope[$var]);
|
|
|
|
|
}
|
2016-08-14 05:26:45 +02:00
|
|
|
|
}
|
2016-11-02 07:29:00 +01:00
|
|
|
|
|
2018-04-25 20:45:51 +02:00
|
|
|
|
if ($hash && $real_method_id && $this instanceof MethodChecker) {
|
2018-04-25 20:33:39 +02:00
|
|
|
|
$new_hash = $real_method_id . json_encode([
|
2017-01-12 03:37:53 +01:00
|
|
|
|
$context->vars_in_scope,
|
2017-05-27 02:05:57 +02:00
|
|
|
|
$context->vars_possibly_in_scope,
|
2018-04-25 20:33:39 +02:00
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
if ($new_hash === $hash) {
|
|
|
|
|
self::$no_effects_hashes[$hash] = [
|
|
|
|
|
$context->vars_in_scope,
|
|
|
|
|
$context->vars_possibly_in_scope,
|
|
|
|
|
];
|
|
|
|
|
}
|
2017-01-12 03:37:53 +01:00
|
|
|
|
}
|
2016-12-07 20:13:39 +01:00
|
|
|
|
}
|
|
|
|
|
|
2016-11-02 07:29:00 +01:00
|
|
|
|
return null;
|
2016-08-14 05:26:45 +02:00
|
|
|
|
}
|
|
|
|
|
|
2017-11-26 22:03:17 +01:00
|
|
|
|
/**
|
2018-02-22 00:59:31 +01:00
|
|
|
|
* @param Type\Union|null $return_type
|
|
|
|
|
* @param string $fq_class_name
|
|
|
|
|
* @param CodeLocation|null $return_type_location
|
2017-11-26 22:03:17 +01:00
|
|
|
|
*
|
2018-02-22 00:59:31 +01:00
|
|
|
|
* @return false|null
|
2017-11-26 22:03:17 +01:00
|
|
|
|
*/
|
2018-02-22 00:59:31 +01:00
|
|
|
|
public function verifyReturnType(
|
2018-09-14 05:39:24 +02:00
|
|
|
|
StatementsChecker $statements_checker,
|
2018-02-22 00:59:31 +01:00
|
|
|
|
Type\Union $return_type = null,
|
|
|
|
|
$fq_class_name = null,
|
|
|
|
|
CodeLocation $return_type_location = null
|
2017-11-26 22:03:17 +01:00
|
|
|
|
) {
|
2018-02-22 00:59:31 +01:00
|
|
|
|
ReturnTypeChecker::verifyReturnType(
|
|
|
|
|
$this->function,
|
2018-09-14 05:39:24 +02:00
|
|
|
|
$statements_checker,
|
2018-02-22 00:59:31 +01:00
|
|
|
|
$this,
|
|
|
|
|
$return_type,
|
|
|
|
|
$fq_class_name,
|
|
|
|
|
$return_type_location
|
|
|
|
|
);
|
|
|
|
|
}
|
2017-11-26 22:03:17 +01:00
|
|
|
|
|
2018-02-22 00:59:31 +01:00
|
|
|
|
/**
|
|
|
|
|
* @param string $param_name
|
|
|
|
|
* @param bool $docblock_only
|
|
|
|
|
*
|
|
|
|
|
* @return void
|
|
|
|
|
*/
|
|
|
|
|
private function addOrUpdateParamType(
|
|
|
|
|
ProjectChecker $project_checker,
|
|
|
|
|
$param_name,
|
|
|
|
|
Type\Union $inferred_return_type,
|
|
|
|
|
$docblock_only = false
|
|
|
|
|
) {
|
|
|
|
|
$manipulator = FunctionDocblockManipulator::getForFunction(
|
|
|
|
|
$project_checker,
|
|
|
|
|
$this->source->getFilePath(),
|
|
|
|
|
$this->getMethodId(),
|
|
|
|
|
$this->function
|
|
|
|
|
);
|
|
|
|
|
$manipulator->setParamType(
|
|
|
|
|
$param_name,
|
|
|
|
|
!$docblock_only && $project_checker->php_major_version >= 7
|
|
|
|
|
? $inferred_return_type->toPhpString(
|
|
|
|
|
$this->source->getNamespace(),
|
|
|
|
|
$this->source->getAliasedClassesFlipped(),
|
|
|
|
|
$this->source->getFQCLN(),
|
|
|
|
|
$project_checker->php_major_version,
|
|
|
|
|
$project_checker->php_minor_version
|
|
|
|
|
) : null,
|
|
|
|
|
$inferred_return_type->toNamespacedString(
|
|
|
|
|
$this->source->getNamespace(),
|
|
|
|
|
$this->source->getAliasedClassesFlipped(),
|
|
|
|
|
$this->source->getFQCLN(),
|
|
|
|
|
false
|
|
|
|
|
),
|
|
|
|
|
$inferred_return_type->toNamespacedString(
|
|
|
|
|
$this->source->getNamespace(),
|
|
|
|
|
$this->source->getAliasedClassesFlipped(),
|
|
|
|
|
$this->source->getFQCLN(),
|
|
|
|
|
true
|
|
|
|
|
),
|
|
|
|
|
$inferred_return_type->canBeFullyExpressedInPhp()
|
|
|
|
|
);
|
2017-11-26 22:03:17 +01:00
|
|
|
|
}
|
|
|
|
|
|
2016-08-14 05:26:45 +02:00
|
|
|
|
/**
|
|
|
|
|
* Adds return types for the given function
|
2016-11-02 07:29:00 +01:00
|
|
|
|
*
|
|
|
|
|
* @param string $return_type
|
|
|
|
|
* @param Context $context
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-11-02 07:29:00 +01:00
|
|
|
|
* @return void
|
2016-08-14 05:26:45 +02:00
|
|
|
|
*/
|
|
|
|
|
public function addReturnTypes($return_type, Context $context)
|
|
|
|
|
{
|
|
|
|
|
if (isset($this->return_vars_in_scope[$return_type])) {
|
2016-11-02 07:29:00 +01:00
|
|
|
|
$this->return_vars_in_scope[$return_type] = TypeChecker::combineKeyedTypes(
|
|
|
|
|
$context->vars_in_scope,
|
|
|
|
|
$this->return_vars_in_scope[$return_type]
|
|
|
|
|
);
|
|
|
|
|
} else {
|
2016-08-14 05:26:45 +02:00
|
|
|
|
$this->return_vars_in_scope[$return_type] = $context->vars_in_scope;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (isset($this->return_vars_possibly_in_scope[$return_type])) {
|
2016-11-02 07:29:00 +01:00
|
|
|
|
$this->return_vars_possibly_in_scope[$return_type] = array_merge(
|
|
|
|
|
$context->vars_possibly_in_scope,
|
|
|
|
|
$this->return_vars_possibly_in_scope[$return_type]
|
|
|
|
|
);
|
|
|
|
|
} else {
|
2016-08-14 05:26:45 +02:00
|
|
|
|
$this->return_vars_possibly_in_scope[$return_type] = $context->vars_possibly_in_scope;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2017-02-22 06:51:34 +01:00
|
|
|
|
/**
|
|
|
|
|
* @return null|string
|
|
|
|
|
*/
|
|
|
|
|
public function getMethodName()
|
|
|
|
|
{
|
|
|
|
|
if ($this->function instanceof ClassMethod) {
|
|
|
|
|
return (string)$this->function->name;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-08-14 05:26:45 +02:00
|
|
|
|
/**
|
2016-12-30 18:41:14 +01:00
|
|
|
|
* @param string|null $context_self
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2017-08-15 01:30:11 +02:00
|
|
|
|
* @return string
|
2016-08-14 05:26:45 +02:00
|
|
|
|
*/
|
2016-12-30 18:41:14 +01:00
|
|
|
|
public function getMethodId($context_self = null)
|
2016-08-14 05:26:45 +02:00
|
|
|
|
{
|
2016-11-21 03:49:06 +01:00
|
|
|
|
if ($this->function instanceof ClassMethod) {
|
2016-11-21 22:44:35 +01:00
|
|
|
|
$function_name = (string)$this->function->name;
|
2016-11-21 20:36:06 +01:00
|
|
|
|
|
2017-01-07 20:35:07 +01:00
|
|
|
|
return ($context_self ?: $this->source->getFQCLN()) . '::' . strtolower($function_name);
|
2016-11-21 03:49:06 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($this->function instanceof Function_) {
|
2017-11-26 22:03:17 +01:00
|
|
|
|
$namespace = $this->source->getNamespace();
|
|
|
|
|
|
2018-04-17 18:16:25 +02:00
|
|
|
|
return ($namespace ? strtolower($namespace) . '\\' : '') . strtolower($this->function->name->name);
|
2016-08-14 05:26:45 +02:00
|
|
|
|
}
|
2016-11-02 07:29:00 +01:00
|
|
|
|
|
2018-05-25 10:21:54 +02:00
|
|
|
|
return $this->getFilePath()
|
|
|
|
|
. ':' . $this->function->getLine()
|
|
|
|
|
. ':' . (int)$this->function->getAttribute('startFilePos')
|
|
|
|
|
. ':-:closure';
|
2016-08-14 05:26:45 +02:00
|
|
|
|
}
|
|
|
|
|
|
2017-12-07 21:50:25 +01:00
|
|
|
|
/**
|
|
|
|
|
* @param string|null $context_self
|
|
|
|
|
*
|
|
|
|
|
* @return string
|
|
|
|
|
*/
|
|
|
|
|
public function getCorrectlyCasedMethodId($context_self = null)
|
|
|
|
|
{
|
|
|
|
|
if ($this->function instanceof ClassMethod) {
|
|
|
|
|
$function_name = (string)$this->function->name;
|
|
|
|
|
|
|
|
|
|
return ($context_self ?: $this->source->getFQCLN()) . '::' . $function_name;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($this->function instanceof Function_) {
|
|
|
|
|
$namespace = $this->source->getNamespace();
|
|
|
|
|
|
|
|
|
|
return ($namespace ? $namespace . '\\' : '') . $this->function->name;
|
|
|
|
|
}
|
|
|
|
|
|
2018-05-25 10:21:54 +02:00
|
|
|
|
return $this->getMethodId();
|
2017-12-07 21:50:25 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-09-04 02:52:54 +02:00
|
|
|
|
/**
|
|
|
|
|
* @return FunctionLikeStorage
|
|
|
|
|
*/
|
2018-03-13 23:11:57 +01:00
|
|
|
|
public function getFunctionLikeStorage(StatementsChecker $statements_checker = null)
|
2017-09-04 02:52:54 +02:00
|
|
|
|
{
|
|
|
|
|
$project_checker = $this->getFileChecker()->project_checker;
|
2018-01-21 19:38:51 +01:00
|
|
|
|
$codebase = $project_checker->codebase;
|
2017-09-04 02:52:54 +02:00
|
|
|
|
|
2018-01-25 07:04:26 +01:00
|
|
|
|
if ($this->function instanceof ClassMethod) {
|
|
|
|
|
$method_id = (string) $this->getMethodId();
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$codebase_methods = $codebase->methods;
|
2018-01-25 07:04:26 +01:00
|
|
|
|
|
|
|
|
|
try {
|
2018-02-04 00:52:35 +01:00
|
|
|
|
return $codebase_methods->getStorage($method_id);
|
2018-01-25 07:04:26 +01:00
|
|
|
|
} catch (\UnexpectedValueException $e) {
|
2018-03-03 22:52:48 +01:00
|
|
|
|
$declaring_method_id = $codebase_methods->getDeclaringMethodId($method_id);
|
|
|
|
|
|
|
|
|
|
if (!$declaring_method_id) {
|
|
|
|
|
throw new \UnexpectedValueException('Cannot get storage for function that doesn‘t exist');
|
|
|
|
|
}
|
2017-09-04 02:52:54 +02:00
|
|
|
|
|
2018-01-25 07:04:26 +01:00
|
|
|
|
// happens for fake constructors
|
2018-02-04 00:52:35 +01:00
|
|
|
|
return $codebase_methods->getStorage($declaring_method_id);
|
2017-09-04 02:52:54 +02:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-02-04 00:52:35 +01:00
|
|
|
|
return $codebase->functions->getStorage($statements_checker, (string) $this->getMethodId());
|
2017-09-04 02:52:54 +02:00
|
|
|
|
}
|
|
|
|
|
|
2016-11-13 00:51:48 +01:00
|
|
|
|
/**
|
|
|
|
|
* @return array<string, string>
|
|
|
|
|
*/
|
|
|
|
|
public function getAliasedClassesFlipped()
|
|
|
|
|
{
|
2017-04-28 06:31:55 +02:00
|
|
|
|
if ($this->source instanceof NamespaceChecker ||
|
|
|
|
|
$this->source instanceof FileChecker ||
|
|
|
|
|
$this->source instanceof ClassLikeChecker
|
|
|
|
|
) {
|
2016-11-13 17:24:46 +01:00
|
|
|
|
return $this->source->getAliasedClassesFlipped();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return [];
|
2016-11-13 00:51:48 +01:00
|
|
|
|
}
|
|
|
|
|
|
2016-11-02 07:29:00 +01:00
|
|
|
|
/**
|
2017-01-07 20:35:07 +01:00
|
|
|
|
* @return string|null
|
2016-11-02 07:29:00 +01:00
|
|
|
|
*/
|
2016-11-08 01:16:51 +01:00
|
|
|
|
public function getFQCLN()
|
2016-08-14 05:26:45 +02:00
|
|
|
|
{
|
2017-01-07 20:35:07 +01:00
|
|
|
|
return $this->source->getFQCLN();
|
2016-08-14 05:26:45 +02:00
|
|
|
|
}
|
|
|
|
|
|
2016-11-02 07:29:00 +01:00
|
|
|
|
/**
|
|
|
|
|
* @return null|string
|
|
|
|
|
*/
|
2016-08-14 05:26:45 +02:00
|
|
|
|
public function getClassName()
|
|
|
|
|
{
|
2017-01-07 20:35:07 +01:00
|
|
|
|
return $this->source->getClassName();
|
2016-08-14 05:26:45 +02:00
|
|
|
|
}
|
|
|
|
|
|
2016-10-09 23:54:58 +02:00
|
|
|
|
/**
|
|
|
|
|
* @return string|null
|
|
|
|
|
*/
|
2017-01-07 20:35:07 +01:00
|
|
|
|
public function getParentFQCLN()
|
2016-08-14 05:26:45 +02:00
|
|
|
|
{
|
2017-01-07 20:35:07 +01:00
|
|
|
|
return $this->source->getParentFQCLN();
|
2016-08-14 05:26:45 +02:00
|
|
|
|
}
|
|
|
|
|
|
2016-11-02 07:29:00 +01:00
|
|
|
|
/**
|
|
|
|
|
* @return bool
|
|
|
|
|
*/
|
2016-08-14 05:26:45 +02:00
|
|
|
|
public function isStatic()
|
|
|
|
|
{
|
|
|
|
|
return $this->is_static;
|
|
|
|
|
}
|
|
|
|
|
|
2016-10-15 06:12:57 +02:00
|
|
|
|
/**
|
|
|
|
|
* @return StatementsSource
|
|
|
|
|
*/
|
2016-08-14 05:26:45 +02:00
|
|
|
|
public function getSource()
|
|
|
|
|
{
|
|
|
|
|
return $this->source;
|
|
|
|
|
}
|
|
|
|
|
|
2016-10-09 23:54:58 +02:00
|
|
|
|
/**
|
2016-12-17 06:48:31 +01:00
|
|
|
|
* @param string $method_id
|
|
|
|
|
* @param array<int, PhpParser\Node\Arg> $args
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-31 16:51:42 +01:00
|
|
|
|
* @return array<int, FunctionLikeParameter>
|
2016-10-09 23:54:58 +02:00
|
|
|
|
*/
|
2017-07-29 21:05:06 +02:00
|
|
|
|
public static function getMethodParamsById(ProjectChecker $project_checker, $method_id, array $args)
|
2016-08-22 21:00:12 +02:00
|
|
|
|
{
|
2016-11-07 23:29:51 +01:00
|
|
|
|
$fq_class_name = strpos($method_id, '::') !== false ? explode('::', $method_id)[0] : null;
|
2016-10-25 17:40:09 +02:00
|
|
|
|
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$codebase = $project_checker->codebase;
|
|
|
|
|
|
2018-02-01 05:27:25 +01:00
|
|
|
|
if ($fq_class_name) {
|
|
|
|
|
$class_storage = $project_checker->codebase->classlike_storage_provider->get($fq_class_name);
|
|
|
|
|
|
|
|
|
|
if ($class_storage->user_defined || $class_storage->stubbed) {
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$method_params = $codebase->methods->getMethodParams($method_id);
|
2016-12-27 02:06:05 +01:00
|
|
|
|
|
2018-02-01 05:27:25 +01:00
|
|
|
|
return $method_params;
|
|
|
|
|
}
|
2016-12-31 16:51:42 +01:00
|
|
|
|
}
|
|
|
|
|
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$declaring_method_id = $codebase->methods->getDeclaringMethodId($method_id);
|
2016-12-31 16:51:42 +01:00
|
|
|
|
|
2018-02-04 00:52:35 +01:00
|
|
|
|
if (CallMap::inCallMap($declaring_method_id ?: $method_id)) {
|
|
|
|
|
$function_param_options = CallMap::getParamsFromCallMap($declaring_method_id ?: $method_id);
|
2016-12-27 02:06:05 +01:00
|
|
|
|
|
2016-12-23 21:06:20 +01:00
|
|
|
|
if ($function_param_options === null) {
|
2017-09-20 14:43:54 +02:00
|
|
|
|
throw new \UnexpectedValueException(
|
|
|
|
|
'Not expecting $function_param_options to be null for ' . $method_id
|
|
|
|
|
);
|
2016-12-23 21:06:20 +01:00
|
|
|
|
}
|
2016-11-07 05:29:54 +01:00
|
|
|
|
|
2017-07-29 21:05:06 +02:00
|
|
|
|
return self::getMatchingParamsFromCallMapOptions($project_checker, $function_param_options, $args);
|
2016-12-31 16:51:42 +01:00
|
|
|
|
}
|
2016-12-23 21:06:20 +01:00
|
|
|
|
|
2018-02-04 00:52:35 +01:00
|
|
|
|
return $codebase->methods->getMethodParams($method_id);
|
2016-12-31 16:51:42 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param string $method_id
|
|
|
|
|
* @param array<int, PhpParser\Node\Arg> $args
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-31 16:51:42 +01:00
|
|
|
|
* @return array<int, FunctionLikeParameter>
|
|
|
|
|
*/
|
2017-07-29 21:05:06 +02:00
|
|
|
|
public static function getFunctionParamsFromCallMapById(ProjectChecker $project_checker, $method_id, array $args)
|
2016-12-31 16:51:42 +01:00
|
|
|
|
{
|
2018-02-04 00:52:35 +01:00
|
|
|
|
$function_param_options = CallMap::getParamsFromCallMap($method_id);
|
2016-12-31 16:51:42 +01:00
|
|
|
|
|
2017-02-10 02:35:17 +01:00
|
|
|
|
if ($function_param_options === null) {
|
2017-09-20 14:43:54 +02:00
|
|
|
|
throw new \UnexpectedValueException(
|
|
|
|
|
'Not expecting $function_param_options to be null for ' . $method_id
|
|
|
|
|
);
|
2016-08-22 21:00:12 +02:00
|
|
|
|
}
|
|
|
|
|
|
2017-07-29 21:05:06 +02:00
|
|
|
|
return self::getMatchingParamsFromCallMapOptions($project_checker, $function_param_options, $args);
|
2016-12-31 16:51:42 +01:00
|
|
|
|
}
|
|
|
|
|
|
2017-05-25 04:07:49 +02:00
|
|
|
|
/**
|
2016-12-31 16:51:42 +01:00
|
|
|
|
* @param array<int, array<int, FunctionLikeParameter>> $function_param_options
|
|
|
|
|
* @param array<int, PhpParser\Node\Arg> $args
|
2017-05-27 02:16:18 +02:00
|
|
|
|
*
|
2016-12-31 16:51:42 +01:00
|
|
|
|
* @return array<int, FunctionLikeParameter>
|
|
|
|
|
*/
|
2017-01-02 21:31:18 +01:00
|
|
|
|
protected static function getMatchingParamsFromCallMapOptions(
|
2017-07-29 21:05:06 +02:00
|
|
|
|
ProjectChecker $project_checker,
|
2017-01-02 21:31:18 +01:00
|
|
|
|
array $function_param_options,
|
2017-07-29 21:05:06 +02:00
|
|
|
|
array $args
|
2017-01-02 21:31:18 +01:00
|
|
|
|
) {
|
2016-08-22 21:00:12 +02:00
|
|
|
|
if (count($function_param_options) === 1) {
|
|
|
|
|
return $function_param_options[0];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
foreach ($function_param_options as $possible_function_params) {
|
|
|
|
|
$all_args_match = true;
|
|
|
|
|
|
2016-11-02 07:29:00 +01:00
|
|
|
|
$last_param = count($possible_function_params)
|
|
|
|
|
? $possible_function_params[count($possible_function_params) - 1]
|
|
|
|
|
: null;
|
2016-10-18 22:43:50 +02:00
|
|
|
|
|
2016-10-26 17:51:59 +02:00
|
|
|
|
$mandatory_param_count = count($possible_function_params);
|
|
|
|
|
|
|
|
|
|
foreach ($possible_function_params as $i => $possible_function_param) {
|
|
|
|
|
if ($possible_function_param->is_optional) {
|
|
|
|
|
$mandatory_param_count = $i;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($mandatory_param_count > count($args)) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2016-08-22 21:00:12 +02:00
|
|
|
|
foreach ($args as $argument_offset => $arg) {
|
2017-01-15 19:16:36 +01:00
|
|
|
|
if ($argument_offset >= count($possible_function_params)) {
|
|
|
|
|
if (!$last_param || !$last_param->is_variadic) {
|
|
|
|
|
$all_args_match = false;
|
|
|
|
|
}
|
|
|
|
|
|
2016-08-22 21:00:12 +02:00
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2016-10-09 23:54:58 +02:00
|
|
|
|
$param_type = $possible_function_params[$argument_offset]->type;
|
2016-08-22 21:00:12 +02:00
|
|
|
|
|
2017-09-02 17:18:56 +02:00
|
|
|
|
if (!$param_type) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2016-08-22 21:00:12 +02:00
|
|
|
|
if (!isset($arg->value->inferredType)) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2016-10-11 04:49:43 +02:00
|
|
|
|
if ($arg->value->inferredType->isMixed()) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2018-06-20 15:09:03 +02:00
|
|
|
|
if (TypeChecker::isContainedBy(
|
|
|
|
|
$project_checker->codebase,
|
|
|
|
|
$arg->value->inferredType,
|
|
|
|
|
$param_type,
|
2018-08-09 05:28:30 +02:00
|
|
|
|
true,
|
|
|
|
|
true
|
2018-06-20 15:09:03 +02:00
|
|
|
|
)) {
|
2016-10-11 04:49:43 +02:00
|
|
|
|
continue;
|
2016-08-22 21:00:12 +02:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$all_args_match = false;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($all_args_match) {
|
|
|
|
|
return $possible_function_params;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// if we don't succeed in finding a match, set to the first possible and wait for issues below
|
|
|
|
|
return $function_param_options[0];
|
|
|
|
|
}
|
2017-01-07 20:35:07 +01:00
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Get a list of suppressed issues
|
|
|
|
|
*
|
|
|
|
|
* @return array<string>
|
|
|
|
|
*/
|
|
|
|
|
public function getSuppressedIssues()
|
|
|
|
|
{
|
|
|
|
|
return $this->suppressed_issues;
|
|
|
|
|
}
|
2017-01-27 07:23:12 +01:00
|
|
|
|
|
2017-10-27 00:19:19 +02:00
|
|
|
|
/**
|
|
|
|
|
* @param array<int, string> $new_issues
|
|
|
|
|
*
|
|
|
|
|
* @return void
|
|
|
|
|
*/
|
|
|
|
|
public function addSuppressedIssues(array $new_issues)
|
|
|
|
|
{
|
|
|
|
|
$this->suppressed_issues = array_merge($new_issues, $this->suppressed_issues);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @param array<int, string> $new_issues
|
|
|
|
|
*
|
|
|
|
|
* @return void
|
|
|
|
|
*/
|
|
|
|
|
public function removeSuppressedIssues(array $new_issues)
|
|
|
|
|
{
|
|
|
|
|
$this->suppressed_issues = array_diff($this->suppressed_issues, $new_issues);
|
|
|
|
|
}
|
|
|
|
|
|
2017-07-26 22:09:09 +02:00
|
|
|
|
/**
|
|
|
|
|
* Adds a suppressed issue, useful when creating a method checker from scratch
|
|
|
|
|
*
|
2017-07-27 05:47:29 +02:00
|
|
|
|
* @param string $issue_name
|
|
|
|
|
*
|
2017-07-26 22:09:09 +02:00
|
|
|
|
* @return void
|
|
|
|
|
*/
|
2017-07-27 05:47:29 +02:00
|
|
|
|
public function addSuppressedIssue($issue_name)
|
2017-07-26 22:09:09 +02:00
|
|
|
|
{
|
|
|
|
|
$this->suppressed_issues[] = $issue_name;
|
|
|
|
|
}
|
|
|
|
|
|
2017-01-27 07:23:12 +01:00
|
|
|
|
/**
|
|
|
|
|
* @return void
|
|
|
|
|
*/
|
|
|
|
|
public static function clearCache()
|
|
|
|
|
{
|
|
|
|
|
self::$no_effects_hashes = [];
|
|
|
|
|
}
|
2017-07-29 21:05:06 +02:00
|
|
|
|
|
2017-11-26 22:03:17 +01:00
|
|
|
|
/**
|
|
|
|
|
* @return FileChecker
|
|
|
|
|
*/
|
2017-07-29 21:05:06 +02:00
|
|
|
|
public function getFileChecker()
|
|
|
|
|
{
|
|
|
|
|
return $this->file_checker;
|
|
|
|
|
}
|
2018-01-14 18:09:40 +01:00
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @return Type\Union
|
|
|
|
|
*/
|
|
|
|
|
public function getLocalReturnType(Type\Union $storage_return_type)
|
|
|
|
|
{
|
|
|
|
|
if ($this->local_return_type) {
|
|
|
|
|
return $this->local_return_type;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$this->local_return_type = ExpressionChecker::fleshOutType(
|
|
|
|
|
$this->file_checker->project_checker,
|
|
|
|
|
$storage_return_type,
|
|
|
|
|
$this->getFQCLN(),
|
2018-01-26 19:51:00 +01:00
|
|
|
|
$this->getFQCLN()
|
2018-01-14 18:09:40 +01:00
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
return $this->local_return_type;
|
|
|
|
|
}
|
2016-08-14 05:26:45 +02:00
|
|
|
|
}
|