1
0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
psalm/tests/TraitTest.php

487 lines
14 KiB
PHP
Raw Normal View History

2016-12-17 04:16:29 +01:00
<?php
namespace Psalm\Tests;
class TraitTest extends TestCase
2016-12-17 04:16:29 +01:00
{
use Traits\FileCheckerInvalidCodeParseTestTrait;
use Traits\FileCheckerValidCodeParseTestTrait;
2016-12-17 04:16:29 +01:00
2017-01-13 20:07:23 +01:00
/**
* @return array
2017-01-13 20:07:23 +01:00
*/
public function providerFileCheckerValidCodeParse()
2016-12-17 04:16:29 +01:00
{
return [
'accessiblePrivateMethodFromTrait' => [
'<?php
trait T {
private function fooFoo() : void {
}
}
class B {
use T;
public function doFoo() : void {
$this->fooFoo();
}
2017-05-27 02:05:57 +02:00
}',
],
'accessibleProtectedMethodFromTrait' => [
'<?php
trait T {
protected function fooFoo() : void {
}
}
class B {
use T;
public function doFoo() : void {
$this->fooFoo();
}
2017-05-27 02:05:57 +02:00
}',
],
'accessiblePublicMethodFromTrait' => [
'<?php
trait T {
public function fooFoo() : void {
}
}
class B {
use T;
public function doFoo() : void {
$this->fooFoo();
}
2017-05-27 02:05:57 +02:00
}',
],
'accessiblePrivatePropertyFromTrait' => [
'<?php
trait T {
/** @var string */
private $fooFoo = "";
}
class B {
use T;
public function doFoo() : void {
echo $this->fooFoo;
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
$this->fooFoo = "hello";
}
2017-05-27 02:05:57 +02:00
}',
],
'accessibleProtectedPropertyFromTrait' => [
'<?php
trait T {
/** @var string */
protected $fooFoo = "";
}
class B {
use T;
public function doFoo() : void {
echo $this->fooFoo;
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
$this->fooFoo = "hello";
}
2017-05-27 02:05:57 +02:00
}',
],
'accessiblePublicPropertyFromTrait' => [
'<?php
trait T {
/** @var string */
public $fooFoo = "";
}
class B {
use T;
public function doFoo() : void {
echo $this->fooFoo;
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
$this->fooFoo = "hello";
}
2017-05-27 02:05:57 +02:00
}',
],
'accessibleProtectedMethodFromInheritedTrait' => [
'<?php
trait T {
protected function fooFoo() : void {
}
}
class B {
use T;
}
class C extends B {
public function doFoo() : void {
$this->fooFoo();
}
2017-05-27 02:05:57 +02:00
}',
],
'accessiblePublicMethodFromInheritedTrait' => [
'<?php
trait T {
public function fooFoo() : void {
}
}
class B {
use T;
}
class C extends B {
public function doFoo() : void {
$this->fooFoo();
}
2017-05-27 02:05:57 +02:00
}',
],
'staticClassMethodFromWithinTrait' => [
'<?php
trait T {
public function fooFoo() : void {
self::barBar();
}
}
class B {
use T;
public static function barBar() : void {
}
2017-05-27 02:05:57 +02:00
}',
],
'redefinedTraitMethodWithoutAlias' => [
'<?php
trait T {
public function fooFoo() : void {
}
}
class B {
use T;
public function fooFoo(string $a) : void {
}
}
2017-05-27 02:05:57 +02:00
(new B)->fooFoo("hello");',
],
'redefinedTraitMethodWithAlias' => [
'<?php
trait T {
public function fooFoo() : void {
}
}
class B {
use T {
fooFoo as barBar;
}
public function fooFoo() : void {
$this->barBar();
}
2017-05-27 02:05:57 +02:00
}',
],
'traitSelf' => [
'<?php
trait T {
public function g(): self
{
return $this;
}
}
class A {
use T;
}
$a = (new A)->g();',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$a' => 'A',
2017-05-27 02:05:57 +02:00
],
],
'parentTraitSelf' => [
'<?php
trait T {
public function g(): self
{
return $this;
}
}
class A {
use T;
}
class B extends A {
}
class C {
use T;
}
$a = (new B)->g();',
'assertions' => [
2017-06-29 16:22:49 +02:00
'$a' => 'A',
2017-05-27 02:05:57 +02:00
],
],
'directStaticCall' => [
'<?php
trait T {
/** @return void */
public static function foo() {}
}
class A {
use T;
/** @return void */
public function bar() {
T::foo();
}
2017-05-27 02:05:57 +02:00
}',
],
'abstractTraitMethod' => [
'<?php
trait T {
/** @return void */
abstract public function foo();
}
abstract class A {
use T;
/** @return void */
public function bar() {
$this->foo();
}
2017-05-27 02:05:57 +02:00
}',
],
'instanceOfTraitUser' => [
'<?php
trait T {
public function f() : void {
if ($this instanceof A) { }
}
}
class A {
use T;
}
class B {
use T;
}',
],
'getClassTraitUser' => [
'<?php
trait T {
public function f() : void {
if (get_class($this) === "B") { }
}
}
class A {
use T;
}
class B {
use T;
}',
],
'useTraitInClassWithAbstractMethod' => [
'<?php
trait T {
abstract public function foo() : void;
}
class A {
public function foo() : void {}
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
}',
],
'useTraitInSubclassWithAbstractMethod' => [
'<?php
trait T {
abstract public function foo() : void;
}
abstract class A {
public function foo() : void {}
}
class B extends A {
use T;
}',
],
'useTraitInSubclassWithAbstractMethodInParent' => [
'<?php
trait T {
public function foo() : void {}
}
abstract class A {
abstract public function foo() : void {}
}
class B extends A {
use T;
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
}',
],
'differentMethodReturnTypes' => [
'<?php
trait T {
public static function getSelf() : self {
return new self();
}
public static function callGetSelf() : self {
return self::getSelf();
}
}
class A {
use T;
}
class B {
use T;
}',
],
'parentRefInTraitShouldNotFail' => [
'<?php
trait T {
public function foo() : void {
parent::foo();
}
}
class A {
public function foo() : void {}
}
class B extends A {
use T;
}',
],
];
2016-12-17 04:16:29 +01:00
}
2017-01-13 20:07:23 +01:00
/**
* @return array
2017-01-13 20:07:23 +01:00
*/
public function providerFileCheckerInvalidCodeParse()
2016-12-17 04:16:29 +01:00
{
return [
'inaccessiblePrivateMethodFromInheritedTrait' => [
'<?php
trait T {
private function fooFoo() : void {
}
}
class B {
use T;
}
class C extends B {
public function doFoo() : void {
$this->fooFoo();
}
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'InaccessibleMethod',
],
'undefinedTrait' => [
'<?php
class B {
use A;
}',
2017-05-27 02:05:57 +02:00
'error_message' => 'UndefinedTrait',
],
'missingPropertyType' => [
'<?php
trait T {
public $foo;
}
class A {
use T;
public function assignToFoo() : void {
$this->foo = 5;
}
}',
2017-07-25 23:04:58 +02:00
'error_message' => 'MissingPropertyType - src/somefile.php:3 - Property T::$foo does not have a ' .
2017-05-27 02:05:57 +02:00
'declared type - consider null|int',
],
'missingPropertyTypeWithConstructorInit' => [
'<?php
trait T {
public $foo;
}
class A {
use T;
public function __construct() : void {
$this->foo = 5;
}
}',
2017-07-25 23:04:58 +02:00
'error_message' => 'MissingPropertyType - src/somefile.php:3 - Property T::$foo does not have a ' .
2017-05-27 02:05:57 +02:00
'declared type - consider int',
],
'missingPropertyTypeWithConstructorInitAndNull' => [
'<?php
trait T {
public $foo;
}
class A {
use T;
public function __construct() : void {
$this->foo = 5;
}
public function makeNull() : void {
$this->foo = null;
}
}',
2017-07-25 23:04:58 +02:00
'error_message' => 'MissingPropertyType - src/somefile.php:3 - Property T::$foo does not have a ' .
2017-05-27 02:05:57 +02:00
'declared type - consider null|int',
],
'missingPropertyTypeWithConstructorInitAndNullDefault' => [
'<?php
trait T {
public $foo = null;
}
class A {
use T;
public function __construct() : void {
$this->foo = 5;
}
}',
2017-07-25 23:04:58 +02:00
'error_message' => 'MissingPropertyType - src/somefile.php:3 - Property T::$foo does not have a ' .
2017-05-27 02:05:57 +02:00
'declared type - consider int|nul',
],
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
'redefinedTraitMethodInSubclass' => [
'<?php
trait T {
public function fooFoo() : void {
}
}
class B {
use T;
}
class C extends B {
public function fooFoo(string $a) : void {
}
}',
'error_message' => 'MethodSignatureMismatch',
],
];
}
2016-12-17 04:16:29 +01:00
}