2018-01-14 18:09:40 +01:00
|
|
|
<?php
|
2018-11-06 03:57:36 +01:00
|
|
|
namespace Psalm\Internal\Analyzer\Statements\Expression;
|
2018-01-14 18:09:40 +01:00
|
|
|
|
|
|
|
use PhpParser;
|
2020-09-03 02:08:09 +02:00
|
|
|
use Psalm\Internal\Analyzer\AlgebraAnalyzer;
|
2018-11-06 03:57:36 +01:00
|
|
|
use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
|
2019-05-02 19:43:18 +02:00
|
|
|
use \Psalm\Internal\Analyzer\Statements\Block\IfAnalyzer;
|
2018-11-06 03:57:36 +01:00
|
|
|
use Psalm\Internal\Analyzer\StatementsAnalyzer;
|
2018-01-14 18:09:40 +01:00
|
|
|
use Psalm\CodeLocation;
|
|
|
|
use Psalm\Context;
|
|
|
|
use Psalm\Type;
|
2018-05-07 07:26:06 +02:00
|
|
|
use Psalm\Type\Algebra;
|
2018-01-14 18:09:40 +01:00
|
|
|
use Psalm\Type\Reconciler;
|
2019-08-10 19:22:21 +02:00
|
|
|
use Psalm\Internal\Type\AssertionReconciler;
|
2019-06-26 22:52:29 +02:00
|
|
|
use function array_merge;
|
|
|
|
use function array_map;
|
|
|
|
use function array_filter;
|
|
|
|
use function array_values;
|
|
|
|
use function array_keys;
|
|
|
|
use function preg_match;
|
|
|
|
use function preg_quote;
|
|
|
|
use function array_intersect_key;
|
2018-01-14 18:09:40 +01:00
|
|
|
|
2018-12-02 00:37:49 +01:00
|
|
|
/**
|
|
|
|
* @internal
|
|
|
|
*/
|
2018-11-06 03:57:36 +01:00
|
|
|
class TernaryAnalyzer
|
2018-01-14 18:09:40 +01:00
|
|
|
{
|
|
|
|
public static function analyze(
|
2018-11-11 18:01:14 +01:00
|
|
|
StatementsAnalyzer $statements_analyzer,
|
2018-01-14 18:09:40 +01:00
|
|
|
PhpParser\Node\Expr\Ternary $stmt,
|
|
|
|
Context $context
|
2020-05-18 21:13:27 +02:00
|
|
|
) : bool {
|
2019-12-06 18:47:27 +01:00
|
|
|
$codebase = $statements_analyzer->getCodebase();
|
2019-05-02 19:43:18 +02:00
|
|
|
|
2019-12-06 18:47:27 +01:00
|
|
|
$if_scope = new \Psalm\Internal\Scope\IfScope();
|
2019-05-02 19:43:18 +02:00
|
|
|
|
2019-12-06 18:47:27 +01:00
|
|
|
try {
|
|
|
|
$if_conditional_scope = IfAnalyzer::analyzeIfConditional(
|
|
|
|
$statements_analyzer,
|
|
|
|
$stmt->cond,
|
|
|
|
$context,
|
|
|
|
$codebase,
|
|
|
|
$if_scope,
|
|
|
|
$context->branch_point ?: (int) $stmt->getAttribute('startFilePos')
|
2019-05-02 19:43:18 +02:00
|
|
|
);
|
|
|
|
|
2019-12-06 18:47:27 +01:00
|
|
|
$if_context = $if_conditional_scope->if_context;
|
2019-05-02 19:43:18 +02:00
|
|
|
|
2019-12-06 18:47:27 +01:00
|
|
|
$cond_referenced_var_ids = $if_conditional_scope->cond_referenced_var_ids;
|
2020-09-03 02:08:09 +02:00
|
|
|
$cond_assigned_var_ids = $if_conditional_scope->cond_assigned_var_ids;
|
2019-12-06 18:47:27 +01:00
|
|
|
} catch (\Psalm\Exception\ScopeAnalysisException $e) {
|
|
|
|
return false;
|
2019-05-02 19:43:18 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
$codebase = $statements_analyzer->getCodebase();
|
|
|
|
|
2020-08-26 21:35:29 +02:00
|
|
|
$cond_id = \spl_object_id($stmt->cond);
|
|
|
|
|
2018-05-07 07:26:06 +02:00
|
|
|
$if_clauses = \Psalm\Type\Algebra::getFormula(
|
2020-08-26 21:35:29 +02:00
|
|
|
$cond_id,
|
|
|
|
$cond_id,
|
2018-01-14 18:09:40 +01:00
|
|
|
$stmt->cond,
|
2019-12-28 21:56:19 +01:00
|
|
|
$context->self,
|
2018-11-11 18:01:14 +01:00
|
|
|
$statements_analyzer,
|
2018-11-06 03:57:36 +01:00
|
|
|
$codebase
|
2018-01-14 18:09:40 +01:00
|
|
|
);
|
|
|
|
|
2018-08-24 22:48:14 +02:00
|
|
|
$mixed_var_ids = [];
|
2018-05-31 02:54:03 +02:00
|
|
|
|
|
|
|
foreach ($context->vars_in_scope as $var_id => $type) {
|
2018-12-08 19:18:55 +01:00
|
|
|
if ($type->hasMixed()) {
|
2018-05-31 02:54:03 +02:00
|
|
|
$mixed_var_ids[] = $var_id;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach ($context->vars_possibly_in_scope as $var_id => $_) {
|
|
|
|
if (!isset($context->vars_in_scope[$var_id])) {
|
|
|
|
$mixed_var_ids[] = $var_id;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$if_clauses = array_values(
|
|
|
|
array_map(
|
|
|
|
/**
|
2018-11-06 03:57:36 +01:00
|
|
|
* @return \Psalm\Internal\Clause
|
2018-05-31 02:54:03 +02:00
|
|
|
*/
|
2020-09-12 17:24:05 +02:00
|
|
|
function (\Psalm\Internal\Clause $c) use ($mixed_var_ids, $cond_id): \Psalm\Internal\Clause {
|
2018-05-31 02:54:03 +02:00
|
|
|
$keys = array_keys($c->possibilities);
|
|
|
|
|
2019-11-12 16:21:27 +01:00
|
|
|
$mixed_var_ids = \array_diff($mixed_var_ids, $keys);
|
2019-11-12 16:12:07 +01:00
|
|
|
|
2018-05-31 02:54:03 +02:00
|
|
|
foreach ($keys as $key) {
|
|
|
|
foreach ($mixed_var_ids as $mixed_var_id) {
|
|
|
|
if (preg_match('/^' . preg_quote($mixed_var_id, '/') . '(\[|-)/', $key)) {
|
2020-08-26 21:35:29 +02:00
|
|
|
return new \Psalm\Internal\Clause([], $cond_id, $cond_id, true);
|
2018-05-31 02:54:03 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return $c;
|
|
|
|
},
|
|
|
|
$if_clauses
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2020-09-03 02:08:09 +02:00
|
|
|
// this will see whether any of the clauses in set A conflict with the clauses in set B
|
|
|
|
AlgebraAnalyzer::checkForParadox(
|
|
|
|
$context->clauses,
|
|
|
|
$if_clauses,
|
|
|
|
$statements_analyzer,
|
|
|
|
$stmt->cond,
|
|
|
|
$cond_assigned_var_ids
|
|
|
|
);
|
|
|
|
|
2019-12-08 06:49:34 +01:00
|
|
|
$ternary_clauses = array_merge($context->clauses, $if_clauses);
|
|
|
|
|
|
|
|
if ($if_context->reconciled_expression_clauses) {
|
|
|
|
$reconciled_expression_clauses = $if_context->reconciled_expression_clauses;
|
|
|
|
|
|
|
|
$ternary_clauses = array_values(
|
|
|
|
array_filter(
|
|
|
|
$ternary_clauses,
|
2020-09-12 17:24:05 +02:00
|
|
|
function ($c) use ($reconciled_expression_clauses): bool {
|
2020-08-26 16:41:47 +02:00
|
|
|
return !\in_array($c->hash, $reconciled_expression_clauses);
|
2019-12-08 06:49:34 +01:00
|
|
|
}
|
|
|
|
)
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
$ternary_clauses = Algebra::simplifyCNF($ternary_clauses);
|
2018-01-14 18:09:40 +01:00
|
|
|
|
2018-05-07 07:26:06 +02:00
|
|
|
$negated_clauses = Algebra::negateFormula($if_clauses);
|
2018-01-14 18:09:40 +01:00
|
|
|
|
2018-05-07 07:26:06 +02:00
|
|
|
$negated_if_types = Algebra::getTruthsFromFormula(
|
|
|
|
Algebra::simplifyCNF(
|
2018-05-06 02:52:10 +02:00
|
|
|
array_merge($context->clauses, $negated_clauses)
|
|
|
|
)
|
|
|
|
);
|
2018-01-14 18:09:40 +01:00
|
|
|
|
2019-12-08 22:35:56 +01:00
|
|
|
$active_if_types = [];
|
|
|
|
|
|
|
|
$reconcilable_if_types = Algebra::getTruthsFromFormula(
|
|
|
|
$ternary_clauses,
|
2020-08-26 21:35:29 +02:00
|
|
|
$cond_id,
|
2019-12-08 22:35:56 +01:00
|
|
|
$cond_referenced_var_ids,
|
|
|
|
$active_if_types
|
|
|
|
);
|
2018-01-14 18:09:40 +01:00
|
|
|
|
|
|
|
$changed_var_ids = [];
|
|
|
|
|
2018-12-17 21:23:56 +01:00
|
|
|
if ($reconcilable_if_types) {
|
2019-12-06 18:47:27 +01:00
|
|
|
$if_vars_in_scope_reconciled = Reconciler::reconcileKeyedTypes(
|
2018-12-17 21:23:56 +01:00
|
|
|
$reconcilable_if_types,
|
2019-12-08 22:35:56 +01:00
|
|
|
$active_if_types,
|
2019-12-06 18:47:27 +01:00
|
|
|
$if_context->vars_in_scope,
|
2018-12-17 21:23:56 +01:00
|
|
|
$changed_var_ids,
|
2019-05-02 19:43:18 +02:00
|
|
|
$cond_referenced_var_ids,
|
2018-12-17 21:23:56 +01:00
|
|
|
$statements_analyzer,
|
2019-12-29 00:37:55 +01:00
|
|
|
$statements_analyzer->getTemplateTypeMap() ?: [],
|
2019-12-06 18:47:27 +01:00
|
|
|
$if_context->inside_loop,
|
2018-12-17 21:23:56 +01:00
|
|
|
new CodeLocation($statements_analyzer->getSource(), $stmt->cond)
|
|
|
|
);
|
|
|
|
|
2019-12-06 18:47:27 +01:00
|
|
|
$if_context->vars_in_scope = $if_vars_in_scope_reconciled;
|
2018-12-17 21:23:56 +01:00
|
|
|
}
|
2018-01-14 18:09:40 +01:00
|
|
|
|
|
|
|
$t_else_context = clone $context;
|
|
|
|
|
|
|
|
if ($stmt->if) {
|
2019-12-06 18:47:27 +01:00
|
|
|
if (ExpressionAnalyzer::analyze($statements_analyzer, $stmt->if, $if_context) === false) {
|
2018-01-14 18:09:40 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2019-12-06 18:47:27 +01:00
|
|
|
foreach ($if_context->vars_in_scope as $var_id => $type) {
|
2018-01-14 18:09:40 +01:00
|
|
|
if (isset($context->vars_in_scope[$var_id])) {
|
|
|
|
$context->vars_in_scope[$var_id] = Type::combineUnionTypes($context->vars_in_scope[$var_id], $type);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$context->referenced_var_ids = array_merge(
|
|
|
|
$context->referenced_var_ids,
|
2019-12-06 18:47:27 +01:00
|
|
|
$if_context->referenced_var_ids
|
2018-01-14 18:09:40 +01:00
|
|
|
);
|
2018-01-25 07:04:26 +01:00
|
|
|
|
|
|
|
$context->unreferenced_vars = array_intersect_key(
|
|
|
|
$context->unreferenced_vars,
|
2019-12-06 18:47:27 +01:00
|
|
|
$if_context->unreferenced_vars
|
2018-01-25 07:04:26 +01:00
|
|
|
);
|
2018-01-14 18:09:40 +01:00
|
|
|
}
|
|
|
|
|
2020-09-03 02:08:09 +02:00
|
|
|
$t_else_context->clauses = Algebra::simplifyCNF(
|
|
|
|
array_merge(
|
|
|
|
$t_else_context->clauses,
|
|
|
|
$negated_clauses
|
|
|
|
)
|
|
|
|
);
|
|
|
|
|
2018-01-14 18:09:40 +01:00
|
|
|
if ($negated_if_types) {
|
2020-09-03 02:08:09 +02:00
|
|
|
$changed_var_ids = [];
|
|
|
|
|
2018-01-14 18:09:40 +01:00
|
|
|
$t_else_vars_in_scope_reconciled = Reconciler::reconcileKeyedTypes(
|
2019-12-08 22:35:56 +01:00
|
|
|
$negated_if_types,
|
2018-01-14 18:09:40 +01:00
|
|
|
$negated_if_types,
|
|
|
|
$t_else_context->vars_in_scope,
|
|
|
|
$changed_var_ids,
|
2019-05-02 19:43:18 +02:00
|
|
|
$cond_referenced_var_ids,
|
2018-11-11 18:01:14 +01:00
|
|
|
$statements_analyzer,
|
2019-12-29 00:37:55 +01:00
|
|
|
$statements_analyzer->getTemplateTypeMap() ?: [],
|
2018-12-08 19:18:55 +01:00
|
|
|
$t_else_context->inside_loop,
|
2018-11-14 19:44:20 +01:00
|
|
|
new CodeLocation($statements_analyzer->getSource(), $stmt->else)
|
2018-01-14 18:09:40 +01:00
|
|
|
);
|
|
|
|
|
|
|
|
$t_else_context->vars_in_scope = $t_else_vars_in_scope_reconciled;
|
2020-09-03 02:08:09 +02:00
|
|
|
|
|
|
|
$t_else_context->clauses = Context::removeReconciledClauses($t_else_context->clauses, $changed_var_ids)[0];
|
2018-01-14 18:09:40 +01:00
|
|
|
}
|
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
if (ExpressionAnalyzer::analyze($statements_analyzer, $stmt->else, $t_else_context) === false) {
|
2018-01-14 18:09:40 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach ($t_else_context->vars_in_scope as $var_id => $type) {
|
|
|
|
if (isset($context->vars_in_scope[$var_id])) {
|
2018-06-01 03:57:17 +02:00
|
|
|
$context->vars_in_scope[$var_id] = Type::combineUnionTypes(
|
|
|
|
$context->vars_in_scope[$var_id],
|
|
|
|
$type
|
|
|
|
);
|
2019-12-12 06:37:00 +01:00
|
|
|
} elseif (isset($if_context->vars_in_scope[$var_id])
|
|
|
|
&& isset($if_context->assigned_var_ids[$var_id])
|
|
|
|
) {
|
2018-06-01 03:57:17 +02:00
|
|
|
$context->vars_in_scope[$var_id] = Type::combineUnionTypes(
|
2019-12-06 18:47:27 +01:00
|
|
|
$if_context->vars_in_scope[$var_id],
|
2018-06-01 03:57:17 +02:00
|
|
|
$type
|
|
|
|
);
|
2018-01-14 18:09:40 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-06-01 03:57:17 +02:00
|
|
|
$context->vars_possibly_in_scope = array_merge(
|
|
|
|
$context->vars_possibly_in_scope,
|
2019-12-06 18:47:27 +01:00
|
|
|
$if_context->vars_possibly_in_scope,
|
2018-06-01 03:57:17 +02:00
|
|
|
$t_else_context->vars_possibly_in_scope
|
|
|
|
);
|
|
|
|
|
2018-01-14 18:09:40 +01:00
|
|
|
$context->referenced_var_ids = array_merge(
|
|
|
|
$context->referenced_var_ids,
|
|
|
|
$t_else_context->referenced_var_ids
|
|
|
|
);
|
|
|
|
|
2018-01-25 07:04:26 +01:00
|
|
|
$context->unreferenced_vars = array_intersect_key(
|
|
|
|
$context->unreferenced_vars,
|
|
|
|
$t_else_context->unreferenced_vars
|
|
|
|
);
|
|
|
|
|
2019-11-13 21:06:22 +01:00
|
|
|
foreach ($context->unreferenced_vars as $var_id => $_) {
|
2019-11-13 20:32:27 +01:00
|
|
|
if (isset($t_else_context->unreferenced_vars[$var_id])) {
|
|
|
|
$context->unreferenced_vars[$var_id] += $t_else_context->unreferenced_vars[$var_id];
|
|
|
|
}
|
|
|
|
|
2019-12-06 18:47:27 +01:00
|
|
|
if (isset($if_context->unreferenced_vars[$var_id])) {
|
|
|
|
$context->unreferenced_vars[$var_id] += $if_context->unreferenced_vars[$var_id];
|
2019-11-13 20:32:27 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-01-14 18:09:40 +01:00
|
|
|
$lhs_type = null;
|
|
|
|
|
|
|
|
if ($stmt->if) {
|
2019-11-25 17:44:54 +01:00
|
|
|
if ($stmt_if_type = $statements_analyzer->node_data->getType($stmt->if)) {
|
|
|
|
$lhs_type = $stmt_if_type;
|
2018-01-14 18:09:40 +01:00
|
|
|
}
|
2019-11-25 17:44:54 +01:00
|
|
|
} elseif ($stmt_cond_type = $statements_analyzer->node_data->getType($stmt->cond)) {
|
2019-08-10 19:22:21 +02:00
|
|
|
$if_return_type_reconciled = AssertionReconciler::reconcile(
|
2018-01-14 18:09:40 +01:00
|
|
|
'!falsy',
|
2019-11-25 17:44:54 +01:00
|
|
|
clone $stmt_cond_type,
|
2018-01-14 18:09:40 +01:00
|
|
|
'',
|
2018-11-11 18:01:14 +01:00
|
|
|
$statements_analyzer,
|
2018-12-08 19:18:55 +01:00
|
|
|
$context->inside_loop,
|
2019-01-23 05:42:54 +01:00
|
|
|
[],
|
2018-11-11 18:01:14 +01:00
|
|
|
new CodeLocation($statements_analyzer->getSource(), $stmt),
|
|
|
|
$statements_analyzer->getSuppressedIssues()
|
2018-01-14 18:09:40 +01:00
|
|
|
);
|
|
|
|
|
|
|
|
$lhs_type = $if_return_type_reconciled;
|
|
|
|
}
|
|
|
|
|
2019-11-25 17:44:54 +01:00
|
|
|
if ($lhs_type && ($stmt_else_type = $statements_analyzer->node_data->getType($stmt->else))) {
|
|
|
|
$statements_analyzer->node_data->setType($stmt, Type::combineUnionTypes($lhs_type, $stmt_else_type));
|
2018-01-14 18:09:40 +01:00
|
|
|
} else {
|
2019-11-25 17:44:54 +01:00
|
|
|
$statements_analyzer->node_data->setType($stmt, Type::getMixed());
|
2018-01-14 18:09:40 +01:00
|
|
|
}
|
|
|
|
|
2020-05-18 21:13:27 +02:00
|
|
|
return true;
|
2018-01-14 18:09:40 +01:00
|
|
|
}
|
|
|
|
}
|