2016-06-20 22:18:47 +02:00
|
|
|
|
<?php
|
2019-12-06 20:58:18 +01:00
|
|
|
|
namespace Psalm\Tests\TypeReconciliation;
|
2016-06-20 22:18:47 +02:00
|
|
|
|
|
2019-06-26 22:52:29 +02:00
|
|
|
|
use const DIRECTORY_SEPARATOR;
|
|
|
|
|
|
2019-12-06 20:58:18 +01:00
|
|
|
|
class ScopeTest extends \Psalm\Tests\TestCase
|
2016-06-20 22:18:47 +02:00
|
|
|
|
{
|
2019-12-06 20:58:18 +01:00
|
|
|
|
use \Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
|
|
|
|
|
use \Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;
|
2017-02-13 01:07:25 +01:00
|
|
|
|
|
2017-01-13 20:07:23 +01:00
|
|
|
|
/**
|
2019-03-01 21:55:20 +01:00
|
|
|
|
* @return iterable<string,array{string,assertions?:array<string,string>,error_levels?:string[]}>
|
2017-01-13 20:07:23 +01:00
|
|
|
|
*/
|
2020-09-12 17:24:05 +02:00
|
|
|
|
public function providerValidCodeParse(): iterable
|
2016-10-18 22:14:52 +02:00
|
|
|
|
{
|
2017-04-25 05:45:02 +02:00
|
|
|
|
return [
|
|
|
|
|
'newVarInIf' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (rand(0,100) === 10) {
|
|
|
|
|
$badge = "hello";
|
2016-12-27 19:58:58 +01:00
|
|
|
|
}
|
2017-04-25 05:45:02 +02:00
|
|
|
|
else {
|
|
|
|
|
$badge = "goodbye";
|
|
|
|
|
}
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-05-27 02:05:57 +02:00
|
|
|
|
echo $badge;',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'newVarInIfWithElseReturn' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (rand(0,100) === 10) {
|
|
|
|
|
$badge = "hello";
|
|
|
|
|
}
|
|
|
|
|
else {
|
|
|
|
|
throw new \Exception();
|
|
|
|
|
}
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-05-27 02:05:57 +02:00
|
|
|
|
echo $badge;',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'assignmentInIf' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if ($row = (rand(0, 10) ? [5] : null)) {
|
|
|
|
|
echo $row[0];
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'negatedAssignmentInIf' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (!($row = (rand(0, 10) ? [5] : null))) {
|
|
|
|
|
// do nothing
|
|
|
|
|
}
|
|
|
|
|
else {
|
|
|
|
|
echo $row[0];
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'assignInElseIf' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (rand(0, 10) > 5) {
|
|
|
|
|
echo "hello";
|
|
|
|
|
} elseif ($row = (rand(0, 10) ? [5] : null)) {
|
|
|
|
|
echo $row[0];
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'ifNotEqualsFalse' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (($row = rand(0,10) ? [1] : false) !== false) {
|
|
|
|
|
echo $row[0];
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'ifNotEqualsNull' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (($row = rand(0,10) ? [1] : null) !== null) {
|
|
|
|
|
echo $row[0];
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'ifNullNotEquals' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (null !== ($row = rand(0,10) ? [1] : null)) {
|
|
|
|
|
echo $row[0];
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'ifNullEquals' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (null === ($row = rand(0,10) ? [1] : null)) {
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
} else {
|
|
|
|
|
echo $row[0];
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'passedByRefInIf' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (preg_match("/bad/", "badger", $matches)) {
|
|
|
|
|
echo (string)$matches[0];
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'passByRefInIfCheckAfter' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (!preg_match("/bad/", "badger", $matches)) {
|
|
|
|
|
exit();
|
|
|
|
|
}
|
2017-05-27 02:05:57 +02:00
|
|
|
|
echo (string)$matches[0];',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'passByRefInIfWithBoolean' => [
|
|
|
|
|
'<?php
|
2017-12-09 20:53:39 +01:00
|
|
|
|
$a = (bool)rand(0, 1);
|
2017-04-25 05:45:02 +02:00
|
|
|
|
if ($a && preg_match("/bad/", "badger", $matches)) {
|
|
|
|
|
echo (string)$matches[0];
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'passByRefInVarWithBoolean' => [
|
|
|
|
|
'<?php
|
|
|
|
|
$a = preg_match("/bad/", "badger", $matches) > 0;
|
|
|
|
|
if ($a) {
|
|
|
|
|
echo (string)$matches[1];
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'functionExists' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (true && function_exists("flabble")) {
|
|
|
|
|
flabble();
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'nestedPropertyFetchInElseif' => [
|
|
|
|
|
'<?php
|
|
|
|
|
class A {
|
|
|
|
|
/** @var A|null */
|
|
|
|
|
public $foo;
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2018-01-11 21:50:45 +01:00
|
|
|
|
public function __toString(): string {
|
2017-04-25 05:45:02 +02:00
|
|
|
|
return "boop";
|
|
|
|
|
}
|
|
|
|
|
}
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2018-01-11 21:50:45 +01:00
|
|
|
|
$a = rand(0, 10) === 5 ? new A(): null;
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2020-03-16 03:23:31 +01:00
|
|
|
|
if (rand(0, 1)) {
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2019-12-06 20:47:05 +01:00
|
|
|
|
} elseif ($a && $a->foo) {
|
2017-04-25 05:45:02 +02:00
|
|
|
|
echo $a;
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'globalReturn' => [
|
|
|
|
|
'<?php
|
|
|
|
|
$foo = "foo";
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2018-01-11 21:50:45 +01:00
|
|
|
|
function a(): string {
|
2017-04-25 05:45:02 +02:00
|
|
|
|
global $foo;
|
2018-06-08 15:31:21 +02:00
|
|
|
|
|
|
|
|
|
return $foo;
|
|
|
|
|
}',
|
|
|
|
|
],
|
|
|
|
|
'globalReturnWithAnnotation' => [
|
|
|
|
|
'<?php
|
|
|
|
|
/**
|
|
|
|
|
* @global string $foo
|
|
|
|
|
*/
|
|
|
|
|
function a(): string {
|
|
|
|
|
global $foo;
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
return $foo;
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'negateAssertionAndOther' => [
|
|
|
|
|
'<?php
|
|
|
|
|
$a = rand(0, 10) ? "hello" : null;
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
if (rand(0, 10) > 1 && is_string($a)) {
|
|
|
|
|
throw new \Exception("bad");
|
|
|
|
|
}',
|
|
|
|
|
'assertions' => [
|
2019-10-17 07:14:33 +02:00
|
|
|
|
'$a' => 'null|string',
|
2017-05-27 02:05:57 +02:00
|
|
|
|
],
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'repeatAssertionWithOther' => [
|
|
|
|
|
'<?php
|
2020-09-11 01:05:47 +02:00
|
|
|
|
function getString() : string {
|
|
|
|
|
return "hello";
|
|
|
|
|
}
|
|
|
|
|
$a = rand(0, 10) ? getString() : null;
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
if (rand(0, 10) > 1 || is_string($a)) {
|
|
|
|
|
if (is_string($a)) {
|
2020-09-11 01:05:47 +02:00
|
|
|
|
echo strpos($a, "e");
|
2017-04-25 05:45:02 +02:00
|
|
|
|
}
|
|
|
|
|
}',
|
|
|
|
|
'assertions' => [
|
2019-10-17 07:14:33 +02:00
|
|
|
|
'$a' => 'null|string',
|
2017-05-27 02:05:57 +02:00
|
|
|
|
],
|
2017-10-23 17:47:00 +02:00
|
|
|
|
'error_levels' => ['PossiblyFalseArgument'],
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'refineOredType' => [
|
|
|
|
|
'<?php
|
|
|
|
|
class A {
|
2018-01-11 21:50:45 +01:00
|
|
|
|
public function doThing(): void
|
2017-04-25 05:45:02 +02:00
|
|
|
|
{
|
|
|
|
|
if ($this instanceof B || $this instanceof C) {
|
|
|
|
|
if ($this instanceof B) {
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
class B extends A {}
|
2017-05-27 02:05:57 +02:00
|
|
|
|
class C extends A {}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'instanceOfSubtraction' => [
|
|
|
|
|
'<?php
|
|
|
|
|
class Foo {}
|
|
|
|
|
class FooBar extends Foo{}
|
|
|
|
|
class FooBarBat extends FooBar{}
|
|
|
|
|
class FooMoo extends Foo{}
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
$a = new Foo();
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
if ($a instanceof FooBar && !$a instanceof FooBarBat) {
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
} elseif ($a instanceof FooMoo) {
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'staticNullRef' => [
|
|
|
|
|
'<?php
|
|
|
|
|
/** @return void */
|
|
|
|
|
function foo() {
|
|
|
|
|
static $bar = null;
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
if ($bar !== null) {
|
|
|
|
|
// do something
|
|
|
|
|
}
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
$bar = 5;
|
2017-05-27 02:05:57 +02:00
|
|
|
|
}',
|
|
|
|
|
],
|
2018-06-09 17:50:17 +02:00
|
|
|
|
'suppressInvalidThis' => [
|
|
|
|
|
'<?php
|
|
|
|
|
/** @psalm-suppress InvalidScope */
|
|
|
|
|
if (!isset($this->value)) {
|
|
|
|
|
$this->value = ["x", "y"];
|
|
|
|
|
echo count($this->value) - 2;
|
|
|
|
|
}',
|
|
|
|
|
'assertions' => [],
|
|
|
|
|
'error_levels' => ['MixedPropertyAssignment', 'MixedArgument'],
|
|
|
|
|
],
|
2019-03-28 05:10:08 +01:00
|
|
|
|
'typedStatic' => [
|
|
|
|
|
'<?php
|
|
|
|
|
function a(): ?int {
|
|
|
|
|
/** @var ?int */
|
|
|
|
|
static $foo = 5;
|
|
|
|
|
|
|
|
|
|
if (rand(0, 1)) {
|
|
|
|
|
return $foo;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$foo = null;
|
|
|
|
|
|
|
|
|
|
return $foo;
|
|
|
|
|
}',
|
|
|
|
|
],
|
2019-08-18 17:18:02 +02:00
|
|
|
|
'psalmScopeThisInTemplate' => [
|
|
|
|
|
'<?php
|
2019-08-26 06:24:56 +02:00
|
|
|
|
$e = new Exception(); // necessary to trick Psalm’s scanner for test
|
2019-08-18 17:18:02 +02:00
|
|
|
|
/** @psalm-scope-this Exception */
|
|
|
|
|
?>
|
|
|
|
|
<h1><?= $this->getMessage() ?></h1>',
|
|
|
|
|
],
|
2019-08-27 04:54:54 +02:00
|
|
|
|
'bleedElseifAssignedVarsIntoElseScope' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (rand(0, 1) === 0) {
|
|
|
|
|
$foo = 0;
|
|
|
|
|
} elseif ($foo = rand(0, 10)) {}
|
|
|
|
|
|
|
|
|
|
echo substr("banana", $foo);',
|
|
|
|
|
],
|
2017-04-25 05:45:02 +02:00
|
|
|
|
];
|
2017-03-15 20:21:00 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
2019-03-01 21:55:20 +01:00
|
|
|
|
* @return iterable<string,array{string,error_message:string,2?:string[],3?:bool,4?:string}>
|
2017-03-15 20:21:00 +01:00
|
|
|
|
*/
|
2020-09-12 17:24:05 +02:00
|
|
|
|
public function providerInvalidCodeParse(): iterable
|
2017-03-15 20:21:00 +01:00
|
|
|
|
{
|
2017-04-25 05:45:02 +02:00
|
|
|
|
return [
|
|
|
|
|
'possiblyUndefinedVarInIf' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (rand(0,100) === 10) {
|
|
|
|
|
$b = "s";
|
|
|
|
|
}
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
echo $b;',
|
2019-02-27 22:00:44 +01:00
|
|
|
|
'error_message' => 'PossiblyUndefinedGlobalVariable - src' . DIRECTORY_SEPARATOR . 'somefile.php:6:26 - Possibly undefined global '
|
2017-12-06 06:56:00 +01:00
|
|
|
|
. 'variable $b, first seen on line 3',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'possiblyUndefinedArrayInIf' => [
|
|
|
|
|
'<?php
|
|
|
|
|
if (rand(0,100) === 10) {
|
|
|
|
|
$array[] = "hello";
|
|
|
|
|
}
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
echo $array;',
|
2019-02-27 22:00:44 +01:00
|
|
|
|
'error_message' => 'PossiblyUndefinedGlobalVariable - src' . DIRECTORY_SEPARATOR . 'somefile.php:3:25 - Possibly undefined global '
|
2017-12-06 06:56:00 +01:00
|
|
|
|
. 'variable $array, first seen on line 3',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'invalidGlobal' => [
|
|
|
|
|
'<?php
|
|
|
|
|
$a = "heli";
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
global $a;',
|
2017-05-27 02:05:57 +02:00
|
|
|
|
'error_message' => 'InvalidGlobal',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'thisInStatic' => [
|
|
|
|
|
'<?php
|
|
|
|
|
class A {
|
|
|
|
|
public static function fooFoo() {
|
|
|
|
|
echo $this;
|
|
|
|
|
}
|
|
|
|
|
}',
|
2017-12-22 16:09:56 +01:00
|
|
|
|
'error_message' => 'InvalidScope',
|
2017-04-25 05:45:02 +02:00
|
|
|
|
],
|
|
|
|
|
'static' => [
|
|
|
|
|
'<?php
|
2018-01-11 21:50:45 +01:00
|
|
|
|
function a(): string {
|
2017-04-25 05:45:02 +02:00
|
|
|
|
static $foo = "foo";
|
2017-06-29 16:22:49 +02:00
|
|
|
|
|
2017-04-25 05:45:02 +02:00
|
|
|
|
return $foo;
|
|
|
|
|
}',
|
2018-01-05 03:36:16 +01:00
|
|
|
|
'error_message' => 'MixedReturnStatement',
|
2017-05-27 02:05:57 +02:00
|
|
|
|
],
|
2019-03-28 05:10:08 +01:00
|
|
|
|
'staticNullRef' => [
|
|
|
|
|
'<?php
|
|
|
|
|
/** @return void */
|
|
|
|
|
function foo() {
|
|
|
|
|
/** @var int */
|
|
|
|
|
static $bar = 5;
|
|
|
|
|
|
|
|
|
|
if ($bar === null) {
|
|
|
|
|
// do something
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$bar = 4;
|
|
|
|
|
}',
|
|
|
|
|
'error_message' => 'DocblockTypeContradiction',
|
|
|
|
|
],
|
|
|
|
|
'typedStaticCannotHaveNullDefault' => [
|
|
|
|
|
'<?php
|
|
|
|
|
function a(): void {
|
|
|
|
|
/** @var string */
|
|
|
|
|
static $foo = null;
|
|
|
|
|
}',
|
|
|
|
|
'error_message' => 'ReferenceConstraintViolation',
|
|
|
|
|
],
|
|
|
|
|
'typedStaticCannotBeAssignedInt' => [
|
|
|
|
|
'<?php
|
|
|
|
|
function a(): void {
|
|
|
|
|
/** @var string */
|
|
|
|
|
static $foo = "foo";
|
|
|
|
|
|
|
|
|
|
$foo = 5;
|
|
|
|
|
}',
|
|
|
|
|
'error_message' => 'ReferenceConstraintViolation',
|
|
|
|
|
],
|
|
|
|
|
'typedStaticCannotBeAssignedNull' => [
|
|
|
|
|
'<?php
|
|
|
|
|
function a(): void {
|
|
|
|
|
/** @var string */
|
|
|
|
|
static $foo = "foo";
|
|
|
|
|
|
|
|
|
|
$foo = null;
|
|
|
|
|
}',
|
|
|
|
|
'error_message' => 'ReferenceConstraintViolation',
|
|
|
|
|
],
|
2017-04-25 05:45:02 +02:00
|
|
|
|
];
|
2017-03-15 20:21:00 +01:00
|
|
|
|
}
|
2016-06-20 22:18:47 +02:00
|
|
|
|
}
|