1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-12 09:19:40 +01:00
psalm/tests/FileManipulationTest.php

1563 lines
48 KiB
PHP
Raw Normal View History

<?php
namespace Psalm\Tests;
2018-11-06 03:57:36 +01:00
use Psalm\Internal\Analyzer\FileAnalyzer;
use Psalm\Context;
use Psalm\Tests\Internal\Provider;
class FileManipulationTest extends TestCase
{
2018-11-06 03:57:36 +01:00
/** @var \Psalm\Internal\Analyzer\ProjectAnalyzer */
2018-11-11 18:01:14 +01:00
protected $project_analyzer;
/**
* @return void
*/
public function setUp()
{
2018-11-06 03:57:36 +01:00
FileAnalyzer::clearCache();
\Psalm\Internal\FileManipulation\FunctionDocblockManipulator::clearCache();
$this->file_provider = new Provider\FakeFileProvider();
}
/**
2018-11-06 03:57:36 +01:00
* @dataProvider providerValidCodeParse
*
* @param string $input_code
* @param string $output_code
* @param string $php_version
* @param string[] $issues_to_fix
2018-01-07 22:14:16 +01:00
* @param bool $safe_types
*
* @return void
*/
2018-01-07 22:11:51 +01:00
public function testValidCode($input_code, $output_code, $php_version, array $issues_to_fix, $safe_types)
{
$test_name = $this->getTestName();
if (strpos($test_name, 'SKIPPED-') !== false) {
$this->markTestSkipped('Skipped due to a bug.');
}
$config = new TestConfig();
2018-11-11 18:01:14 +01:00
$this->project_analyzer = new \Psalm\Internal\Analyzer\ProjectAnalyzer(
$config,
2018-11-06 03:57:36 +01:00
new \Psalm\Internal\Provider\Providers(
$this->file_provider,
new Provider\FakeParserCacheProvider()
)
);
if (empty($issues_to_fix)) {
2018-11-06 03:57:36 +01:00
$config->addPluginPath('examples/plugins/ClassUnqualifier.php');
2018-11-11 18:01:14 +01:00
$config->initializePlugins($this->project_analyzer);
}
$context = new Context();
$file_path = self::$src_dir_path . 'somefile.php';
$this->addFile(
$file_path,
$input_code
);
$this->project_analyzer->setPhpVersion($php_version);
$keyed_issues_to_fix = [];
foreach ($issues_to_fix as $issue) {
$keyed_issues_to_fix[$issue] = true;
}
2018-11-11 18:01:14 +01:00
$this->project_analyzer->setIssuesToFix($keyed_issues_to_fix);
$this->project_analyzer->alterCodeAfterCompletion(
2018-01-07 22:11:51 +01:00
false,
$safe_types
);
$this->analyzeFile($file_path, $context);
2018-11-11 18:01:14 +01:00
$this->project_analyzer->getCodebase()->analyzer->updateFile($file_path, false);
$this->assertSame($output_code, $this->project_analyzer->getCodebase()->getFileContents($file_path));
}
/**
2019-02-23 22:22:39 +01:00
* @return array<string,array{string,string,string,string[],bool}>
*/
2018-11-06 03:57:36 +01:00
public function providerValidCodeParse()
{
return [
'addMissingVoidReturnType56' => [
'<?php
function foo() { }',
'<?php
/**
* @return void
*/
function foo() { }',
'5.6',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingVoidReturnType70' => [
'<?php
function foo() { }',
'<?php
/**
* @return void
*/
function foo() { }',
'7.0',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingVoidReturnType71' => [
'<?php
function foo() { }',
'<?php
2018-01-11 21:50:45 +01:00
function foo(): void { }',
'7.1',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingStringReturnType56' => [
'<?php
function foo() {
return "hello";
}',
'<?php
/**
* @return string
*/
function foo() {
return "hello";
}',
'5.6',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingStringReturnType70' => [
'<?php
function foo() {
return "hello";
}',
'<?php
2018-01-11 21:50:45 +01:00
function foo(): string {
return "hello";
}',
'7.0',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingClosureStringReturnType56' => [
'<?php
$a = function() {
return "hello";
2018-09-17 18:15:45 +02:00
};',
'<?php
$a = /**
* @return string
*/
function() {
return "hello";
2018-09-17 18:15:45 +02:00
};',
'5.6',
['MissingClosureReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingNullableStringReturnType56' => [
'<?php
function foo() {
return rand(0, 1) ? "hello" : null;
}',
'<?php
/**
* @return string|null
*/
function foo() {
return rand(0, 1) ? "hello" : null;
}',
'5.6',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingNullableStringReturnType70' => [
'<?php
function foo() {
return rand(0, 1) ? "hello" : null;
}',
'<?php
/**
* @return string|null
*/
function foo() {
return rand(0, 1) ? "hello" : null;
}',
'7.0',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingStringReturnType71' => [
'<?php
function foo() {
return rand(0, 1) ? "hello" : null;
}',
'<?php
2018-01-11 21:50:45 +01:00
function foo(): ?string {
return rand(0, 1) ? "hello" : null;
}',
'7.1',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingStringReturnTypeWithComment71' => [
'<?php
function foo() /** : ?string */ {
return rand(0, 1) ? "hello" : null;
}',
'<?php
2018-01-11 21:50:45 +01:00
function foo(): ?string /** : ?string */ {
return rand(0, 1) ? "hello" : null;
}',
'7.1',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
2018-01-07 19:14:50 +01:00
'addMissingStringReturnTypeWithSingleLineComment71' => [
'<?php
function foo()// cool
{
return rand(0, 1) ? "hello" : null;
}',
'<?php
2018-01-11 21:50:45 +01:00
function foo(): ?string// cool
2018-01-07 19:14:50 +01:00
{
return rand(0, 1) ? "hello" : null;
}',
'7.1',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
2018-01-07 19:14:50 +01:00
],
'addMissingStringArrayReturnType56' => [
'<?php
function foo() {
return ["hello"];
}',
'<?php
/**
* @return string[]
*
* @psalm-return array{0:string}
*/
function foo() {
return ["hello"];
}',
'5.6',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingStringArrayReturnType70' => [
'<?php
function foo() {
return ["hello"];
}',
'<?php
/**
* @return string[]
*
* @psalm-return array{0:string}
*/
2018-01-11 21:50:45 +01:00
function foo(): array {
return ["hello"];
}',
'7.0',
['MissingReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'addMissingObjectLikeReturnType70' => [
'<?php
function foo() {
return rand(0, 1) ? ["a" => "hello"] : ["a" => "goodbye", "b" => "hello again"];
}',
'<?php
/**
* @return string[]
*
* @psalm-return array{a:string, b?:string}
*/
function foo(): array {
return rand(0, 1) ? ["a" => "hello"] : ["a" => "goodbye", "b" => "hello again"];
}',
'7.0',
['MissingReturnType'],
true,
],
'addMissingObjectLikeReturnTypeWithEmptyArray' => [
'<?php
function foo() {
if (rand(0, 1)) {
return [];
}
return [
"a" => 1,
"b" => 2,
];
}',
'<?php
/**
* @return int[]
*
* @psalm-return array{a?:int, b?:int}
*/
function foo(): array {
if (rand(0, 1)) {
return [];
}
return [
"a" => 1,
"b" => 2,
];
}',
'7.0',
['MissingReturnType'],
true,
],
'addMissingObjectLikeReturnTypeSeparateStatements70' => [
'<?php
function foo() {
if (rand(0, 1)) {
return ["a" => "hello", "b" => "hello again"];
}
if (rand(0, 1)) {
return ["a" => "hello", "b" => "hello again"];
}
return ["a" => "goodbye"];
}',
'<?php
/**
* @return string[]
*
* @psalm-return array{a:string, b?:string}
*/
function foo(): array {
if (rand(0, 1)) {
return ["a" => "hello", "b" => "hello again"];
}
if (rand(0, 1)) {
return ["a" => "hello", "b" => "hello again"];
}
return ["a" => "goodbye"];
}',
'7.0',
['MissingReturnType'],
true,
],
2018-01-07 22:11:51 +01:00
'addMissingStringArrayReturnTypeFromCall71' => [
'<?php
/** @return string[] */
2018-01-11 21:50:45 +01:00
function foo(): array {
2018-01-07 22:11:51 +01:00
return ["hello"];
}
function bar() {
return foo();
}',
'<?php
/** @return string[] */
2018-01-11 21:50:45 +01:00
function foo(): array {
2018-01-07 22:11:51 +01:00
return ["hello"];
}
/**
* @return string[]
*
* @psalm-return array<array-key, string>
2018-01-07 22:11:51 +01:00
*/
2018-01-11 21:50:45 +01:00
function bar(): array {
2018-01-07 22:11:51 +01:00
return foo();
}',
'7.1',
['MissingReturnType'],
true,
],
'addMissingDocblockStringArrayReturnTypeFromCall71' => [
'<?php
/** @return string[] */
function foo() {
return ["hello"];
}
function bar() {
return foo();
}',
'<?php
/** @return string[] */
function foo() {
return ["hello"];
}
/**
* @return string[]
*
* @psalm-return array<array-key, string>
2018-01-07 22:11:51 +01:00
*/
function bar() {
return foo();
}',
'7.1',
['MissingReturnType'],
true,
],
'addMissingNullableStringReturnType71' => [
'<?php
/** @return string[] */
2018-01-11 21:50:45 +01:00
function foo(): array {
2018-01-07 22:11:51 +01:00
return ["hello"];
}
function bar() {
foreach (foo() as $f) {
return $f;
}
return null;
}',
'<?php
/** @return string[] */
2018-01-11 21:50:45 +01:00
function foo(): array {
2018-01-07 22:11:51 +01:00
return ["hello"];
}
/**
* @return null|string
*/
function bar() {
foreach (foo() as $f) {
return $f;
}
return null;
}',
'7.1',
['MissingReturnType'],
true,
],
2018-01-10 19:04:37 +01:00
'addMissingNullableStringReturnTypeWithMaybeReturn71' => [
'<?php
function foo() {
if (rand(0, 1)) return new stdClass;
}',
'<?php
/**
* @return null|stdClass
2018-01-10 19:04:37 +01:00
*/
function foo() {
if (rand(0, 1)) return new stdClass;
}',
'7.1',
['MissingReturnType'],
true,
],
2018-01-07 22:11:51 +01:00
'addMissingUnsafeNullableStringReturnType71' => [
'<?php
/** @return string[] */
2018-01-11 21:50:45 +01:00
function foo(): array {
2018-01-07 22:11:51 +01:00
return ["hello"];
}
function bar() {
foreach (foo() as $f) {
return $f;
}
return null;
}',
'<?php
/** @return string[] */
2018-01-11 21:50:45 +01:00
function foo(): array {
2018-01-07 22:11:51 +01:00
return ["hello"];
}
2018-01-11 21:50:45 +01:00
function bar(): ?string {
2018-01-07 22:11:51 +01:00
foreach (foo() as $f) {
return $f;
}
return null;
}',
'7.1',
['MissingReturnType'],
false,
],
2018-01-23 00:00:19 +01:00
'addSelfReturnType' => [
'<?php
class A {
public function foo() {
return $this;
}
}',
'<?php
class A {
public function foo(): self {
return $this;
}
}',
'7.1',
['MissingReturnType'],
false,
],
'addIterableReturnType' => [
'<?php
function foo() {
return bar();
}
function bar(): iterable {
return [1, 2, 3];
}',
'<?php
function foo(): iterable {
return bar();
}
function bar(): iterable {
return [1, 2, 3];
}',
'7.1',
['MissingReturnType'],
false,
],
'addGenericIterableReturnType' => [
'<?php
function foo() {
return bar();
}
/** @return iterable<int> */
function bar(): iterable {
return [1, 2, 3];
}',
'<?php
/**
* @return iterable
*
* @psalm-return iterable<mixed, int>
*/
function foo(): iterable {
return bar();
}
/** @return iterable<int> */
function bar(): iterable {
return [1, 2, 3];
}',
'7.1',
['MissingReturnType'],
false,
],
2018-01-23 18:03:18 +01:00
'addMissingNullableReturnTypeInDocblockOnly71' => [
'<?php
function foo() {
if (rand(0, 1)) {
return;
}
return "hello";
}
function bar() {
if (rand(0, 1)) {
return;
}
if (rand(0, 1)) {
return null;
}
return "hello";
}',
'<?php
/**
* @return string|null
*/
function foo() {
if (rand(0, 1)) {
return;
}
return "hello";
}
/**
* @return string|null
*/
function bar() {
if (rand(0, 1)) {
return;
}
if (rand(0, 1)) {
return null;
}
return "hello";
}',
'7.1',
['MissingReturnType'],
false,
],
'addMissingVoidReturnTypeToOldArray71' => [
'<?php
function foo(array $a = array()) {}
function bar(array $a = array() ) {}',
'<?php
function foo(array $a = array()): void {}
function bar(array $a = array() ): void {}',
'7.1',
['MissingReturnType'],
false,
],
'addMissingVoidReturnTypeClosureUse71' => [
'<?php
$a = "foo";
$b = function() use ($a) {};',
'<?php
$a = "foo";
$b = function() use ($a): void {};',
'7.1',
['MissingClosureReturnType'],
false,
],
2018-01-23 00:00:19 +01:00
'dontAddMissingVoidReturnType56' => [
'<?php
/** @return void */
function foo() { }
function bar() {
return foo();
}',
'<?php
/** @return void */
function foo() { }
function bar() {
return foo();
}',
'5.6',
['MissingReturnType'],
true,
],
'dontAddMissingVoidReturnTypehintForSubclass71' => [
'<?php
class A {
public function foo() {}
}
class B extends A {
public function foo() {}
}',
'<?php
class A {
/**
* @return void
*/
public function foo() {}
}
class B extends A {
/**
* @return void
*/
public function foo() {}
}',
'7.1',
['MissingReturnType'],
true,
],
'dontAddMissingVoidReturnTypehintForPrivateMethodInSubclass71' => [
'<?php
class A {
private function foo() {}
}
class B extends A {
private function foo() {}
}',
'<?php
class A {
private function foo(): void {}
}
class B extends A {
private function foo(): void {}
}',
'7.1',
['MissingReturnType'],
true,
],
'dontAddMissingClassReturnTypehintForSubclass71' => [
'<?php
class A {
public function foo() {
return $this;
}
}
class B extends A {
public function foo() {
return $this;
}
}',
'<?php
class A {
/**
* @return self
*/
public function foo() {
return $this;
}
}
class B extends A {
/**
* @return self
*/
public function foo() {
return $this;
}
}',
'7.1',
['MissingReturnType'],
true,
],
'dontAddMissingClassReturnTypehintForSubSubclass71' => [
'<?php
class A {
public function foo() {
return $this;
}
}
class B extends A {}
class C extends B {
public function foo() {
return $this;
}
}',
'<?php
class A {
/**
* @return self
*/
public function foo() {
return $this;
}
}
class B extends A {}
class C extends B {
/**
* @return self
*/
public function foo() {
return $this;
}
}',
'7.1',
['MissingReturnType'],
true,
],
'fixInvalidIntReturnType56' => [
'<?php
/**
* @return int
*/
function foo() {
return "hello";
}',
'<?php
/**
* @return string
*/
function foo() {
return "hello";
}',
'5.6',
['InvalidReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'fixInvalidIntReturnType70' => [
'<?php
/**
* @return int
*/
2018-01-11 21:50:45 +01:00
function foo(): int {
return "hello";
}',
'<?php
/**
* @return string
*/
2018-01-11 21:50:45 +01:00
function foo(): string {
return "hello";
}',
'7.0',
['InvalidReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'fixInvalidIntReturnTypeJustInTypehint70' => [
'<?php
2018-01-11 21:50:45 +01:00
function foo(): int {
return "hello";
}',
'<?php
2018-01-11 21:50:45 +01:00
function foo(): string {
return "hello";
}',
'7.0',
['InvalidReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'fixInvalidStringReturnTypeThatIsNotPhpCompatible70' => [
2018-01-07 23:17:18 +01:00
'<?php
2018-01-11 21:50:45 +01:00
function foo(): string {
2018-01-07 23:17:18 +01:00
return rand(0, 1) ? "hello" : false;
}',
'<?php
/**
* @return string|false
*/
2018-01-11 21:50:45 +01:00
function foo() {
2018-01-07 23:17:18 +01:00
return rand(0, 1) ? "hello" : false;
}',
'7.0',
['InvalidFalsableReturnType'],
true,
],
'fixInvalidIntReturnTypeThatIsNotPhpCompatible70' => [
'<?php
2018-01-11 21:50:45 +01:00
function foo(): string {
return rand(0, 1) ? "hello" : null;
}',
'<?php
/**
* @return string|null
*/
2018-01-11 21:50:45 +01:00
function foo() {
return rand(0, 1) ? "hello" : null;
}',
'7.0',
['InvalidNullableReturnType'],
true,
],
'fixInvalidIntReturnTypeJustInTypehintWithComment70' => [
'<?php
function foo() /** cool : beans */ : int /** cool : beans */ {
return "hello";
}',
'<?php
function foo() /** cool : beans */ : string /** cool : beans */ {
return "hello";
}',
'7.0',
['InvalidReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
'fixInvalidIntReturnTypeJustInTypehintWithSingleLineComment70' => [
'<?php
function foo() // hello
: int {
return "hello";
}',
'<?php
function foo() // hello
: string {
return "hello";
}',
'7.0',
['InvalidReturnType'],
2018-01-07 22:11:51 +01:00
true,
],
2018-01-07 16:23:02 +01:00
'fixMismatchingDocblockReturnType70' => [
'<?php
/**
* @return int
*/
2018-01-11 21:50:45 +01:00
function foo(): string {
2018-01-07 16:23:02 +01:00
return "hello";
}',
'<?php
/**
* @return string
*/
2018-01-11 21:50:45 +01:00
function foo(): string {
2018-01-07 16:23:02 +01:00
return "hello";
}',
'7.0',
['MismatchingDocblockReturnType'],
2018-01-07 22:11:51 +01:00
true,
2018-01-07 16:23:02 +01:00
],
'fixMismatchingDocblockParamType70' => [
'<?php
/**
* @param int $s
*/
2018-01-11 21:50:45 +01:00
function foo(string $s): string {
2018-01-07 16:23:02 +01:00
return "hello";
}',
'<?php
/**
* @param string $s
*/
2018-01-11 21:50:45 +01:00
function foo(string $s): string {
2018-01-07 16:23:02 +01:00
return "hello";
}',
'7.0',
['MismatchingDocblockParamType'],
2018-01-07 22:11:51 +01:00
true,
2018-01-07 16:23:02 +01:00
],
2018-01-07 18:53:25 +01:00
'fixNamespacedMismatchingDocblockParamsType70' => [
'<?php
namespace Foo\Bar {
class A {
/**
* @param \B $b
2018-01-07 18:53:25 +01:00
* @param \C $c
*/
2018-01-11 21:50:45 +01:00
function foo(B $b, C $c): string {
return "hello";
}
}
class B {}
2018-01-07 18:53:25 +01:00
class C {}
}',
'<?php
namespace Foo\Bar {
class A {
/**
* @param B $b
2018-01-07 18:53:25 +01:00
* @param C $c
*/
2018-01-11 21:50:45 +01:00
function foo(B $b, C $c): string {
return "hello";
}
}
class B {}
2018-01-07 18:53:25 +01:00
class C {}
}',
'7.0',
['MismatchingDocblockParamType'],
2018-01-07 22:11:51 +01:00
true,
],
'preserveFormat' => [
'<?php
/**
* Here is a paragraph
*
* And another one
*
* @other is
* a friend of mine
* + Members
* - `google`
* @return int
*/
2018-01-11 21:50:45 +01:00
function foo(): int {
return "hello";
}',
'<?php
/**
* Here is a paragraph
*
* And another one
*
* @other is
* a friend of mine
* + Members
* - `google`
*
* @return string
*/
2018-01-11 21:50:45 +01:00
function foo(): string {
return "hello";
}',
'7.0',
['InvalidReturnType'],
true,
],
'possiblyUndefinedVariable' => [
'<?php
$flag = rand(0, 1);
$otherflag = rand(0, 1);
$yetanotherflag = rand(0, 1);
if ($flag) {
if ($otherflag) {
$a = 5;
}
echo $a;
}
if ($flag) {
if ($yetanotherflag) {
$a = 5;
}
echo $a;
}',
'<?php
$flag = rand(0, 1);
$otherflag = rand(0, 1);
$yetanotherflag = rand(0, 1);
$a = null;
if ($flag) {
if ($otherflag) {
$a = 5;
}
echo $a;
}
if ($flag) {
if ($yetanotherflag) {
$a = 5;
}
echo $a;
}',
'5.6',
['PossiblyUndefinedGlobalVariable'],
true,
],
2018-01-22 03:45:56 +01:00
'twoPossiblyUndefinedVariables' => [
'<?php
if (rand(0, 1)) {
$a = 1;
$b = 2;
}
echo $a;
echo $b;',
'<?php
$a = null;
$b = null;
if (rand(0, 1)) {
$a = 1;
$b = 2;
}
echo $a;
echo $b;',
'5.6',
['PossiblyUndefinedGlobalVariable'],
true,
],
'possiblyUndefinedVariableInElse' => [
'<?php
if (rand(0, 1)) {
// do nothing
} else {
$a = 5;
}
echo $a;',
'<?php
$a = null;
if (rand(0, 1)) {
// do nothing
} else {
$a = 5;
}
echo $a;',
'5.6',
['PossiblyUndefinedGlobalVariable'],
true,
],
'unsetPossiblyUndefinedVariable' => [
'<?php
if (rand(0, 1)) {
$a = "bar";
}
unset($a);',
'<?php
if (rand(0, 1)) {
$a = "bar";
}
unset($a);',
'5.6',
['PossiblyUndefinedGlobalVariable'],
true,
],
2018-03-07 19:11:36 +01:00
'addLessSpecificArrayReturnType71' => [
'<?php
namespace A\B {
class C {}
}
namespace C {
use A\B;
class D {
public function getArrayOfC(): array {
return [new \A\B\C];
}
}
}',
'<?php
namespace A\B {
class C {}
}
namespace C {
use A\B;
class D {
/**
* @return \A\B\C[]
*
* @psalm-return array{0:\A\B\C}
*/
public function getArrayOfC(): array {
return [new \A\B\C];
}
}
}',
'7.1',
['LessSpecificReturnType'],
true,
],
'fixLessSpecificClosureReturnType' => [
'<?php
function foo(string $name) : string {
return $name . " hello";
}
function bar() : callable {
return function(string $name) {
return foo($name);
};
}',
'<?php
function foo(string $name) : string {
return $name . " hello";
}
/**
* @return Closure
*
* @psalm-return Closure(string):string
*/
function bar() : Closure {
return function(string $name) {
return foo($name);
};
}',
'7.1',
['LessSpecificReturnType'],
false,
],
'fixLessSpecificReturnTypePreserveNotes' => [
'<?php
namespace Foo;
/**
* @return object some description
*/
function foo() {
return new \stdClass();
}',
'<?php
namespace Foo;
/**
* @return \stdClass some description
*/
function foo() {
return new \stdClass();
}',
'5.6',
['LessSpecificReturnType'],
false,
],
2018-09-14 06:07:56 +02:00
'fixInvalidReturnTypePreserveNotes' => [
'<?php
namespace Foo;
class A {
/**
* @return string some description
*/
function foo() {
return new \stdClass();
}
}',
'<?php
namespace Foo;
class A {
/**
* @return \stdClass some description
*/
function foo() {
return new \stdClass();
}
}',
'5.6',
['InvalidReturnType'],
false,
],
'fixInvalidNullableReturnTypePreserveNotes' => [
'<?php
namespace Foo;
class A {
/**
* @return string|null some notes
*/
function foo() : ?string {
return "hello";
}
}',
'<?php
namespace Foo;
class A {
/**
* @return string some notes
*/
function foo() : string {
return "hello";
}
}',
'7.1',
['LessSpecificReturnType'],
false,
],
2018-03-07 19:11:36 +01:00
'fixLessSpecificReturnType' => [
'<?php
class A {}
class B extends A {}
class C extends B {
public function getB(): ?\A {
return new B;
}
public function getC(): ?\A {
return new C;
}
}',
'<?php
class A {}
class B extends A {}
class C extends B {
public function getB(): B {
return new B;
}
public function getC(): self {
return new C;
}
}',
'7.1',
['LessSpecificReturnType'],
true,
],
'useUnqualifierPlugin' => [
'<?php
namespace A\B\C {
class D {}
}
namespace Foo\Bar {
use A\B\C\D;
new \A\B\C\D();
}',
'<?php
namespace A\B\C {
class D {}
}
namespace Foo\Bar {
use A\B\C\D;
new D();
}',
PHP_VERSION,
[],
2018-01-07 22:11:51 +01:00
true,
],
'noStringParamType' => [
'<?php
function fooFoo($a): void {
echo substr($a, 4, 2);
}',
'<?php
/**
* @param string $a
*/
function fooFoo($a): void {
echo substr($a, 4, 2);
}',
'7.1',
['MissingParamType'],
true,
],
'stringParamTypeAndConcatNoop' => [
'<?php
function fooFoo(string $a): void {
echo $a . "foo";
}',
'<?php
function fooFoo(string $a): void {
echo $a . "foo";
}',
'7.1',
['MissingParamType'],
true,
],
'noParamTypeButConcat' => [
'<?php
function fooFoo($a): void {
echo $a . "foo";
}',
2019-02-02 18:10:52 +01:00
'<?php
/**
* @param string|int $a
2019-02-02 18:10:52 +01:00
*/
function fooFoo($a): void {
echo $a . "foo";
}',
'7.1',
['MissingParamType'],
true,
],
'noParamTypeButConcatAndStringUsage' => [
'<?php
function fooFoo($a): void {
echo $a . "foo";
echo substr($a, 4, 2);
}',
'<?php
/**
* @param string $a
*/
function fooFoo($a): void {
echo $a . "foo";
2019-02-02 18:10:52 +01:00
echo substr($a, 4, 2);
}',
'7.1',
['MissingParamType'],
true,
],
'noParamTypeButConcatAndStringUsageReversed' => [
'<?php
function fooFoo($a): void {
echo substr($a, 4, 2);
echo $a . "foo";
}',
'<?php
/**
* @param string $a
*/
function fooFoo($a): void {
echo substr($a, 4, 2);
echo $a . "foo";
}',
'7.1',
['MissingParamType'],
true,
],
'noParamTypeButAddition' => [
'<?php
function fooFoo($a): void {
echo $a + 5;
}',
'<?php
/**
* @param int|float $a
*/
function fooFoo($a): void {
echo $a + 5;
}',
'7.1',
['MissingParamType'],
true,
],
'noParamTypeButAdditionAndDefault' => [
'<?php
function fooFoo($a = 5): void {
takesInt($a);
}
function takesInt(int $i) {}',
'<?php
/**
* @param int $a
*/
function fooFoo($a = 5): void {
takesInt($a);
}
function takesInt(int $i) {}',
'7.1',
['MissingParamType'],
true,
],
'noParamTypeButIntUseAndNullCheck' => [
'<?php
function fooFoo($a): void {
if ($a === null) {
return;
}
takesInt($a);
}
function takesInt(int $i) {}',
'<?php
/**
* @param null|int $a
*/
function fooFoo($a): void {
if ($a === null) {
return;
}
takesInt($a);
}
function takesInt(int $i) {}',
'7.1',
['MissingParamType'],
true,
],
'noParamTypeButDivision' => [
'<?php
function fooFoo($a): void {
echo $a / 5;
}',
'<?php
/**
* @param int|float $a
*/
function fooFoo($a): void {
echo $a / 5;
}',
'7.1',
['MissingParamType'],
true,
],
'noParamTypeButTemplatedString' => [
'<?php
function fooFoo($a): void {
echo "$a";
}',
2019-02-02 18:10:52 +01:00
'<?php
/**
* @param string|int|float $a
*/
function fooFoo($a): void {
echo "$a";
}',
'7.1',
['MissingParamType'],
true,
],
'noParamTypeButTemplatedStringAntStringUsage' => [
'<?php
function fooFoo($a): void {
echo "$a";
echo substr($a, 4, 2);
}',
'<?php
/**
* @param string $a
*/
function fooFoo($a): void {
echo "$a";
2019-02-02 18:10:52 +01:00
echo substr($a, 4, 2);
}',
'7.1',
['MissingParamType'],
true,
],
'noStringIntParamType' => [
'<?php
function fooFoo($a): void {
if (is_string($a)) {
echo substr($a, 4, 2);
} else {
echo substr("hello", $a, 2);
}
}',
'<?php
/**
* @param int|string $a
*/
function fooFoo($a): void {
if (is_string($a)) {
echo substr($a, 4, 2);
} else {
echo substr("hello", $a, 2);
}
}',
'7.1',
['MissingParamType'],
true,
],
'alreadyHasCheck' => [
'<?php
function takesString(string $s): void {}
function shouldTakeString($s): void {
if (is_string($s)) {
takesString($s);
}
}',
'<?php
function takesString(string $s): void {}
function shouldTakeString($s): void {
if (is_string($s)) {
takesString($s);
}
}',
'7.1',
['MissingParamType'],
true,
],
'isSetBeforeInferrence' => [
'<?php
function takesString(string $s): void {}
/** @return mixed */
function returnsMixed() {}
function shouldTakeString($s): void {
$s = returnsMixed();
takesString($s);
}',
'<?php
function takesString(string $s): void {}
/** @return mixed */
function returnsMixed() {}
function shouldTakeString($s): void {
$s = returnsMixed();
takesString($s);
}',
'7.1',
['MissingParamType'],
true,
],
];
}
}