2017-02-08 00:28:26 -05:00
|
|
|
<?php
|
|
|
|
namespace Psalm\Tests;
|
|
|
|
|
|
|
|
use Psalm\Checker\FileChecker;
|
2017-07-25 17:04:58 -04:00
|
|
|
use Psalm\Context;
|
2017-02-08 00:28:26 -05:00
|
|
|
|
2017-04-24 23:45:02 -04:00
|
|
|
class UnusedCodeTest extends TestCase
|
2017-02-08 00:28:26 -05:00
|
|
|
{
|
|
|
|
/** @var \Psalm\Checker\ProjectChecker */
|
|
|
|
protected $project_checker;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
*/
|
|
|
|
public function setUp()
|
|
|
|
{
|
|
|
|
FileChecker::clearCache();
|
2017-07-25 16:11:02 -04:00
|
|
|
|
|
|
|
$this->file_provider = new Provider\FakeFileProvider();
|
|
|
|
|
|
|
|
$this->project_checker = new \Psalm\Checker\ProjectChecker(
|
|
|
|
$this->file_provider,
|
2017-10-15 11:57:44 -04:00
|
|
|
new Provider\FakeParserCacheProvider()
|
2017-07-25 16:11:02 -04:00
|
|
|
);
|
|
|
|
|
2017-07-25 17:04:58 -04:00
|
|
|
$this->project_checker->setConfig(new TestConfig());
|
2017-02-08 00:28:26 -05:00
|
|
|
|
2017-04-24 23:45:02 -04:00
|
|
|
$this->project_checker->collect_references = true;
|
2017-02-08 00:28:26 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-07-25 17:04:58 -04:00
|
|
|
* @dataProvider providerFileCheckerValidCodeParse
|
|
|
|
*
|
|
|
|
* @param string $code
|
|
|
|
* @param array<string, string> $assertions
|
|
|
|
* @param array<string> $error_levels
|
|
|
|
*
|
|
|
|
* @return void
|
|
|
|
*/
|
|
|
|
public function testValidCode($code)
|
|
|
|
{
|
|
|
|
$test_name = $this->getName();
|
|
|
|
if (strpos($test_name, 'PHP7-') !== false) {
|
|
|
|
if (version_compare(PHP_VERSION, '7.0.0dev', '<')) {
|
|
|
|
$this->markTestSkipped('Test case requires PHP 7.');
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
} elseif (strpos($test_name, 'SKIPPED-') !== false) {
|
|
|
|
$this->markTestSkipped('Skipped due to a bug.');
|
|
|
|
}
|
|
|
|
|
|
|
|
$context = new Context();
|
|
|
|
|
|
|
|
$this->addFile(
|
|
|
|
self::$src_dir_path . 'somefile.php',
|
|
|
|
$code
|
|
|
|
);
|
|
|
|
|
|
|
|
$file_checker = new FileChecker(self::$src_dir_path . 'somefile.php', $this->project_checker);
|
|
|
|
$file_checker->visitAndAnalyzeMethods($context);
|
|
|
|
$this->project_checker->checkClassReferences();
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider providerFileCheckerInvalidCodeParse
|
2017-05-26 20:16:18 -04:00
|
|
|
*
|
2017-04-24 23:45:02 -04:00
|
|
|
* @param string $code
|
|
|
|
* @param string $error_message
|
2017-05-26 20:16:18 -04:00
|
|
|
*
|
2017-02-08 00:28:26 -05:00
|
|
|
* @return void
|
|
|
|
*/
|
2017-07-25 17:04:58 -04:00
|
|
|
public function testInvalidCode($code, $error_message)
|
2017-02-08 00:28:26 -05:00
|
|
|
{
|
2017-07-25 17:04:58 -04:00
|
|
|
if (strpos($this->getName(), 'SKIPPED-') !== false) {
|
|
|
|
$this->markTestSkipped();
|
|
|
|
}
|
|
|
|
|
2017-04-24 23:45:02 -04:00
|
|
|
$this->expectException('\Psalm\Exception\CodeException');
|
2017-11-15 21:04:25 -05:00
|
|
|
$this->expectExceptionMessageRegexp('/\b' . preg_quote($error_message, '/') . '/');
|
2017-02-08 00:28:26 -05:00
|
|
|
|
2017-07-25 16:11:02 -04:00
|
|
|
$this->addFile(
|
2017-07-25 17:04:58 -04:00
|
|
|
self::$src_dir_path . 'somefile.php',
|
2017-07-25 16:11:02 -04:00
|
|
|
$code
|
|
|
|
);
|
2017-02-08 00:28:26 -05:00
|
|
|
|
2017-07-25 17:04:58 -04:00
|
|
|
$context = new Context();
|
|
|
|
|
|
|
|
$file_checker = new FileChecker(self::$src_dir_path . 'somefile.php', $this->project_checker);
|
|
|
|
$file_checker->visitAndAnalyzeMethods($context);
|
2017-04-24 23:45:02 -04:00
|
|
|
$this->project_checker->checkClassReferences();
|
2017-02-08 00:28:26 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-04-24 23:45:02 -04:00
|
|
|
* @return array
|
2017-02-08 00:28:26 -05:00
|
|
|
*/
|
2017-04-24 23:45:02 -04:00
|
|
|
public function providerFileCheckerValidCodeParse()
|
2017-02-08 00:28:26 -05:00
|
|
|
{
|
2017-04-24 23:45:02 -04:00
|
|
|
return [
|
|
|
|
'unset' => [
|
|
|
|
'<?php
|
|
|
|
/** @return void */
|
|
|
|
function foo() {
|
|
|
|
$a = 0;
|
2017-05-04 14:25:58 -04:00
|
|
|
|
2017-04-24 23:45:02 -04:00
|
|
|
$arr = ["hello"];
|
2017-05-04 14:25:58 -04:00
|
|
|
|
2017-04-24 23:45:02 -04:00
|
|
|
unset($arr[$a]);
|
2017-05-26 20:05:57 -04:00
|
|
|
}',
|
2017-07-25 17:04:58 -04:00
|
|
|
],
|
|
|
|
'usedVariables' => [
|
|
|
|
'<?php
|
|
|
|
/** @return string */
|
|
|
|
function foo() {
|
|
|
|
$a = 5;
|
|
|
|
$b = [];
|
|
|
|
return $a . implode(",", $b);
|
|
|
|
}',
|
|
|
|
],
|
|
|
|
'ifInFunction' => [
|
|
|
|
'<?php
|
|
|
|
/** @return string */
|
|
|
|
function foo() {
|
|
|
|
$a = 5;
|
|
|
|
if (rand(0, 1)) {
|
|
|
|
$b = "hello";
|
|
|
|
} else {
|
|
|
|
$b = "goodbye";
|
|
|
|
}
|
|
|
|
return $a . $b;
|
|
|
|
}',
|
2017-11-09 16:42:39 -05:00
|
|
|
],
|
|
|
|
'booleanOr' => [
|
|
|
|
'<?php
|
|
|
|
function foo(int $a, int $b): bool {
|
|
|
|
return $a || $b;
|
|
|
|
}',
|
2017-05-26 20:05:57 -04:00
|
|
|
],
|
2017-11-10 18:08:17 -05:00
|
|
|
'magicCall' => [
|
|
|
|
'<?php
|
|
|
|
class A {
|
|
|
|
/** @var string */
|
|
|
|
private $value = "default";
|
|
|
|
|
|
|
|
/** @param string[] $args */
|
|
|
|
public function __call(string $name, array $args) {
|
|
|
|
if (count($args) == 1) {
|
|
|
|
$this->modify($name, $args[0]);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
private function modify(string $name, string $value) : void {
|
|
|
|
call_user_func(array($this, "modify_" . $name), $value);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function modifyFoo(string $value) : void {
|
|
|
|
$this->value = $value;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$m = new A();
|
|
|
|
$m->foo("value");
|
|
|
|
$m->modifyFoo("value2");',
|
|
|
|
],
|
2017-12-29 11:26:28 -05:00
|
|
|
'usedTraitMethod' => [
|
|
|
|
'<?php
|
|
|
|
class A {
|
|
|
|
public function foo() : void {
|
|
|
|
echo "parent method";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
trait T {
|
|
|
|
public function foo() : void {
|
|
|
|
echo "trait method";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
class B extends A {
|
|
|
|
use T;
|
|
|
|
}
|
|
|
|
|
|
|
|
(new A)->foo();
|
|
|
|
(new B)->foo();',
|
|
|
|
],
|
2017-12-29 19:38:01 -05:00
|
|
|
'usedInterfaceMethod' => [
|
|
|
|
'<?php
|
|
|
|
interface I {
|
|
|
|
public function foo() : void;
|
|
|
|
}
|
|
|
|
|
|
|
|
class A implements I {
|
|
|
|
public function foo() : void {}
|
|
|
|
}
|
|
|
|
|
|
|
|
(new A)->foo();',
|
|
|
|
],
|
2017-04-24 23:45:02 -04:00
|
|
|
];
|
2017-02-08 00:28:26 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-04-24 23:45:02 -04:00
|
|
|
* @return array
|
2017-02-08 00:28:26 -05:00
|
|
|
*/
|
2017-04-24 23:45:02 -04:00
|
|
|
public function providerFileCheckerInvalidCodeParse()
|
2017-02-08 00:28:26 -05:00
|
|
|
{
|
2017-04-24 23:45:02 -04:00
|
|
|
return [
|
|
|
|
'function' => [
|
|
|
|
'<?php
|
|
|
|
/** @return int */
|
|
|
|
function foo() {
|
|
|
|
$a = 5;
|
|
|
|
$b = [];
|
|
|
|
return $a;
|
|
|
|
}',
|
2017-05-26 20:05:57 -04:00
|
|
|
'error_message' => 'UnusedVariable',
|
2017-04-24 23:45:02 -04:00
|
|
|
],
|
|
|
|
'ifInFunction' => [
|
|
|
|
'<?php
|
|
|
|
/** @return int */
|
|
|
|
function foo() {
|
|
|
|
$a = 5;
|
|
|
|
if (rand(0, 1)) {
|
|
|
|
$b = "hello";
|
|
|
|
} else {
|
|
|
|
$b = "goodbye";
|
|
|
|
}
|
|
|
|
return $a;
|
|
|
|
}',
|
2017-05-26 20:05:57 -04:00
|
|
|
'error_message' => 'UnusedVariable',
|
|
|
|
],
|
2017-04-24 23:45:02 -04:00
|
|
|
'unusedClass' => [
|
|
|
|
'<?php
|
|
|
|
class A { }',
|
2017-05-26 20:05:57 -04:00
|
|
|
'error_message' => 'UnusedClass',
|
2017-04-24 23:45:02 -04:00
|
|
|
],
|
|
|
|
'publicUnusedMethod' => [
|
|
|
|
'<?php
|
|
|
|
class A {
|
|
|
|
/** @return void */
|
|
|
|
public function foo() {}
|
|
|
|
}
|
2017-05-04 14:25:58 -04:00
|
|
|
|
2017-04-24 23:45:02 -04:00
|
|
|
new A();',
|
2017-05-26 20:05:57 -04:00
|
|
|
'error_message' => 'PossiblyUnusedMethod',
|
2017-04-24 23:45:02 -04:00
|
|
|
],
|
|
|
|
'privateUnusedMethod' => [
|
|
|
|
'<?php
|
|
|
|
class A {
|
|
|
|
/** @return void */
|
|
|
|
private function foo() {}
|
|
|
|
}
|
2017-05-04 14:25:58 -04:00
|
|
|
|
2017-04-24 23:45:02 -04:00
|
|
|
new A();',
|
2017-05-26 20:05:57 -04:00
|
|
|
'error_message' => 'UnusedMethod',
|
|
|
|
],
|
2017-04-24 23:45:02 -04:00
|
|
|
];
|
2017-02-08 00:28:26 -05:00
|
|
|
}
|
|
|
|
}
|